170667 2017-04-10 01:12:03 -0700 REGRESSION(r214426): [GTK] Test media/video-click-dblckick-standalone.html started to fail in the bots after r214426 2017-04-10 04:44:30 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply zan oldest_to_newest 1295926 0 cgarcia 2017-04-10 01:12:03 -0700 I thought it was because of the early return added in MediaDocument::defaultEventHandler(), so I disabled modern media controls runtime feature in GTK+ port. But the test is still failing, so I guess it's the test that is enabling that feature 1295927 1 cgarcia 2017-04-10 01:16:36 -0700 For some reason I can't reproduce it locally, but it's always failing in the bots. 1295953 2 306679 cgarcia 2017-04-10 03:48:57 -0700 Created attachment 306679 Patch 1295962 3 cgarcia 2017-04-10 04:44:30 -0700 Committed r215178: <http://trac.webkit.org/changeset/215178> 306679 2017-04-10 03:48:57 -0700 2017-04-10 04:24:39 -0700 Patch wk2-modern-media-controls-tests.diff text/plain 3141 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA0NmNkNzIxYzhlNy4uNTdiNmFmMGZkNzAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNiBAQAog MjAxNy0wNC0xMCAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK KyAgICAgICAgUkVHUkVTU0lPTihyMjE0NDI2KTogW0dUS10gVGVzdCBtZWRpYS92aWRlby1jbGlj ay1kYmxja2ljay1zdGFuZGFsb25lLmh0bWwgc3RhcnRlZCB0byBmYWlsIGluIHRoZSBib3RzIGFm dGVyIHIyMTQ0MjYKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MDY2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFVuc2tpcCB0aGVuIHRlc3QgdGhhdCBpcyBwYXNzaW5nIG5vdy4KKworICAgICAgICAqIHBs YXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zOgorCisyMDE3LTA0LTEwICBDYXJsb3MgR2FyY2lh IENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKwogICAgICAgICBVbnJldmlld2VkIEdUSysg Z2FyZGVuaW5nLiBNYXJrIHNldmVyYWwgdGVzdHMgYXMgZmFpbGluZy90aW1pbmcgb3V0LgogCiAg ICAgICAgICogcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnM6CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL3BsYXRm b3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGZiMDYwMDNlZDE5Li4zZmRiNGRjMGUyMyAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTM0OTUsOCAr MzQ5NSw2IEBAIHdlYmtpdC5vcmcvYi8xNzAwNTMgbWVkaWEvdmlkZW8tbG9hZC1yZXF1aXJlLXVz ZXItZ2VzdHVyZS5odG1sIFsgRmFpbHVyZSBdCiB3ZWJraXQub3JnL2IvMTcwMzM1IGNhbnZhcy9w aGlsaXAvdGVzdHMvMmQucGF0dGVybi5hbmltYXRlZC5naWYuaHRtbCBbIEZhaWx1cmUgXQogd2Vi a2l0Lm9yZy9iLzE3MDMzNSBzdmcvYW5pbWF0aW9ucy9hbmltYXRlZC1zdmctaW1hZ2Utb3V0c2lk ZS12aWV3cG9ydC1wYXVzZWQuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2IvMTcwNjY3 IG1lZGlhL3ZpZGVvLWNsaWNrLWRibGNraWNrLXN0YW5kYWxvbmUuaHRtbCBbIEZhaWx1cmUgXQot CiAjLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLwogIyBFbmQgb2Ygbm9uLWNyYXNoaW5n LCBub24tZmxha3kgdGVzdHMgZmFpbGluZwogIy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8KZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBl YWE4OWI4N2U2My4uYmUyNDExZGVkMTYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxNy0wNC0xMCAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MjE0NDI2KTogW0dUS10gVGVzdCBtZWRpYS92aWRlby1jbGljay1kYmxja2ljay1zdGFuZGFsb25l Lmh0bWwgc3RhcnRlZCB0byBmYWlsIGluIHRoZSBib3RzIGFmdGVyIHIyMTQ0MjYKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDY2NworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEluIHIyMTQ2NjYgd2UgZGlz YWJsZWQgbW9kZXJuIG1lZGlhIGNvbnRyb2xzIHJ1bnRpbWUgZmVhdHVyZSBmb3IgdGhlIEdUSysg cG9ydCwgYnV0IGxheW91dCB0ZXN0cyBzdGlsbCBvdmVycmlkZQorICAgICAgICB0aGF0IHZhbHVl LgorCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3Bw OgorICAgICAgICAoV1RSOjpUZXN0Q29udHJvbGxlcjo6dXBkYXRlUGxhdGZvcm1TcGVjaWZpY1Rl c3RPcHRpb25zRm9yVGVzdCk6IERpc2FibGUgbW9kZXJuIG1lZGlhIGNvbnRyb2xzLgorCiAyMDE3 LTA0LTA5ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAg ICAgICBXVFI6IEF2b2lkIGNvbnZlcnNpb24gZnJvbSBwbGF0Zm9ybSBpbWFnZSB0byBXS0ltYWdl IGFuZCB0aGVuIHRvIHBsYXRmb3JtIGltYWdlIGFnYWluIHdoZW4gZHVtcGluZyBwaXhlbCByZXN1 bHRzCmRpZmYgLS1naXQgYS9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxl ckd0ay5jcHAgYi9Ub29scy9XZWJLaXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5j cHAKaW5kZXggNjBiYzk5YmU5YzEuLmQ3ODQ5NzIyYTI5IDEwMDY0NAotLS0gYS9Ub29scy9XZWJL aXRUZXN0UnVubmVyL2d0ay9UZXN0Q29udHJvbGxlckd0ay5jcHAKKysrIGIvVG9vbHMvV2ViS2l0 VGVzdFJ1bm5lci9ndGsvVGVzdENvbnRyb2xsZXJHdGsuY3BwCkBAIC0xNTUsOCArMTU1LDkgQEAg dm9pZCBUZXN0Q29udHJvbGxlcjo6cGxhdGZvcm1SZXNldFByZWZlcmVuY2VzVG9Db25zaXN0ZW50 VmFsdWVzKCkKICAgICBtX21haW5XZWJWaWV3LT5kaXNtaXNzQWxsUG9wdXBNZW51cygpOwogfQog Ci12b2lkIFRlc3RDb250cm9sbGVyOjp1cGRhdGVQbGF0Zm9ybVNwZWNpZmljVGVzdE9wdGlvbnNG b3JUZXN0KFRlc3RPcHRpb25zJiwgY29uc3Qgc3RkOjpzdHJpbmcmKSBjb25zdAordm9pZCBUZXN0 Q29udHJvbGxlcjo6dXBkYXRlUGxhdGZvcm1TcGVjaWZpY1Rlc3RPcHRpb25zRm9yVGVzdChUZXN0 T3B0aW9ucyYgb3B0aW9ucywgY29uc3Qgc3RkOjpzdHJpbmcmKSBjb25zdAogeworICAgIG9wdGlv bnMuZW5hYmxlTW9kZXJuTWVkaWFDb250cm9scyA9IGZhbHNlOwogfQogCiB9IC8vIG5hbWVzcGFj ZSBXVFIK