170648 2017-04-08 17:28:54 -0700 test262: test262/test/annexB/language/comments/multi-line-html-close.js 2017-04-11 09:54:54 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck buildbot commit-queue joepeck keith_miller mark.lam msaboff saam oldest_to_newest 1295717 0 joepeck 2017-04-08 17:28:54 -0700 A multi-line multi-line comment with HTML Closing Comment should treat trailing content like HTML Closing Comment (single line comment) Test: 1/* */--> This should be a comment Expected: 1 Result: SyntaxError Test: test262/test/annexB/language/comments/multi-line-html-close.js 1295718 1 306586 joepeck 2017-04-08 17:31:41 -0700 Created attachment 306586 [PATCH] Proposed Fix 1295719 2 306586 joepeck 2017-04-08 17:33:49 -0700 Comment on attachment 306586 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review > Source/JavaScriptCore/parser/Lexer.cpp:1994 > + if ((m_atLineStart || m_terminator) && m_current == '>') { I might be able to just drop m_atLineStart entirely and just use m_terminator. 1295720 3 306586 joepeck 2017-04-08 17:39:28 -0700 Comment on attachment 306586 [PATCH] Proposed Fix Yes, I think I can drop the entire variable. Existing tests pass I'm going to add a few more. 1295721 4 joepeck 2017-04-08 17:40:47 -0700 > Yes, I think I can drop the entire variable. Existing tests pass I'm going > to add a few more. Nope I lied, existing tests did not pass. Leaving patch as it is! 1295824 5 306586 joepeck 2017-04-09 12:32:34 -0700 Comment on attachment 306586 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review >> Source/JavaScriptCore/parser/Lexer.cpp:1994 >> + if ((m_atLineStart || m_terminator) && m_current == '>') { > > I might be able to just drop m_atLineStart entirely and just use m_terminator. Nope. Other tests failed. Patch is reviewable as is. 1296291 6 joepeck 2017-04-10 22:51:41 -0700 Ping reviewers 1296431 7 306586 keith_miller 2017-04-11 09:26:13 -0700 Comment on attachment 306586 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=306586&action=review r=me. > LayoutTests/js/parser-xml-close-comment-expected.txt:1 > +Test to ensure correct handling of --> as a single line comment when at the beginning of a line or preceeded by a multi-line comment Wow, I didn't know this was a thing... weird 1296449 8 306586 commit-queue 2017-04-11 09:54:52 -0700 Comment on attachment 306586 [PATCH] Proposed Fix Clearing flags on attachment: 306586 Committed r215235: <http://trac.webkit.org/changeset/215235> 1296450 9 commit-queue 2017-04-11 09:54:54 -0700 All reviewed patches have been landed. Closing bug. 306586 2017-04-08 17:31:41 -0700 2017-04-11 09:54:52 -0700 [PATCH] Proposed Fix eh-1.patch text/plain 6242 joepeck ZGlmZiAtLWdpdCBhL0pTVGVzdHMvQ2hhbmdlTG9nIGIvSlNUZXN0cy9DaGFuZ2VMb2cKaW5kZXgg NjQ5N2NiYjYwYjUuLjlhMjk0ZGFlZTRkIDEwMDY0NAotLS0gYS9KU1Rlc3RzL0NoYW5nZUxvZwor KysgYi9KU1Rlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA0LTA4ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgdGVzdDI2MjogdGVz dDI2Mi90ZXN0L2FubmV4Qi9sYW5ndWFnZS9jb21tZW50cy9tdWx0aS1saW5lLWh0bWwtY2xvc2Uu anMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDY0 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogdGVz dDI2Mi55YW1sOgorCiAyMDE3LTA0LTA3ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUu Y29tPgogCiAgICAgICAgIEZpeCBhbmQgZW5hYmxlIENoYWtyYUNvcmUvdGVzdC9lczYvRVM2RnVu Y3Rpb25fYnVncy5qcyBhZnRlciByMjE1MDcyCmRpZmYgLS1naXQgYS9KU1Rlc3RzL3Rlc3QyNjIu eWFtbCBiL0pTVGVzdHMvdGVzdDI2Mi55YW1sCmluZGV4IDNjYTExYTVmZmEzLi4xMzdiYzg2Y2Y5 ZSAxMDA2NDQKLS0tIGEvSlNUZXN0cy90ZXN0MjYyLnlhbWwKKysrIGIvSlNUZXN0cy90ZXN0MjYy LnlhbWwKQEAgLTg5Miw5ICs4OTIsOSBAQAogLSBwYXRoOiB0ZXN0MjYyL3Rlc3QvYW5uZXhCL2J1 aWx0LWlucy91bmVzY2FwZS90d28uanMKICAgY21kOiBydW5UZXN0MjYyIDpub3JtYWwsICJOb0V4 Y2VwdGlvbiIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4v aGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCiAtIHBhdGg6IHRlc3QyNjIvdGVzdC9hbm5leEIv bGFuZ3VhZ2UvY29tbWVudHMvbXVsdGktbGluZS1odG1sLWNsb3NlLmpzCi0gIGNtZDogcnVuVGVz dDI2MiA6ZmFpbCwgIlRlc3QyNjJFcnJvciIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQu anMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgW10KKyAgY21kOiBydW5UZXN0MjYy IDpub3JtYWwsICJUZXN0MjYyRXJyb3IiLCBbIi4uLy4uLy4uLy4uL2hhcm5lc3MvYXNzZXJ0Lmpz IiwgIi4uLy4uLy4uLy4uL2hhcm5lc3Mvc3RhLmpzIl0sIFtdCiAtIHBhdGg6IHRlc3QyNjIvdGVz dC9hbm5leEIvbGFuZ3VhZ2UvY29tbWVudHMvbXVsdGktbGluZS1odG1sLWNsb3NlLmpzCi0gIGNt ZDogcnVuVGVzdDI2MiA6ZmFpbCwgIlRlc3QyNjJFcnJvciIsIFsiLi4vLi4vLi4vLi4vaGFybmVz cy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4vaGFybmVzcy9zdGEuanMiXSwgWzpzdHJpY3RdCisg IGNtZDogcnVuVGVzdDI2MiA6bm9ybWFsLCAiVGVzdDI2MkVycm9yIiwgWyIuLi8uLi8uLi8uLi9o YXJuZXNzL2Fzc2VydC5qcyIsICIuLi8uLi8uLi8uLi9oYXJuZXNzL3N0YS5qcyJdLCBbOnN0cmlj dF0KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2FubmV4Qi9sYW5ndWFnZS9jb21tZW50cy9zaW5nbGUt bGluZS1odG1sLWNsb3NlLWFzaS5qcwogICBjbWQ6IHJ1blRlc3QyNjIgOm5vcm1hbCwgIlRlc3Qy NjJFcnJvciIsIFsiLi4vLi4vLi4vLi4vaGFybmVzcy9hc3NlcnQuanMiLCAiLi4vLi4vLi4vLi4v aGFybmVzcy9zdGEuanMiXSwgW10KIC0gcGF0aDogdGVzdDI2Mi90ZXN0L2FubmV4Qi9sYW5ndWFn ZS9jb21tZW50cy9zaW5nbGUtbGluZS1odG1sLWNsb3NlLWFzaS5qcwpkaWZmIC0tZ2l0IGEvTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmluZGV4IDg0Y2JjMmIy YjRhLi5lYjJhNjc2YWM4YyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBi L0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTA0LTA4ICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgdGVzdDI2MjogdGVz dDI2Mi90ZXN0L2FubmV4Qi9sYW5ndWFnZS9jb21tZW50cy9tdWx0aS1saW5lLWh0bWwtY2xvc2Uu anMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDY0 OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICoganMv cGFyc2VyLXhtbC1jbG9zZS1jb21tZW50LWV4cGVjdGVkLnR4dDoKKyAgICAgICAgKiBqcy9zY3Jp cHQtdGVzdHMvcGFyc2VyLXhtbC1jbG9zZS1jb21tZW50LmpzOgorICAgICAgICBVcGRhdGUgdGVz dCBjb3ZlcmFnZSBmb3IgSmF2YVNjcmlwdCBIVE1MIGNvbW1lbnRzLgorCiAyMDE3LTA0LTA3ICBZ dWljaGlybyBLaWt1cmEgIDx5Lmtpa3VyYUBnbWFpbC5jb20+CiAKICAgICAgICAgV2ViR1BVOiBp bXBsZW1lbnQgQ29tcHV0ZUNvbW1hbmRFbmNvZGVyIGFuZCByZWxhdGVkIGNvbXBvbmVudHMgICAg CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9qcy9wYXJzZXIteG1sLWNsb3NlLWNvbW1lbnQtZXhw ZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvanMvcGFyc2VyLXhtbC1jbG9zZS1jb21tZW50LWV4cGVj dGVkLnR4dAppbmRleCAzODI3ZWI4ZTg1OS4uMDZkZmQ2YzFiNzAgMTAwNjQ0Ci0tLSBhL0xheW91 dFRlc3RzL2pzL3BhcnNlci14bWwtY2xvc2UtY29tbWVudC1leHBlY3RlZC50eHQKKysrIGIvTGF5 b3V0VGVzdHMvanMvcGFyc2VyLXhtbC1jbG9zZS1jb21tZW50LWV4cGVjdGVkLnR4dApAQCAtMSwx NCArMSwyNSBAQAotVGVzdCB0byBlbnN1cmUgY29ycmVjdCBoYW5kbGluZyBvZiAtLT4gYXMgYSBz aW5nbGUgbGluZSBjb21tZW50IHdoZW4gYXQgdGhlIGJlZ2lubmluZyBvZiBhIGxpbmUKK1Rlc3Qg dG8gZW5zdXJlIGNvcnJlY3QgaGFuZGxpbmcgb2YgLS0+IGFzIGEgc2luZ2xlIGxpbmUgY29tbWVu dCB3aGVuIGF0IHRoZSBiZWdpbm5pbmcgb2YgYSBsaW5lIG9yIHByZWNlZWRlZCBieSBhIG11bHRp LWxpbmUgY29tbWVudAogCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBB U1MiIG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAogUEFTUyAnc2hv dWxkIGJlIGEgc3ludGF4IGVycm9yJyAtLT4gdGhyZXcgZXhjZXB0aW9uIFN5bnRheEVycm9yOiBV bmV4cGVjdGVkIGVuZCBvZiBzY3JpcHQuCitQQVNTIC8qKi8gMS0tPiB0aHJldyBleGNlcHRpb24g U3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgZW5kIG9mIHNjcmlwdC4KIFBBU1MgLyoqLyAxIC0tPiB0 aHJldyBleGNlcHRpb24gU3ludGF4RXJyb3I6IFVuZXhwZWN0ZWQgZW5kIG9mIHNjcmlwdC4KK1BB U1MgMSAvKiovLS0+IHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjogVW5leHBlY3RlZCBlbmQg b2Ygc2NyaXB0LgogUEFTUyAxIC8qKi8gLS0+IHRocmV3IGV4Y2VwdGlvbiBTeW50YXhFcnJvcjog VW5leHBlY3RlZCBlbmQgb2Ygc2NyaXB0LgogUEFTUyAxLyoKLSovLS0+IHRocmV3IGV4Y2VwdGlv biBTeW50YXhFcnJvcjogVW5leHBlY3RlZCB0b2tlbiAnPicuCisqLy0tPiBpcyAxCitQQVNTIDEv KgorKi8KKy0tPiBpcyAxCitQQVNTIDIvKgorKi8gLS0+IGlzIDIKK1BBU1MgMi8qCisqLworIC0t PiBpcyAyCiBQQVNTIC0tPiBpcyB1bmRlZmluZWQuCitQQVNTICAtLT4gaXMgdW5kZWZpbmVkLgog UEFTUyAvKiovLS0+IGlzIHVuZGVmaW5lZC4KIFBBU1MgLyoKICovLS0+IGlzIHVuZGVmaW5lZC4K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2pzL3NjcmlwdC10ZXN0cy9wYXJzZXIteG1sLWNsb3Nl LWNvbW1lbnQuanMgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcGFyc2VyLXhtbC1jbG9z ZS1jb21tZW50LmpzCmluZGV4IDhhZjY5N2Y3OGFjLi5jZGIzNjc0MjY4MiAxMDA2NDQKLS0tIGEv TGF5b3V0VGVzdHMvanMvc2NyaXB0LXRlc3RzL3BhcnNlci14bWwtY2xvc2UtY29tbWVudC5qcwor KysgYi9MYXlvdXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvcGFyc2VyLXhtbC1jbG9zZS1jb21tZW50 LmpzCkBAIC0xLDEwICsxLDE3IEBACi1kZXNjcmlwdGlvbigiVGVzdCB0byBlbnN1cmUgY29ycmVj dCBoYW5kbGluZyBvZiAtLT4gYXMgYSBzaW5nbGUgbGluZSBjb21tZW50IHdoZW4gYXQgdGhlIGJl Z2lubmluZyBvZiBhIGxpbmUiKTsKK2Rlc2NyaXB0aW9uKCJUZXN0IHRvIGVuc3VyZSBjb3JyZWN0 IGhhbmRsaW5nIG9mIC0tPiBhcyBhIHNpbmdsZSBsaW5lIGNvbW1lbnQgd2hlbiBhdCB0aGUgYmVn aW5uaW5nIG9mIGEgbGluZSBvciBwcmVjZWVkZWQgYnkgYSBtdWx0aS1saW5lIGNvbW1lbnQiKTsK IAogc2hvdWxkVGhyb3coIidzaG91bGQgYmUgYSBzeW50YXggZXJyb3InIC0tPiIpOworc2hvdWxk VGhyb3coIi8qKi8gMS0tPiIpOwogc2hvdWxkVGhyb3coIi8qKi8gMSAtLT4iKTsKK3Nob3VsZFRo cm93KCIxIC8qKi8tLT4iKTsKIHNob3VsZFRocm93KCIxIC8qKi8gLS0+Iik7Ci1zaG91bGRUaHJv dygiMS8qXG4qLy0tPiIpOworCitzaG91bGRCZSgiMS8qXG4qLy0tPiIsIGAxYCk7CitzaG91bGRC ZSgiMS8qXG4qL1xuLS0+IiwgYDFgKTsKK3Nob3VsZEJlKCIyLypcbiovIC0tPiIsIGAyYCk7Citz aG91bGRCZSgiMi8qXG4qL1xuIC0tPiIsIGAyYCk7CiAKIHNob3VsZEJlVW5kZWZpbmVkKCItLT4i KTsKK3Nob3VsZEJlVW5kZWZpbmVkKCIgLS0+Iik7CiBzaG91bGRCZVVuZGVmaW5lZCgiLyoqLy0t PiIpOwogc2hvdWxkQmVVbmRlZmluZWQoIi8qXG4qLy0tPiIpOwpkaWZmIC0tZ2l0IGEvU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKaW5kZXggMGY3ZjM1NWMzZGMuLmVmMThiMjcwNWM0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNyBAQAorMjAxNy0wNC0wOCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jh cm9AYXBwbGUuY29tPgorCisgICAgICAgIHRlc3QyNjI6IHRlc3QyNjIvdGVzdC9hbm5leEIvbGFu Z3VhZ2UvY29tbWVudHMvbXVsdGktbGluZS1odG1sLWNsb3NlLmpzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDgKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBhcnNlci9MZXhlci5jcHA6CisgICAg ICAgIChKU0M6OkxleGVyPFQ+OjpsZXgpOgorICAgICAgICBBIG11bHRpLWxpbmUgY29tbWVudCB0 aGF0IGNvbnRhaW5zIGEgbGluZSB0ZXJtaW5hdG9yIGlzIGl0c2VsZiB0cmVhdGVkCisgICAgICAg IGxpa2UgYSBsaW5lIHRlcm1pbmF0b3IuIEFuIEhUTUwgQ2xvc2UgQ29tbWVudCB0aGF0IGNvbWVz IGFmdGVyIGl0IGNhbgorICAgICAgICB0aGVyZWZvcmUgdHJlYXQgaXQgbGlrZSBpdCBpcyBhdCB0 aGUgc3RhcnQgb2YgYSBsaW5lLCBiZWNhdXNlIGl0IHdhcworICAgICAgICBpbW1lZGlhdGVseSBw cmVjZWVkZWQgYnkgdGhlIGVxdWl2YWxlbnQgb2YgYSBsaW5lIHRlcm1pbmF0b3IuCisKIDIwMTct MDQtMDcgIFl1aWNoaXJvIEtpa3VyYSAgPHkua2lrdXJhQGdtYWlsLmNvbT4KIAogICAgICAgICBX ZWJHUFU6IGltcGxlbWVudCBDb21wdXRlQ29tbWFuZEVuY29kZXIgYW5kIHJlbGF0ZWQgY29tcG9u ZW50cwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9MZXhlci5jcHAg Yi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL0xleGVyLmNwcAppbmRleCBkYWVhNTZkMGVj Mi4uZDEzYzZjZDhiNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIv TGV4ZXIuY3BwCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvTGV4ZXIuY3BwCkBA IC0xOTkxLDcgKzE5OTEsNyBAQCBzdGFydDoKICAgICAgICAgc2hpZnQoKTsKICAgICAgICAgaWYg KG1fY3VycmVudCA9PSAnLScpIHsKICAgICAgICAgICAgIHNoaWZ0KCk7Ci0gICAgICAgICAgICBp ZiAobV9hdExpbmVTdGFydCAmJiBtX2N1cnJlbnQgPT0gJz4nKSB7CisgICAgICAgICAgICBpZiAo KG1fYXRMaW5lU3RhcnQgfHwgbV90ZXJtaW5hdG9yKSAmJiBtX2N1cnJlbnQgPT0gJz4nKSB7CiAg ICAgICAgICAgICAgICAgaWYgKG1fc2NyaXB0TW9kZSA9PSBKU1BhcnNlclNjcmlwdE1vZGU6OkNs YXNzaWMpIHsKICAgICAgICAgICAgICAgICAgICAgc2hpZnQoKTsKICAgICAgICAgICAgICAgICAg ICAgZ290byBpblNpbmdsZUxpbmVDb21tZW50Owo=