170646 2017-04-08 15:20:41 -0700 Remove use of strcpy from JSC 2017-04-09 16:47:22 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 oliver oliver buildbot jfbastien keith_miller mark.lam msaboff saam oldest_to_newest 1295699 0 oliver 2017-04-08 15:20:41 -0700 Remove use of strcpy from JSC 1295700 1 306583 oliver 2017-04-08 15:22:33 -0700 Created attachment 306583 Patch 1295702 2 oliver 2017-04-08 15:23:16 -0700 Unbelievably trivial patch :) 1295703 3 306583 mark.lam 2017-04-08 15:29:04 -0700 Comment on attachment 306583 Patch r=me, but can you fix the GTK build failure? Is strlcpy available for all posix? 1295732 4 306593 oliver 2017-04-08 19:13:07 -0700 Created attachment 306593 Patch 1295734 5 306593 mark.lam 2017-04-08 19:25:58 -0700 Comment on attachment 306593 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306593&action=review r=me with ChangeLog comment fixed. > Source/JavaScriptCore/ChangeLog:10 > + Replace the use of strcpy with strlcpy as strcpy keeps > + on tripping various analyser warnings even though its > + trivially safe in this case. Your comment needs to be updated. 1295850 6 oliver 2017-04-09 16:47:22 -0700 Committed r215168: <http://trac.webkit.org/changeset/215168> 306583 2017-04-08 15:22:33 -0700 2017-04-08 19:13:05 -0700 Patch bug-170646-20170408152234.patch text/plain 1995 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MTAzMmVjNGNmYWI2NDVkZGMxODgwYWVhZTk3MDAxZTM1ZDIyYWFhLi43ZjQxNjBkMjU2ZGVkYThi ODFmZDcxYjQ3YWZkZmI2MmVmYjFjMGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wNC0wOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJlbW92ZSB1c2Ugb2Ygc3RyY3B5IGZyb20gSlNDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIHRoZSB1c2Ugb2Ygc3RyY3B5 IHdpdGggc3RybGNweSBhcyBzdHJjcHkga2VlcHMKKyAgICAgICAgb24gdHJpcHBpbmcgdmFyaW91 cyBhbmFseXNlciB3YXJuaW5ncyBldmVuIHRob3VnaCBpdHMKKyAgICAgICAgdHJpdmlhbGx5IHNh ZmUgaW4gdGhpcyBjYXNlLgorCisgICAgICAgIEVzc2VudGlhbGx5IGNvZGUgaHlnaWVuZSwgbm8g Y2hhbmdlIGluIGJlaGF2aW91ciwgbm8KKyAgICAgICAgcGVyZiBpbXBhY3QuCisKKyAgICAgICAg KiBkZmcvREZHRGlzYXNzZW1ibGVyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpEaXNhc3NlbWJs ZXI6OmR1bXBEaXNhc3NlbWJseSk6CisKIDIwMTctMDQtMDcgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHk6IE1ha2UgdG8gYSBjb21waWxhdGlv biBBUEkgdGhhdCBhbGxvd3MgZm9yIG11bHRpLVZNIGNvbmN1cnJlbnQgY29tcGlsYXRpb25zIG9m IFdhc20gTW9kdWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdE aXNhc3NlbWJsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEaXNhc3NlbWJs ZXIuY3BwCmluZGV4IDE1Y2JlYTBhNTI0M2QxYmM3OGNiNWU0ZjdjZmUzNGQ3MGZhYzNmNjguLmU3 YTkxOWQ5MDY1MzI2ZDFjZGEzOTM0MTk3ZjkyMmQ3MTAyZWQ0MjggMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRGlzYXNzZW1ibGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0Rpc2Fzc2VtYmxlci5jcHAKQEAgLTE1OCw4ICsxNTgsOSBAQCB2 b2lkIERpc2Fzc2VtYmxlcjo6ZHVtcERpc2Fzc2VtYmx5KFByaW50U3RyZWFtJiBvdXQsIGNvbnN0 IGNoYXIqIHByZWZpeCwgTGlua0J1ZgogICAgICAgICBhbW91bnRPZk5vZGVXaGl0ZVNwYWNlID0g MDsKICAgICBlbHNlCiAgICAgICAgIGFtb3VudE9mTm9kZVdoaXRlU3BhY2UgPSBHcmFwaDo6YW1v dW50T2ZOb2RlV2hpdGVTcGFjZShjb250ZXh0KTsKLSAgICBhdXRvIHByZWZpeEJ1ZmZlciA9IHN0 ZDo6bWFrZV91bmlxdWU8Y2hhcltdPihwcmVmaXhMZW5ndGggKyBhbW91bnRPZk5vZGVXaGl0ZVNw YWNlICsgMSk7Ci0gICAgc3RyY3B5KHByZWZpeEJ1ZmZlci5nZXQoKSwgcHJlZml4KTsKKyAgICBz aXplX3QgYnVmZmVyU2l6ZSA9IHByZWZpeExlbmd0aCArIGFtb3VudE9mTm9kZVdoaXRlU3BhY2Ug KyAxOworICAgIGF1dG8gcHJlZml4QnVmZmVyID0gc3RkOjptYWtlX3VuaXF1ZTxjaGFyW10+KGJ1 ZmZlclNpemUpOworICAgIHN0cmxjcHkocHJlZml4QnVmZmVyLmdldCgpLCBwcmVmaXgsIGJ1ZmZl clNpemUpOwogICAgIGZvciAoaW50IGkgPSAwOyBpIDwgYW1vdW50T2ZOb2RlV2hpdGVTcGFjZTsg KytpKQogICAgICAgICBwcmVmaXhCdWZmZXJbaSArIHByZWZpeExlbmd0aF0gPSAnICc7CiAgICAg cHJlZml4QnVmZmVyW3ByZWZpeExlbmd0aCArIGFtb3VudE9mTm9kZVdoaXRlU3BhY2VdID0gMDsK 306593 2017-04-08 19:13:07 -0700 2017-04-08 19:25:58 -0700 Patch bug-170646-20170408191306.patch text/plain 1828 oliver U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MTExCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBh MTAzMmVjNGNmYWI2NDVkZGMxODgwYWVhZTk3MDAxZTM1ZDIyYWFhLi43ZjQxNjBkMjU2ZGVkYThi ODFmZDcxYjQ3YWZkZmI2MmVmYjFjMGUyIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwyMCBAQAorMjAxNy0wNC0wOCAgT2xpdmVyIEh1bnQgIDxvbGl2ZXJAYXBwbGUuY29tPgor CisgICAgICAgIFJlbW92ZSB1c2Ugb2Ygc3RyY3B5IGZyb20gSlNDCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZXBsYWNlIHRoZSB1c2Ugb2Ygc3RyY3B5 IHdpdGggc3RybGNweSBhcyBzdHJjcHkga2VlcHMKKyAgICAgICAgb24gdHJpcHBpbmcgdmFyaW91 cyBhbmFseXNlciB3YXJuaW5ncyBldmVuIHRob3VnaCBpdHMKKyAgICAgICAgdHJpdmlhbGx5IHNh ZmUgaW4gdGhpcyBjYXNlLgorCisgICAgICAgIEVzc2VudGlhbGx5IGNvZGUgaHlnaWVuZSwgbm8g Y2hhbmdlIGluIGJlaGF2aW91ciwgbm8KKyAgICAgICAgcGVyZiBpbXBhY3QuCisKKyAgICAgICAg KiBkZmcvREZHRGlzYXNzZW1ibGVyLmNwcDoKKyAgICAgICAgKEpTQzo6REZHOjpEaXNhc3NlbWJs ZXI6OmR1bXBEaXNhc3NlbWJseSk6CisKIDIwMTctMDQtMDcgIFNhYW0gQmFyYXRpICA8c2JhcmF0 aUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHk6IE1ha2UgdG8gYSBjb21waWxhdGlv biBBUEkgdGhhdCBhbGxvd3MgZm9yIG11bHRpLVZNIGNvbmN1cnJlbnQgY29tcGlsYXRpb25zIG9m IFdhc20gTW9kdWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdE aXNhc3NlbWJsZXIuY3BwIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdEaXNhc3NlbWJs ZXIuY3BwCmluZGV4IDE1Y2JlYTBhNTI0M2QxYmM3OGNiNWU0ZjdjZmUzNGQ3MGZhYzNmNjguLjE2 OGExNmRiMDRkM2JhYjE1YjkxMjkzNDI3YTkzMWM4YmZlMTFlMGIgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRGlzYXNzZW1ibGVyLmNwcAorKysgYi9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvZGZnL0RGR0Rpc2Fzc2VtYmxlci5jcHAKQEAgLTE1OSw3ICsxNTksNyBAQCB2 b2lkIERpc2Fzc2VtYmxlcjo6ZHVtcERpc2Fzc2VtYmx5KFByaW50U3RyZWFtJiBvdXQsIGNvbnN0 IGNoYXIqIHByZWZpeCwgTGlua0J1ZgogICAgIGVsc2UKICAgICAgICAgYW1vdW50T2ZOb2RlV2hp dGVTcGFjZSA9IEdyYXBoOjphbW91bnRPZk5vZGVXaGl0ZVNwYWNlKGNvbnRleHQpOwogICAgIGF1 dG8gcHJlZml4QnVmZmVyID0gc3RkOjptYWtlX3VuaXF1ZTxjaGFyW10+KHByZWZpeExlbmd0aCAr IGFtb3VudE9mTm9kZVdoaXRlU3BhY2UgKyAxKTsKLSAgICBzdHJjcHkocHJlZml4QnVmZmVyLmdl dCgpLCBwcmVmaXgpOworICAgIG1lbWNweShwcmVmaXhCdWZmZXIuZ2V0KCksIHByZWZpeCwgcHJl Zml4TGVuZ3RoKTsKICAgICBmb3IgKGludCBpID0gMDsgaSA8IGFtb3VudE9mTm9kZVdoaXRlU3Bh Y2U7ICsraSkKICAgICAgICAgcHJlZml4QnVmZmVyW2kgKyBwcmVmaXhMZW5ndGhdID0gJyAnOwog ICAgIHByZWZpeEJ1ZmZlcltwcmVmaXhMZW5ndGggKyBhbW91bnRPZk5vZGVXaGl0ZVNwYWNlXSA9 IDA7Cg==