170642 2017-04-08 12:47:01 -0700 [MediaStream Mac] Revert change of Mac video capture format 2017-04-12 11:24:06 -0700 1 1 1 Unclassified WebKit Media Other Unspecified Unspecified ASSIGNED InRadar P2 Normal --- 1 eric.carlson eric.carlson buildbot commit-queue jonlee sam webkit-bug-importer youennf oldest_to_newest 1295675 0 eric.carlson 2017-04-08 12:47:01 -0700 Revert r214968 which changed macOS video capture format to kCVPixelFormatType_420YpCbCr8BiPlanarFullRange from kCVPixelFormatType_420YpCbCr8Planar because AVSampleBufferDisplayLayer sometimes fails to display the former. 1295676 1 306575 eric.carlson 2017-04-08 12:51:59 -0700 Created attachment 306575 Proposed patch. 1295678 2 webkit-bug-importer 2017-04-08 12:52:33 -0700 <rdar://problem/31520492> 1295679 3 buildbot 2017-04-08 12:53:30 -0700 Attachment 306575 did not pass style-queue: ERROR: Source/WebCore/platform/mediastream/mac/AVVideoCaptureSource.mm:107: Code inside a namespace should not be indented. [whitespace/indent] [4] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1295684 4 306578 eric.carlson 2017-04-08 13:06:10 -0700 Created attachment 306578 Patch. 1295711 5 306578 sam 2017-04-08 16:18:49 -0700 Comment on attachment 306578 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review > Source/WebCore/ChangeLog:9 > + * platform/mediastream/mac/AVVideoCaptureSource.mm: Could use a bit more info about why its being reverted. 1295730 6 306578 eric.carlson 2017-04-08 19:10:14 -0700 Comment on attachment 306578 Patch. View in context: https://bugs.webkit.org/attachment.cgi?id=306578&action=review >> Source/WebCore/ChangeLog:9 >> + * platform/mediastream/mac/AVVideoCaptureSource.mm: > > Could use a bit more info about why its being reverted. Done. 1295731 7 306592 eric.carlson 2017-04-08 19:10:37 -0700 Created attachment 306592 Patch for landing. 1295743 8 306592 commit-queue 2017-04-08 19:51:22 -0700 Comment on attachment 306592 Patch for landing. Clearing flags on attachment: 306592 Committed r215158: <http://trac.webkit.org/changeset/215158> 306575 2017-04-08 12:51:59 -0700 2017-04-08 13:06:10 -0700 Proposed patch. video_capture_format_patch.txt text/plain 1351 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTE0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBACisyMDE3LTA0LTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBN YWNdIFJldmVydCBjaGFuZ2Ugb2YgTWFjIHZpZGVvIGNhcHR1cmUgZm9ybWF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3Ry ZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNvdXJjZS5tbToKKwogMjAxNy0wNC0wOCAgU2ltb24gRnJh c2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnByZWZpeCBDU1MgY3Vy c29yIHZhbHVlcyBncmFiIGFuZCBncmFiYmluZwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL21hYy9BVlZpZGVvQ2FwdHVyZVNv dXJjZS5tbQkocmV2aXNpb24gMjE1MDQzKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0x MDMsNyArMTAzLDExIEBAIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwogCiBuYW1lc3BhY2UgV2Vi Q29yZSB7CiAKLWNvbnN0IE9TVHlwZSB2aWRlb0NhcHR1cmVGb3JtYXQgPSBrQ1ZQaXhlbEZvcm1h dFR5cGVfNDIwWXBDYkNyOEJpUGxhbmFyRnVsbFJhbmdlOworI2lmIFBMQVRGT1JNKE1BQykKKyAg ICBjb25zdCBPU1R5cGUgdmlkZW9DYXB0dXJlRm9ybWF0ID0ga0NWUGl4ZWxGb3JtYXRUeXBlXzQy MFlwQ2JDcjhQbGFuYXI7CisjZWxzZQorICAgIGNvbnN0IE9TVHlwZSB2aWRlb0NhcHR1cmVGb3Jt YXQgPSBrQ1ZQaXhlbEZvcm1hdFR5cGVfNDIwWXBDYkNyOEJpUGxhbmFyRnVsbFJhbmdlOworI2Vu ZGlmCiAKIGNsYXNzIEFWVmlkZW9DYXB0dXJlU291cmNlRmFjdG9yeSA6IHB1YmxpYyBSZWFsdGlt ZU1lZGlhU291cmNlOjpDYXB0dXJlRmFjdG9yeSB7CiBwdWJsaWM6Cg== 306578 2017-04-08 13:06:10 -0700 2017-04-12 11:24:06 -0700 Patch. video_capture_format_patch_2.txt text/plain 1295 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTE0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBN YWNdIFJldmVydCBjaGFuZ2Ugb2YgTWFjIHZpZGVvIGNhcHR1cmUgZm9ybWF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMxNTIwNDkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJl U291cmNlLm1tOgorCiAyMDE3LTA0LTA4ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBw bGUuY29tPgogCiAgICAgICAgIFVucHJlZml4IENTUyBjdXJzb3IgdmFsdWVzIGdyYWIgYW5kIGdy YWJiaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZW aWRlb0NhcHR1cmVTb3VyY2UubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tCShyZXZpc2lvbiAyMTUw NDMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0Nh cHR1cmVTb3VyY2UubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwMyw3ICsxMDMsMTEgQEAgdXNpbmcg bmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAorI2lmIFBMQVRGT1JN KE1BQykKK2NvbnN0IE9TVHlwZSB2aWRlb0NhcHR1cmVGb3JtYXQgPSBrQ1ZQaXhlbEZvcm1hdFR5 cGVfNDIwWXBDYkNyOFBsYW5hcjsKKyNlbHNlCiBjb25zdCBPU1R5cGUgdmlkZW9DYXB0dXJlRm9y bWF0ID0ga0NWUGl4ZWxGb3JtYXRUeXBlXzQyMFlwQ2JDcjhCaVBsYW5hckZ1bGxSYW5nZTsKKyNl bmRpZgogCiBjbGFzcyBBVlZpZGVvQ2FwdHVyZVNvdXJjZUZhY3RvcnkgOiBwdWJsaWMgUmVhbHRp bWVNZWRpYVNvdXJjZTo6Q2FwdHVyZUZhY3RvcnkgewogcHVibGljOgo= 306592 2017-04-08 19:10:37 -0700 2017-04-08 19:51:22 -0700 Patch for landing. video_capture_format_patch_3.txt text/plain 1541 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTE0NikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtNZWRpYVN0cmVhbSBN YWNdIFJldmVydCBjaGFuZ2Ugb2YgTWFjIHZpZGVvIGNhcHR1cmUgZm9ybWF0CisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2NDIKKyAgICAgICAgPHJk YXI6Ly9wcm9ibGVtLzMxNTIwNDkyPgorCisgICAgICAgIFJldmlld2VkIGJ5IFNhbSBXZWluaWcu CisKKyAgICAgICAgUmV2ZXJ0IHIyMTQ5Njggd2hpY2ggY2hhbmdlZCBtYWNPUyB2aWRlbyBjYXB0 dXJlIGZvcm1hdCB0byBrQ1ZQaXhlbEZvcm1hdFR5cGVfNDIwWXBDYkNyOEJpUGxhbmFyRnVsbFJh bmdlCisgICAgICAgIGZyb20ga0NWUGl4ZWxGb3JtYXRUeXBlXzQyMFlwQ2JDcjhQbGFuYXIgYmVj YXVzZSBBVlNhbXBsZUJ1ZmZlckRpc3BsYXlMYXllciBzb21ldGltZXMgZmFpbHMKKyAgICAgICAg dG8gZGlzcGxheSB0aGUgZm9ybWVyLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0v bWFjL0FWVmlkZW9DYXB0dXJlU291cmNlLm1tOgorCiAyMDE3LTA0LTA4ICBTaW1vbiBGcmFzZXIg IDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFVucHJlZml4IENTUyBjdXJzb3Ig dmFsdWVzIGdyYWIgYW5kIGdyYWJiaW5nCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UubW0KPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbWFjL0FWVmlkZW9DYXB0dXJlU291cmNl Lm1tCShyZXZpc2lvbiAyMTUwNDMpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0 cmVhbS9tYWMvQVZWaWRlb0NhcHR1cmVTb3VyY2UubW0JKHdvcmtpbmcgY29weSkKQEAgLTEwMyw3 ICsxMDMsMTEgQEAgdXNpbmcgbmFtZXNwYWNlIFdlYkNvcmU7CiAKIG5hbWVzcGFjZSBXZWJDb3Jl IHsKIAorI2lmIFBMQVRGT1JNKE1BQykKK2NvbnN0IE9TVHlwZSB2aWRlb0NhcHR1cmVGb3JtYXQg PSBrQ1ZQaXhlbEZvcm1hdFR5cGVfNDIwWXBDYkNyOFBsYW5hcjsKKyNlbHNlCiBjb25zdCBPU1R5 cGUgdmlkZW9DYXB0dXJlRm9ybWF0ID0ga0NWUGl4ZWxGb3JtYXRUeXBlXzQyMFlwQ2JDcjhCaVBs YW5hckZ1bGxSYW5nZTsKKyNlbmRpZgogCiBjbGFzcyBBVlZpZGVvQ2FwdHVyZVNvdXJjZUZhY3Rv cnkgOiBwdWJsaWMgUmVhbHRpbWVNZWRpYVNvdXJjZTo6Q2FwdHVyZUZhY3RvcnkgewogcHVibGlj Ogo=