170641 2017-04-08 03:45:24 -0700 WebAssembly: There is a short window of time where a CodeBlock could be destroyed before all of its async compilation callbacks are called 2017-04-14 13:52:44 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam achristensen buildbot commit-queue jfbastien keith_miller mark.lam msaboff oldest_to_newest 1295651 0 saam 2017-04-08 03:45:24 -0700 Thought about this while on the plane. I need to read the code again to prove to myself that this is indeed the case. The race I'm worried about is a failed compilation causing us to create a new CodeBlock before we iterate all the callbacks. 1297413 1 307119 saam 2017-04-14 10:13:19 -0700 Created attachment 307119 patch 1297414 2 307119 keith_miller 2017-04-14 10:17:44 -0700 Comment on attachment 307119 patch r=me. Maybe we should also have the plan null out the tasks after it runs them. 1297418 3 307120 saam 2017-04-14 10:24:08 -0700 Created attachment 307120 patch for landing 1297420 4 307120 keith_miller 2017-04-14 10:26:12 -0700 Comment on attachment 307120 patch for landing adding the clear lgtm. 1297436 5 307120 commit-queue 2017-04-14 11:09:38 -0700 Comment on attachment 307120 patch for landing Clearing flags on attachment: 307120 Committed r215368: <http://trac.webkit.org/changeset/215368> 1297437 6 commit-queue 2017-04-14 11:09:40 -0700 All reviewed patches have been landed. Closing bug. 1297492 7 achristensen 2017-04-14 13:52:44 -0700 http://trac.webkit.org/r215373 307119 2017-04-14 10:13:19 -0700 2017-04-14 10:24:08 -0700 patch b-backup.diff text/plain 3200 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1MzYyKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBA CisyMDE3LTA0LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBUaGVyZSBpcyBhIHNob3J0IHdpbmRvdyBvZiB0aW1lIHdoZXJlIGEgQ29k ZUJsb2NrIGNvdWxkIGJlIGRlc3Ryb3llZCBiZWZvcmUgYWxsIG9mIGl0cyBhc3luYyBjb21waWxh dGlvbiBjYWxsYmFja3MgYXJlIGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhlcmUgaXMgYW4gdW5saWtlbHkgcmFjZSB3aGVuIGEgQ29kZUJs b2NrIGNvbXBpbGF0aW9uIGZhaWxzLAorICAgICAgICB0aGUgbW9kdWxlIGNvbXBpbGVzIGEgbmV3 IENvZGVCbG9jayBmb3IgdGhhdCBtZW1vcnkgbW9kZSwgYWxsIHdoaWxlCisgICAgICAgIHRoZSBD b2RlQmxvY2sgaXMgbm90aWZ5aW5nIGl0cyBjYWxsYmFja3MgdGhhdCBpdCBoYXMgZmluaXNoZWQu CisgICAgICAgIFRoZXJlIGlzIGEgY2hhbmNlIHRoYXQgdGhlIE1vZHVsZSBjb3VsZCBkZXJlZiBp dHMgZmFpbGVkIENvZGVCbG9jayAKKyAgICAgICAgYXQgdGhhdCBwb2ludCwgZGVzdHJveWluZyBp dCwgYmVmb3JlIHRoZSBjYWxsYmFja3Mgd2VyZSBhYmxlIHRvCisgICAgICAgIGdyYWIgYSBSZWYg dG8gdGhlIENvZGVCbG9jay4gVGhpcyBwYXRjaCBmaXhlcyB0aGUgcmFjZSBieSBoYXZpbmcgdGhl CisgICAgICAgIGNhbGxiYWNrcyByZWYgdGhlIENvZGVCbG9jay4KKworICAgICAgICAqIHdhc20v V2FzbUNvZGVCbG9jay5jcHA6CisgICAgICAgIChKU0M6Oldhc206OkNvZGVCbG9jazo6Q29kZUJs b2NrKToKKyAgICAgICAgKEpTQzo6V2FzbTo6Q29kZUJsb2NrOjpjb21waWxlQXN5bmMpOgorCiAy MDE3LTA0LTEzICBKRiBCYXN0aWVuICA8amZiYXN0aWVuQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJBc3NlbWJseTogZml4IHdpbmRvd3MgYnVpbGQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS93YXNtL1dhc21Db2RlQmxvY2suY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS93YXNtL1dhc21Db2RlQmxvY2suY3BwCShyZXZpc2lvbiAyMTUzNjIpCisrKyBTb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQ29kZUJsb2NrLmNwcAkod29ya2luZyBjb3B5KQpAQCAt MzksMTEgKzM5LDggQEAgQ29kZUJsb2NrOjpDb2RlQmxvY2soVk0mIHZtLCBNZW1vcnlNb2RlIAog ICAgIDogbV9jYWxsZWVDb3VudChtb2R1bGVJbmZvcm1hdGlvbi5pbnRlcm5hbEZ1bmN0aW9uQ291 bnQoKSkKICAgICAsIG1fbW9kZShtb2RlKQogewotICAgIG1fcGxhbiA9IGFkb3B0UmVmKCpuZXcg UGxhbih2bSwgbWFrZVJlZihtb2R1bGVJbmZvcm1hdGlvbiksIFBsYW46OkZ1bGxDb21waWxlLCBj cmVhdGVTaGFyZWRUYXNrPFBsYW46OkNhbGxiYWNrVHlwZT4oW3RoaXNdIChWTSYsIFBsYW4mKSB7 Ci0gICAgICAgIC8vIEl0J3Mgc2FmZSB0byB1c2UgfHRoaXN8IGhlcmUgYmVjYXVzZSBvdXIgTW9k dWxlIG93bnMgdXMsIGFuZCBhIE1vZHVsZQotICAgICAgICAvLyBjYW4ndCBiZSBkZXN0cm95ZWQg dW50aWwgaXQgaGFzIGZpbmlzaGVkIGNvbXBpbGluZyBpdHMgdmFyaW91cyBXYXNtIGJpdHMuCi0g ICAgICAgIC8vIFRoZSBKUyBBUEkgZW5zdXJlcyB0aGlzIGludmFyaWFudCBieSBrZWVwaW5nIGFs aXZlIHRoZSBtb2R1bGUgYXMgaXQgaGFzCi0gICAgICAgIC8vIGEgcGVuZGluZyBwcm9taXNlLgor ICAgIFJlZlB0cjxDb2RlQmxvY2s+IHByb3RlY3RlZFRoaXMgPSB0aGlzOworICAgIG1fcGxhbiA9 IGFkb3B0UmVmKCpuZXcgUGxhbih2bSwgbWFrZVJlZihtb2R1bGVJbmZvcm1hdGlvbiksIFBsYW46 OkZ1bGxDb21waWxlLCBjcmVhdGVTaGFyZWRUYXNrPFBsYW46OkNhbGxiYWNrVHlwZT4oW3RoaXMs IHByb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3RlY3RlZFRoaXMpXSAoVk0mLCBQbGFuJikgewog ICAgICAgICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fbG9jayk7CiAgICAgICAgIGlmIChtX3Bs YW4tPmZhaWxlZCgpKSB7CiAgICAgICAgICAgICBtX2Vycm9yTWVzc2FnZSA9IG1fcGxhbi0+ZXJy b3JNZXNzYWdlKCk7CkBAIC05NCw5ICs5MSwxMCBAQCB2b2lkIENvZGVCbG9jazo6Y29tcGlsZUFz eW5jKFZNJiB2bSwgQXN5CiAgICAgfQogCiAgICAgaWYgKHBsYW4pIHsKLSAgICAgICAgLy8gT3Vy IGxpZmV0aW1lIGlzIGd1YXJhbnRlZWQgYnkgdGhlIEpTIGNvZGUgYnkgaGF2aW5nIGl0Ci0gICAg ICAgIC8vIGtlZXAgYWxpdmUgdGhlIEpTIG9iamVjdHMgdGhhdCBlbnN1cmUgb3VyIGxpZmV0aW1l LgotICAgICAgICBwbGFuLT5hZGRDb21wbGV0aW9uVGFzayh2bSwgY3JlYXRlU2hhcmVkVGFzazxQ bGFuOjpDYWxsYmFja1R5cGU+KFt0aGlzLCB0YXNrID0gV1RGTW92ZSh0YXNrKV0gKFZNJiB2bSwg UGxhbiYpIHsKKyAgICAgICAgLy8gV2UgZG9uJ3QgbmVlZCB0byBrZWVwIGEgUmVmUHRyIG9uIHRo ZSBQbGFuIGJlY2F1c2UgdGhlIHdvcmtsaXN0IHdpbGwga2VlcAorICAgICAgICAvLyBhIFJlZlB0 ciBvbiB0aGUgUGxhbiB1bnRpbCB0aGUgcGxhbiBmaW5pc2hlcyBub3RpZnlpbmcgYWxsIG9mIGl0 cyBjYWxsYmFja3MuCisgICAgICAgIFJlZlB0cjxDb2RlQmxvY2s+IHByb3RlY3RlZFRoaXMgPSB0 aGlzOworICAgICAgICBwbGFuLT5hZGRDb21wbGV0aW9uVGFzayh2bSwgY3JlYXRlU2hhcmVkVGFz azxQbGFuOjpDYWxsYmFja1R5cGU+KFt0aGlzLCB0YXNrID0gV1RGTW92ZSh0YXNrKSwgcHJvdGVj dGVkVGhpcyA9IFdURk1vdmUocHJvdGVjdGVkVGhpcyldIChWTSYgdm0sIFBsYW4mKSB7CiAgICAg ICAgICAgICB0YXNrLT5ydW4odm0sIG1ha2VSZWYoKnRoaXMpKTsKICAgICAgICAgfSkpOwogICAg IH0gZWxzZQo= 307120 2017-04-14 10:24:08 -0700 2017-04-14 11:09:38 -0700 patch for landing b-backup.diff text/plain 3976 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1MzYzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI4IEBA CisyMDE3LTA0LTE0ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBUaGVyZSBpcyBhIHNob3J0IHdpbmRvdyBvZiB0aW1lIHdoZXJlIGEgQ29k ZUJsb2NrIGNvdWxkIGJlIGRlc3Ryb3llZCBiZWZvcmUgYWxsIG9mIGl0cyBhc3luYyBjb21waWxh dGlvbiBjYWxsYmFja3MgYXJlIGNhbGxlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjQxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgS2VpdGggTWls bGVyLgorCisgICAgICAgIFRoZXJlIGlzIGFuIHVubGlrZWx5IHJhY2Ugd2hlbiBhIENvZGVCbG9j ayBjb21waWxhdGlvbiBmYWlscywKKyAgICAgICAgdGhlIG1vZHVsZSBjb21waWxlcyBhIG5ldyBD b2RlQmxvY2sgZm9yIHRoYXQgbWVtb3J5IG1vZGUsIGFsbCB3aGlsZQorICAgICAgICB0aGUgQ29k ZUJsb2NrIGlzIG5vdGlmeWluZyBpdHMgY2FsbGJhY2tzIHRoYXQgaXQgaGFzIGZpbmlzaGVkLgor ICAgICAgICBUaGVyZSBpcyBhIGNoYW5jZSB0aGF0IHRoZSBNb2R1bGUgY291bGQgZGVyZWYgaXRz IGZhaWxlZCBDb2RlQmxvY2sgCisgICAgICAgIGF0IHRoYXQgcG9pbnQsIGRlc3Ryb3lpbmcgaXQs IGJlZm9yZSB0aGUgY2FsbGJhY2tzIHdlcmUgYWJsZSB0bworICAgICAgICBncmFiIGEgUmVmIHRv IHRoZSBDb2RlQmxvY2suIFRoaXMgcGF0Y2ggZml4ZXMgdGhlIHJhY2UgYnkgaGF2aW5nIHRoZQor ICAgICAgICBjYWxsYmFja3MgcmVmIHRoZSBDb2RlQmxvY2suCisKKyAgICAgICAgVGhpcyBwYXRj aCBhbHNvIGhhcyB0aGUgUGxhbiBjbGVhciBvdXQgYWxsIG9mIGl0cyBjYWxsYmFja3MKKyAgICAg ICAgb25jZSBpdCBnZXRzIGNvbXBsZXRlZC4gVGhpcyBhZGRzIGFuIGV4dHJhIGRlZmVuc2UgdG8g YW55Ym9keQorICAgICAgICB0aGF0IGdyYWJzIHJlZnMgdG8gdGhlIFBsYW4gaW4gdGhlIGNhbGxi YWNrLgorCisgICAgICAgICogd2FzbS9XYXNtQ29kZUJsb2NrLmNwcDoKKyAgICAgICAgKEpTQzo6 V2FzbTo6Q29kZUJsb2NrOjpDb2RlQmxvY2spOgorICAgICAgICAoSlNDOjpXYXNtOjpDb2RlQmxv Y2s6OmNvbXBpbGVBc3luYyk6CisgICAgICAgICogd2FzbS9XYXNtUGxhbi5jcHA6CisgICAgICAg IChKU0M6Oldhc206OlBsYW46OmNvbXBsZXRlKToKKwogMjAxNy0wNC0xMyAgSkYgQmFzdGllbiAg PGpmYmFzdGllbkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHk6IGZpeCB3aW5kb3dz IGJ1aWxkCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQ29kZUJsb2NrLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQ29kZUJsb2Nr LmNwcAkocmV2aXNpb24gMjE1MzYyKQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2Fz bUNvZGVCbG9jay5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM5LDExICszOSw4IEBAIENvZGVCbG9j azo6Q29kZUJsb2NrKFZNJiB2bSwgTWVtb3J5TW9kZSAKICAgICA6IG1fY2FsbGVlQ291bnQobW9k dWxlSW5mb3JtYXRpb24uaW50ZXJuYWxGdW5jdGlvbkNvdW50KCkpCiAgICAgLCBtX21vZGUobW9k ZSkKIHsKLSAgICBtX3BsYW4gPSBhZG9wdFJlZigqbmV3IFBsYW4odm0sIG1ha2VSZWYobW9kdWxl SW5mb3JtYXRpb24pLCBQbGFuOjpGdWxsQ29tcGlsZSwgY3JlYXRlU2hhcmVkVGFzazxQbGFuOjpD YWxsYmFja1R5cGU+KFt0aGlzXSAoVk0mLCBQbGFuJikgewotICAgICAgICAvLyBJdCdzIHNhZmUg dG8gdXNlIHx0aGlzfCBoZXJlIGJlY2F1c2Ugb3VyIE1vZHVsZSBvd25zIHVzLCBhbmQgYSBNb2R1 bGUKLSAgICAgICAgLy8gY2FuJ3QgYmUgZGVzdHJveWVkIHVudGlsIGl0IGhhcyBmaW5pc2hlZCBj b21waWxpbmcgaXRzIHZhcmlvdXMgV2FzbSBiaXRzLgotICAgICAgICAvLyBUaGUgSlMgQVBJIGVu c3VyZXMgdGhpcyBpbnZhcmlhbnQgYnkga2VlcGluZyBhbGl2ZSB0aGUgbW9kdWxlIGFzIGl0IGhh cwotICAgICAgICAvLyBhIHBlbmRpbmcgcHJvbWlzZS4KKyAgICBSZWZQdHI8Q29kZUJsb2NrPiBw cm90ZWN0ZWRUaGlzID0gdGhpczsKKyAgICBtX3BsYW4gPSBhZG9wdFJlZigqbmV3IFBsYW4odm0s IG1ha2VSZWYobW9kdWxlSW5mb3JtYXRpb24pLCBQbGFuOjpGdWxsQ29tcGlsZSwgY3JlYXRlU2hh cmVkVGFzazxQbGFuOjpDYWxsYmFja1R5cGU+KFt0aGlzLCBwcm90ZWN0ZWRUaGlzID0gV1RGTW92 ZShwcm90ZWN0ZWRUaGlzKV0gKFZNJiwgUGxhbiYpIHsKICAgICAgICAgYXV0byBsb2NrZXIgPSBo b2xkTG9jayhtX2xvY2spOwogICAgICAgICBpZiAobV9wbGFuLT5mYWlsZWQoKSkgewogICAgICAg ICAgICAgbV9lcnJvck1lc3NhZ2UgPSBtX3BsYW4tPmVycm9yTWVzc2FnZSgpOwpAQCAtOTQsOSAr OTEsMTAgQEAgdm9pZCBDb2RlQmxvY2s6OmNvbXBpbGVBc3luYyhWTSYgdm0sIEFzeQogICAgIH0K IAogICAgIGlmIChwbGFuKSB7Ci0gICAgICAgIC8vIE91ciBsaWZldGltZSBpcyBndWFyYW50ZWVk IGJ5IHRoZSBKUyBjb2RlIGJ5IGhhdmluZyBpdAotICAgICAgICAvLyBrZWVwIGFsaXZlIHRoZSBK UyBvYmplY3RzIHRoYXQgZW5zdXJlIG91ciBsaWZldGltZS4KLSAgICAgICAgcGxhbi0+YWRkQ29t cGxldGlvblRhc2sodm0sIGNyZWF0ZVNoYXJlZFRhc2s8UGxhbjo6Q2FsbGJhY2tUeXBlPihbdGhp cywgdGFzayA9IFdURk1vdmUodGFzayldIChWTSYgdm0sIFBsYW4mKSB7CisgICAgICAgIC8vIFdl IGRvbid0IG5lZWQgdG8ga2VlcCBhIFJlZlB0ciBvbiB0aGUgUGxhbiBiZWNhdXNlIHRoZSB3b3Jr bGlzdCB3aWxsIGtlZXAKKyAgICAgICAgLy8gYSBSZWZQdHIgb24gdGhlIFBsYW4gdW50aWwgdGhl IHBsYW4gZmluaXNoZXMgbm90aWZ5aW5nIGFsbCBvZiBpdHMgY2FsbGJhY2tzLgorICAgICAgICBS ZWZQdHI8Q29kZUJsb2NrPiBwcm90ZWN0ZWRUaGlzID0gdGhpczsKKyAgICAgICAgcGxhbi0+YWRk Q29tcGxldGlvblRhc2sodm0sIGNyZWF0ZVNoYXJlZFRhc2s8UGxhbjo6Q2FsbGJhY2tUeXBlPihb dGhpcywgdGFzayA9IFdURk1vdmUodGFzayksIHByb3RlY3RlZFRoaXMgPSBXVEZNb3ZlKHByb3Rl Y3RlZFRoaXMpXSAoVk0mIHZtLCBQbGFuJikgewogICAgICAgICAgICAgdGFzay0+cnVuKHZtLCBt YWtlUmVmKCp0aGlzKSk7CiAgICAgICAgIH0pKTsKICAgICB9IGVsc2UKSW5kZXg6IFNvdXJjZS9K YXZhU2NyaXB0Q29yZS93YXNtL1dhc21QbGFuLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtUGxhbi5jcHAJKHJldmlzaW9uIDIxNTM2MikKKysrIFNvdXJj ZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21QbGFuLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI1 LDYgKzMyNSw3IEBAIHZvaWQgUGxhbjo6Y29tcGxldGUoY29uc3QgQWJzdHJhY3RMb2NrZXIKICAg ICAgICAgbW92ZVRvU3RhdGUoU3RhdGU6OkNvbXBsZXRlZCk7CiAgICAgICAgIGZvciAoYXV0byYg dGFzayA6IG1fY29tcGxldGlvblRhc2tzKQogICAgICAgICAgICAgdGFzay5zZWNvbmQtPnJ1bigq dGFzay5maXJzdCwgKnRoaXMpOworICAgICAgICBtX2NvbXBsZXRpb25UYXNrcy5jbGVhcigpOwog ICAgICAgICBtX2NvbXBsZXRlZC5ub3RpZnlBbGwoKTsKICAgICB9CiB9Cg==