170638 2017-04-07 20:10:09 -0700 WebAssembly: Fix issue with BrTable targeting a Loop 2017-04-07 22:30:51 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller buildbot commit-queue mark.lam msaboff saam oldest_to_newest 1295628 0 keith_miller 2017-04-07 20:10:09 -0700 WebAssembly: Fix issue with BrTable targeting a Loop 1295629 1 306565 keith_miller 2017-04-07 20:12:31 -0700 Created attachment 306565 Patch 1295633 2 306565 saam 2017-04-07 21:34:45 -0700 Comment on attachment 306565 Patch Please add a test 1295634 3 keith_miller 2017-04-07 21:36:00 -0700 There is a test in the spec-tests. I'm planning to import the next round of those tests shortly. 1295637 4 saam 2017-04-07 22:03:17 -0700 (In reply to Keith Miller from comment #3) > There is a test in the spec-tests. I'm planning to import the next round of > those tests shortly. 👍🏽 1295639 5 306565 commit-queue 2017-04-07 22:30:50 -0700 Comment on attachment 306565 Patch Clearing flags on attachment: 306565 Committed r215141: <http://trac.webkit.org/changeset/215141> 1295640 6 commit-queue 2017-04-07 22:30:51 -0700 All reviewed patches have been landed. Closing bug. 306565 2017-04-07 20:12:31 -0700 2017-04-07 22:30:50 -0700 Patch bug-170638-20170407201230.patch text/plain 3283 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MTI2CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBk NDNkYmE4ZWE1MGIzYzM4YWI5YTJmYTU4M2M2ZDBjNjhjZDM3ZmNlLi5jNjU1OTJmNjUzMDFmODk0 YTc1MTk4NjI2YTFhNjFhY2VjZDUxYWQ0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxNy0wNC0wNyAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJBc3NlbWJseTogRml4IGlzc3VlIHdpdGggQnJUYWJsZSB0YXJn ZXRpbmcgYSBMb29wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzA2MzgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGlzIGZpeGVzIHRoZSBzYW1lIGlzc3VlIFY4IGhhZCBpbjogaHR0cHM6Ly9naXRodWIu Y29tL1dlYkFzc2VtYmx5L3NwZWMvcHVsbC80NTYjZXZlbnQtMTAzMzU0NzUzNworCisgICAgICAg ICogd2FzbS9XYXNtVmFsaWRhdGUuY3BwOgorICAgICAgICAoSlNDOjpXYXNtOjpWYWxpZGF0ZTo6 Q29udHJvbERhdGE6OmJyYW5jaFRhcmdldFNpZ25hdHVyZSk6CisKIDIwMTctMDQtMDcgIFNhYW0g QmFyYXRpICA8c2JhcmF0aUBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViQXNzZW1ibHk6IE1vZHVs ZTo6Z2V0T3JDcmVhdGVDb2RlQmxvY2sgaXMgd3JvbmcKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS93YXNtL1dhc21WYWxpZGF0ZS5jcHAgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUv d2FzbS9XYXNtVmFsaWRhdGUuY3BwCmluZGV4IGQ5NDk4MTllMmIzOTEzNGY0Mzg4NWYxMGRmNDMx MjY5Mzg5Y2NkZDkuLmRkMjgzZWE4MTE1NmY4MTRjODJiMjU4NjUyNjkyMjAwMDM0NTA1ZTUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21WYWxpZGF0ZS5jcHAKKysr IGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbVZhbGlkYXRlLmNwcApAQCAtNzEsNiAr NzEsNyBAQCBwdWJsaWM6CiAKICAgICAgICAgQmxvY2tUeXBlIHR5cGUoKSBjb25zdCB7IHJldHVy biBtX2Jsb2NrVHlwZTsgfQogICAgICAgICBUeXBlIHNpZ25hdHVyZSgpIGNvbnN0IHsgcmV0dXJu IG1fc2lnbmF0dXJlOyB9CisgICAgICAgIFR5cGUgYnJhbmNoVGFyZ2V0U2lnbmF0dXJlKCkgY29u c3QgeyByZXR1cm4gdHlwZSgpID09IEJsb2NrVHlwZTo6TG9vcCA/IFZvaWQgOiBzaWduYXR1cmUo KTsgfQogICAgIHByaXZhdGU6CiAgICAgICAgIEJsb2NrVHlwZSBtX2Jsb2NrVHlwZTsKICAgICAg ICAgVHlwZSBtX3NpZ25hdHVyZTsKQEAgLTI2NSwxOCArMjY2LDE1IEBAIGF1dG8gVmFsaWRhdGU6 OmFkZFJldHVybihDb250cm9sVHlwZSYgdG9wTGV2ZWwsIGNvbnN0IEV4cHJlc3Npb25MaXN0JiBy ZXR1cm5WYWx1CiB9CiAKIGF1dG8gVmFsaWRhdGU6OmNoZWNrQnJhbmNoVGFyZ2V0KENvbnRyb2xU eXBlJiB0YXJnZXQsIGNvbnN0IEV4cHJlc3Npb25MaXN0JiBleHByZXNzaW9uU3RhY2spIC0+IFJl c3VsdAotICAgIHsKLSAgICAgICAgaWYgKHRhcmdldC50eXBlKCkgPT0gQmxvY2tUeXBlOjpMb29w KQotICAgICAgICAgICAgcmV0dXJuIHsgfTsKLQotICAgICAgICBpZiAodGFyZ2V0LnNpZ25hdHVy ZSgpID09IFZvaWQpCi0gICAgICAgICAgICByZXR1cm4geyB9OworeworICAgIGlmICh0YXJnZXQu YnJhbmNoVGFyZ2V0U2lnbmF0dXJlKCkgPT0gVm9pZCkKKyAgICAgICAgcmV0dXJuIHsgfTsKIAot ICAgICAgICBXQVNNX1ZBTElEQVRPUl9GQUlMX0lGKGV4cHJlc3Npb25TdGFjay5pc0VtcHR5KCks IHRhcmdldC50eXBlKCkgPT0gQmxvY2tUeXBlOjpUb3BMZXZlbCA/ICJicmFuY2ggb3V0IG9mIGZ1 bmN0aW9uIiA6ICJicmFuY2ggdG8gYmxvY2siLCAiIG9uIGVtcHR5IGV4cHJlc3Npb24gc3RhY2ss IGJ1dCBleHBlY3RlZCAiLCB0YXJnZXQuc2lnbmF0dXJlKCkpOwotICAgICAgICBXQVNNX1ZBTElE QVRPUl9GQUlMX0lGKHRhcmdldC5zaWduYXR1cmUoKSAhPSBleHByZXNzaW9uU3RhY2subGFzdCgp LCAiYnJhbmNoJ3Mgc3RhY2sgdHlwZSBkb2Vzbid0IG1hdGNoIGJsb2NrJ3MgdHlwZSIpOworICAg IFdBU01fVkFMSURBVE9SX0ZBSUxfSUYoZXhwcmVzc2lvblN0YWNrLmlzRW1wdHkoKSwgdGFyZ2V0 LnR5cGUoKSA9PSBCbG9ja1R5cGU6OlRvcExldmVsID8gImJyYW5jaCBvdXQgb2YgZnVuY3Rpb24i IDogImJyYW5jaCB0byBibG9jayIsICIgb24gZW1wdHkgZXhwcmVzc2lvbiBzdGFjaywgYnV0IGV4 cGVjdGVkICIsIHRhcmdldC5zaWduYXR1cmUoKSk7CisgICAgV0FTTV9WQUxJREFUT1JfRkFJTF9J Rih0YXJnZXQuYnJhbmNoVGFyZ2V0U2lnbmF0dXJlKCkgIT0gZXhwcmVzc2lvblN0YWNrLmxhc3Qo KSwgImJyYW5jaCdzIHN0YWNrIHR5cGUgZG9lc24ndCBtYXRjaCBibG9jaydzIHR5cGUiKTsKIAot ICAgICAgICByZXR1cm4geyB9OwotICAgIH0KKyAgICByZXR1cm4geyB9OworfQogCiBhdXRvIFZh bGlkYXRlOjphZGRCcmFuY2goQ29udHJvbFR5cGUmIHRhcmdldCwgRXhwcmVzc2lvblR5cGUgY29u ZGl0aW9uLCBjb25zdCBFeHByZXNzaW9uTGlzdCYgc3RhY2spIC0+IFJlc3VsdAogewpAQCAtMjkw LDcgKzI4OCw3IEBAIGF1dG8gVmFsaWRhdGU6OmFkZFN3aXRjaChFeHByZXNzaW9uVHlwZSBjb25k aXRpb24sIGNvbnN0IFZlY3RvcjxDb250cm9sRGF0YSo+JiB0CiAgICAgV0FTTV9WQUxJREFUT1Jf RkFJTF9JRihjb25kaXRpb24gIT0gSTMyLCAiYnJfdGFibGUgd2l0aCBub24taTMyIGNvbmRpdGlv biAiLCBjb25kaXRpb24pOwogCiAgICAgZm9yIChhdXRvIHRhcmdldCA6IHRhcmdldHMpCi0gICAg ICAgIFdBU01fVkFMSURBVE9SX0ZBSUxfSUYoZGVmYXVsdFRhcmdldC5zaWduYXR1cmUoKSAhPSB0 YXJnZXQtPnNpZ25hdHVyZSgpLCAiYnJfdGFibGUgdGFyZ2V0IHR5cGUgbWlzbWF0Y2giKTsKKyAg ICAgICAgV0FTTV9WQUxJREFUT1JfRkFJTF9JRihkZWZhdWx0VGFyZ2V0LmJyYW5jaFRhcmdldFNp Z25hdHVyZSgpICE9IHRhcmdldC0+YnJhbmNoVGFyZ2V0U2lnbmF0dXJlKCksICJicl90YWJsZSB0 YXJnZXQgdHlwZSBtaXNtYXRjaCIpOwogCiAgICAgcmV0dXJuIGNoZWNrQnJhbmNoVGFyZ2V0KGRl ZmF1bHRUYXJnZXQsIGV4cHJlc3Npb25TdGFjayk7CiB9Cg==