170630 2017-04-07 17:24:24 -0700 Align the timers for throttled rAF to reduce power usage 2017-04-11 01:26:02 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170719 InRadar P2 Normal --- 1 simon.fraser simon.fraser barraclough buildbot cdumez cgarcia dbates esprehn+autocc jonlee kangil.han simon.fraser webkit-bug-importer zan oldest_to_newest 1295578 0 simon.fraser 2017-04-07 17:24:24 -0700 Align the timers for throttled rAF to reduce power usage 1295582 1 306553 simon.fraser 2017-04-07 17:26:19 -0700 Created attachment 306553 Patch 1295708 2 306553 cdumez 2017-04-08 16:04:43 -0700 Comment on attachment 306553 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306553&action=review r=me > Source/WebCore/dom/ScriptedAnimationController.cpp:313 > + Seconds alignment = (fireTime + alignmentInterval / 2).secondsSinceEpoch() % alignmentInterval; MonotonicTime has % operator, so I don't think we need .secondsSinceEpoch(), do we? 1295910 3 jonlee 2017-04-10 00:09:01 -0700 rdar://problem/31490620 1296307 4 cgarcia 2017-04-11 01:11:28 -0700 This landed in r215153, but I guess you forgot to close the bug. This broke RAF animations in GTK+ port, there must be something wrong in the aligned fire time calculation, because we are getting negative delays. 1296311 5 cgarcia 2017-04-11 01:21:04 -0700 Ah, wait, I think the problem is that in mac port, the timer is only used when throttling. Anyway, I'll close this bug and open a new one. 1296312 6 306553 cgarcia 2017-04-11 01:22:07 -0700 Comment on attachment 306553 Patch Committed r215153: <http://trac.webkit.org/changeset/215153> 306553 2017-04-07 17:26:19 -0700 2017-04-11 01:22:07 -0700 Patch bug-170630-20170407172619.patch text/plain 2378 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDcwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTY0MWU1NmRjOWJhNTM5 NTY2N2NjNDQ2MjE1OGM3NzMwN2Y5MTY4OS4uNWUxMDUwZTcyNzYwYzgwOGJlZmVjODg2OGI1ZDMw ZGMzZGM0MzdhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTA3ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIEFsaWduIHRoZSB0 aW1lcnMgZm9yIHRocm90dGxlZCByQUYgdG8gcmVkdWNlIHBvd2VyIHVzYWdlCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2MzAKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vMzE0OTA2MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBBbGlnbiB0aGUgdGltZXJzIGZvciBhbGwgdGhyb3R0bGVkIFNjcmlwdGVk QW5pbWF0aW9uQ29udHJvbGxlcnMgaW4gdGhlIHByb2Nlc3Mgd2l0aAorICAgICAgICBhIHJlc29s dXRpb24gb2YgMzBtcywgd2hpY2ggcmVkdWNlcyBwcm9jZXNzIHdha2UtdXBzIGFuZCB0aHVzIHNh dmVzIHBvd2VyLgorCisgICAgICAgICogZG9tL1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5j cHA6CisgICAgICAgIChXZWJDb3JlOjpTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXI6OnNjaGVk dWxlQW5pbWF0aW9uKToKKwogMjAxNy0wNC0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2Vy QGFwcGxlLmNvbT4KIAogICAgICAgICBUaHJvdHRsZSByZXF1ZXN0QW5pbWF0aW9uRnJhbWUgaW4g Y3Jvc3Mtb3JpZ2luIGlmcmFtZXMgdG8gMzBmcHMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2RvbS9TY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvZG9t L1NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlci5jcHAKaW5kZXggNTRkZDM0ZmEzOTczOTlhZmMz YjIyODA3MTAxZGE3ZGNkYjIyOGYyNy4uYzU3MWRmOWU5MGM2ODg3ZjZmNTU0NTBlZjNiODY4NGE0 YTIzM2E5MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9u Q29udHJvbGxlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL1NjcmlwdGVkQW5pbWF0aW9u Q29udHJvbGxlci5jcHAKQEAgLTMwMyw4ICszMDMsMTggQEAgdm9pZCBTY3JpcHRlZEFuaW1hdGlv bkNvbnRyb2xsZXI6OnNjaGVkdWxlQW5pbWF0aW9uKCkKICAgICAgICAgcmV0dXJuOwogCiAgICAg U2Vjb25kcyBhbmltYXRpb25JbnRlcnZhbCA9IGludGVydmFsKCk7Ci0gICAgZG91YmxlIHNjaGVk dWxlRGVsYXkgPSBzdGQ6Om1heDxkb3VibGU+KGFuaW1hdGlvbkludGVydmFsLnZhbHVlKCkgLSAo bV9kb2N1bWVudC0+ZG9tV2luZG93KCktPm5vd1RpbWVzdGFtcCgpIC0gbV9sYXN0QW5pbWF0aW9u RnJhbWVUaW1lc3RhbXApLCAwKTsKLSAgICBtX2FuaW1hdGlvblRpbWVyLnN0YXJ0T25lU2hvdChz Y2hlZHVsZURlbGF5KTsKKworICAgIC8vIEZJWE1FOiBub3QgaWRlYWwgdG8gc25hcHNob3QgdGlt ZSBib3RoIGluIG5vdygpIGFuZCBub3dUaW1lc3RhbXAoKSwgdGhlIGxhdHRlciBvZiB3aGljaCBh bHNvIGhhcyByZWR1Y2VkIHJlc29sdXRpb24uCisgICAgTW9ub3RvbmljVGltZSBub3cgPSBNb25v dG9uaWNUaW1lOjpub3coKTsKKworICAgIE1vbm90b25pY1RpbWUgZmlyZVRpbWUgPSBub3cgKyBz dGQ6Om1heChhbmltYXRpb25JbnRlcnZhbCAtIFNlY29uZHMobV9kb2N1bWVudC0+ZG9tV2luZG93 KCktPm5vd1RpbWVzdGFtcCgpIC0gbV9sYXN0QW5pbWF0aW9uRnJhbWVUaW1lc3RhbXApLCAwX3Mp OworICAgIFNlY29uZHMgYWxpZ25tZW50SW50ZXJ2YWwgPSAzMF9tczsKKyAgICAvLyBTbmFwIHRv IHRoZSBuZWFyZXN0IGFsaWdubWVudEludGVydmFsLgorICAgIFNlY29uZHMgYWxpZ25tZW50ID0g KGZpcmVUaW1lICsgYWxpZ25tZW50SW50ZXJ2YWwgLyAyKS5zZWNvbmRzU2luY2VFcG9jaCgpICUg YWxpZ25tZW50SW50ZXJ2YWw7CisgICAgTW9ub3RvbmljVGltZSBhbGlnbmVkRmlyZVRpbWUgPSBm aXJlVGltZSAtIGFsaWdubWVudDsKKworICAgIG1fYW5pbWF0aW9uVGltZXIuc3RhcnRPbmVTaG90 KGFsaWduZWRGaXJlVGltZSAtIG5vdyk7CisKICAgICBkaXNwYXRjaExvZ2dpbmdFdmVudElmUmVx dWlyZWQoInJhZi1zY2hlZHVsZS1hbmltYXRpb24tdGltZXIiKTsKICNlbHNlCiAgICAgaWYgKEZy YW1lVmlldyogZnJhbWVWaWV3ID0gbV9kb2N1bWVudC0+dmlldygpKQo=