170620 2017-04-07 14:53:14 -0700 REGRESSION: LayoutTest media/controls/pip-placeholder-without-video-controls.html is a flaky failure 2026-01-12 09:03:04 -0800 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 1 ryanhaddad webkit-unassigned graouts webkit-bug-importer oldest_to_newest 1295496 0 ryanhaddad 2017-04-07 14:53:14 -0700 LayoutTest media/controls/pip-placeholder-without-video-controls.html is a flaky failure https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r215094%20(498)/results.html https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=media%2Fcontrols%2Fpip-placeholder-without-video-controls.html --- /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/controls/pip-placeholder-without-video-controls-expected.txt +++ /Volumes/Data/slave/sierra-release-tests-wk2/build/layout-test-results/media/controls/pip-placeholder-without-video-controls-actual.txt @@ -10,7 +10,7 @@ EVENT: webkitpresentationmodechanged PASS: Should be in pip mode PASS: Inline placeholder should be visible at this point -PASS: Inline placeholder should have the 'picture-in-picture' class +FAIL: Inline placeholder should have the 'picture-in-picture' class Expected to contain "picture-in-picture". Actual: "appletv" Testing finished. 1295497 1 ryanhaddad 2017-04-07 14:53:39 -0700 This is limited to the Sierra Release WK2 bots according to flakiness dashboard. 1414533 2 ryanhaddad 2018-04-13 16:38:40 -0700 (In reply to Ryan Haddad from comment #1) > This is limited to the Sierra Release WK2 bots according to flakiness > dashboard. It looks like the test is also flaky on High Sierra Release WK2, too (though it doesn't fail nearly as often as it does on Sierra). 1419427 3 webkit-bug-importer 2018-05-01 14:35:04 -0700 <rdar://problem/39879021> 1420270 4 ryanhaddad 2018-05-03 12:42:43 -0700 Marked test as flaky in https://trac.webkit.org/r231320 1426161 5 graouts 2018-05-22 08:27:38 -0700 On Sierra, I get a reproducible failure with this command: run-webkit-tests --release media/controls/airplay-picker.html media/controls/pip-placeholder-without-video-controls.html --force 1426165 6 graouts 2018-05-22 08:45:58 -0700 The diff definitely points at the media being in AirPlay mode since it has an "appletv" class. So it's a matter of a previous test making this test run in AirPlay still. 1426223 7 graouts 2018-05-22 11:56:17 -0700 Even after setMockMediaPlaybackTargetPickerState(emptyString(), MediaPlaybackTargetContext::Unknown) has been called by Internals::resetToConsistentState() and WebMediaSessionManager::setMockMediaPlaybackTargetPickerState() has received the message from the UI process, which means the state has been reset as expected, the failing test will receive a "webkitcurrentplaybacktargetiswirelesschanged" event and video.webkitCurrentPlaybackTargetIsWireless will be set to true. As such the test thinks it's Airplaying and showing the wrong message. 1426238 8 graouts 2018-05-22 12:24:47 -0700 Even when the test passes, div[pseudo='-webkit-media-controls-wireless-playback-status'].className is "picture-in-picture appletv", which makes no sense to me. It should be one or the other… 1426244 9 graouts 2018-05-22 12:36:11 -0700 The crux of the problem is that HTMLMediaElement::mediaPlayerCurrentPlaybackTargetIsWirelessChanged() is called with the media in the wrong state and this causes the test to act as it's AirPlaying.