170612 2017-04-07 12:07:49 -0700 WebAssembly: Module::getOrCreateCodeBlock is wrong 2017-04-07 12:43:16 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 saam saam benjamin fpizlo ggaren gskachkov jfbastien keith_miller mark.lam msaboff ticaiolima ysuzuki oldest_to_newest 1295438 0 saam 2017-04-07 12:07:49 -0700 It needs to check something that isn't runnable() 1295440 1 306526 saam 2017-04-07 12:14:09 -0700 Created attachment 306526 patch 1295443 2 306526 jfbastien 2017-04-07 12:20:21 -0700 Comment on attachment 306526 patch View in context: https://bugs.webkit.org/attachment.cgi?id=306526&action=review > Source/JavaScriptCore/wasm/WasmCodeBlock.h:65 > + return false; "don't know" shouldn't be false? Can you use an optional instead? 1295444 3 306526 keith_miller 2017-04-07 12:21:30 -0700 Comment on attachment 306526 patch View in context: https://bugs.webkit.org/attachment.cgi?id=306526&action=review >> Source/JavaScriptCore/wasm/WasmCodeBlock.h:65 >> + return false; > > "don't know" shouldn't be false? Can you use an optional instead? I think we should just use a TriState. 1295446 4 306526 saam 2017-04-07 12:24:38 -0700 Comment on attachment 306526 patch View in context: https://bugs.webkit.org/attachment.cgi?id=306526&action=review >>> Source/JavaScriptCore/wasm/WasmCodeBlock.h:65 >>> + return false; >> >> "don't know" shouldn't be false? Can you use an optional instead? > > I think we should just use a TriState. Maybe I'll just make the caller do this. Since we just have one caller. if (!codeBlock || (codeBlock->compilationFinished() && !codeBlock->runnable()) 1295452 5 306527 saam 2017-04-07 12:33:19 -0700 Created attachment 306527 patch 1295453 6 306527 keith_miller 2017-04-07 12:36:07 -0700 Comment on attachment 306527 patch r=me. 1295455 7 saam 2017-04-07 12:43:16 -0700 landed in: https://trac.webkit.org/changeset/215114/webkit 306526 2017-04-07 12:14:09 -0700 2017-04-07 12:33:19 -0700 patch c-backup.diff text/plain 2756 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1MTA5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBA CisyMDE3LTA0LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBNb2R1bGU6OmdldE9yQ3JlYXRlQ29kZUJsb2NrIGlzIHdyb25nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2MTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIHdlcmUg Z2V0dGluZyBhIG1vZHVsZSdzIENvZGVCbG9jaywgd2Ugd2VyZSBjaGVja2luZyBpZiAhcnVubmFi bGUoKSwKKyAgICAgICAgYW5kIGlmICFydW5uYWJsZSgpLCB3ZSB3ZXJlIHJlLWNyZWF0aW5nIHRo ZSBDb2RlQmxvY2suIFRoaXMgaXMgd3JvbmcsIHNpbmNlCisgICAgICAgICFydW5uYWJsZSgpIGlz IHRydWUgd2hpbGUgdGhlIENvZGVCbG9jayBpcyBjb21waWxpbmcuIEluc3RlYWQsIHdlIHNob3Vs ZCBjaGVjaworICAgICAgICBpZiB3ZSd2ZSBmaW5pc2hlZCBjb21waWxpbmcsIGFuZCBpZiBzbywg aWYgdGhhdCBjb21waWxhdGlvbiBmYWlsZWQuCisKKyAgICAgICAgKiB3YXNtL1dhc21Db2RlQmxv Y2suaDoKKyAgICAgICAgKEpTQzo6V2FzbTo6Q29kZUJsb2NrOjpydW5uYWJsZSk6CisgICAgICAg IChKU0M6Oldhc206OkNvZGVCbG9jazo6Y29tcGlsYXRpb25GYWlsZWQpOgorICAgICAgICAqIHdh c20vV2FzbU1vZHVsZS5jcHA6CisgICAgICAgIChKU0M6Oldhc206Ok1vZHVsZTo6Z2V0T3JDcmVh dGVDb2RlQmxvY2spOgorCiAyMDE3LTA0LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUu Y29tPgogCiAgICAgICAgIFdlYkFzc2VtYmx5OiBNYWtlIHRvIGEgY29tcGlsYXRpb24gQVBJIHRo YXQgYWxsb3dzIGZvciBtdWx0aS1WTSBjb25jdXJyZW50IGNvbXBpbGF0aW9ucyBvZiBXYXNtIE1v ZHVsZXMKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Db2RlQmxvY2suaAo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQ29kZUJsb2NrLmgJ KHJldmlzaW9uIDIxNTEwMykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21Db2Rl QmxvY2suaAkod29ya2luZyBjb3B5KQpAQCAtNTMsNyArNTMsMTkgQEAgcHVibGljOgogICAgICAg ICBhdXRvIGxvY2tlciA9IGhvbGRMb2NrKG1fbG9jayk7CiAgICAgICAgIHJldHVybiAhbV9wbGFu OwogICAgIH0KLSAgICBib29sIHJ1bm5hYmxlKCkgeyByZXR1cm4gY29tcGlsYXRpb25GaW5pc2hl ZCgpICYmICFtX2Vycm9yTWVzc2FnZTsgfQorICAgIGJvb2wgcnVubmFibGUoKQorICAgIHsKKyAg ICAgICAgcmV0dXJuIGNvbXBpbGF0aW9uRmluaXNoZWQoKSAmJiAhbV9lcnJvck1lc3NhZ2U7Cisg ICAgfQorICAgIGJvb2wgY29tcGlsYXRpb25GYWlsZWQoKQorICAgIHsKKyAgICAgICAgYXV0byBs b2NrZXIgPSBob2xkTG9jayhtX2xvY2spOworICAgICAgICBpZiAobV9wbGFuKSB7CisgICAgICAg ICAgICAvLyBXZSBkb24ndCBrbm93IHlldCwgc2luY2Ugd2UncmUgc3RpbGwgY29tcGlsaW5nLgor ICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworICAgICAgICB9CisgICAgICAgIHJldHVybiAhIW1f ZXJyb3JNZXNzYWdlOworICAgIH0KIAogICAgIC8vIE5vdGUsIHdlIGRvIHRoaXMgY29weSB0byBl bnN1cmUgaXQncyB0aHJlYWQgc2FmZSB0byBoYXZlIHRoaXMKICAgICAvLyBjYWxsZWQgZnJvbSBt dWx0aXBsZSB0aHJlYWRzIHNpbXVsdGFuZW91c2x5LgpJbmRleDogU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbU1vZHVsZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbU1vZHVsZS5jcHAJKHJldmlzaW9uIDIxNTEwMykKKysrIFNvdXJjZS9KYXZh U2NyaXB0Q29yZS93YXNtL1dhc21Nb2R1bGUuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC02MSw3ICs2 MSw3IEBAIFJlZjxDb2RlQmxvY2s+IE1vZHVsZTo6Z2V0T3JDcmVhdGVDb2RlQmwKICAgICAvLyBJ dCdzIHdvcnRoIHJldHJ5aW5nLgogICAgIC8vIEZJWE1FOiBXZSBtaWdodCB3YW50IHRvIGJhY2sg b2ZmIHJldHJ5aW5nIGF0IHNvbWUgcG9pbnQ6CiAgICAgLy8gaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTE3MDYwNwotICAgIGlmICghY29kZUJsb2NrIHx8ICFjb2RlQmxv Y2stPnJ1bm5hYmxlKCkpIHsKKyAgICBpZiAoIWNvZGVCbG9jayB8fCBjb2RlQmxvY2stPmNvbXBp bGF0aW9uRmFpbGVkKCkpIHsKICAgICAgICAgY29kZUJsb2NrID0gQ29kZUJsb2NrOjpjcmVhdGUo dm0sIG1vZGUsIGNvbnN0X2Nhc3Q8TW9kdWxlSW5mb3JtYXRpb24mPihtb2R1bGVJbmZvcm1hdGlv bigpKSk7CiAgICAgICAgIG1fY29kZUJsb2Nrc1tzdGF0aWNfY2FzdDx1aW50OF90Pihtb2RlKV0g PSBjb2RlQmxvY2s7CiAgICAgfQo= 306527 2017-04-07 12:33:19 -0700 2017-04-07 12:36:07 -0700 patch c-backup.diff text/plain 1777 saam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1MTEzKQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBA CisyMDE3LTA0LTA3ICBTYWFtIEJhcmF0aSAgPHNiYXJhdGlAYXBwbGUuY29tPgorCisgICAgICAg IFdlYkFzc2VtYmx5OiBNb2R1bGU6OmdldE9yQ3JlYXRlQ29kZUJsb2NrIGlzIHdyb25nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA2MTIKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIHdlIHdlcmUg Z2V0dGluZyBhIG1vZHVsZSdzIENvZGVCbG9jaywgd2Ugd2VyZSBjaGVja2luZyBpZiAhcnVubmFi bGUoKSwKKyAgICAgICAgYW5kIGlmICFydW5uYWJsZSgpLCB3ZSB3ZXJlIHJlLWNyZWF0aW5nIHRo ZSBDb2RlQmxvY2suIFRoaXMgaXMgd3JvbmcsIHNpbmNlCisgICAgICAgICFydW5uYWJsZSgpIGlz IHRydWUgd2hpbGUgdGhlIENvZGVCbG9jayBpcyBjb21waWxpbmcuIEluc3RlYWQsIHdlIHNob3Vs ZCBjaGVjaworICAgICAgICBpZiB3ZSd2ZSBmaW5pc2hlZCBjb21waWxpbmcsIGFuZCBpZiBzbywg aWYgdGhhdCBjb21waWxhdGlvbiBmYWlsZWQuCisKKyAgICAgICAgKiB3YXNtL1dhc21Nb2R1bGUu Y3BwOgorICAgICAgICAoSlNDOjpXYXNtOjpNb2R1bGU6OmdldE9yQ3JlYXRlQ29kZUJsb2NrKToK KwogMjAxNy0wNC0wNyAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAg ICBXZWJBc3NlbWJseTogTWFrZSB0byBhIGNvbXBpbGF0aW9uIEFQSSB0aGF0IGFsbG93cyBmb3Ig bXVsdGktVk0gY29uY3VycmVudCBjb21waWxhdGlvbnMgb2YgV2FzbSBNb2R1bGVzCkluZGV4OiBT b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtTW9kdWxlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtTW9kdWxlLmNwcAkocmV2aXNpb24gMjE1MTAz KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbU1vZHVsZS5jcHAJKHdvcmtpbmcg Y29weSkKQEAgLTYxLDcgKzYxLDcgQEAgUmVmPENvZGVCbG9jaz4gTW9kdWxlOjpnZXRPckNyZWF0 ZUNvZGVCbAogICAgIC8vIEl0J3Mgd29ydGggcmV0cnlpbmcuCiAgICAgLy8gRklYTUU6IFdlIG1p Z2h0IHdhbnQgdG8gYmFjayBvZmYgcmV0cnlpbmcgYXQgc29tZSBwb2ludDoKICAgICAvLyBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjA3Ci0gICAgaWYgKCFjb2Rl QmxvY2sgfHwgIWNvZGVCbG9jay0+cnVubmFibGUoKSkgeworICAgIGlmICghY29kZUJsb2NrIHx8 IChjb2RlQmxvY2stPmNvbXBpbGF0aW9uRmluaXNoZWQoKSAmJiAhY29kZUJsb2NrLT5ydW5uYWJs ZSgpKSkgewogICAgICAgICBjb2RlQmxvY2sgPSBDb2RlQmxvY2s6OmNyZWF0ZSh2bSwgbW9kZSwg Y29uc3RfY2FzdDxNb2R1bGVJbmZvcm1hdGlvbiY+KG1vZHVsZUluZm9ybWF0aW9uKCkpKTsKICAg ICAgICAgbV9jb2RlQmxvY2tzW3N0YXRpY19jYXN0PHVpbnQ4X3Q+KG1vZGUpXSA9IGNvZGVCbG9j azsKICAgICB9Cg==