170611 2017-04-07 12:06:09 -0700 Web Inspector: DOM/XHR breakpoint tree elements shouldn't persist their represented objects 2017-04-07 12:31:10 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 mattbaker mattbaker commit-queue inspector-bugzilla-changes joepeck webkit-bug-importer oldest_to_newest 1295432 0 mattbaker 2017-04-07 12:06:09 -0700 Summary: DOM/XHR breakpoint tree elements shouldn't persist their represented objects. Steps to Reproduce: 1. Inspector > Debugger tab 2. Select something from Sources 3. Select the global "All Requests" XHR breakpoint 4. Refresh the page => After a delay (1-2s): - Global XHR breakpoint is selected - Debugger tab content view changes to the DOMTree - Assertion: [Error] Assertion Failed: createFromRepresentedObject and resolvedRepresentedObjectForRepresentedObject are out of sync for type – "XHRBreakpoint" contentViewForRepresentedObject (ContentView.js:194) showContentViewForRepresentedObject (ContentBrowser.js:146) showDefaultContentViewForTreeElement (NavigationSidebarPanel.js:195:83) _checkElementsForPendingViewStateCookie (NavigationSidebarPanel.js:710) finalAttemptToRestoreViewStateFromCookie (NavigationSidebarPanel.js:248) finalAttemptToRestoreViewStateFromCookie 1295435 1 webkit-bug-importer 2017-04-07 12:07:07 -0700 <rdar://problem/31506161> 1295439 2 306525 mattbaker 2017-04-07 12:12:06 -0700 Created attachment 306525 Patch 1295441 3 306525 joepeck 2017-04-07 12:16:53 -0700 Comment on attachment 306525 Patch r=me 1295449 4 306525 commit-queue 2017-04-07 12:31:09 -0700 Comment on attachment 306525 Patch Clearing flags on attachment: 306525 Committed r215113: <http://trac.webkit.org/changeset/215113> 1295450 5 commit-queue 2017-04-07 12:31:10 -0700 All reviewed patches have been landed. Closing bug. 306525 2017-04-07 12:12:06 -0700 2017-04-07 12:31:09 -0700 Patch bug-170611-20170407121205.patch text/plain 3247 mattbaker U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MTA0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZwppbmRleCBk YzIyZjFkZWRlYTVmNDJhYmZmZmFmZWY5MzQxMTYzMWQxZDY3NDgwLi40NjMxMGYzZDhkNmUwNTQ5 NTcxMzM4MGM2YmIyYjNhY2I4MDU4NDIyIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxOSBAQAorMjAxNy0wNC0wNyAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+ CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogRE9NL1hIUiBicmVha3BvaW50IHRyZWUgZWxlbWVu dHMgc2hvdWxkbid0IHBlcnNpc3QgdGhlaXIgcmVwcmVzZW50ZWQgb2JqZWN0cworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjExCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS8zMTUwNjE2MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBQcmV2ZW50IHRyZWUgZWxlbWVudHMgZm9yIERPTSBhbmQgWEhSIGJy ZWFrcG9pbnRzIGZyb20gcGVyc2lzdGluZyB0aGVpcgorICAgICAgICByZXByZXNlbnRlZCBvYmpl Y3RzLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qczoKKyAg ICAgICAgKFdlYkluc3BlY3Rvci5Db250ZW50Vmlldy5jcmVhdGVGcm9tUmVwcmVzZW50ZWRPYmpl Y3QpOgorICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5l bC5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLnByb3Rv dHlwZS5faXNUcmVlRWxlbWVudFdpdGhvdXRSZXByZXNlbnRlZE9iamVjdCk6CisKIDIwMTctMDQt MDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBTb3VyY2UgTWFwIFJlc291cmNlcyBzaG91bGQgc2hvdyB1cCBpbiB0aGUgRGVi dWdnZXIgU291cmNlcyBsaXN0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNl ckludGVyZmFjZS9WaWV3cy9Db250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCmluZGV4IGUwZDJjMGY3Y2NjZDgzOTkw NGQ3Y2UxZGUxNmIzMTY0MjBmZGViNjAuLjliY2E4ZTcwNTAyNDE5Mzk4ZDc1NjRlMDNiMDYxZjdi YmFmN2U1NjkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0NvbnRlbnRWaWV3LmpzCkBAIC0xMjEsMTQgKzEyMSw2IEBAIFdlYkluc3Bl Y3Rvci5Db250ZW50VmlldyA9IGNsYXNzIENvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9y LlZpZXcKICAgICAgICAgICAgIH0KICAgICAgICAgfQogCi0gICAgICAgIGlmIChyZXByZXNlbnRl ZE9iamVjdCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5ET01CcmVha3BvaW50KSB7Ci0gICAgICAg ICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QuZG9tTm9kZSkKLSAgICAgICAgICAgICAgICByZXR1 cm4gV2ViSW5zcGVjdG9yLkNvbnRlbnRWaWV3LmNyZWF0ZUZyb21SZXByZXNlbnRlZE9iamVjdChy ZXByZXNlbnRlZE9iamVjdC5kb21Ob2RlLCBleHRyYUFyZ3VtZW50cyk7Ci0gICAgICAgIH0KLQot ICAgICAgICBpZiAocmVwcmVzZW50ZWRPYmplY3QgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuWEhS QnJlYWtwb2ludCkKLSAgICAgICAgICAgIHJldHVybiBXZWJJbnNwZWN0b3IuQ29udGVudFZpZXcu Y3JlYXRlRnJvbVJlcHJlc2VudGVkT2JqZWN0KFdlYkluc3BlY3Rvci5mcmFtZVJlc291cmNlTWFu YWdlci5tYWluRnJhbWUuZG9tVHJlZSwgZXh0cmFBcmd1bWVudHMpOwotCiAgICAgICAgIGlmIChy ZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5Tb3VyY2VDb2RlU2VhcmNo TWF0Y2hPYmplY3QpIHsKICAgICAgICAgICAgIHZhciByZXN1bHRWaWV3OwogICAgICAgICAgICAg aWYgKHJlcHJlc2VudGVkT2JqZWN0LnNvdXJjZUNvZGUgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3Iu UmVzb3VyY2UpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFj ZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvTmF2aWdhdGlvblNpZGViYXJQYW5lbC5qcwppbmRleCBiMWRk YjZhMjA0MDZlY2M3ZDA2MjYwMzJmMzI1NWVmMWQ4MGJiYTNhLi40YzMyNzYzY2JlOTE4ODNhOWFi N2E0YmIwMjYyODJmZGI5NDdjYWQzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9OYXZpZ2F0aW9uU2lkZWJhclBhbmVsLmpzCisrKyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL05hdmlnYXRpb25TaWRlYmFyUGFu ZWwuanMKQEAgLTY0Myw2ICs2NDMsOCBAQCBXZWJJbnNwZWN0b3IuTmF2aWdhdGlvblNpZGViYXJQ YW5lbCA9IGNsYXNzIE5hdmlnYXRpb25TaWRlYmFyUGFuZWwgZXh0ZW5kcyBXZWJJbgogICAgICAg ICAgICAgfHwgdHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNwZWN0b3IuQXBwbGljYXRpb25D YWNoZU1hbmlmZXN0VHJlZUVsZW1lbnQKICAgICAgICAgICAgIHx8IHRyZWVFbGVtZW50IGluc3Rh bmNlb2YgV2ViSW5zcGVjdG9yLlRocmVhZFRyZWVFbGVtZW50CiAgICAgICAgICAgICB8fCB0cmVl RWxlbWVudCBpbnN0YW5jZW9mIFdlYkluc3BlY3Rvci5JZGxlVHJlZUVsZW1lbnQKKyAgICAgICAg ICAgIHx8IHRyZWVFbGVtZW50IGluc3RhbmNlb2YgV2ViSW5zcGVjdG9yLkRPTUJyZWFrcG9pbnRU cmVlRWxlbWVudAorICAgICAgICAgICAgfHwgdHJlZUVsZW1lbnQgaW5zdGFuY2VvZiBXZWJJbnNw ZWN0b3IuWEhSQnJlYWtwb2ludFRyZWVFbGVtZW50CiAgICAgICAgICAgICB8fCB0eXBlb2YgdHJl ZUVsZW1lbnQucmVwcmVzZW50ZWRPYmplY3QgPT09ICJzdHJpbmciCiAgICAgICAgICAgICB8fCB0 cmVlRWxlbWVudC5yZXByZXNlbnRlZE9iamVjdCBpbnN0YW5jZW9mIFN0cmluZzsKICAgICB9Cg==