170603 2017-04-07 09:04:49 -0700 Missing conversion from window to content coordinates when adjusting unobscured content rects for input view 2017-04-08 02:42:18 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 wenson_hsieh wenson_hsieh commit-queue simon.fraser thorton oldest_to_newest 1295358 0 wenson_hsieh 2017-04-07 09:04:49 -0700 In -[WKContentView _computeUnobscuredContentRectRespectingInputViewBounds:unobscuredContentRect:inputViewBounds:scale:], inputViewBounds is in window coordinates, while unobscuredContentRect is specified in content coordinates. Before doing math with inputViewBounds, we need to convert it to content view coordinates. 1295367 1 306512 wenson_hsieh 2017-04-07 09:45:31 -0700 Created attachment 306512 Patch 1295429 2 306524 wenson_hsieh 2017-04-07 11:59:39 -0700 Created attachment 306524 Patch for landing 1295442 3 306524 commit-queue 2017-04-07 12:17:39 -0700 Comment on attachment 306524 Patch for landing Clearing flags on attachment: 306524 Committed r215111: <http://trac.webkit.org/changeset/215111> 306512 2017-04-07 09:45:31 -0700 2017-04-07 10:13:20 -0700 Patch bug-170603-20170407094530.patch text/plain 3672 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGI3MGIyZTAzOGQ5M2Y3 MmNhYzBjOWNmMDQ4NzRkYzI0MGJlMWQ3MC4uY2E3M2JmMDcyMmRlOGE5NmI2MDFmM2EwZGIzYTA2 MWM3ZmZhYzE5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTA3ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgY29u dmVyc2lvbiBmcm9tIHdpbmRvdyB0byBjb250ZW50IGNvb3JkaW5hdGVzIHdoZW4gYWRqdXN0aW5n IHVub2JzY3VyZWQgY29udGVudCByZWN0cyBmb3IgaW5wdXQgdmlldworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUmVmYWN0b3JzIC1bV0tDb250ZW50Vmll dyBfY29tcHV0ZVVub2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZpZXdCb3VuZHM6 dW5vYnNjdXJlZENvbnRlbnRSZWN0OmlucHV0Vmlld0JvdW5kczpzY2FsZTpdCisgICAgICAgIHRv IGNvbnZlcnQgdGhlIGlucHV0IHZpZXcgYm91bmRzIGludG8gY29udGVudCBjb29yZGluYXRlcyBp bnN0ZWFkIG9mIHVzaW5nIHRoZSB6b29tIHNjYWxlIHRvIGFkanVzdCB0aGUgaGVpZ2h0IG9mIGlu cHV0Vmlld0JvdW5kcy4KKyAgICAgICAgQ292ZXJlZCBieSB0aGUgZXhpc3RpbmcgTGF5b3V0VGVz dCwgZml4ZWQtZWxlbWVudC1vbi1ib3R0b20td2l0aC1rZXlib2FyZC5odG1sLgorCisgICAgICAg ICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRW aWV3IF9jb21wdXRlVW5vYnNjdXJlZENvbnRlbnRSZWN0UmVzcGVjdGluZ0lucHV0Vmlld0JvdW5k czp1bm9ic2N1cmVkQ29udGVudFJlY3Q6aW5wdXRWaWV3Qm91bmRzOnNjYWxlOl0pOgorCiAyMDE3 LTA0LTA2ICBSeWFuIEhhZGRhZCAgPHJ5YW5oYWRkYWRAYXBwbGUuY29tPgogCiAgICAgICAgIFVu cmV2aWV3ZWQsIHJvbGxpbmcgb3V0IHIyMTUwNDYuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvaW9zL1dLQ29udGVudFZpZXcubW0KaW5kZXggMzliMDBhYzJhMWYyZmUwMTk1ODFmYmQ5YTVk Y2Y5M2ZhZTBjYTUxZS4uZDVjZGUzMGRiM2QxYWJjYzY5YjJiZjYxZDgxMWVlMGQ5MTRjMzkwNiAx MDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1t CisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQpAQCAt MzcyLDEwICszNzIsMTIgQEAgcHJpdmF0ZToKICAgICBbW193ZWJTZWxlY3Rpb25Bc3Npc3RhbnQg c2VsZWN0aW9uVmlld10gc2V0SGlkZGVuOllFU107CiB9CiAKLS0gKENHUmVjdClfY29tcHV0ZVVu b2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZpZXdCb3VuZHM6KENHUmVjdCl2aXNp YmxlQ29udGVudFJlY3QgdW5vYnNjdXJlZENvbnRlbnRSZWN0OihDR1JlY3QpdW5vYnNjdXJlZENv bnRlbnRSZWN0IGlucHV0Vmlld0JvdW5kczooQ0dSZWN0KWlucHV0Vmlld0JvdW5kcyBzY2FsZToo Q0dGbG9hdClzY2FsZQorLSAoQ0dSZWN0KV9jb21wdXRlVW5vYnNjdXJlZENvbnRlbnRSZWN0UmVz cGVjdGluZ0lucHV0Vmlld0JvdW5kczooQ0dSZWN0KXVub2JzY3VyZWRDb250ZW50UmVjdCBpbnB1 dFZpZXdCb3VuZHM6KENHUmVjdClpbnB1dFZpZXdCb3VuZHMKIHsKLSAgICBpZiAoaW5wdXRWaWV3 Qm91bmRzLnNpemUuaGVpZ2h0KQotICAgICAgICB1bm9ic2N1cmVkQ29udGVudFJlY3Quc2l6ZS5o ZWlnaHQgPSBzdGQ6Om1pbjxmbG9hdD4odW5vYnNjdXJlZENvbnRlbnRSZWN0LnNpemUuaGVpZ2h0 LCB2aXNpYmxlQ29udGVudFJlY3Qub3JpZ2luLnkgKyAoaW5wdXRWaWV3Qm91bmRzLm9yaWdpbi55 IC8gc2NhbGUpIC0gdW5vYnNjdXJlZENvbnRlbnRSZWN0Lm9yaWdpbi55KTsKKyAgICAvLyBUaGUg aW5wdXQgdmlldyBib3VuZHMgYXJlIGluIHdpbmRvdyBjb29yZGluYXRlcywgYnV0IHRoZSB2aXNp YmxlIGFuZCB1bm9ic2N1cmVkIHJlY3RzIGFyZSBpbiBjb250ZW50IGNvb3JkaW5hdGVzLiBBY2Nv dW50IGZvciB0aGlzIGJ5IGNvbnZlcnRpbmcgaW5wdXQgdmlldyBib3VuZHMgdG8gY29udGVudCBj b29yZGluYXRlcy4KKyAgICBDR1JlY3QgaW5wdXRWaWV3Qm91bmRzSW5Db250ZW50Q29vcmRpbmF0 ZXMgPSBbc2VsZi53aW5kb3cgY29udmVydFJlY3Q6aW5wdXRWaWV3Qm91bmRzIHRvVmlldzpzZWxm XTsKKyAgICBpZiAoQ0dSZWN0R2V0SGVpZ2h0KGlucHV0Vmlld0JvdW5kc0luQ29udGVudENvb3Jk aW5hdGVzKSkKKyAgICAgICAgdW5vYnNjdXJlZENvbnRlbnRSZWN0LnNpemUuaGVpZ2h0ID0gc3Rk OjptaW48ZmxvYXQ+KENHUmVjdEdldEhlaWdodCh1bm9ic2N1cmVkQ29udGVudFJlY3QpLCBDR1Jl Y3RHZXRNaW5ZKGlucHV0Vmlld0JvdW5kc0luQ29udGVudENvb3JkaW5hdGVzKSAtIENHUmVjdEdl dE1pblkodW5vYnNjdXJlZENvbnRlbnRSZWN0KSk7CiAgICAgcmV0dXJuIHVub2JzY3VyZWRDb250 ZW50UmVjdDsKIH0KIApAQCAtNDAyLDcgKzQwNCw3IEBAIHByaXZhdGU6CiAKICAgICBSZW1vdGVT Y3JvbGxpbmdDb29yZGluYXRvclByb3h5KiBzY3JvbGxpbmdDb29yZGluYXRvciA9IF9wYWdlLT5z Y3JvbGxpbmdDb29yZGluYXRvclByb3h5KCk7CiAKLSAgICBDR1JlY3QgdW5vYnNjdXJlZENvbnRl bnRSZWN0UmVzcGVjdGluZ0lucHV0Vmlld0JvdW5kcyA9IFtzZWxmIF9jb21wdXRlVW5vYnNjdXJl ZENvbnRlbnRSZWN0UmVzcGVjdGluZ0lucHV0Vmlld0JvdW5kczp2aXNpYmxlQ29udGVudFJlY3Qg dW5vYnNjdXJlZENvbnRlbnRSZWN0OnVub2JzY3VyZWRDb250ZW50UmVjdCBpbnB1dFZpZXdCb3Vu ZHM6aW5wdXRWaWV3Qm91bmRzIHNjYWxlOnpvb21TY2FsZV07CisgICAgQ0dSZWN0IHVub2JzY3Vy ZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZpZXdCb3VuZHMgPSBbc2VsZiBfY29tcHV0ZVVu b2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZpZXdCb3VuZHM6dW5vYnNjdXJlZENv bnRlbnRSZWN0IGlucHV0Vmlld0JvdW5kczppbnB1dFZpZXdCb3VuZHNdOwogICAgIEZsb2F0UmVj dCBmaXhlZFBvc2l0aW9uUmVjdEZvckxheW91dCA9IF9wYWdlLT5jb21wdXRlQ3VzdG9tRml4ZWRQ b3NpdGlvblJlY3QodW5vYnNjdXJlZENvbnRlbnRSZWN0LCB1bm9ic2N1cmVkQ29udGVudFJlY3RS ZXNwZWN0aW5nSW5wdXRWaWV3Qm91bmRzLCBfcGFnZS0+Y3VzdG9tRml4ZWRQb3NpdGlvblJlY3Qo KSwgem9vbVNjYWxlLCBXZWJQYWdlUHJveHk6OlVub2JzY3VyZWRSZWN0Q29uc3RyYWludDo6Q29u c3RyYWluZWRUb0RvY3VtZW50UmVjdCwgc2Nyb2xsaW5nQ29vcmRpbmF0b3ItPnZpc3VhbFZpZXdw b3J0RW5hYmxlZCgpKTsKIAogICAgIFZpc2libGVDb250ZW50UmVjdFVwZGF0ZUluZm8gdmlzaWJs ZUNvbnRlbnRSZWN0VXBkYXRlSW5mbygK 306524 2017-04-07 11:59:39 -0700 2017-04-07 12:17:39 -0700 Patch for landing bug-170603-20170407115938.patch text/plain 3656 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMGI3MGIyZTAzOGQ5M2Y3 MmNhYzBjOWNmMDQ4NzRkYzI0MGJlMWQ3MC4uOWRiNTU2YWUwMDEzM2ZmMzFhOGMxNGU5OTU4YTk4 ODQxNDU1ZDJhYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA0LTA3ICBXZW5z b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIE1pc3NpbmcgY29u dmVyc2lvbiBmcm9tIHdpbmRvdyB0byBjb250ZW50IGNvb3JkaW5hdGVzIHdoZW4gYWRqdXN0aW5n IHVub2JzY3VyZWQgY29udGVudCByZWN0cyBmb3IgaW5wdXQgdmlldworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNjAzCisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgU2ltb24gRnJhc2VyLgorCisgICAgICAgIFJlZmFjdG9ycyAtW1dLQ29udGVudFZpZXcg X2NvbXB1dGVVbm9ic2N1cmVkQ29udGVudFJlY3RSZXNwZWN0aW5nSW5wdXRWaWV3Qm91bmRzOnVu b2JzY3VyZWRDb250ZW50UmVjdDppbnB1dFZpZXdCb3VuZHM6c2NhbGU6XQorICAgICAgICB0byBj b252ZXJ0IHRoZSBpbnB1dCB2aWV3IGJvdW5kcyBpbnRvIGNvbnRlbnQgY29vcmRpbmF0ZXMgaW5z dGVhZCBvZiB1c2luZyB0aGUgem9vbSBzY2FsZSB0byBhZGp1c3QgdGhlIGhlaWdodCBvZiBpbnB1 dFZpZXdCb3VuZHMuCisgICAgICAgIENvdmVyZWQgYnkgdGhlIGV4aXN0aW5nIExheW91dFRlc3Qs IGZpeGVkLWVsZW1lbnQtb24tYm90dG9tLXdpdGgta2V5Ym9hcmQuaHRtbC4KKworICAgICAgICAq IFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbToKKyAgICAgICAgKC1bV0tDb250ZW50Vmll dyBfY29tcHV0ZVVub2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZpZXdCb3VuZHM6 dW5vYnNjdXJlZENvbnRlbnRSZWN0OmlucHV0Vmlld0JvdW5kczpzY2FsZTpdKToKKwogMjAxNy0w NC0wNiAgUnlhbiBIYWRkYWQgIDxyeWFuaGFkZGFkQGFwcGxlLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByMjE1MDQ2LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIv VUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3Lm1tIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L2lvcy9XS0NvbnRlbnRWaWV3Lm1tCmluZGV4IDM5YjAwYWMyYTFmMmZlMDE5NTgxZmJkOWE1ZGNm OTNmYWUwY2E1MWUuLmQ3YzYzOTIyMzMzNmJjMjBlNGRiZDA4N2Q3YTVlZDE5M2M1ZTcxMzYgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQor KysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXcubW0KQEAgLTM3 MiwxMCArMzcyLDEyIEBAIHByaXZhdGU6CiAgICAgW1tfd2ViU2VsZWN0aW9uQXNzaXN0YW50IHNl bGVjdGlvblZpZXddIHNldEhpZGRlbjpZRVNdOwogfQogCi0tIChDR1JlY3QpX2NvbXB1dGVVbm9i c2N1cmVkQ29udGVudFJlY3RSZXNwZWN0aW5nSW5wdXRWaWV3Qm91bmRzOihDR1JlY3QpdmlzaWJs ZUNvbnRlbnRSZWN0IHVub2JzY3VyZWRDb250ZW50UmVjdDooQ0dSZWN0KXVub2JzY3VyZWRDb250 ZW50UmVjdCBpbnB1dFZpZXdCb3VuZHM6KENHUmVjdClpbnB1dFZpZXdCb3VuZHMgc2NhbGU6KENH RmxvYXQpc2NhbGUKKy0gKENHUmVjdClfY29tcHV0ZVVub2JzY3VyZWRDb250ZW50UmVjdFJlc3Bl Y3RpbmdJbnB1dFZpZXdCb3VuZHM6KENHUmVjdCl1bm9ic2N1cmVkQ29udGVudFJlY3QgaW5wdXRW aWV3Qm91bmRzOihDR1JlY3QpaW5wdXRWaWV3Qm91bmRzCiB7Ci0gICAgaWYgKGlucHV0Vmlld0Jv dW5kcy5zaXplLmhlaWdodCkKLSAgICAgICAgdW5vYnNjdXJlZENvbnRlbnRSZWN0LnNpemUuaGVp Z2h0ID0gc3RkOjptaW48ZmxvYXQ+KHVub2JzY3VyZWRDb250ZW50UmVjdC5zaXplLmhlaWdodCwg dmlzaWJsZUNvbnRlbnRSZWN0Lm9yaWdpbi55ICsgKGlucHV0Vmlld0JvdW5kcy5vcmlnaW4ueSAv IHNjYWxlKSAtIHVub2JzY3VyZWRDb250ZW50UmVjdC5vcmlnaW4ueSk7CisgICAgLy8gVGhlIGlu cHV0IHZpZXcgYm91bmRzIGFyZSBpbiB3aW5kb3cgY29vcmRpbmF0ZXMsIGJ1dCB0aGUgdW5vYnNj dXJlZCByZWN0IGlzIGluIGNvbnRlbnQgY29vcmRpbmF0ZXMuIEFjY291bnQgZm9yIHRoaXMgYnkg Y29udmVydGluZyBpbnB1dCB2aWV3IGJvdW5kcyB0byBjb250ZW50IGNvb3JkaW5hdGVzLgorICAg IENHUmVjdCBpbnB1dFZpZXdCb3VuZHNJbkNvbnRlbnRDb29yZGluYXRlcyA9IFtzZWxmLndpbmRv dyBjb252ZXJ0UmVjdDppbnB1dFZpZXdCb3VuZHMgdG9WaWV3OnNlbGZdOworICAgIGlmIChDR1Jl Y3RHZXRIZWlnaHQoaW5wdXRWaWV3Qm91bmRzSW5Db250ZW50Q29vcmRpbmF0ZXMpKQorICAgICAg ICB1bm9ic2N1cmVkQ29udGVudFJlY3Quc2l6ZS5oZWlnaHQgPSBzdGQ6Om1pbjxmbG9hdD4oQ0dS ZWN0R2V0SGVpZ2h0KHVub2JzY3VyZWRDb250ZW50UmVjdCksIENHUmVjdEdldE1pblkoaW5wdXRW aWV3Qm91bmRzSW5Db250ZW50Q29vcmRpbmF0ZXMpIC0gQ0dSZWN0R2V0TWluWSh1bm9ic2N1cmVk Q29udGVudFJlY3QpKTsKICAgICByZXR1cm4gdW5vYnNjdXJlZENvbnRlbnRSZWN0OwogfQogCkBA IC00MDIsNyArNDA0LDcgQEAgcHJpdmF0ZToKIAogICAgIFJlbW90ZVNjcm9sbGluZ0Nvb3JkaW5h dG9yUHJveHkqIHNjcm9sbGluZ0Nvb3JkaW5hdG9yID0gX3BhZ2UtPnNjcm9sbGluZ0Nvb3JkaW5h dG9yUHJveHkoKTsKIAotICAgIENHUmVjdCB1bm9ic2N1cmVkQ29udGVudFJlY3RSZXNwZWN0aW5n SW5wdXRWaWV3Qm91bmRzID0gW3NlbGYgX2NvbXB1dGVVbm9ic2N1cmVkQ29udGVudFJlY3RSZXNw ZWN0aW5nSW5wdXRWaWV3Qm91bmRzOnZpc2libGVDb250ZW50UmVjdCB1bm9ic2N1cmVkQ29udGVu dFJlY3Q6dW5vYnNjdXJlZENvbnRlbnRSZWN0IGlucHV0Vmlld0JvdW5kczppbnB1dFZpZXdCb3Vu ZHMgc2NhbGU6em9vbVNjYWxlXTsKKyAgICBDR1JlY3QgdW5vYnNjdXJlZENvbnRlbnRSZWN0UmVz cGVjdGluZ0lucHV0Vmlld0JvdW5kcyA9IFtzZWxmIF9jb21wdXRlVW5vYnNjdXJlZENvbnRlbnRS ZWN0UmVzcGVjdGluZ0lucHV0Vmlld0JvdW5kczp1bm9ic2N1cmVkQ29udGVudFJlY3QgaW5wdXRW aWV3Qm91bmRzOmlucHV0Vmlld0JvdW5kc107CiAgICAgRmxvYXRSZWN0IGZpeGVkUG9zaXRpb25S ZWN0Rm9yTGF5b3V0ID0gX3BhZ2UtPmNvbXB1dGVDdXN0b21GaXhlZFBvc2l0aW9uUmVjdCh1bm9i c2N1cmVkQ29udGVudFJlY3QsIHVub2JzY3VyZWRDb250ZW50UmVjdFJlc3BlY3RpbmdJbnB1dFZp ZXdCb3VuZHMsIF9wYWdlLT5jdXN0b21GaXhlZFBvc2l0aW9uUmVjdCgpLCB6b29tU2NhbGUsIFdl YlBhZ2VQcm94eTo6VW5vYnNjdXJlZFJlY3RDb25zdHJhaW50OjpDb25zdHJhaW5lZFRvRG9jdW1l bnRSZWN0LCBzY3JvbGxpbmdDb29yZGluYXRvci0+dmlzdWFsVmlld3BvcnRFbmFibGVkKCkpOwog CiAgICAgVmlzaWJsZUNvbnRlbnRSZWN0VXBkYXRlSW5mbyB2aXNpYmxlQ29udGVudFJlY3RVcGRh dGVJbmZvKAo=