170601 2017-04-07 08:22:28 -0700 REGRESSION (r214553): Allow layout-tests to be run from Xcode without re-directing stdout, stdin and stderr 2017-04-07 12:07:38 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jbedard jbedard commit-queue lforschler simon.fraser oldest_to_newest 1295330 0 jbedard 2017-04-07 08:22:28 -0700 <http://trac.webkit.org/changeset/214553> always expects to use TCP for stdout, stdin and stderr on iOS simulators. Both WebKitTestRunnerApp.app and DumpRenderTree.app should allow for stdout, stdin and stderr to be routed to their normal file handles for Xcode debugging if the PORT environment is not defined. 1295336 1 jbedard 2017-04-07 08:28:59 -0700 <rdar://problem/31492696> 1295360 2 306510 jbedard 2017-04-07 09:10:47 -0700 Created attachment 306510 Patch 1295361 3 306510 simon.fraser 2017-04-07 09:14:48 -0700 Comment on attachment 306510 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306510&action=review > Tools/TestRunnerShared/IOSLayoutTestCommunication.cpp:54 > int port = atoi(getenv("PORT")); Why not use portFromEnvironment here? 1295363 4 306511 jbedard 2017-04-07 09:19:30 -0700 Created attachment 306511 Patch 1295436 5 306511 commit-queue 2017-04-07 12:07:36 -0700 Comment on attachment 306511 Patch Clearing flags on attachment: 306511 Committed r215109: <http://trac.webkit.org/changeset/215109> 1295437 6 commit-queue 2017-04-07 12:07:38 -0700 All reviewed patches have been landed. Closing bug. 306510 2017-04-07 09:10:47 -0700 2017-04-07 09:19:29 -0700 Patch bug-170601-20170407091046.patch text/plain 1901 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA0LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjE0NTUzKTogQWxsb3cgbGF5b3V0LXRlc3RzIHRv IGJlIHJ1biBmcm9tIFhjb2RlIHdpdGhvdXQgcmUtZGlyZWN0aW5nIHN0ZG91dCwgc3RkaW4gYW5k IHN0ZGVycgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcwNjAxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTQ5MjY5Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFRlc3RSdW5uZXJTaGFyZWQvSU9T TGF5b3V0VGVzdENvbW11bmljYXRpb24uY3BwOgorICAgICAgICAoc2V0VXBJT1NMYXlvdXRUZXN0 Q29tbXVuaWNhdGlvbik6IFNraXAgVENQIHNldHVwIGlmIG5vIHBvcnQgaXMgaW4gdGhlIGVudmly b25tZW50LgorICAgICAgICAodGVhckRvd25JT1NMYXlvdXRUZXN0Q29tbXVuaWNhdGlvbik6IE9u bHkgdGVhcmRvd24gaWYgVENQIHdhcyB1c2VkLgorCiAyMDE3LTA0LTA2ICBNeWxlcyBDLiBNYXhm aWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBGb250V2l0aEZlYXR1 cmVzIHRlc3QgZm9udCBwYXNzIE9UUwpJbmRleDogVG9vbHMvVGVzdFJ1bm5lclNoYXJlZC9JT1NM YXlvdXRUZXN0Q29tbXVuaWNhdGlvbi5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gVG9vbHMvVGVzdFJ1bm5l clNoYXJlZC9JT1NMYXlvdXRUZXN0Q29tbXVuaWNhdGlvbi5jcHAJKHJldmlzaW9uIDIxNTA5NCkK KysrIFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvSU9TTGF5b3V0VGVzdENvbW11bmljYXRpb24uY3Bw CSh3b3JraW5nIGNvcHkpCkBAIC0zNiw2ICszNiw3IEBACiBzdGF0aWMgaW50IHN0ZGluU29ja2V0 Owogc3RhdGljIGludCBzdGRvdXRTb2NrZXQ7CiBzdGF0aWMgaW50IHN0ZGVyclNvY2tldDsKK3N0 YXRpYyBib29sIGlzVXNpbmdUQ1AgPSBmYWxzZTsKIAogc3RhdGljIGludCBjb25uZWN0VG9TZXJ2 ZXIoc29ja2FkZHJfaW4mIHNlcnZlckFkZHJlc3MpCiB7CkBAIC00Nyw4ICs0OCwxMiBAQCBzdGF0 aWMgaW50IGNvbm5lY3RUb1NlcnZlcihzb2NrYWRkcl9pbiYgCiAKIHZvaWQgc2V0VXBJT1NMYXlv dXRUZXN0Q29tbXVuaWNhdGlvbigpCiB7CisgICAgY2hhciogcG9ydEZyb21FbnZpcm9ubWVudCA9 IGdldGVudigiUE9SVCIpOworICAgIGlmICghcG9ydEZyb21FbnZpcm9ubWVudCkKKyAgICAgICAg cmV0dXJuOwogICAgIGludCBwb3J0ID0gYXRvaShnZXRlbnYoIlBPUlQiKSk7CiAgICAgUkVMRUFT RV9BU1NFUlQocG9ydCA+IDApOworICAgIGlzVXNpbmdUQ1AgPSB0cnVlOwogCiAgICAgc3RydWN0 IGhvc3RlbnQqIGhvc3QgPSBnZXRob3N0YnluYW1lKCIxMjcuMC4wLjEiKTsKICAgICBzdHJ1Y3Qg c29ja2FkZHJfaW4gc2VydmVyQWRkcmVzczsKQEAgLTczLDYgKzc4LDggQEAgdm9pZCBzZXRVcElP U0xheW91dFRlc3RDb21tdW5pY2F0aW9uKCkKIAogdm9pZCB0ZWFyRG93bklPU0xheW91dFRlc3RD b21tdW5pY2F0aW9uKCkKIHsKKyAgICBpZiAoIWlzVXNpbmdUQ1ApCisgICAgICAgIHJldHVybjsK ICAgICBjbG9zZShzdGRpblNvY2tldCk7CiAgICAgY2xvc2Uoc3Rkb3V0U29ja2V0KTsKICAgICBj bG9zZShzdGRlcnJTb2NrZXQpOwo= 306511 2017-04-07 09:19:30 -0700 2017-04-07 12:07:36 -0700 Patch bug-170601-20170407091929.patch text/plain 1942 jbedard SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDIxNTA5NSkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDE3LTA0LTA3ICBKb25hdGhhbiBCZWRhcmQgIDxqYmVkYXJkQGFwcGxlLmNv bT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMjE0NTUzKTogQWxsb3cgbGF5b3V0LXRlc3RzIHRv IGJlIHJ1biBmcm9tIFhjb2RlIHdpdGhvdXQgcmUtZGlyZWN0aW5nIHN0ZG91dCwgc3RkaW4gYW5k IHN0ZGVycgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcwNjAxCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTQ5MjY5Nj4KKworICAgICAgICBSZXZp ZXdlZCBieSBTaW1vbiBGcmFzZXIuCisKKyAgICAgICAgKiBUZXN0UnVubmVyU2hhcmVkL0lPU0xh eW91dFRlc3RDb21tdW5pY2F0aW9uLmNwcDoKKyAgICAgICAgKHNldFVwSU9TTGF5b3V0VGVzdENv bW11bmljYXRpb24pOiBTa2lwIFRDUCBzZXR1cCBpZiBubyBwb3J0IGlzIGluIHRoZSBlbnZpcm9u bWVudC4KKyAgICAgICAgKHRlYXJEb3duSU9TTGF5b3V0VGVzdENvbW11bmljYXRpb24pOiBPbmx5 IHRlYXJkb3duIGlmIFRDUCB3YXMgdXNlZC4KKwogMjAxNy0wNC0wNiAgTXlsZXMgQy4gTWF4Zmll bGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgRm9udFdpdGhGZWF0dXJl cyB0ZXN0IGZvbnQgcGFzcyBPVFMKSW5kZXg6IFRvb2xzL1Rlc3RSdW5uZXJTaGFyZWQvSU9TTGF5 b3V0VGVzdENvbW11bmljYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1Rlc3RSdW5uZXJT aGFyZWQvSU9TTGF5b3V0VGVzdENvbW11bmljYXRpb24uY3BwCShyZXZpc2lvbiAyMTUwOTQpCisr KyBUb29scy9UZXN0UnVubmVyU2hhcmVkL0lPU0xheW91dFRlc3RDb21tdW5pY2F0aW9uLmNwcAko d29ya2luZyBjb3B5KQpAQCAtMzYsNiArMzYsNyBAQAogc3RhdGljIGludCBzdGRpblNvY2tldDsK IHN0YXRpYyBpbnQgc3Rkb3V0U29ja2V0Owogc3RhdGljIGludCBzdGRlcnJTb2NrZXQ7CitzdGF0 aWMgYm9vbCBpc1VzaW5nVENQID0gZmFsc2U7CiAKIHN0YXRpYyBpbnQgY29ubmVjdFRvU2VydmVy KHNvY2thZGRyX2luJiBzZXJ2ZXJBZGRyZXNzKQogewpAQCAtNDcsOCArNDgsMTIgQEAgc3RhdGlj IGludCBjb25uZWN0VG9TZXJ2ZXIoc29ja2FkZHJfaW4mIAogCiB2b2lkIHNldFVwSU9TTGF5b3V0 VGVzdENvbW11bmljYXRpb24oKQogewotICAgIGludCBwb3J0ID0gYXRvaShnZXRlbnYoIlBPUlQi KSk7CisgICAgY2hhciogcG9ydEZyb21FbnZpcm9ubWVudCA9IGdldGVudigiUE9SVCIpOworICAg IGlmICghcG9ydEZyb21FbnZpcm9ubWVudCkKKyAgICAgICAgcmV0dXJuOworICAgIGludCBwb3J0 ID0gYXRvaShwb3J0RnJvbUVudmlyb25tZW50KTsKICAgICBSRUxFQVNFX0FTU0VSVChwb3J0ID4g MCk7CisgICAgaXNVc2luZ1RDUCA9IHRydWU7CiAKICAgICBzdHJ1Y3QgaG9zdGVudCogaG9zdCA9 IGdldGhvc3RieW5hbWUoIjEyNy4wLjAuMSIpOwogICAgIHN0cnVjdCBzb2NrYWRkcl9pbiBzZXJ2 ZXJBZGRyZXNzOwpAQCAtNzMsNiArNzgsOCBAQCB2b2lkIHNldFVwSU9TTGF5b3V0VGVzdENvbW11 bmljYXRpb24oKQogCiB2b2lkIHRlYXJEb3duSU9TTGF5b3V0VGVzdENvbW11bmljYXRpb24oKQog eworICAgIGlmICghaXNVc2luZ1RDUCkKKyAgICAgICAgcmV0dXJuOwogICAgIGNsb3NlKHN0ZGlu U29ja2V0KTsKICAgICBjbG9zZShzdGRvdXRTb2NrZXQpOwogICAgIGNsb3NlKHN0ZGVyclNvY2tl dCk7Cg==