170596 2017-04-07 04:14:35 -0700 [GTK] Fix ASSERT about missing codecs in OWR 2017-04-07 08:01:09 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned bugs-noreply cgarcia commit-queue mcatanzaro xan.lopez oldest_to_newest 1295265 0 xan.lopez 2017-04-07 04:14:35 -0700 This should make debugging for missing codecs a bit easier for developers. 1295266 1 306486 xan.lopez 2017-04-07 04:15:44 -0700 Created attachment 306486 Add message to ASSERT about missing codec 1295276 2 306486 commit-queue 2017-04-07 05:01:03 -0700 Comment on attachment 306486 Add message to ASSERT about missing codec Clearing flags on attachment: 306486 Committed r215090: <http://trac.webkit.org/changeset/215090> 1295277 3 commit-queue 2017-04-07 05:01:04 -0700 All reviewed patches have been landed. Closing bug. 1295296 4 306492 xan.lopez 2017-04-07 06:17:42 -0700 Created attachment 306492 Also fix the codec name, this was actually subtly broken. 306486 2017-04-07 04:15:44 -0700 2017-04-07 06:17:42 -0700 Add message to ASSERT about missing codec 0001-GTK-Add-message-about-missing-codecs-to-ASSERT-in-OW.patch text/plain 2298 xan.lopez RnJvbSA2ZDE3ZDM2MDlhZDYyZDM5NzE2NGU0YjJiMmQ5MjhiOTc2OWExZmI2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogRnJpLCA3IEFwciAyMDE3IDEzOjE1OjAzICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0dUS10gQWRkIG1lc3NhZ2UgYWJvdXQgbWlzc2luZyBjb2RlY3MgdG8gQVNTRVJUIGlu IE9XUgogaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDU5NgoKUGF0 Y2ggYnkgWGFuIExvcGV6IDx4YW5AaWdhbGlhLmNvbT4gb24gMjAxNy0wNC0wNwpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRp YUVuZHBvaW50T3dyLmNwcDoKKFdlYkNvcmU6Ok1lZGlhRW5kcG9pbnRPd3I6OnByZXBhcmVNZWRp YVNlc3Npb24pOiBhZGQgYSBtZXNzYWdlCmFib3V0IHRoZSBtaXNzaW5nIGNvZGVkIHRvIHRoZSBB U1NFUlQuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiAuLi4vcGxhdGZvcm0vbWVkaWFzdHJl YW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcCAgICAgIHwgIDIgKy0KIDIgZmlsZXMg Y2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA1 ZjA1ODVkLi5jMWIyNTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTctMDQtMDcg IFhhbiBMb3BleiAgPHhhbkBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdIEFkZCBtZXNzYWdl IGFib3V0IG1pc3NpbmcgY29kZWNzIHRvIEFTU0VSVCBpbiBPV1IKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDU5NgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3Bl bndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhRW5k cG9pbnRPd3I6OnByZXBhcmVNZWRpYVNlc3Npb24pOiBhZGQgYSBtZXNzYWdlCisgICAgICAgIGFi b3V0IHRoZSBtaXNzaW5nIGNvZGVkIHRvIHRoZSBBU1NFUlQuCisKIDIwMTctMDQtMDcgIFphbiBE b2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHQ3J5cHRdIEltcGxl bWVudCBBRVNfQ0JDIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01lZGlhRW5kcG9pbnRPd3IuY3Bw CmluZGV4IGRjM2UwNjYuLjg4NDNjYjUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93ci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50 T3dyLmNwcApAQCAtNTIwLDcgKzUyMCw3IEBAIHZvaWQgTWVkaWFFbmRwb2ludE93cjo6cHJlcGFy ZU1lZGlhU2Vzc2lvbihPd3JNZWRpYVNlc3Npb24qIG1lZGlhU2Vzc2lvbiwgUGVlck1lCiAKICAg ICAgICAgYXV0byogcnR4UGF5bG9hZCA9IGZpbmRSdHhQYXlsb2FkKG1lZGlhRGVzY3JpcHRpb24t PnBheWxvYWRzLCBwYXlsb2FkLnR5cGUpOwogCi0gICAgICAgIEFTU0VSVChjb2RlY1R5cGVzLmZp bmQocGF5bG9hZC5lbmNvZGluZ05hbWUpICE9IG5vdEZvdW5kKTsKKyAgICAgICAgQVNTRVJUX1dJ VEhfTUVTU0FHRShjb2RlY1R5cGVzLmZpbmQocGF5bG9hZC5lbmNvZGluZ05hbWUpICE9IG5vdEZv dW5kLCAiVW5hYmxlIHRvIGZpbmQgY29kZWM6ICVzIiwgcGF5bG9hZC5lbmNvZGluZ05hbWUudXRm OCgpLmRhdGEoKSk7CiAgICAgICAgIE93ckNvZGVjVHlwZSBjb2RlY1R5cGUgPSBzdGF0aWNfY2Fz dDxPd3JDb2RlY1R5cGU+KGNvZGVjVHlwZXMuZmluZChwYXlsb2FkLmVuY29kaW5nTmFtZS5jb252 ZXJ0VG9BU0NJSVVwcGVyY2FzZSgpKSk7CiAKICAgICAgICAgT3dyUGF5bG9hZCogcmVjZWl2ZVBh eWxvYWQ7Ci0tIAoyLjkuMwoK 306492 2017-04-07 06:17:42 -0700 2017-04-07 08:01:09 -0700 Also fix the codec name, this was actually subtly broken. 0001-GTK-Fix-ASSERT-about-missing-codecs-in-OWR.patch text/plain 2342 xan.lopez RnJvbSBhZTgzYjYzZGM0ZWVkZmVmY2VhZTM3MGMzMjViMzA2NDA1ZDEwYzlhIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogRnJpLCA3IEFwciAyMDE3IDEzOjE1OjAzICswMjAwClN1YmplY3Q6IFtQ QVRDSF0gW0dUS10gRml4IEFTU0VSVCBhYm91dCBtaXNzaW5nIGNvZGVjcyBpbiBPV1IKIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA1OTYKClBhdGNoIGJ5IFhhbiBM b3BleiA8eGFuQGlnYWxpYS5jb20+IG9uIDIwMTctMDQtMDcKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgoqIHBsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93 ci5jcHA6CihXZWJDb3JlOjpNZWRpYUVuZHBvaW50T3dyOjpwcmVwYXJlTWVkaWFTZXNzaW9uKTog YWRkIGEgbWVzc2FnZSBhYm91dAp0aGUgbWlzc2luZyBjb2RlZCB0byB0aGUgQVNTRVJUIGFuZCB1 cHBlcmNhc2UgdGhlIGNvZGVjIG5hbWUuCi0tLQogU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICB8IDExICsrKysrKysrKysrCiAuLi4v cGxhdGZvcm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcCAgICAg IHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbigt KQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1ZjA1ODVkLi5jMWIyNTIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEs MTQgQEAKKzIwMTctMDQtMDcgIFhhbiBMb3BleiAgPHhhbkBpZ2FsaWEuY29tPgorCisgICAgICAg IFtHVEtdIEFkZCBtZXNzYWdlIGFib3V0IG1pc3NpbmcgY29kZWNzIHRvIEFTU0VSVCBpbiBPV1IK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDU5Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZv cm0vbWVkaWFzdHJlYW0vb3BlbndlYnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6Ok1lZGlhRW5kcG9pbnRPd3I6OnByZXBhcmVNZWRpYVNlc3Npb24pOiBhZGQgYSBt ZXNzYWdlCisgICAgICAgIGFib3V0IHRoZSBtaXNzaW5nIGNvZGVkIHRvIHRoZSBBU1NFUlQuCisK IDIwMTctMDQtMDcgIFphbiBEb2JlcnNlayAgPHpkb2JlcnNla0BpZ2FsaWEuY29tPgogCiAgICAg ICAgIFtHQ3J5cHRdIEltcGxlbWVudCBBRVNfQ0JDIHN1cHBvcnQKZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2ludE93 ci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9vcGVud2VicnRjL01l ZGlhRW5kcG9pbnRPd3IuY3BwCmluZGV4IGRjM2UwNjYuLjYxNWVjOWUgMTAwNjQ0Ci0tLSBhL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL29wZW53ZWJydGMvTWVkaWFFbmRwb2lu dE93ci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vb3Blbndl YnJ0Yy9NZWRpYUVuZHBvaW50T3dyLmNwcApAQCAtNTIwLDcgKzUyMCw3IEBAIHZvaWQgTWVkaWFF bmRwb2ludE93cjo6cHJlcGFyZU1lZGlhU2Vzc2lvbihPd3JNZWRpYVNlc3Npb24qIG1lZGlhU2Vz c2lvbiwgUGVlck1lCiAKICAgICAgICAgYXV0byogcnR4UGF5bG9hZCA9IGZpbmRSdHhQYXlsb2Fk KG1lZGlhRGVzY3JpcHRpb24tPnBheWxvYWRzLCBwYXlsb2FkLnR5cGUpOwogCi0gICAgICAgIEFT U0VSVChjb2RlY1R5cGVzLmZpbmQocGF5bG9hZC5lbmNvZGluZ05hbWUpICE9IG5vdEZvdW5kKTsK KyAgICAgICAgQVNTRVJUX1dJVEhfTUVTU0FHRShjb2RlY1R5cGVzLmZpbmQocGF5bG9hZC5lbmNv ZGluZ05hbWUuY29udmVydFRvQVNDSUlVcHBlcmNhc2UoKSkgIT0gbm90Rm91bmQsICJVbmFibGUg dG8gZmluZCBjb2RlYzogJXMiLCBwYXlsb2FkLmVuY29kaW5nTmFtZS51dGY4KCkuZGF0YSgpKTsK ICAgICAgICAgT3dyQ29kZWNUeXBlIGNvZGVjVHlwZSA9IHN0YXRpY19jYXN0PE93ckNvZGVjVHlw ZT4oY29kZWNUeXBlcy5maW5kKHBheWxvYWQuZW5jb2RpbmdOYW1lLmNvbnZlcnRUb0FTQ0lJVXBw ZXJjYXNlKCkpKTsKIAogICAgICAgICBPd3JQYXlsb2FkKiByZWNlaXZlUGF5bG9hZDsKLS0gCjIu OS4zCgo=