170593 2017-04-07 02:51:53 -0700 [CMake][Windows] WebKitGUID.lib should be built with the release CRT 2017-04-07 09:22:11 -0700 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 fujii fujii achristensen bfulgham commit-queue pvollan oldest_to_newest 1295255 0 fujii 2017-04-07 02:51:53 -0700 Source/cmake/OptionsWin.cmake has a following trick to force using /MT. > foreach (flag_var > CMAKE_CXX_FLAGS CMAKE_CXX_FLAGS_DEBUG CMAKE_CXX_FLAGS_RELEASE > CMAKE_CXX_FLAGS_MINSIZEREL CMAKE_CXX_FLAGS_RELWITHDEBINFO) > # Use the multithreaded static runtime library instead of the default DLL runtime. > string(REGEX REPLACE "/MD" "/MT" ${flag_var} "${${flag_var}}") > > # No debug runtime, even in debug builds. > if (NOT DEBUG_SUFFIX) > string(REGEX REPLACE "/MTd" "/MT" ${flag_var} "${${flag_var}}") > string(REGEX REPLACE "/D_DEBUG" "" ${flag_var} "${${flag_var}}") > endif () > endforeach () But, this trick affect only to C++, but C. As the result, WebKitGUID.lib is build with debug CRT because it has C source files. The below warning messages are reported by this issue. > LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library 1295256 1 306482 fujii 2017-04-07 03:03:29 -0700 Created attachment 306482 Patch 1295348 2 306482 bfulgham 2017-04-07 08:54:16 -0700 Comment on attachment 306482 Patch Good catch! 1295364 3 306482 commit-queue 2017-04-07 09:22:09 -0700 Comment on attachment 306482 Patch Clearing flags on attachment: 306482 Committed r215097: <http://trac.webkit.org/changeset/215097> 1295365 4 commit-queue 2017-04-07 09:22:11 -0700 All reviewed patches have been landed. Closing bug. 306482 2017-04-07 03:03:29 -0700 2017-04-07 09:22:09 -0700 Patch bug-170593-20170407190328.patch text/plain 1654 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc1dpbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCmluZGV4IGI5OGU4 MTExNWQ5YmMxMDhkYTJkMTc5YjcxMDVlY2U1NDFhM2VkZjYuLmU3MTU5ODAyOTczNmQ1ZmJkOTY3 NDk3ZGNhYzJmNmMwNWJmMTIzMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRpb25zV2lu LmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zV2luLmNtYWtlCkBAIC0xNjYsNiArMTY2 LDggQEAgaWYgKE1TVkMpCiAgICAgZW5kaWYgKCkKIAogICAgIGZvcmVhY2ggKGZsYWdfdmFyCisg ICAgICAgIENNQUtFX0NfRkxBR1MgQ01BS0VfQ19GTEFHU19ERUJVRyBDTUFLRV9DX0ZMQUdTX1JF TEVBU0UKKyAgICAgICAgQ01BS0VfQ19GTEFHU19NSU5TSVpFUkVMIENNQUtFX0NfRkxBR1NfUkVM V0lUSERFQklORk8KICAgICAgICAgQ01BS0VfQ1hYX0ZMQUdTIENNQUtFX0NYWF9GTEFHU19ERUJV RyBDTUFLRV9DWFhfRkxBR1NfUkVMRUFTRQogICAgICAgICBDTUFLRV9DWFhfRkxBR1NfTUlOU0la RVJFTCBDTUFLRV9DWFhfRkxBR1NfUkVMV0lUSERFQklORk8pCiAgICAgICAgICMgVXNlIHRoZSBt dWx0aXRocmVhZGVkIHN0YXRpYyBydW50aW1lIGxpYnJhcnkgaW5zdGVhZCBvZiB0aGUgZGVmYXVs dCBETEwgcnVudGltZS4KZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4 OTJhOTUwOTUwMDA3MGJjZDIzZjUwMmY0NmE1M2ZhZDE5NWY2M2U1Li43YmM1MWRhMjJmOTUzNjk3 ZTU5MDFmY2RjOGU1ZjM3NjE3MGYwNTlmIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDQtMDcgIEZ1amlpIEhpcm9ub3JpICA8SGly b25vcmkuRnVqaWlAc29ueS5jb20+CisKKyAgICAgICAgW0NNYWtlXVtXaW5kb3dzXSBXZWJLaXRH VUlELmxpYiBzaG91bGQgYmUgYnVpbHQgd2l0aCB0aGUgcmVsZWFzZSBDUlQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDU5MworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvdXJjZS9jbWFrZS9PcHRpb25z V2luLmNtYWtlIGhhcyBhIHRyaWNrIHRvIGZvcmNlIHVzaW5nIHRoZQorICAgICAgICByZWxlYXNl IENSVCBldmVuIGZvciBkZWJ1ZyBidWlsZCBjb25maWd1cmF0aW9uLiBCdXQsIHRoaXMgd29ya3MK KyAgICAgICAgb25seSBmb3IgQysrLCBidXQgZm9yIEMuIEFzIHRoZSByZXN1bHQsIFdlYktpdEdV SUQubGliIGlzIGJ1aWx0CisgICAgICAgIHdpdGggdGhlIGRlYnVnIENSVCBpbiBkZWJ1ZyBidWls ZCBjb25maWd1cmF0aW9uIGJlY2F1c2UgaXQgaGFzIEMKKyAgICAgICAgc291cmNlIGZpbGVzLgor CisgICAgICAgICogU291cmNlL2NtYWtlL09wdGlvbnNXaW4uY21ha2U6IFByb2Nlc3MgQ01BS0Vf Q19GTEFHU18qIGFzIHdlbGwgYXMgQ01BS0VfQ1hYX0ZMQUdTXyouCisKIDIwMTctMDQtMDYgIE5h ZWwgT3VlZHJhb2dvICA8bmFlbC5vdWVkcmFvZ29AY3JmLmNhbm9uLmZyPgogCiAgICAgICAgIFtH VEtdIEJ1aWxkIGZhaWxzIHdoZW4gdXNpbmcgaWNlY3JlYW0sIGNjYWNoZSBhbmQgY21ha2UgMy42 Cg==