170591 2017-04-07 02:17:36 -0700 [GTK] Animations not played properly when using synchronous decoding 2017-04-13 17:32:24 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170333 InRadar P2 Normal --- 1 magomez magomez bugs-noreply cgarcia commit-queue mcatanzaro sabouhallawa webkit-bug-importer oldest_to_newest 1295246 0 magomez 2017-04-07 02:17:36 -0700 For PNG and GIF images, async decoding is used if the file size is bigger than a threshold, otherwise sync decoding is used. Bug 170333, which happens because async decoding stopped being used, revealed that sync decoding is not working properly. 1295250 1 magomez 2017-04-07 02:27:43 -0700 There seems to be an error in ImageFrameCache::destroyDecodedData(). Theoretically this should destroy all the decoded frames except one we want to keep, but what it's actually doing is destroying all the odd ones (including the one we want to keep if it's odd). 1295253 2 306481 magomez 2017-04-07 02:36:44 -0700 Created attachment 306481 Patch 1295254 3 306481 cgarcia 2017-04-07 02:38:18 -0700 Comment on attachment 306481 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306481&action=review > Source/WebCore/platform/graphics/ImageFrameCache.cpp:101 > - decodedSize += m_frames[index++].clearImage(); > + decodedSize += m_frames[index].clearImage(); oh! good catch! 1295291 4 306481 commit-queue 2017-04-07 05:52:30 -0700 Comment on attachment 306481 Patch Clearing flags on attachment: 306481 Committed r215091: <http://trac.webkit.org/changeset/215091> 1295292 5 commit-queue 2017-04-07 05:52:31 -0700 All reviewed patches have been landed. Closing bug. 1297233 6 sabouhallawa 2017-04-13 17:32:24 -0700 <rdar://problem/31617277> 306481 2017-04-07 02:36:44 -0700 2017-04-07 05:52:30 -0700 Patch bug-170591-20170407113642.patch text/plain 1656 magomez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTExZmU1NmY5YjA1ODQ3 NDVhY2E0NWIyZDBlNzMzZjRkNjAyYTMyZi4uZDljNDU5MzljMGJiMTJjMjE5NjZjZmE0NjE4MmM4 YmY1N2UxZTBlNCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTA3ICBNaWd1 ZWwgR29tZXogIDxtYWdvbWV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUSytdIEFuaW1hdGlv bnMgbm90IHBsYXllZCBwcm9wZXJseSB3aGVuIHVzaW5nIHN5bmNocm9ub3VzIGRlY29kaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA1OTEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYW4gaW5k ZXggZXJyb3Igd2hlbiBkZXN0cm95aW5nIGRlY29kZWQgZnJhbWVzIHRoYXQgd2FzIHNvbWV0aW1l cyBkZWxldGluZyB0aGUgZnJhbWUgd2Ugd2FudGVkCisgICAgICAgIHRvIGtlZXAuCisKKyAgICAg ICAgQ292ZXJlZCBieSBleGl0ZW50IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhp Y3MvSW1hZ2VGcmFtZUNhY2hlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkltYWdlRnJhbWVDYWNo ZTo6ZGVzdHJveURlY29kZWREYXRhKToKKwogMjAxNy0wNC0wNiAgWW91ZW5uIEZhYmxldCAgPHlv dWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgW0RlYnVnXSBBU1NFUlQoIXRocm93U2NvcGUuZXhj ZXB0aW9uKCkpIG9uIGltcG9ydGVkL3czYy93ZWItcGxhdGZvcm0tdGVzdHMvZmV0Y2gvYXBpL2Nv cnMvY29ycy1wcmVmbGlnaHQtc3RhdHVzLXdvcmtlci5odG1sCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvSW1hZ2VGcmFtZUNhY2hlLmNwcAppbmRleCA3Y2FmMjNl MmI2MDQ0OGUwNWIyNjUzZGE4M2QwMTgyYzRhMDdmZjEyLi45MGUyMjU2ZjAxZWM2MjU3ODg3MmQ2 NWU5NWE1YTk3ZWQ5NjYxMzFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9n cmFwaGljcy9JbWFnZUZyYW1lQ2FjaGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL0ltYWdlRnJhbWVDYWNoZS5jcHAKQEAgLTk4LDcgKzk4LDcgQEAgdm9pZCBJbWFn ZUZyYW1lQ2FjaGU6OmRlc3Ryb3lEZWNvZGVkRGF0YShzaXplX3QgZnJhbWVDb3VudCwgc2l6ZV90 IGV4Y2x1ZGVGcmFtZSkKICAgICBmb3IgKHNpemVfdCBpbmRleCA9IDA7IGluZGV4IDwgZnJhbWVD b3VudDsgKytpbmRleCkgewogICAgICAgICBpZiAoaW5kZXggPT0gZXhjbHVkZUZyYW1lKQogICAg ICAgICAgICAgY29udGludWU7Ci0gICAgICAgIGRlY29kZWRTaXplICs9IG1fZnJhbWVzW2luZGV4 KytdLmNsZWFySW1hZ2UoKTsKKyAgICAgICAgZGVjb2RlZFNpemUgKz0gbV9mcmFtZXNbaW5kZXhd LmNsZWFySW1hZ2UoKTsKICAgICB9CiAKICAgICBkZWNvZGVkU2l6ZVJlc2V0KGRlY29kZWRTaXpl KTsK