170587 2017-04-06 21:47:29 -0700 [JSC] Change --debug option to --debugger 2017-04-07 16:26:12 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ticaiolima webkit-unassigned commit-queue keith_miller mattbaker saam oldest_to_newest 1295203 0 ticaiolima 2017-04-06 21:47:29 -0700 The new flag to trigger lldb on Tools/Scripts/run-jsc is shadowing the flag --debug to run JSC with Debug build. It should be good change it to --debugger. 1295204 1 306467 ticaiolima 2017-04-06 21:52:09 -0700 Created attachment 306467 Patch 1295207 2 306467 mattbaker 2017-04-06 22:03:18 -0700 Comment on attachment 306467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review > Tools/ChangeLog:10 > + This patch is chaging the new debugger flag for Tools/Scripts/run-jsc Typo: changing 1295208 3 306467 keith_miller 2017-04-06 22:04:58 -0700 Comment on attachment 306467 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306467&action=review r=me with comment. > Tools/Scripts/run-jsc:43 > my $debug = 0; nit: I would change this to $debugger. 1295264 4 306485 ticaiolima 2017-04-07 04:00:04 -0700 Created attachment 306485 Patch for landing Fixing Keith's comments 1295393 5 306517 ticaiolima 2017-04-07 11:06:38 -0700 Created attachment 306517 Patch for landing Fixing Typos as well. 1295416 6 saam 2017-04-07 11:46:38 -0700 Did you make sure "--debug" no longer launches a release build? 1295420 7 306517 commit-queue 2017-04-07 11:50:00 -0700 Comment on attachment 306517 Patch for landing Clearing flags on attachment: 306517 Committed r215105: <http://trac.webkit.org/changeset/215105> 1295421 8 commit-queue 2017-04-07 11:50:02 -0700 All reviewed patches have been landed. Closing bug. 1295536 9 ticaiolima 2017-04-07 16:26:12 -0700 (In reply to Saam Barati from comment #6) > Did you make sure "--debug" no longer launches a release build? Yes. I changed that because I always use "--debug" and "--release". 306467 2017-04-06 21:52:09 -0700 2017-04-07 04:00:04 -0700 Patch bug-170587-20170407015207.patch text/plain 1488 ticaiolima U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDg0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZDM1YWVkODcxNTBkZWU0MTE5NzE0NmZlZWYwYjA5ZmY0 NmU4NDA2MC4uYjM0OTk4MTkxZjFmNjk3OWFmY2UwNmVmMTFjYTNlOGZlYjkxMjc1NSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTA0LTA2ICBDYWlvIExpbWEgIDx0aWNhaW9saW1hQGdtYWlsLmNvbT4KKworICAg ICAgICBbSlNDXSBDaGFuZ2UgLS1kZWJ1ZyBvcHRpb24gdG8gLS1kZWJ1Z2dlcgorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTg3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qc2M6 CisKKyAgICAgICAgVGhpcyBwYXRjaCBpcyBjaGFnaW5nIHRoZSBuZXcgZGVidWdnZXIgZmxhZyBm b3IgVG9vbHMvU2NyaXB0cy9ydW4tanNjCisgICAgICAgIHRvIC0tZGVidWdnZXIgdG8gYXZvaWQg c2hhZG93aW5nIC0tZGVidWcgZmxhZyB1c2VkIHRvIHJ1biBKU0Mgd2l0aAorICAgICAgICBEZWJ1 ZyBidWlsZC4KKwogMjAxNy0wNC0wNiAgTXlsZXMgQy4gTWF4ZmllbGQgIDxtbWF4ZmllbGRAYXBw bGUuY29tPgogCiAgICAgICAgIE1ha2UgRm9udFdpdGhGZWF0dXJlcyB0ZXN0IGZvbnQgcGFzcyBP VFMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYyBiL1Rvb2xzL1NjcmlwdHMvcnVu LWpzYwppbmRleCAzOTY0MzZhY2M0NTVlYzBiMDNhOTc5YTI3YTA0MjkwMDkzMmM1NGU5Li41NDVh NWVhZTdhY2M1ZTVjYmExYTI3YWMzODg3YzFhOGU3ZDYyY2JiIDEwMDc1NQotLS0gYS9Ub29scy9T Y3JpcHRzL3J1bi1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjCkBAIC0zNSwxNSArMzUs MTUgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1c2UgR2V0b3B0OjpM b25nOwogdXNlIHdlYmtpdGRpcnM7Ci1HZXRvcHQ6Okxvbmc6OkNvbmZpZ3VyZSgicGFzc190aHJv dWdoIik7CitHZXRvcHQ6Okxvbmc6OkNvbmZpZ3VyZSgibm9fYXV0b19hYmJyZXYiLCAicGFzc190 aHJvdWdoIik7CiAKLW15ICR1c2FnZSA9ICJVc2FnZTogcnVuLWpzYyBbLS1jb3VudCBydW5fY291 bnRdIFstLWRlYnVnXSBzaGVsbF9maWxlIFtmaWxlMi4uLl0iOworbXkgJHVzYWdlID0gIlVzYWdl OiBydW4tanNjIFstLWNvdW50IHJ1bl9jb3VudF0gWy0tZGVidWdnZXJdIHNoZWxsX2ZpbGUgW2Zp bGUyLi4uXSI7CiAKIG15ICRjb3VudCA9IDE7CiBteSAkZGVidWcgPSAwOwogCiBHZXRPcHRpb25z KCJjb3VudHxjPWkiID0+IFwkY291bnQpOwotR2V0T3B0aW9ucygiZGVidWciID0+IFwkZGVidWcp OworR2V0T3B0aW9ucygiZGVidWdnZXIiID0+IFwkZGVidWcpOwogCiBzZXRDb25maWd1cmF0aW9u KCk7CiAK 306485 2017-04-07 04:00:04 -0700 2017-04-07 11:07:03 -0700 Patch for landing debugger-option.diff text/plain 1808 ticaiolima ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMzVh ZWQ4Li5iMzQ5OTgxIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDQtMDYgIENhaW8gTGltYSAgPHRpY2Fpb2xp bWFAZ21haWwuY29tPgorCisgICAgICAgIFtKU0NdIENoYW5nZSAtLWRlYnVnIG9wdGlvbiB0byAt LWRlYnVnZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzA1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvcnVuLWpzYzoKKworICAgICAgICBUaGlzIHBhdGNoIGlzIGNoYWdpbmcgdGhl IG5ldyBkZWJ1Z2dlciBmbGFnIGZvciBUb29scy9TY3JpcHRzL3J1bi1qc2MKKyAgICAgICAgdG8g LS1kZWJ1Z2dlciB0byBhdm9pZCBzaGFkb3dpbmcgLS1kZWJ1ZyBmbGFnIHVzZWQgdG8gcnVuIEpT QyB3aXRoCisgICAgICAgIERlYnVnIGJ1aWxkLgorCiAyMDE3LTA0LTA2ICBNeWxlcyBDLiBNYXhm aWVsZCAgPG1tYXhmaWVsZEBhcHBsZS5jb20+CiAKICAgICAgICAgTWFrZSBGb250V2l0aEZlYXR1 cmVzIHRlc3QgZm9udCBwYXNzIE9UUwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9ydW4tanNj IGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjCmluZGV4IDM5NjQzNmEuLjNhMDU0YjQgMTAwNzU1Ci0t LSBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2MKQEAg LTM1LDIyICszNSwyMiBAQCB1c2UgRmluZEJpbjsKIHVzZSBsaWIgJEZpbmRCaW46OkJpbjsKIHVz ZSBHZXRvcHQ6Okxvbmc7CiB1c2Ugd2Via2l0ZGlyczsKLUdldG9wdDo6TG9uZzo6Q29uZmlndXJl KCJwYXNzX3Rocm91Z2giKTsKK0dldG9wdDo6TG9uZzo6Q29uZmlndXJlKCJub19hdXRvX2FiYnJl diIsICJwYXNzX3Rocm91Z2giKTsKIAotbXkgJHVzYWdlID0gIlVzYWdlOiBydW4tanNjIFstLWNv dW50IHJ1bl9jb3VudF0gWy0tZGVidWddIHNoZWxsX2ZpbGUgW2ZpbGUyLi4uXSI7CitteSAkdXNh Z2UgPSAiVXNhZ2U6IHJ1bi1qc2MgWy0tY291bnQgcnVuX2NvdW50XSBbLS1kZWJ1Z2dlcl0gc2hl bGxfZmlsZSBbZmlsZTIuLi5dIjsKIAogbXkgJGNvdW50ID0gMTsKLW15ICRkZWJ1ZyA9IDA7Citt eSAkZGVidWdnZXIgPSAwOwogCiBHZXRPcHRpb25zKCJjb3VudHxjPWkiID0+IFwkY291bnQpOwot R2V0T3B0aW9ucygiZGVidWciID0+IFwkZGVidWcpOworR2V0T3B0aW9ucygiZGVidWdnZXIiID0+ IFwkZGVidWdnZXIpOwogCiBzZXRDb25maWd1cmF0aW9uKCk7CiAKIG15ICRqc2M7Ci1pZiAoJGRl YnVnKSB7Ci0gICAgbXkgJGRlYnVnZ2VyID0gZGVmaW5lZCgkRU5WeyJERUJVR0dFUiJ9KSA/ICRF TlZ7IkRFQlVHR0VSIn0gOiAibGxkYiI7Ci0gICAgJGpzYyA9ICRkZWJ1Z2dlciAuICIgIiAuIEZp bGU6OlNwZWMtPmNhdGZpbGUoanNjUHJvZHVjdERpcigpLCAianNjIC0tICIpIC4gIkBBUkdWIjsK K2lmICgkZGVidWdnZXIpIHsKKyAgICBteSAkZGVidWdnZXJDbWQgPSBkZWZpbmVkKCRFTlZ7IkRF QlVHR0VSIn0pID8gJEVOVnsiREVCVUdHRVIifSA6ICJsbGRiIjsKKyAgICAkanNjID0gJGRlYnVn Z2VyQ21kIC4gIiAiIC4gRmlsZTo6U3BlYy0+Y2F0ZmlsZShqc2NQcm9kdWN0RGlyKCksICJqc2Mg LS0gIikgLiAiQEFSR1YiOwogfSBlbHNlIHsKICAgICAkanNjID0gRmlsZTo6U3BlYy0+Y2F0Zmls ZShqc2NQcm9kdWN0RGlyKCksICJqc2MgIikgLiAiQEFSR1YiOwogfQo= 306517 2017-04-07 11:06:38 -0700 2017-04-07 11:50:00 -0700 Patch for landing run_jsc_debugger.diff text/plain 1809 ticaiolima ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCBkMzVh ZWQ4Li5hZWIzZTA2IDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDQtMDYgIENhaW8gTGltYSAgPHRpY2Fpb2xp bWFAZ21haWwuY29tPgorCisgICAgICAgIFtKU0NdIENoYW5nZSAtLWRlYnVnIG9wdGlvbiB0byAt LWRlYnVnZ2VyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xNzA1ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIFNjcmlwdHMvcnVuLWpzYzoKKworICAgICAgICBUaGlzIHBhdGNoIGlzIGNoYW5naW5nIHRo ZSBuZXcgZGVidWdnZXIgZmxhZyBmb3IgVG9vbHMvU2NyaXB0cy9ydW4tanNjCisgICAgICAgIHRv IC0tZGVidWdnZXIgdG8gYXZvaWQgc2hhZG93aW5nIC0tZGVidWcgZmxhZyB1c2VkIHRvIHJ1biBK U0Mgd2l0aAorICAgICAgICBEZWJ1ZyBidWlsZC4KKwogMjAxNy0wNC0wNiAgTXlsZXMgQy4gTWF4 ZmllbGQgIDxtbWF4ZmllbGRAYXBwbGUuY29tPgogCiAgICAgICAgIE1ha2UgRm9udFdpdGhGZWF0 dXJlcyB0ZXN0IGZvbnQgcGFzcyBPVFMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpz YyBiL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYwppbmRleCAzOTY0MzZhLi4zYTA1NGI0IDEwMDc1NQot LS0gYS9Ub29scy9TY3JpcHRzL3J1bi1qc2MKKysrIGIvVG9vbHMvU2NyaXB0cy9ydW4tanNjCkBA IC0zNSwyMiArMzUsMjIgQEAgdXNlIEZpbmRCaW47CiB1c2UgbGliICRGaW5kQmluOjpCaW47CiB1 c2UgR2V0b3B0OjpMb25nOwogdXNlIHdlYmtpdGRpcnM7Ci1HZXRvcHQ6Okxvbmc6OkNvbmZpZ3Vy ZSgicGFzc190aHJvdWdoIik7CitHZXRvcHQ6Okxvbmc6OkNvbmZpZ3VyZSgibm9fYXV0b19hYmJy ZXYiLCAicGFzc190aHJvdWdoIik7CiAKLW15ICR1c2FnZSA9ICJVc2FnZTogcnVuLWpzYyBbLS1j b3VudCBydW5fY291bnRdIFstLWRlYnVnXSBzaGVsbF9maWxlIFtmaWxlMi4uLl0iOworbXkgJHVz YWdlID0gIlVzYWdlOiBydW4tanNjIFstLWNvdW50IHJ1bl9jb3VudF0gWy0tZGVidWdnZXJdIHNo ZWxsX2ZpbGUgW2ZpbGUyLi4uXSI7CiAKIG15ICRjb3VudCA9IDE7Ci1teSAkZGVidWcgPSAwOwor bXkgJGRlYnVnZ2VyID0gMDsKIAogR2V0T3B0aW9ucygiY291bnR8Yz1pIiA9PiBcJGNvdW50KTsK LUdldE9wdGlvbnMoImRlYnVnIiA9PiBcJGRlYnVnKTsKK0dldE9wdGlvbnMoImRlYnVnZ2VyIiA9 PiBcJGRlYnVnZ2VyKTsKIAogc2V0Q29uZmlndXJhdGlvbigpOwogCiBteSAkanNjOwotaWYgKCRk ZWJ1ZykgewotICAgIG15ICRkZWJ1Z2dlciA9IGRlZmluZWQoJEVOVnsiREVCVUdHRVIifSkgPyAk RU5WeyJERUJVR0dFUiJ9IDogImxsZGIiOwotICAgICRqc2MgPSAkZGVidWdnZXIgLiAiICIgLiBG aWxlOjpTcGVjLT5jYXRmaWxlKGpzY1Byb2R1Y3REaXIoKSwgImpzYyAtLSAiKSAuICJAQVJHViI7 CitpZiAoJGRlYnVnZ2VyKSB7CisgICAgbXkgJGRlYnVnZ2VyQ21kID0gZGVmaW5lZCgkRU5WeyJE RUJVR0dFUiJ9KSA/ICRFTlZ7IkRFQlVHR0VSIn0gOiAibGxkYiI7CisgICAgJGpzYyA9ICRkZWJ1 Z2dlckNtZCAuICIgIiAuIEZpbGU6OlNwZWMtPmNhdGZpbGUoanNjUHJvZHVjdERpcigpLCAianNj IC0tICIpIC4gIkBBUkdWIjsKIH0gZWxzZSB7CiAgICAgJGpzYyA9IEZpbGU6OlNwZWMtPmNhdGZp bGUoanNjUHJvZHVjdERpcigpLCAianNjICIpIC4gIkBBUkdWIjsKIH0K