170580 2017-04-06 17:44:42 -0700 Fix and enable ChakraCore/test/es6/ES6Function_bugs.js after r215072 2017-04-07 17:56:29 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 msaboff msaboff commit-queue jfbastien oldest_to_newest 1295148 0 msaboff 2017-04-06 17:44:42 -0700 After change set r215072, ChakraCore/test/es6/ES6Function_bugs.js fails one subtest. That subtest however appears to be wrong. It checks that defineProperty("length") to a getter on a sealed function shouldn't throw. JSC and V8 both throw and that behavior seems to be consistent with the ECMAScript spec. That part of the test should be disabled. 1295155 1 306449 msaboff 2017-04-06 17:47:16 -0700 Created attachment 306449 Patch 1295587 2 306449 jfbastien 2017-04-07 17:37:37 -0700 Comment on attachment 306449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306449&action=review r=me > JSTests/ChakraCore/test/es6/ES6Function_bugs.js:32 > + * Verified that V8 also throws here. Can you file a bug on test262 for this? 1295588 3 msaboff 2017-04-07 17:38:20 -0700 (In reply to JF Bastien from comment #2) > Comment on attachment 306449 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306449&action=review > > r=me > > > JSTests/ChakraCore/test/es6/ES6Function_bugs.js:32 > > + * Verified that V8 also throws here. > > Can you file a bug on test262 for this? This is Chakra's own test. 1295598 4 306449 commit-queue 2017-04-07 17:56:27 -0700 Comment on attachment 306449 Patch Clearing flags on attachment: 306449 Committed r215133: <http://trac.webkit.org/changeset/215133> 1295599 5 commit-queue 2017-04-07 17:56:29 -0700 All reviewed patches have been landed. Closing bug. 306449 2017-04-06 17:47:16 -0700 2017-04-07 17:56:27 -0700 Patch 170580.patch text/plain 2540 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTUwNzgpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIEZpeCBhbmQgZW5hYmxlIENoYWtyYUNvcmUvdGVzdC9lczYvRVM2 RnVuY3Rpb25fYnVncy5qcyBhZnRlciByMjE1MDcyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA1ODAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICBDb21tZW50ZWQgb3V0IHN1YnRlc3QgdGhhdCBleHBlY3Rz IGRlZmluZVByb3BlcnR5KCJsZW5ndGgiKSB0byBhIGdldHRlciBvbiBhCisgICAgICAgIHNlYWxl ZCBmdW5jdGlvbiBzaG91bGRuJ3QgdGhyb3cuCisKKyAgICAgICAgKiBDaGFrcmFDb3JlLnlhbWw6 CisgICAgICAgICogQ2hha3JhQ29yZS90ZXN0L2VzNi9FUzZGdW5jdGlvbl9idWdzLmpzOgorCiAy MDE3LTA0LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAg IENhbm5vdCBPYmplY3Quc2VhbCgpIG9yIE9iamVjdC5mcmVlemUoKSBnbG9iYWwgInRoaXMiCklu ZGV4OiBKU1Rlc3RzL0NoYWtyYUNvcmUueWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL0NoYWty YUNvcmUueWFtbAkocmV2aXNpb24gMjE1MDcyKQorKysgSlNUZXN0cy9DaGFrcmFDb3JlLnlhbWwJ KHdvcmtpbmcgY29weSkKQEAgLTE4MzQsOCArMTgzNCw3IEBACiAgICMgRGlmZmVyZW50IGJlaGF2 aW9yLgogICBjbWQ6IHJ1bkNoYWtyYSA6c2tpcCwgIk5vRXhjZXB0aW9uIiwgInByb3h5dGVzdDku YmFzZWxpbmUiLCBbXQogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvZXM2L0VTNkZ1bmN0aW9uX2J1 Z3MuanMKLSAgIyBEaWZmZXJlbnQgYmVoYXZpb3Igd2l0aCBPYmplY3Quc2VhbCgpLgotICBjbWQ6 IHJ1bkNoYWtyYSA6c2tpcCwgIk5vRXhjZXB0aW9uIiwgIiIsIFsiLi4vVW5pdFRlc3RGcmFtZXdv cmsvVW5pdFRlc3RGcmFtZXdvcmsuanMiXQorICBjbWQ6IHJ1bkNoYWtyYSA6cGFzcywgIk5vRXhj ZXB0aW9uIiwgIiIsIFsiLi4vVW5pdFRlc3RGcmFtZXdvcmsvVW5pdFRlc3RGcmFtZXdvcmsuanMi XQogLSBwYXRoOiBDaGFrcmFDb3JlL3Rlc3QvZXM2L09TXzI3MDA3NzguanMKICAgY21kOiBydW5D aGFrcmEgOnBhc3MsICJOb0V4Y2VwdGlvbiIsICIiLCBbXQogLSBwYXRoOiBDaGFrcmFDb3JlL3Rl c3QvZXM2L2J1Z19PU18yMTg0Nzk1LmpzCkluZGV4OiBKU1Rlc3RzL0NoYWtyYUNvcmUvdGVzdC9l czYvRVM2RnVuY3Rpb25fYnVncy5qcwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL0NoYWtyYUNvcmUv dGVzdC9lczYvRVM2RnVuY3Rpb25fYnVncy5qcwkocmV2aXNpb24gMjE1MDcyKQorKysgSlNUZXN0 cy9DaGFrcmFDb3JlL3Rlc3QvZXM2L0VTNkZ1bmN0aW9uX2J1Z3MuanMJKHdvcmtpbmcgY29weSkK QEAgLTI4LDcgKzI4LDEwIEBAIHZhciB0ZXN0cyA9IFsKICAgICAgICAgICAgICAgICAgICAgZ2V0 OiBmdW5jdGlvbiAoKSB7IH0KICAgICAgICAgICAgICAgICAgICAgfSk7CiAgICAgICAgICAgICB9 Ci0gICAgICAgICAgICBhc3NlcnQuZG9lc05vdFRocm93KGZ1bmN0aW9uICgpIHsgZygnbGVuZ3Ro JykgfSwgImFzc2VydGlvbiBmYWlsdXJlIG9uIGRlZmluZVByb3BlcnR5ICdsZW5ndGgnIHdpdGgg Z2V0dGVyIGFmdGVyIHNlYWxpbmcgYSBmdW5jdGlvbiBvYmplY3QiKTsKKy8qIFRoaXMgY2hlY2sg c2VlbXMgd3JvbmcgaW4gdGhhdCB3ZSBhcmUgdHJ5aW5nIHRvIGNoYW5nZSBsZW5ndGggdG8gYSBn ZXR0ZXIsIHdoaWNoIHNob3VsZCB0aHJvdy4KKyAqIFZlcmlmaWVkIHRoYXQgVjggYWxzbyB0aHJv d3MgaGVyZS4KKyAqICAgICAgICAgIGFzc2VydC5kb2VzTm90VGhyb3coZnVuY3Rpb24gKCkgeyBn KCdsZW5ndGgnKSB9LCAiYXNzZXJ0aW9uIGZhaWx1cmUgb24gZGVmaW5lUHJvcGVydHkgJ2xlbmd0 aCcgd2l0aCBnZXR0ZXIgYWZ0ZXIgc2VhbGluZyBhIGZ1bmN0aW9uIG9iamVjdCIpOworICovCiAg ICAgICAgICAgICBhc3NlcnQudGhyb3dzKGZ1bmN0aW9uICgpIHsgZygnYXJndW1lbnRzJykgfSwg VHlwZUVycm9yLCAiQ2Fubm90IHJlZGVmaW5lIG5vbi1jb25maWd1cmFibGUgcHJvcGVydHkgJ2Fy Z3VtZW50cyciKTsKICAgICAgICAgICAgIGFzc2VydC50aHJvd3MoZnVuY3Rpb24gKCkgeyBnKCdj YWxsZXInKSB9LCBUeXBlRXJyb3IsICJDYW5ub3QgcmVkZWZpbmUgbm9uLWNvbmZpZ3VyYWJsZSBw cm9wZXJ0eSAnY2FsbGVyJyIpOwogICAgICAgICAgfQo=