170575 2017-04-06 16:58:27 -0700 Web Inspector: Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics 2017-04-06 17:40:07 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck bburg buildbot cdumez cgarcia commit-queue inspector-bugzilla-changes joepeck youennf oldest_to_newest 1295117 0 joepeck 2017-04-06 16:58:27 -0700 Hangs when loading under SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics with Inspector open. This is infinite looping because m_networkLoad is (this). #if USE(NETWORK_SESSION) bool SpeculativeLoad::shouldCaptureExtraNetworkLoadMetrics() const { return m_networkLoad->shouldCaptureExtraNetworkLoadMetrics(); } #endif We can just drop this method and get the right behavior. 1295120 1 306439 joepeck 2017-04-06 17:01:09 -0700 Created attachment 306439 [PATCH] Proposed Fix 1295121 2 306439 bburg 2017-04-06 17:02:03 -0700 Comment on attachment 306439 [PATCH] Proposed Fix rs=🤣 1295146 3 joepeck 2017-04-06 17:40:07 -0700 <https://trac.webkit.org/changeset/215078/webkit> 306439 2017-04-06 17:01:09 -0700 2017-04-06 17:37:42 -0700 [PATCH] Proposed Fix awesome-sauce-1.patch text/plain 2308 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCBkOGEwODU5ODRlZC4uMTU1NzdmY2VkM2EgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNyBAQAogMjAxNy0wNC0wNiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUu Y29tPgogCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEhhbmdzIHdoZW4gbG9hZGluZyB1bmRlciBT cGVjdWxhdGl2ZUxvYWQ6OnNob3VsZENhcHR1cmVFeHRyYU5ldHdvcmtMb2FkTWV0cmljcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTc1CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJv Y2Vzcy9jYWNoZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWQuY3BwOgorICAgICAgICAoV2Vi S2l0OjpOZXR3b3JrQ2FjaGU6OlNwZWN1bGF0aXZlTG9hZDo6c2hvdWxkQ2FwdHVyZUV4dHJhTmV0 d29ya0xvYWRNZXRyaWNzKTogRGVsZXRlZC4KKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWQuaDoKKyAgICAgICAgbV9uZXR3b3JrTG9hZCBp cyBhIHdyYXBwZXIgYXJvdW5kIGB0aGlzYCBhcyB0aGUgY2xpZW50LCBzbyB3ZSB3b3VsZCBpbmZp bml0ZSBsb29wIGhlcmUuCisKKzIwMTctMDQtMDYgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJv QGFwcGxlLmNvbT4KKwogICAgICAgICBXZWIgSW5zcGVjdG9yOiBPbmx5IENhcHR1cmUgRXh0cmEg TmV0d29yayBMb2FkIE1ldHJpY3Mgd2hlbiB0aGVyZSBpcyBhIFdlYiBJbnNwZWN0b3IgRnJvbnRl bmQKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDUy NQogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNoZS9OZXR3 b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWQuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcAppbmRleCAyZTJmNGIxODgz Yi4uYjkzODY4YzlmNTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5jcHAKKysrIGIvU291cmNlL1dlYktp dDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0NhY2hlU3BlY3VsYXRpdmVMb2FkLmNwcApA QCAtMTU2LDEzICsxNTYsNiBAQCB2b2lkIFNwZWN1bGF0aXZlTG9hZDo6ZGlkQ29tcGxldGUoKQog ICAgIG1fY29tcGxldGlvbkhhbmRsZXIoV1RGTW92ZShtX2NhY2hlRW50cnkpKTsKIH0KIAotI2lm IFVTRShORVRXT1JLX1NFU1NJT04pCi1ib29sIFNwZWN1bGF0aXZlTG9hZDo6c2hvdWxkQ2FwdHVy ZUV4dHJhTmV0d29ya0xvYWRNZXRyaWNzKCkgY29uc3QKLXsKLSAgICByZXR1cm4gbV9uZXR3b3Jr TG9hZC0+c2hvdWxkQ2FwdHVyZUV4dHJhTmV0d29ya0xvYWRNZXRyaWNzKCk7Ci19Ci0jZW5kaWYK LQogfSAvLyBuYW1lc3BhY2UgTmV0d29ya0NhY2hlCiB9IC8vIG5hbWVzcGFjZSBXZWJLaXQKIApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nlc3MvY2FjaGUvTmV0d29ya0Nh Y2hlU3BlY3VsYXRpdmVMb2FkLmggYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9jYWNo ZS9OZXR3b3JrQ2FjaGVTcGVjdWxhdGl2ZUxvYWQuaAppbmRleCBjMjJjMmU4YzkwMC4uYTNmZTkw NjYwMGYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL2NhY2hlL05l dHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL2NhY2hlL05ldHdvcmtDYWNoZVNwZWN1bGF0aXZlTG9hZC5oCkBAIC02NCwxMCArNjQs NiBAQCBwcml2YXRlOgogICAgIHZvaWQgZGlkRmluaXNoTG9hZGluZyhjb25zdCBXZWJDb3JlOjpO ZXR3b3JrTG9hZE1ldHJpY3MmKSBvdmVycmlkZTsKICAgICB2b2lkIGRpZEZhaWxMb2FkaW5nKGNv bnN0IFdlYkNvcmU6OlJlc291cmNlRXJyb3ImKSBvdmVycmlkZTsKIAotI2lmIFVTRShORVRXT1JL X1NFU1NJT04pCi0gICAgYm9vbCBzaG91bGRDYXB0dXJlRXh0cmFOZXR3b3JrTG9hZE1ldHJpY3Mo KSBjb25zdCBvdmVycmlkZTsKLSNlbmRpZgotCiAgICAgdm9pZCBkaWRDb21wbGV0ZSgpOwogCiAg ICAgR2xvYmFsRnJhbWVJRCBtX2ZyYW1lSUQ7Cg==