170563 2017-04-06 13:18:07 -0700 B3 -O1 should generate better code than -O0 2017-04-06 16:14:13 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build All All RESOLVED FIXED P2 Normal --- 1 fpizlo fpizlo buildbot keith_miller mark.lam msaboff saam oldest_to_newest 1295010 0 fpizlo 2017-04-06 13:18:07 -0700 Patch forthcoming. 1295018 1 306420 fpizlo 2017-04-06 13:26:31 -0700 Created attachment 306420 the patch 1295026 2 306420 msaboff 2017-04-06 13:42:38 -0700 Comment on attachment 306420 the patch r=me 1295032 3 fpizlo 2017-04-06 13:58:57 -0700 Landed in https://trac.webkit.org/changeset/215057/webkit 1295102 4 306420 saam 2017-04-06 16:14:13 -0700 Comment on attachment 306420 the patch View in context: https://bugs.webkit.org/attachment.cgi?id=306420&action=review LGTM too > Source/JavaScriptCore/ChangeLog:27 > + This makes wasm -O1 compile 17% faster. This makes wasm -O1 run 19% faster. This makes -O1 code Nice! 306420 2017-04-06 13:26:31 -0700 2017-04-06 13:42:38 -0700 the patch blah.patch text/plain 7118 fpizlo SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMjE1MDU0KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM1IEBA CisyMDE3LTA0LTA2ICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CisKKyAgICAgICAg QjMgLU8xIHNob3VsZCBnZW5lcmF0ZSBiZXR0ZXIgY29kZSB0aGFuIC1PMAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTYzCisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisgICAgICAgIAorICAgICAgICBQcmlvciB0byB0aGlz IGNoYW5nZSwgY29kZSBnZW5lcmF0ZWQgYnkgLU8xIHJhbiBzbG93ZXIgdGhhbiBjb2RlIGdlbmVy YXRlZCBieSAtTzAuIFRoaXMgdHVybmVkCisgICAgICAgIG91dCB0byBiZSBiZWNhdXNlIG9mIHJl ZHVjZVN0cmVuZ3RoIG9wdGltaXphdGlvbnMgdGhhdCBpbmNyZWFzZSBsaXZlIHJhbmdlcyBhbmQg Y3JlYXRlIHJlZ2lzdGVyCisgICAgICAgIHByZXNzdXJlLCB3aGljaCB0aGVuIGNyZWF0ZXMgcHJv YmxlbXMgZm9yIGxpbmVhciBzY2FuLgorICAgICAgICAKKyAgICAgICAgSXQgc2VlbWVkIG9idmlv dXMgdGhhdCBjYW5vbmljYWxpemF0aW9ucyB0aGF0IGhlbHAgaXNlbCwgY29uc3RhbnQgZm9sZGlu ZywgYW5kIG9uZS1mb3Itb25lCisgICAgICAgIHN0cmVuZ3RoIHJlZHVjdGlvbnMgc2hvdWxkIHN0 YXkuIEl0IGFsc28gc2VlbWVkIG9idmlvdXMgdGhhdCBTU0EgYW5kIENGRyBzaW1wbGlmaWNhdGlv biBhcmUgZmFzdAorICAgICAgICBhbmQgaGFybWxlc3MuIFNvLCBJIGZvY3VzZWQgb24gcmVtb3Zp bmc6CisgICAgICAgIAorICAgICAgICAtIENTRSwgd2hpY2ggaW5jcmVhc2VzIGxpdmUgcmFuZ2Vz LiBUaGlzIGlzIGEgcmlza3kgb3B0aW1pemF0aW9uIHdoZW4gd2Uga25vdyB0aGF0IHdlJ3ZlIGNo b3NlbgorICAgICAgICAgIHRvIHVzZSBhIGJhZCByZWdpc3RlciBhbGxvY2F0b3IuCisgICAgICAg IAorICAgICAgICAtIFNvcGhpc3RpY2F0ZWQgc3RyZW5ndGggcmVkdWN0aW9ucyB0aGF0IGNyZWF0 ZSBtb3JlIGNvZGUsIGxpa2UgdGhlIGluc2FuZSBkaXZpc2lvbiBvcHRpbWl6YXRpb24uCisgICAg ICAgIAorICAgICAgICAtIEFueXRoaW5nIHRoYXQgaW5zZXJ0cyBiYXNpYyBibG9ja3MuCisgICAg ICAgIAorICAgICAgICBDU0UgYXBwZWFyZWQgdG8gYmUgdGhlIGNhdXNlIG9mIGhhbGYgb2YgdGhl IHRocm91Z2hwdXQgcmVncmVzc2lvbiBvZiAtTzEgYnV0IG5vbmUgb2YgdGhlIGNvbXBpbGUKKyAg ICAgICAgdGltZS4gVGhpcyBjaGFuZ2UgYWxzbyByZWR1Y2VzIHRoZSBydW5uaW5nIHRpbWUgb2Yg cmVkdWNlU3RyZW5ndGggYnkgbWFraW5nIGl0IG5vdCBhIGZpeHBvaW50IGF0CisgICAgICAgIG9w dExldmVsPDIuCisgICAgICAgIAorICAgICAgICBUaGlzIG1ha2VzIHdhc20gLU8xIGNvbXBpbGUg MTclIGZhc3Rlci4gVGhpcyBtYWtlcyB3YXNtIC1PMSBydW4gMTklIGZhc3Rlci4gVGhpcyBtYWtl cyAtTzEgY29kZQorICAgICAgICBydW4gMyUgZmFzdGVyIHRoYW4gLU8wLCBhbmQgY29tcGlsZSBh Ym91dCA0JSBzbG93ZXIgdGhhbiAtTzAuIFdlIG1heSB5ZXQgZW5kIHVwIGNob29zaW5nIHRvIHVz ZQorICAgICAgICAtTzAsIGJ1dCBhdCBsZWFzdCBub3cgLU8xIGlzbid0IHRvdGFsbHkgdXNlbGVz cy4KKworICAgICAgICAqIGIzL0IzUmVkdWNlU3RyZW5ndGguY3BwOgorCiAyMDE3LTA0LTA2ICBK b24gRGF2aXMgIDxqb25kQGFwcGxlLmNvbT4KIAogICAgICAgICBVcGRhdGVzIGZlYXR1cmUgc3Rh dHVzIGZvciByZWNlbnRseSBzaGlwcGVkIGZlYXR1cmVzCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlw dENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFT Y3JpcHRDb3JlL2IzL0IzUmVkdWNlU3RyZW5ndGguY3BwCShyZXZpc2lvbiAyMTQ5NzApCisrKyBT b3VyY2UvSmF2YVNjcmlwdENvcmUvYjMvQjNSZWR1Y2VTdHJlbmd0aC5jcHAJKHdvcmtpbmcgY29w eSkKQEAgLTQ0Miw5ICs0NDIsMTEgQEAgcHVibGljOgogICAgICAgICAgICAgCiAgICAgICAgICAg ICBzaW1wbGlmeVNTQSgpOwogICAgICAgICAgICAgCi0gICAgICAgICAgICBtX3Byb2MucmVzZXRW YWx1ZU93bmVycygpOwotICAgICAgICAgICAgbV9kb21pbmF0b3JzID0gJm1fcHJvYy5kb21pbmF0 b3JzKCk7IC8vIFJlY29tcHV0ZSBpZiBuZWNlc3NhcnkuCi0gICAgICAgICAgICBtX3B1cmVDU0Uu Y2xlYXIoKTsKKyAgICAgICAgICAgIGlmIChtX3Byb2Mub3B0TGV2ZWwoKSA+PSAyKSB7CisgICAg ICAgICAgICAgICAgbV9wcm9jLnJlc2V0VmFsdWVPd25lcnMoKTsKKyAgICAgICAgICAgICAgICBt X2RvbWluYXRvcnMgPSAmbV9wcm9jLmRvbWluYXRvcnMoKTsgLy8gUmVjb21wdXRlIGlmIG5lY2Vz c2FyeS4KKyAgICAgICAgICAgICAgICBtX3B1cmVDU0UuY2xlYXIoKTsKKyAgICAgICAgICAgIH0K IAogICAgICAgICAgICAgZm9yIChCYXNpY0Jsb2NrKiBibG9jayA6IG1fcHJvYy5ibG9ja3NJblBy ZU9yZGVyKCkpIHsKICAgICAgICAgICAgICAgICBtX2Jsb2NrID0gYmxvY2s7CkBAIC00NTcsMjMg KzQ1OSwyNSBAQCBwdWJsaWM6CiAgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAg ICAgICAgbV92YWx1ZSA9IG1fYmxvY2stPmF0KG1faW5kZXgpOwogICAgICAgICAgICAgICAgICAg ICBtX3ZhbHVlLT5wZXJmb3JtU3Vic3RpdHV0aW9uKCk7Ci0gICAgICAgICAgICAgICAgICAgIAog ICAgICAgICAgICAgICAgICAgICByZWR1Y2VWYWx1ZVN0cmVuZ3RoKCk7Ci0gICAgICAgICAgICAg ICAgICAgIHJlcGxhY2VJZlJlZHVuZGFudCgpOworICAgICAgICAgICAgICAgICAgICBpZiAobV9w cm9jLm9wdExldmVsKCkgPj0gMikKKyAgICAgICAgICAgICAgICAgICAgICAgIHJlcGxhY2VJZlJl ZHVuZGFudCgpOwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAgICBtX2luc2VydGlv blNldC5leGVjdXRlKG1fYmxvY2spOwogICAgICAgICAgICAgfQogCiAgICAgICAgICAgICBtX2No YW5nZWRDRkcgfD0gbV9ibG9ja0luc2VydGlvblNldC5leGVjdXRlKCk7Ci0gICAgICAgICAgICBp ZiAobV9jaGFuZ2VkQ0ZHKSB7Ci0gICAgICAgICAgICAgICAgbV9wcm9jLnJlc2V0UmVhY2hhYmls aXR5KCk7Ci0gICAgICAgICAgICAgICAgbV9wcm9jLmludmFsaWRhdGVDRkcoKTsKLSAgICAgICAg ICAgICAgICBtX2RvbWluYXRvcnMgPSBudWxscHRyOyAvLyBEb21pbmF0b3JzIGFyZSBub3QgdmFs aWQgYW55bW9yZSwgYW5kIHdlIGRvbid0IG5lZWQgdGhlbSB5ZXQuCi0gICAgICAgICAgICAgICAg bV9jaGFuZ2VkID0gdHJ1ZTsKLSAgICAgICAgICAgIH0KKyAgICAgICAgICAgIGhhbmRsZUNoYW5n ZWRDRkdJZk5lY2Vzc2FyeSgpOwogICAgICAgICAgICAgCiAgICAgICAgICAgICByZXN1bHQgfD0g bV9jaGFuZ2VkOwotICAgICAgICB9IHdoaWxlIChtX2NoYW5nZWQpOworICAgICAgICB9IHdoaWxl IChtX2NoYW5nZWQgJiYgbV9wcm9jLm9wdExldmVsKCkgPj0gMik7CisgICAgICAgIAorICAgICAg ICBpZiAobV9wcm9jLm9wdExldmVsKCkgPCAyKSB7CisgICAgICAgICAgICBtX2NoYW5nZWRDRkcg PSBmYWxzZTsKKyAgICAgICAgICAgIHNpbXBsaWZ5Q0ZHKCk7CisgICAgICAgICAgICBoYW5kbGVD aGFuZ2VkQ0ZHSWZOZWNlc3NhcnkoKTsKKyAgICAgICAgfQorICAgICAgICAKICAgICAgICAgcmV0 dXJuIHJlc3VsdDsKICAgICB9CiAgICAgCkBAIC03MjYsNiArNzMwLDkgQEAgcHJpdmF0ZToKIAog ICAgICAgICAgICAgICAgICAgICBpZiAobV92YWx1ZS0+dHlwZSgpICE9IEludDMyKQogICAgICAg ICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIAorICAgICAgICAg ICAgICAgICAgICBpZiAobV9wcm9jLm9wdExldmVsKCkgPCAyKQorICAgICAgICAgICAgICAgICAg ICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgICAgICAgICAgaW50MzJfdCBkaXZpc29yID0gbV92 YWx1ZS0+Y2hpbGQoMSktPmFzSW50MzIoKTsKICAgICAgICAgICAgICAgICAgICAgRGl2aXNpb25N YWdpYzxpbnQzMl90PiBtYWdpYyA9IGNvbXB1dGVEaXZpc2lvbk1hZ2ljKGRpdmlzb3IpOwpAQCAt ODIxLDYgKzgyOCw5IEBAIHByaXZhdGU6CiAgICAgICAgICAgICAgICAgICAgIGJyZWFrOwogCiAg ICAgICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICAgICAgaWYgKG1fcHJvYy5v cHRMZXZlbCgpIDwgMikKKyAgICAgICAgICAgICAgICAgICAgICAgIGJyZWFrOworICAgICAgICAg ICAgICAgICAgICAKICAgICAgICAgICAgICAgICAgICAgLy8gVHVybiB0aGlzOiBNb2QoTiwgRCkK ICAgICAgICAgICAgICAgICAgICAgLy8gSW50byB0aGlzOiBTdWIoTiwgTXVsKERpdihOLCBEKSwg RCkpCiAgICAgICAgICAgICAgICAgICAgIC8vCkBAIC0xODQxLDYgKzE4NTEsOSBAQCBwcml2YXRl OgogICAgICAgICAgICAgICAgIGNoZWNrVmFsdWUtPmNoaWxkKDApID0gY2hlY2tWYWx1ZS0+Y2hp bGQoMCktPmNoaWxkKDApOwogICAgICAgICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CiAgICAg ICAgICAgICB9CisgICAgICAgICAgICAKKyAgICAgICAgICAgIGlmIChtX3Byb2Mub3B0TGV2ZWwo KSA8IDIpCisgICAgICAgICAgICAgICAgYnJlYWs7CiAKICAgICAgICAgICAgIC8vIElmIHdlIGFy ZSBjaGVja2luZyBzb21lIGJvdW5kZWQtc2l6ZSBTU0EgZXhwcmVzc2lvbiB0aGF0IGxlYWRzIHRv IGEgU2VsZWN0IHRoYXQKICAgICAgICAgICAgIC8vIGhhcyBhIGNvbnN0YW50IGFzIG9uZSBvZiBp dHMgcmVzdWx0cywgdGhlbiB0dXJuIHRoZSBTZWxlY3QgaW50byBhIEJyYW5jaCBhbmQgc3BsaXQK QEAgLTE5NDcsMTcgKzE5NjAsMTkgQEAgcHJpdmF0ZToKICAgICAgICAgICAgICAgICBicmVhazsK ICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAgLy8gSWYgYSBjaGVjayBmb3IgdGhlIHNhbWUg cHJvcGVydHkgZG9taW5hdGVzIHVzLCB3ZSBjYW4ga2lsbCB0aGUgYnJhbmNoLiBUaGlzIHNvcnQK LSAgICAgICAgICAgIC8vIG9mIG1ha2VzIHNlbnNlIGhlcmUgYmVjYXVzZSBpdCdzIGNoZWFwLCBi dXQgaGFja3MgbGlrZSB0aGlzIHNob3cgdGhhdCB3ZSdyZSBnb2luZwotICAgICAgICAgICAgLy8g dG8gbmVlZCBTQ0NQLgotICAgICAgICAgICAgVmFsdWUqIGNoZWNrID0gbV9wdXJlQ1NFLmZpbmRN YXRjaCgKLSAgICAgICAgICAgICAgICBWYWx1ZUtleShDaGVjaywgVm9pZCwgbV92YWx1ZS0+Y2hp bGQoMCkpLCBtX2Jsb2NrLCAqbV9kb21pbmF0b3JzKTsKLSAgICAgICAgICAgIGlmIChjaGVjaykg ewotICAgICAgICAgICAgICAgIC8vIFRoZSBDaGVjayB3b3VsZCBoYXZlIHNpZGUtZXhpdGVkIGlm IGNoaWxkKDApIHdhcyBub24temVyby4gU28sIGl0IG11c3QgYmUKLSAgICAgICAgICAgICAgICAv LyB6ZXJvIGhlcmUuCi0gICAgICAgICAgICAgICAgbV9ibG9jay0+dGFrZW4oKS5ibG9jaygpLT5y ZW1vdmVQcmVkZWNlc3NvcihtX2Jsb2NrKTsKLSAgICAgICAgICAgICAgICBtX3ZhbHVlLT5yZXBs YWNlV2l0aEp1bXAobV9ibG9jaywgbV9ibG9jay0+bm90VGFrZW4oKSk7Ci0gICAgICAgICAgICAg ICAgbV9jaGFuZ2VkQ0ZHID0gdHJ1ZTsKKyAgICAgICAgICAgIGlmIChtX3Byb2Mub3B0TGV2ZWwo KSA+PSAyKSB7CisgICAgICAgICAgICAgICAgLy8gSWYgYSBjaGVjayBmb3IgdGhlIHNhbWUgcHJv cGVydHkgZG9taW5hdGVzIHVzLCB3ZSBjYW4ga2lsbCB0aGUgYnJhbmNoLiBUaGlzIHNvcnQKKyAg ICAgICAgICAgICAgICAvLyBvZiBtYWtlcyBzZW5zZSBoZXJlIGJlY2F1c2UgaXQncyBjaGVhcCwg YnV0IGhhY2tzIGxpa2UgdGhpcyBzaG93IHRoYXQgd2UncmUgZ29pbmcKKyAgICAgICAgICAgICAg ICAvLyB0byBuZWVkIFNDQ1AuCisgICAgICAgICAgICAgICAgVmFsdWUqIGNoZWNrID0gbV9wdXJl Q1NFLmZpbmRNYXRjaCgKKyAgICAgICAgICAgICAgICAgICAgVmFsdWVLZXkoQ2hlY2ssIFZvaWQs IG1fdmFsdWUtPmNoaWxkKDApKSwgbV9ibG9jaywgKm1fZG9taW5hdG9ycyk7CisgICAgICAgICAg ICAgICAgaWYgKGNoZWNrKSB7CisgICAgICAgICAgICAgICAgICAgIC8vIFRoZSBDaGVjayB3b3Vs ZCBoYXZlIHNpZGUtZXhpdGVkIGlmIGNoaWxkKDApIHdhcyBub24temVyby4gU28sIGl0IG11c3Qg YmUKKyAgICAgICAgICAgICAgICAgICAgLy8gemVybyBoZXJlLgorICAgICAgICAgICAgICAgICAg ICBtX2Jsb2NrLT50YWtlbigpLmJsb2NrKCktPnJlbW92ZVByZWRlY2Vzc29yKG1fYmxvY2spOwor ICAgICAgICAgICAgICAgICAgICBtX3ZhbHVlLT5yZXBsYWNlV2l0aEp1bXAobV9ibG9jaywgbV9i bG9jay0+bm90VGFrZW4oKSk7CisgICAgICAgICAgICAgICAgICAgIG1fY2hhbmdlZENGRyA9IHRy dWU7CisgICAgICAgICAgICAgICAgfQogICAgICAgICAgICAgfQogICAgICAgICAgICAgYnJlYWs7 CiAgICAgICAgIH0KQEAgLTIzNzgsNiArMjM5MywxNiBAQCBwcml2YXRlOgogICAgICAgICAgICAg ZGF0YUxvZyhtX3Byb2MpOwogICAgICAgICB9CiAgICAgfQorICAgIAorICAgIHZvaWQgaGFuZGxl Q2hhbmdlZENGR0lmTmVjZXNzYXJ5KCkKKyAgICB7CisgICAgICAgIGlmIChtX2NoYW5nZWRDRkcp IHsKKyAgICAgICAgICAgIG1fcHJvYy5yZXNldFJlYWNoYWJpbGl0eSgpOworICAgICAgICAgICAg bV9wcm9jLmludmFsaWRhdGVDRkcoKTsKKyAgICAgICAgICAgIG1fZG9taW5hdG9ycyA9IG51bGxw dHI7IC8vIERvbWluYXRvcnMgYXJlIG5vdCB2YWxpZCBhbnltb3JlLCBhbmQgd2UgZG9uJ3QgbmVl ZCB0aGVtIHlldC4KKyAgICAgICAgICAgIG1fY2hhbmdlZCA9IHRydWU7CisgICAgICAgIH0KKyAg ICB9CiAKICAgICB2b2lkIGNoZWNrUHJlZGVjZXNzb3JWYWxpZGl0eSgpCiAgICAgewo=