170556 2017-04-06 11:04:59 -0700 REGRESSION (r209882): Web Inspector: Console's filter bar has text search field, but the next/previous buttons don't do anything 2017-04-19 16:41:24 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=164847 https://bugs.webkit.org/show_bug.cgi?id=170555 InRadar P2 Normal --- 1 bburg nvasilyev commit-queue inspector-bugzilla-changes mattbaker nvasilyev webkit-bug-importer oldest_to_newest 1294958 0 bburg 2017-04-06 11:04:59 -0700 We should remove these until we plan to actually make this a find bar instead of a filter bar (e.g., https://bugs.webkit.org/show_bug.cgi?id=164847). 1294960 1 webkit-bug-importer 2017-04-06 11:05:35 -0700 <rdar://problem/31481755> 1298510 2 nvasilyev 2017-04-18 16:48:18 -0700 This broke in https://trac.webkit.org/changeset/209882/webkit. 1298517 3 nvasilyev 2017-04-18 17:11:32 -0700 From UserInterface/Views/FindBanner.js: set numberOfResults(numberOfResults) { if (numberOfResults === undefined || isNaN(numberOfResults)) numberOfResults = null; this._numberOfResults = numberOfResults; this._previousResultButton.disabled = this._nextResultButton.disabled = (numberOfResults <= 0); It appears that when searching in Console tab, next/previous buttons of an instance of WebInspector.FindBanner gets disabled as expected. That problem is that it's a wrong instance of WebInspector.FindBanner, one that isn't even attached to the DOM. this._previousResultButton.parentNode // null 1298541 4 nvasilyev 2017-04-18 18:38:33 -0700 My comment above might be unrelated to this bug. See https://bugs.webkit.org/show_bug.cgi?id=164047#c10 for the cause of this regression. 1298799 5 307503 nvasilyev 2017-04-19 13:24:33 -0700 Created attachment 307503 Patch 1298881 6 307503 mattbaker 2017-04-19 16:16:56 -0700 Comment on attachment 307503 Patch r=me 1298907 7 307503 commit-queue 2017-04-19 16:41:22 -0700 Comment on attachment 307503 Patch Clearing flags on attachment: 307503 Committed r215543: <http://trac.webkit.org/changeset/215543> 1298908 8 commit-queue 2017-04-19 16:41:24 -0700 All reviewed patches have been landed. Closing bug. 307503 2017-04-19 13:24:33 -0700 2017-04-19 16:41:22 -0700 Patch patch.txt text/plain 2524 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEyZjNjMjIuLjdmNzZmZjcgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTE5ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDk4ODIp OiBXZWIgSW5zcGVjdG9yOiBDb25zb2xlJ3MgZmlsdGVyIGJhciBoYXMgdGV4dCBzZWFyY2ggZmll bGQsIGJ1dCB0aGUgbmV4dC9wcmV2aW91cyBidXR0b25zIGRvbid0IGRvIGFueXRoaW5nCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA1NTYKKyAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzMxNDgxNzU1PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmll dy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5cGUucGVy Zm9ybVNlYXJjaCk6CisgICAgICAgIFVwZGF0ZSBudW1iZXJPZlJlc3VsdHMgc2V0dGVyLCB3aGlj aCBzZXRzICJkaXNhYmxlZCIgYXR0cmlidXRlIHRvIGZhbHNlIHdoZW4gbnVtYmVyT2ZSZXN1bHRz ID4gMC4KKwogMjAxNy0wNC0xOCAgTWF0dCBCYWtlciAgPG1hdHRiYWtlckBhcHBsZS5jb20+CiAK ICAgICAgICAgV2ViIEluc3BlY3RvcjogWEhSIGJyZWFrcG9pbnRzIHNob3VsZG4ndCBiZSBjbGVh cmVkIGZyb20gdGhlIHNpZGViYXIgb24gcmVsb2FkCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCmluZGV4 IDFjN2U1ZWYuLjkwMWJlYmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCkBAIC05MjEsNiArOTIx LDcgQEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3MgTG9nQ29udGVudFZpZXcg ZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ29udGVudFYKICAgICAgICAgdGhpcy5fc2VhcmNoTWF0Y2hl cyA9IFtdOwogICAgICAgICB0aGlzLl9zZWxlY3RlZFNlYXJjaE1hdGNoSXNWYWxpZCA9IGZhbHNl OwogICAgICAgICB0aGlzLl9zZWxlY3RlZFNlYXJjaE1hdGNoID0gbnVsbDsKKyAgICAgICAgbGV0 IG51bWJlck9mUmVzdWx0cyA9IDA7CiAKICAgICAgICAgaWYgKHRoaXMuX2N1cnJlbnRTZWFyY2hR dWVyeSA9PT0gIiIpIHsKICAgICAgICAgICAgIHRoaXMuZWxlbWVudC5jbGFzc0xpc3QucmVtb3Zl KFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5TZWFyY2hJblByb2dyZXNzU3R5bGVDbGFzc05h bWUpOwpAQCAtOTM2LDYgKzkzNyw3IEBAIFdlYkluc3BlY3Rvci5Mb2dDb250ZW50VmlldyA9IGNs YXNzIExvZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVjdG9yLkNvbnRlbnRWCiAgICAgICAg ICAgICBsZXQgdGV4dCA9IG1lc3NhZ2UudGV4dENvbnRlbnQ7CiAgICAgICAgICAgICBsZXQgbWF0 Y2ggPSBzZWFyY2hSZWdleC5leGVjKHRleHQpOwogICAgICAgICAgICAgd2hpbGUgKG1hdGNoKSB7 CisgICAgICAgICAgICAgICAgbnVtYmVyT2ZSZXN1bHRzKys7CiAgICAgICAgICAgICAgICAgbWF0 Y2hSYW5nZXMucHVzaCh7b2Zmc2V0OiBtYXRjaC5pbmRleCwgbGVuZ3RoOiBtYXRjaFswXS5sZW5n dGh9KTsKICAgICAgICAgICAgICAgICBtYXRjaCA9IHNlYXJjaFJlZ2V4LmV4ZWModGV4dCk7CiAg ICAgICAgICAgICB9CkBAIC05NTIsNiArOTU0LDggQEAgV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRW aWV3ID0gY2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuQ29udGVudFYK IAogICAgICAgICB0aGlzLmRpc3BhdGNoRXZlbnRUb0xpc3RlbmVycyhXZWJJbnNwZWN0b3IuQ29u dGVudFZpZXcuRXZlbnQuTnVtYmVyT2ZTZWFyY2hSZXN1bHRzRGlkQ2hhbmdlKTsKIAorICAgICAg ICB0aGlzLl9maW5kQmFubmVyLm51bWJlck9mUmVzdWx0cyA9IG51bWJlck9mUmVzdWx0czsKKwog ICAgICAgICBpZiAoIXRoaXMuX3NlbGVjdGVkU2VhcmNoTWF0Y2hJc1ZhbGlkICYmIHRoaXMuX3Nl bGVjdGVkU2VhcmNoTWF0Y2gpIHsKICAgICAgICAgICAgIHRoaXMuX3NlbGVjdGVkU2VhcmNoTWF0 Y2guaGlnaGxpZ2h0LmNsYXNzTGlzdC5yZW1vdmUoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3 LlNlbGVjdGVkU3R5bGVDbGFzc05hbWUpOwogICAgICAgICAgICAgdGhpcy5fc2VsZWN0ZWRTZWFy Y2hNYXRjaCA9IG51bGw7Cg==