170555 2017-04-06 10:48:24 -0700 REGRESSION (r209882): Web Inspector: Command-G does not work in the console 2017-04-25 23:39:05 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170556 https://bugs.webkit.org/show_bug.cgi?id=170554 InRadar P2 Normal --- 1 bburg nvasilyev bburg commit-queue inspector-bugzilla-changes nvasilyev webkit-bug-importer oldest_to_newest 1294951 0 bburg 2017-04-06 10:48:24 -0700 ------- Inspected URL: any Loading completed: true Frontend User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_12_5) AppleWebKit/604.1.16+ (KHTML, like Gecko) Uncaught Exceptions: - TypeError: this.delegate.highlightNextSearchMatch is not a function. (In 'this.delegate.highlightNextSearchMatch()', 'this.delegate.highlightNextSearchMatch' is undefined) (at JavaScriptLogViewController.js:260:47) _handleFindNextShortcut @ JavaScriptLogViewController.js:260:47 _handleFindNextShortcut @ [native code] _handleKeyDown @ KeyboardShortcut.js:84:42 ------- * STEPS TO REPRODUCE 1. Go to Console tab 2. Add some results so it's not empty 3. Search for a string with no results using Console find bar 4. Cmd-g => Boom This seems to work as expected if there is a matching search result being highlighted. 1294953 1 webkit-bug-importer 2017-04-06 10:49:17 -0700 <rdar://problem/31481247> 1300746 2 nvasilyev 2017-04-24 17:18:51 -0700 I’m unable to reproduce the bug. Steps I tried: 1. Open https://webkit.org 2. Go to Console tab 3. Type “foo” in the console, press Enter 4. Press Commang-F, type “bar” 5. Press Commang-G Please let me know if I missed something. 1300754 3 nvasilyev 2017-04-24 17:27:01 -0700 I was able to reproduce once. I'm not sure how it happened :) _handleFindNextShortcut() { this.delegate.highlightNextSearchMatch(); } highlightNextSearchMatch is not defined anywhere in Web Inspector front-end. 1300758 4 nvasilyev 2017-04-24 17:38:33 -0700 Steps to reproduce the bug: 1. Go to Console tab 2. Click on the console content view (any message in the console, for example) 3. Press Commang-G this.delegate.highlightNextSearchMatch() was added in 2013 when Web Inspector was open sourced back to WebKit. At some point highlightNextSearchMatch was removed. 1300764 5 nvasilyev 2017-04-24 17:47:23 -0700 By using git log -c -S'highlightNextSearchMatch' -- Source/WebInspectorUI I found out that it was removed in https://bugs.webkit.org/show_bug.cgi?id=164047#c12. 1300769 6 308031 nvasilyev 2017-04-24 18:05:13 -0700 Created attachment 308031 Patch 1301501 7 308031 bburg 2017-04-25 23:08:09 -0700 Comment on attachment 308031 Patch r=me 1301513 8 308031 commit-queue 2017-04-25 23:39:03 -0700 Comment on attachment 308031 Patch Clearing flags on attachment: 308031 Committed r215795: <http://trac.webkit.org/changeset/215795> 1301514 9 commit-queue 2017-04-25 23:39:05 -0700 All reviewed patches have been landed. Closing bug. 308031 2017-04-24 18:05:13 -0700 2017-04-25 23:39:03 -0700 Patch patch.txt text/plain 2246 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGY2ODgzYTAuLjM5M2M3N2EgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA0LTI0ICBOaWtpdGEgVmFzaWx5 ZXYgIDxudmFzaWx5ZXZAYXBwbGUuY29tPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyMDk4ODIp OiBXZWIgSW5zcGVjdG9yOiBDb21tYW5kLUcgZG9lcyBub3Qgd29yayBpbiB0aGUgY29uc29sZQor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTU1Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMTQ4MTI0Nz4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDb21tYW5kLUcgZGlkbid0IHdvcmsgaW4gdGhlIGNv bnNvbGUgd2hlbiB0aGUgY29uc29sZSBjb250ZW50IHZpZXcgd2FzIGluIGZvY3VzLiBJdCBvbmx5 CisgICAgICAgIHdvcmtlZCB3aGVuIHRoZSBzZWFyY2ggaW5wdXQgZmllbGQgd2FzIGZvY3VzZWQu CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzOgorICAg ICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3LnByb3RvdHlwZS5maW5kQmFubmVyUmV2 ZWFsUHJldmlvdXNSZXN1bHQpOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkxvZ0NvbnRlbnRWaWV3 LnByb3RvdHlwZS5oaWdobGlnaHRQcmV2aW91c1NlYXJjaE1hdGNoKTogQWRkZWQuCisgICAgICAg IChXZWJJbnNwZWN0b3IuTG9nQ29udGVudFZpZXcucHJvdG90eXBlLmZpbmRCYW5uZXJSZXZlYWxO ZXh0UmVzdWx0KToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5Mb2dDb250ZW50Vmlldy5wcm90b3R5 cGUuaGlnaGxpZ2h0TmV4dFNlYXJjaE1hdGNoKTogQWRkZWQuCisgICAgICAgIFJlLWludHJvZHVj ZSBoaWdobGlnaHRQcmV2aW91c1NlYXJjaE1hdGNoIGFuZCBoaWdobGlnaHROZXh0U2VhcmNoTWF0 Y2ggbWV0aG9kcyB0aGF0IHdlcmUKKyAgICAgICAgcmVtb3ZlZCBpbiByMjA5ODgyLgorCiAyMDE3 LTA0LTI0ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIg SW5zcGVjdG9yOiBET00vWEhSIGJyZWFrcG9pbnQgc2VjdGlvbnMgc2hvdWxkIGJlIGNvbGxhcHNl ZCBieSBkZWZhdWx0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9Mb2dDb250ZW50Vmlldy5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2Vy SW50ZXJmYWNlL1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCmluZGV4IDkwMWJlYmEuLjgxOTBlYzEg MTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0xv Z0NvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0xvZ0NvbnRlbnRWaWV3LmpzCkBAIC0yMjksNiArMjI5LDExIEBAIFdlYkluc3BlY3Rv ci5Mb2dDb250ZW50VmlldyA9IGNsYXNzIExvZ0NvbnRlbnRWaWV3IGV4dGVuZHMgV2ViSW5zcGVj dG9yLkNvbnRlbnRWCiAKICAgICBmaW5kQmFubmVyUmV2ZWFsUHJldmlvdXNSZXN1bHQoKQogICAg IHsKKyAgICAgICAgdGhpcy5oaWdobGlnaHRQcmV2aW91c1NlYXJjaE1hdGNoKCk7CisgICAgfQor CisgICAgaGlnaGxpZ2h0UHJldmlvdXNTZWFyY2hNYXRjaCgpCisgICAgewogICAgICAgICBpZiAo IXRoaXMuaGFzUGVyZm9ybWVkU2VhcmNoIHx8IGlzRW1wdHlPYmplY3QodGhpcy5fc2VhcmNoTWF0 Y2hlcykpCiAgICAgICAgICAgICByZXR1cm47CiAKQEAgLTIzOCw2ICsyNDMsMTEgQEAgV2ViSW5z cGVjdG9yLkxvZ0NvbnRlbnRWaWV3ID0gY2xhc3MgTG9nQ29udGVudFZpZXcgZXh0ZW5kcyBXZWJJ bnNwZWN0b3IuQ29udGVudFYKIAogICAgIGZpbmRCYW5uZXJSZXZlYWxOZXh0UmVzdWx0KCkKICAg ICB7CisgICAgICAgIHRoaXMuaGlnaGxpZ2h0TmV4dFNlYXJjaE1hdGNoKCk7CisgICAgfQorCisg ICAgaGlnaGxpZ2h0TmV4dFNlYXJjaE1hdGNoKCkKKyAgICB7CiAgICAgICAgIGlmICghdGhpcy5o YXNQZXJmb3JtZWRTZWFyY2ggfHwgaXNFbXB0eU9iamVjdCh0aGlzLl9zZWFyY2hNYXRjaGVzKSkK ICAgICAgICAgICAgIHJldHVybjsKIAo=