170549 2017-04-06 08:43:39 -0700 Cannot Object.seal() or Object.freeze() global "this" 2017-04-06 17:17:48 -0700 1 1 1 Unclassified WebKit JavaScriptCore Other Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 msaboff msaboff buildbot keith_miller mark.lam saam oldest_to_newest 1294893 0 msaboff 2017-04-06 08:43:39 -0700 The ECMAScript standard describes a isExtensible method for Proxy objects that forwards on to the wrapped object. See <https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and-internal-slots-isextensible>. We don’t have that method in JavaScriptCore. <rdar://problem/31478302> 1294894 1 saam 2017-04-06 08:48:53 -0700 (In reply to Michael Saboff from comment #0) > The ECMAScript standard describes a isExtensible method for Proxy objects > that forwards on to the wrapped object. See > <https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and- > internal-slots-isextensible>. We don’t have that method in JavaScriptCore. > > <rdar://problem/31478302> The spec you linked to is for ProxyObject, not JSProxy. Perhaps the JSProxy info is in the HTML spec? 1294900 2 msaboff 2017-04-06 09:12:16 -0700 (In reply to Saam Barati from comment #1) > (In reply to Michael Saboff from comment #0) > > The ECMAScript standard describes a isExtensible method for Proxy objects > > that forwards on to the wrapped object. See > > <https://tc39.github.io/ecma262/#sec-proxy-object-internal-methods-and- > > internal-slots-isextensible>. We don’t have that method in JavaScriptCore. > > > > <rdar://problem/31478302> > > The spec you linked to is for ProxyObject, not JSProxy. Perhaps the JSProxy > info is in the HTML spec? I should have been more specific. This is needed for the global "this" as it is a JSProxy to the global object. JSProxy doesn't implement isExtensible, but ProxyObject does. 1295020 3 msaboff 2017-04-06 13:31:02 -0700 Changing the bug title to the symptom of the problem instead the cause. Doing this since it appears the fix requires changes to other code besides JSProxy. 1295027 4 306423 msaboff 2017-04-06 13:43:01 -0700 Created attachment 306423 Patch 1295029 5 306423 msaboff 2017-04-06 13:56:49 -0700 Comment on attachment 306423 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306423&action=review > Source/JavaScriptCore/interpreter/Interpreter.cpp:1162 > + return checkedReturn(throwTypeError(callFrame, throwScope, ASCIILiteral(ReadonlyPropertyWriteError))); A better error message is NonExtensibleObjectPropertyDefineError. I made that change locally. 1295031 6 306423 mark.lam 2017-04-06 13:57:17 -0700 Comment on attachment 306423 Patch r=me 1295133 7 msaboff 2017-04-06 17:17:48 -0700 Fix landed in change set r215072: <http://trac.webkit.org/changeset/215072> 306423 2017-04-06 13:43:01 -0700 2017-04-06 13:57:17 -0700 Patch 170549.patch text/plain 6423 msaboff SW5kZXg6IEpTVGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hhbmdlTG9n CShyZXZpc2lvbiAyMTUwNTUpCisrKyBKU1Rlc3RzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA QCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTA2ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBw bGUuY29tPgorCisgICAgICAgIENhbm5vdCBPYmplY3Quc2VhbCgpIG9yIE9iamVjdC5mcmVlemUo KSBnbG9iYWwgInRoaXMiCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xNzA1NDkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBFbmFibGVkIGZhaWxpbmcgdGVzdHMgZml4ZWQgYnkgdGhlIGNvcnJlc3BvbmRpbmcg Y29kZSBjaGFuZ2U6CisgICAgICAgICAgICBDaGFrcmFDb3JlL3Rlc3QvTGV0Q29uc3QvZGVsZXRl LmpzCisgICAgICAgICAgICBDaGFrcmFDb3JlL3Rlc3QvTGV0Q29uc3QvZG9wLmpzCisgICAgICAg ICAgICBDaGFrcmFDb3JlL3Rlc3QvTGV0Q29uc3QvZG9wMS5qcworCisgICAgICAgICogQ2hha3Jh Q29yZS55YW1sOgorICAgICAgICAqIENoYWtyYUNvcmUvdGVzdC9MZXRDb25zdC9kb3AuYmFzZWxp bmUtanNjOiBBZGRlZCBKU0Mgc3BlY2lmaWMgZXhwZWN0ZWQgb3V0cHV0LgorICAgICAgICAqIENo YWtyYUNvcmUvdGVzdC9MZXRDb25zdC9kb3AxLmJhc2VsaW5lLWpzYzogQWRkZWQgSlNDIHNwZWNp ZmljIGV4cGVjdGVkIG91dHB1dC4KKwogMjAxNy0wNC0wNSAgSm9zZXBoIFBlY29yYXJvICA8cGVj b3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIHRlc3QyNjI6IEVTMjAxNyB0ZXN0IHByb2dyZXNz aW9ucyBuZWVkIHVwZGF0ZWQgZXhwZWN0YXRpb25zIChhcmd1bWVudHMuY2FsbGVyIHJlbW92ZWQp CkluZGV4OiBKU1Rlc3RzL0NoYWtyYUNvcmUueWFtbAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKU1Rlc3RzL0No YWtyYUNvcmUueWFtbAkocmV2aXNpb24gMjE1MDM3KQorKysgSlNUZXN0cy9DaGFrcmFDb3JlLnlh bWwJKHdvcmtpbmcgY29weSkKQEAgLTgwOSwxNCArODA5LDExIEBACiAtIHBhdGg6IENoYWtyYUNv cmUvdGVzdC9MZXRDb25zdC9kZWZlcjUuanMKICAgY21kOiBydW5DaGFrcmEgOmJhc2VsaW5lLCAi UmVmZXJlbmNlRXJyb3IiLCAiZGVmZXI1LmJhc2VsaW5lLWpzYyIsIFtdCiAtIHBhdGg6IENoYWty YUNvcmUvdGVzdC9MZXRDb25zdC9kZWxldGUuanMKLSAgIyBEaWZmZXJlbmNlcyBpbiBPYmplY3Qu c2VhbCgpLgotICBjbWQ6IHJ1bkNoYWtyYSA6c2tpcCwgIk5vRXhjZXB0aW9uIiwgImRlbGV0ZS5i YXNlbGluZSIsIFtdCisgIGNtZDogcnVuQ2hha3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0aW9uIiwg ImRlbGV0ZS5iYXNlbGluZSIsIFtdCiAtIHBhdGg6IENoYWtyYUNvcmUvdGVzdC9MZXRDb25zdC9k b3AuanMKLSAgIyBEaWZmZXJlbmNlcyBpbiBPYmplY3Quc2VhbCgpLgotICBjbWQ6IHJ1bkNoYWty YSA6c2tpcCwgIk5vRXhjZXB0aW9uIiwgImRvcC5iYXNlbGluZSIsIFtdCisgIGNtZDogcnVuQ2hh a3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0aW9uIiwgImRvcC5iYXNlbGluZS1qc2MiLCBbXQogLSBw YXRoOiBDaGFrcmFDb3JlL3Rlc3QvTGV0Q29uc3QvZG9wMS5qcwotICAjIERpZmZlcmVuY2VzIGlu IE9iamVjdC5zZWFsKCkuCi0gIGNtZDogcnVuQ2hha3JhIDpza2lwLCAiTm9FeGNlcHRpb24iLCAi ZG9wMS5iYXNlbGluZSIsIFtdCisgIGNtZDogcnVuQ2hha3JhIDpiYXNlbGluZSwgIk5vRXhjZXB0 aW9uIiwgImRvcDEuYmFzZWxpbmUtanNjIiwgW10KIC0gcGF0aDogQ2hha3JhQ29yZS90ZXN0L0xl dENvbnN0L2V2YWxfZm5jZGVjbC5qcwogICAjIFNlZW1zIGxpa2UgYSBidWcuICBXZSB0cnkgdG8g ZGVmaW5lIGEgZnVuY3Rpb24gaW4gYSBmYWxzZSAidGhlbiIgYmxvY2suCiAgIGNtZDogcnVuQ2hh a3JhIDpza2lwLCAiTm9FeGNlcHRpb24iLCAiZXZhbF9mbmNkZWNsLmJhc2VsaW5lIiwgW10KSW5k ZXg6IEpTVGVzdHMvQ2hha3JhQ29yZS90ZXN0L0xldENvbnN0L2RvcDEuYmFzZWxpbmUtanNjCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIEpTVGVzdHMvQ2hha3JhQ29yZS90ZXN0L0xldENvbnN0L2RvcDEuYmFzZWxp bmUtanNjCShub25leGlzdGVudCkKKysrIEpTVGVzdHMvQ2hha3JhQ29yZS90ZXN0L0xldENvbnN0 L2RvcDEuYmFzZWxpbmUtanNjCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsNCBAQAorZXhjZXB0 aW9uOiBUeXBlRXJyb3I6IEF0dGVtcHRpbmcgdG8gZGVmaW5lIHByb3BlcnR5IG9uIG9iamVjdCB0 aGF0IGlzIG5vdCBleHRlbnNpYmxlLgorbGV0IHgKK3VuZGVmaW5lZAordHJ1ZQpJbmRleDogSlNU ZXN0cy9DaGFrcmFDb3JlL3Rlc3QvTGV0Q29uc3QvZG9wLmJhc2VsaW5lLWpzYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBKU1Rlc3RzL0NoYWtyYUNvcmUvdGVzdC9MZXRDb25zdC9kb3AuYmFzZWxpbmUtanNjCShu b25leGlzdGVudCkKKysrIEpTVGVzdHMvQ2hha3JhQ29yZS90ZXN0L0xldENvbnN0L2RvcC5iYXNl bGluZS1qc2MJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw0IEBACitleGNlcHRpb246IFR5cGVF cnJvcjogQXR0ZW1wdGluZyB0byBkZWZpbmUgcHJvcGVydHkgb24gb2JqZWN0IHRoYXQgaXMgbm90 IGV4dGVuc2libGUuCitsZXQgeAordW5kZWZpbmVkCit0cnVlCkluZGV4OiBTb3VyY2UvSmF2YVNj cmlwdENvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9D aGFuZ2VMb2cJKHJldmlzaW9uIDIxNTAzNykKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFu Z2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMyBAQAorMjAxNy0wNC0wNiAgTWljaGFl bCBTYWJvZmYgIDxtc2Fib2ZmQGFwcGxlLmNvbT4KKworICAgICAgICBDYW5ub3QgT2JqZWN0LnNl YWwoKSBvciBPYmplY3QuZnJlZXplKCkgZ2xvYmFsICJ0aGlzIgorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTQ5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTmVlZGVkIHRvIGltcGxlbWVudCBKU1Byb3h5 Ojppc0V4dGVuc2libGUoKSB3aGljaCByZXR1cm5zIHRoZSByZXN1bHRzIG9mIGNhbGxpbmcKKyAg ICAgICAgdGhlIHNhbWUgb24gd3JhcHBlZCBvYmplY3QuCisKKyAgICAgICAgSW1wbGVtZW50ZWQg c3RlcCAxMSBvZiBSdW50aW1lIFNlbWFudGljczogRXZhbERlY2xhcmF0aW9uSW5zdGFudGlhdGlv biBmcm9tIHRoZSBFQ01BU2NyaXB0CisgICAgICAgIHNwZWMgdG8gcHJvcGVybHkgcmV0dXJuIGEg VHlwZUVycm9yIG9iamVjdCB3aGVuIGF0dGVtcHRpbmcgdG8gYWRkIHByb3BlcnRpZXMgdG8gYQor ICAgICAgICBub24tZXh0ZW5zaWJsZSBnbG9iYWwgb2JqZWN0LgorCisgICAgICAgICogaW50ZXJw cmV0ZXIvSW50ZXJwcmV0ZXIuY3BwOgorICAgICAgICAoSlNDOjpJbnRlcnByZXRlcjo6ZXhlY3V0 ZSk6CisgICAgICAgICogcnVudGltZS9KU1Byb3h5LmNwcDoKKyAgICAgICAgKEpTQzo6SlNQcm94 eTo6aXNFeHRlbnNpYmxlKToKKyAgICAgICAgKiBydW50aW1lL0pTUHJveHkuaDoKKwogMjAxNy0w NC0wNSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OIGZpeCBiYWQgaXNXYXNtKCkgdGVzdCBieSBlbnN1cmluZyBwcm9wZXIgV2FzbSBjYWxsZWUg Yml0IHBhdHRlcm4KSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9pbnRlcnByZXRlci9JbnRl cnByZXRlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL0phdmFTY3JpcHRDb3JlL2ludGVycHJl dGVyL0ludGVycHJldGVyLmNwcAkocmV2aXNpb24gMjE1MDM3KQorKysgU291cmNlL0phdmFTY3Jp cHRDb3JlL2ludGVycHJldGVyL0ludGVycHJldGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTE1 OCw2ICsxMTU4LDggQEAgSlNWYWx1ZSBJbnRlcnByZXRlcjo6ZXhlY3V0ZShFdmFsRXhlY3V0YQog ICAgICAgICAgICAgUkVUVVJOX0lGX0VYQ0VQVElPTih0aHJvd1Njb3BlLCBjaGVja2VkUmV0dXJu KHRocm93U2NvcGUuZXhjZXB0aW9uKCkpKTsKICAgICAgICAgICAgIGlmICghaGFzUHJvcGVydHkp IHsKICAgICAgICAgICAgICAgICBQdXRQcm9wZXJ0eVNsb3Qgc2xvdCh2YXJpYWJsZU9iamVjdCk7 CisgICAgICAgICAgICAgICAgaWYgKCF2YXJpYWJsZU9iamVjdC0+aXNFeHRlbnNpYmxlKGNhbGxG cmFtZSkpCisgICAgICAgICAgICAgICAgICAgIHJldHVybiBjaGVja2VkUmV0dXJuKHRocm93VHlw ZUVycm9yKGNhbGxGcmFtZSwgdGhyb3dTY29wZSwgQVNDSUlMaXRlcmFsKFJlYWRvbmx5UHJvcGVy dHlXcml0ZUVycm9yKSkpOwogICAgICAgICAgICAgICAgIHZhcmlhYmxlT2JqZWN0LT5tZXRob2RU YWJsZSgpLT5wdXQodmFyaWFibGVPYmplY3QsIGNhbGxGcmFtZSwgaWRlbnQsIGpzVW5kZWZpbmVk KCksIHNsb3QpOwogICAgICAgICAgICAgICAgIFJFVFVSTl9JRl9FWENFUFRJT04odGhyb3dTY29w ZSwgY2hlY2tlZFJldHVybih0aHJvd1Njb3BlLmV4Y2VwdGlvbigpKSk7CiAgICAgICAgICAgICB9 CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3h5LmNwcAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGltZS9KU1Byb3h5LmNwcAkocmV2aXNp b24gMjE1MDM3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvSlNQcm94eS5jcHAJ KHdvcmtpbmcgY29weSkKQEAgLTExNSw2ICsxMTUsMTIgQEAgYm9vbCBKU1Byb3h5OjpkZWxldGVQ cm9wZXJ0eShKU0NlbGwqIGNlbAogICAgIHJldHVybiB0aGlzT2JqZWN0LT50YXJnZXQoKS0+bWV0 aG9kVGFibGUoZXhlYy0+dm0oKSktPmRlbGV0ZVByb3BlcnR5KHRoaXNPYmplY3QtPnRhcmdldCgp LCBleGVjLCBwcm9wZXJ0eU5hbWUpOwogfQogCitib29sIEpTUHJveHk6OmlzRXh0ZW5zaWJsZShK U09iamVjdCogb2JqZWN0LCBFeGVjU3RhdGUqIGV4ZWMpCit7CisgICAgSlNQcm94eSogdGhpc09i amVjdCA9IGpzQ2FzdDxKU1Byb3h5Kj4ob2JqZWN0KTsKKyAgICByZXR1cm4gdGhpc09iamVjdC0+ dGFyZ2V0KCktPm1ldGhvZFRhYmxlKGV4ZWMtPnZtKCkpLT5pc0V4dGVuc2libGUodGhpc09iamVj dC0+dGFyZ2V0KCksIGV4ZWMpOworfQorCiBib29sIEpTUHJveHk6OnByZXZlbnRFeHRlbnNpb25z KEpTT2JqZWN0KiBvYmplY3QsIEV4ZWNTdGF0ZSogZXhlYykKIHsKICAgICBKU1Byb3h5KiB0aGlz T2JqZWN0ID0ganNDYXN0PEpTUHJveHkqPihvYmplY3QpOwpJbmRleDogU291cmNlL0phdmFTY3Jp cHRDb3JlL3J1bnRpbWUvSlNQcm94eS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0 Q29yZS9ydW50aW1lL0pTUHJveHkuaAkocmV2aXNpb24gMjE1MDM3KQorKysgU291cmNlL0phdmFT Y3JpcHRDb3JlL3J1bnRpbWUvSlNQcm94eS5oCSh3b3JraW5nIGNvcHkpCkBAIC05Niw2ICs5Niw3 IEBAIHByb3RlY3RlZDoKICAgICBKU19FWFBPUlRfUFJJVkFURSBzdGF0aWMgYm9vbCBkZWZpbmVP d25Qcm9wZXJ0eShKU09iamVjdCosIEV4ZWNTdGF0ZSosIFByb3BlcnR5TmFtZSwgY29uc3QgUHJv cGVydHlEZXNjcmlwdG9yJiwgYm9vbCBzaG91bGRUaHJvdyk7CiAgICAgSlNfRVhQT1JUX1BSSVZB VEUgc3RhdGljIGJvb2wgc2V0UHJvdG90eXBlKEpTT2JqZWN0KiwgRXhlY1N0YXRlKiwgSlNWYWx1 ZSwgYm9vbCBzaG91bGRUaHJvd0lmQ2FudFNldCk7CiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3Rh dGljIEpTVmFsdWUgZ2V0UHJvdG90eXBlKEpTT2JqZWN0KiwgRXhlY1N0YXRlKik7CisgICAgSlNf RVhQT1JUX1BSSVZBVEUgc3RhdGljIGJvb2wgaXNFeHRlbnNpYmxlKEpTT2JqZWN0KiwgRXhlY1N0 YXRlKik7CiAgICAgSlNfRVhQT1JUX1BSSVZBVEUgc3RhdGljIGJvb2wgcHJldmVudEV4dGVuc2lv bnMoSlNPYmplY3QqLCBFeGVjU3RhdGUqKTsKIAogcHJpdmF0ZToK