170545 2017-04-06 06:41:27 -0700 Add hasVideo property to WebAVPlayerController. 2017-04-07 06:43:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pvollan pvollan bfulgham commit-queue eric.carlson jer.noble jonlee webkit-bug-importer oldest_to_newest 1294860 0 pvollan 2017-04-06 06:41:27 -0700 The existing “hasEnabledVideo” property may briefly toggle to NO at video item boundaries if the audio track is a tiny bit longer than the video track. We would like to add a new "hasVideo" property which does not have this behavior, but can be used to discover if any video content is present in the playback item, whether video content is currently enabled or not. 1294861 1 pvollan 2017-04-06 06:42:29 -0700 rdar://problem/31325182 1294865 2 306379 pvollan 2017-04-06 07:08:55 -0700 Created attachment 306379 Patch 1294884 3 306389 pvollan 2017-04-06 08:13:05 -0700 Created attachment 306389 Patch 1294907 4 306389 eric.carlson 2017-04-06 09:32:26 -0700 Comment on attachment 306389 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306389&action=review > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:541 > + if (hasVideo) > + [playerController() setHasVideo:hasVideo]; Won't this do the wrong thing if a media stream switches from video+audio to audio-only (eg. an HLS stream when available bandwidth is too low)? 1295288 5 306489 pvollan 2017-04-07 05:23:49 -0700 Created attachment 306489 Patch 1295290 6 pvollan 2017-04-07 05:36:43 -0700 (In reply to Eric Carlson from comment #4) > Comment on attachment 306389 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306389&action=review > > > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:541 > > + if (hasVideo) > > + [playerController() setHasVideo:hasVideo]; > > Won't this do the wrong thing if a media stream switches from video+audio to > audio-only (eg. an HLS stream when available bandwidth is too low)? I removed the if statement, which appears to be unnecessary since WebVideoFullscreenInterfaceAVKit::hasVideoChanged is only called when we enter/leave fullscreen/PiP, as far as I can see. This means the value of the "hasVideo" property equals 'true' in this implementation, also when the audio track is a bit longer than the video track. Thanks for reviewing! 1295304 7 306489 commit-queue 2017-04-07 06:43:41 -0700 Comment on attachment 306489 Patch Clearing flags on attachment: 306489 Committed r215092: <http://trac.webkit.org/changeset/215092> 1295305 8 commit-queue 2017-04-07 06:43:43 -0700 All reviewed patches have been landed. Closing bug. 306379 2017-04-06 07:08:55 -0700 2017-04-06 08:13:01 -0700 Patch bug-170545-20170406070854.patch text/plain 3846 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTAzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA0LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgaGFzVmlkZW8gcHJv cGVydHkgdG8gV2ViQVZQbGF5ZXJDb250cm9sbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGV4aXN0aW5nIOKAnGhhc0VuYWJsZWRWaWRlb+KA nSBwcm9wZXJ0eSBtYXkgYnJpZWZseSB0b2dnbGUgdG8gTk8gYXQgdmlkZW8gaXRlbSBib3VuZGFy aWVzIGlmIHRoZSBhdWRpbyB0cmFjaworICAgICAgICBpcyBhIHRpbnkgYml0IGxvbmdlciB0aGFu IHRoZSB2aWRlbyB0cmFjay4gV2Ugd291bGQgbGlrZSB0byBhZGQgYSBuZXcgImhhc1ZpZGVvIiBw cm9wZXJ0eSB3aGljaCBkb2VzIG5vdAorICAgICAgICBoYXZlIHRoaXMgYmVoYXZpb3IsIGJ1dCBj YW4gYmUgdXNlZCB0byBkaXNjb3ZlciBpZiBhbnkgdmlkZW8gY29udGVudCBpcyBwcmVzZW50IGlu IHRoZSBwbGF5YmFjayBpdGVtLAorICAgICAgICB3aGV0aGVyIHZpZGVvIGNvbnRlbnQgaXMgY3Vy cmVudGx5IGVuYWJsZWQgb3Igbm90LgorCisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYkFWUGxh eWVyQ29udHJvbGxlci5oOgorICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJQbGF5YmFja1Nlc3Np b25JbnRlcmZhY2VBVktpdC5tbToKKyAgICAgICAgKFdlYkNvcmU6OldlYlBsYXliYWNrU2Vzc2lv bkludGVyZmFjZUFWS2l0OjpyZXNldE1lZGlhU3RhdGUpOgorICAgICAgICAqIHBsYXRmb3JtL2lv cy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbToKKyAgICAgICAgKFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpoYXNWaWRlb0NoYW5nZWQpOgorICAgICAgICAoV2Vi VmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnZpZGVvRGltZW5zaW9uc0NoYW5nZWQpOgor CiAyMDE3LTA0LTA1ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAg ICAgICAgIFNldCBsYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wIG9uIGFsbCBhbmNlc3Rv ciBkb2N1bWVudHMsIG5vdCBqdXN0IHRoZSB0b3AgZG9jdW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJD b3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIuaAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQVZQbGF5ZXJDb250cm9sbGVyLmgJKHJldmlz aW9uIDIxNDk5MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNv bnRyb2xsZXIuaAkod29ya2luZyBjb3B5KQpAQCAtNjEsNiArNjEsNyBAQCBjbGFzcyBXZWJQbGF5 YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdDsKIEBwcm9wZXJ0eSBDR1NpemUgY29udGVudERpbWVu c2lvbnM7CiBAcHJvcGVydHkgQk9PTCBoYXNFbmFibGVkQXVkaW87CiBAcHJvcGVydHkgQk9PTCBo YXNFbmFibGVkVmlkZW87CitAcHJvcGVydHkgQk9PTCBoYXNWaWRlbzsKIEBwcm9wZXJ0eSBOU1Rp bWVJbnRlcnZhbCBtaW5UaW1lOwogQHByb3BlcnR5IE5TVGltZUludGVydmFsIG1heFRpbWU7CiBA cHJvcGVydHkgTlNUaW1lSW50ZXJ2YWwgY29udGVudER1cmF0aW9uV2l0aGluRW5kVGltZXM7Cklu ZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViUGxheWJhY2tTZXNzaW9uSW50ZXJm YWNlQVZLaXQubW0KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dl YlBsYXliYWNrU2Vzc2lvbkludGVyZmFjZUFWS2l0Lm1tCShyZXZpc2lvbiAyMTQ5OTEpCisrKyBT b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZL aXQubW0JKHdvcmtpbmcgY29weSkKQEAgLTg4LDYgKzg4LDcgQEAgdm9pZCBXZWJQbGF5YmFja1Nl c3Npb25JbnRlcmZhY2VBVktpdDo6cgogICAgIHBsYXllckNvbnRyb2xsZXIuY2FuUGF1c2UgPSBO TzsKICAgICBwbGF5ZXJDb250cm9sbGVyLmNhblRvZ2dsZVBsYXliYWNrID0gTk87CiAgICAgcGxh eWVyQ29udHJvbGxlci5oYXNFbmFibGVkQXVkaW8gPSBOTzsKKyAgICBwbGF5ZXJDb250cm9sbGVy Lmhhc1ZpZGVvID0gTk87CiAgICAgcGxheWVyQ29udHJvbGxlci5jYW5TZWVrID0gTk87CiAgICAg cGxheWVyQ29udHJvbGxlci5taW5UaW1lID0gMDsKICAgICBwbGF5ZXJDb250cm9sbGVyLnN0YXR1 cyA9IEFWUGxheWVyQ29udHJvbGxlclN0YXR1c1Vua25vd247CkluZGV4OiBTb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0KPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbklu dGVyZmFjZUFWS2l0Lm1tCShyZXZpc2lvbiAyMTQ5OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW0JKHdvcmtpbmcgY29w eSkKQEAgLTUzNiw2ICs1MzYsOSBAQCB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFW S2l0OjpzCiB2b2lkIFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpoYXNWaWRlb0No YW5nZWQoYm9vbCBoYXNWaWRlbykKIHsKICAgICBbcGxheWVyQ29udHJvbGxlcigpIHNldEhhc0Vu YWJsZWRWaWRlbzpoYXNWaWRlb107CisgICAgCisgICAgaWYgKGhhc1ZpZGVvKQorICAgICAgICBb cGxheWVyQ29udHJvbGxlcigpIHNldEhhc1ZpZGVvOnRydWVdOwogfQogCiB2b2lkIFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojp2aWRlb0RpbWVuc2lvbnNDaGFuZ2VkKGNvbnN0IEZs b2F0U2l6ZSYgdmlkZW9EaW1lbnNpb25zKQpAQCAtNTQ5LDcgKzU1Miw3IEBAIHZvaWQgV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnYKICAgICBXZWJBVlBpY3R1cmVJblBpY3R1cmVQ bGF5ZXJMYXllclZpZXcgKnBpcFZpZXcgPSAoV2ViQVZQaWN0dXJlSW5QaWN0dXJlUGxheWVyTGF5 ZXJWaWV3ICopW21fcGxheWVyTGF5ZXJWaWV3IHBpY3R1cmVJblBpY3R1cmVQbGF5ZXJMYXllclZp ZXddOwogICAgIFdlYkFWUGxheWVyTGF5ZXIgKnBpcFBsYXllckxheWVyID0gKFdlYkFWUGxheWVy TGF5ZXIgKilbcGlwVmlldyBsYXllcl07CiAgICAgW3BpcFBsYXllckxheWVyIHNldFZpZGVvRGlt ZW5zaW9uczpwbGF5ZXJMYXllci52aWRlb0RpbWVuc2lvbnNdOwotICAgIFtwaXBWaWV3IHNldE5l ZWRzTGF5b3V0XTsgICAgCisgICAgW3BpcFZpZXcgc2V0TmVlZHNMYXlvdXRdOwogfQogCiB2b2lk IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpleHRlcm5hbFBsYXliYWNrQ2hhbmdl ZChib29sIGVuYWJsZWQsIFdlYlBsYXliYWNrU2Vzc2lvbk1vZGVsOjpFeHRlcm5hbFBsYXliYWNr VGFyZ2V0VHlwZSwgY29uc3QgU3RyaW5nJikK 306389 2017-04-06 08:13:05 -0700 2017-04-07 05:23:45 -0700 Patch bug-170545-20170406081304.patch text/plain 3846 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTAzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIyIEBACisyMDE3LTA0LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgaGFzVmlkZW8gcHJv cGVydHkgdG8gV2ViQVZQbGF5ZXJDb250cm9sbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTQ1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIGV4aXN0aW5nICJoYXNFbmFibGVkVmlkZW8iIHBy b3BlcnR5IG1heSBicmllZmx5IHRvZ2dsZSB0byBOTyBhdCB2aWRlbyBpdGVtIGJvdW5kYXJpZXMg aWYgdGhlIGF1ZGlvIHRyYWNrCisgICAgICAgIGlzIGEgdGlueSBiaXQgbG9uZ2VyIHRoYW4gdGhl IHZpZGVvIHRyYWNrLiBXZSB3b3VsZCBsaWtlIHRvIGFkZCBhIG5ldyAiaGFzVmlkZW8iIHByb3Bl cnR5IHdoaWNoIGRvZXMgbm90CisgICAgICAgIGhhdmUgdGhpcyBiZWhhdmlvciwgYnV0IGNhbiBi ZSB1c2VkIHRvIGRpc2NvdmVyIGlmIGFueSB2aWRlbyBjb250ZW50IGlzIHByZXNlbnQgaW4gdGhl IHBsYXliYWNrIGl0ZW0sCisgICAgICAgIHdoZXRoZXIgdmlkZW8gY29udGVudCBpcyBjdXJyZW50 bHkgZW5hYmxlZCBvciBub3QuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViQVZQbGF5ZXJD b250cm9sbGVyLmg6CisgICAgICAgICogcGxhdGZvcm0vaW9zL1dlYlBsYXliYWNrU2Vzc2lvbklu dGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoV2ViQ29yZTo6V2ViUGxheWJhY2tTZXNzaW9uSW50 ZXJmYWNlQVZLaXQ6OnJlc2V0TWVkaWFTdGF0ZSk6CisgICAgICAgICogcGxhdGZvcm0vaW9zL1dl YlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Lm1tOgorICAgICAgICAoV2ViVmlkZW9GdWxs c2NyZWVuSW50ZXJmYWNlQVZLaXQ6Omhhc1ZpZGVvQ2hhbmdlZCk6CisgICAgICAgIChXZWJWaWRl b0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6dmlkZW9EaW1lbnNpb25zQ2hhbmdlZCk6CisKIDIw MTctMDQtMDUgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAg ICAgU2V0IGxhc3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAgb24gYWxsIGFuY2VzdG9yIGRv Y3VtZW50cywgbm90IGp1c3QgdGhlIHRvcCBkb2N1bWVudApJbmRleDogU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5oCj09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIuaAkocmV2aXNpb24g MjE0OTkxKQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJv bGxlci5oCSh3b3JraW5nIGNvcHkpCkBAIC02MSw2ICs2MSw3IEBAIGNsYXNzIFdlYlBsYXliYWNr U2Vzc2lvbkludGVyZmFjZUFWS2l0OwogQHByb3BlcnR5IENHU2l6ZSBjb250ZW50RGltZW5zaW9u czsKIEBwcm9wZXJ0eSBCT09MIGhhc0VuYWJsZWRBdWRpbzsKIEBwcm9wZXJ0eSBCT09MIGhhc0Vu YWJsZWRWaWRlbzsKK0Bwcm9wZXJ0eSBCT09MIGhhc1ZpZGVvOwogQHByb3BlcnR5IE5TVGltZUlu dGVydmFsIG1pblRpbWU7CiBAcHJvcGVydHkgTlNUaW1lSW50ZXJ2YWwgbWF4VGltZTsKIEBwcm9w ZXJ0eSBOU1RpbWVJbnRlcnZhbCBjb250ZW50RHVyYXRpb25XaXRoaW5FbmRUaW1lczsKSW5kZXg6 IFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VB VktpdC5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViUGxh eWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQubW0JKHJldmlzaW9uIDIxNDk5MSkKKysrIFNvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9XZWJQbGF5YmFja1Nlc3Npb25JbnRlcmZhY2VBVktpdC5t bQkod29ya2luZyBjb3B5KQpAQCAtODgsNiArODgsNyBAQCB2b2lkIFdlYlBsYXliYWNrU2Vzc2lv bkludGVyZmFjZUFWS2l0OjpyCiAgICAgcGxheWVyQ29udHJvbGxlci5jYW5QYXVzZSA9IE5POwog ICAgIHBsYXllckNvbnRyb2xsZXIuY2FuVG9nZ2xlUGxheWJhY2sgPSBOTzsKICAgICBwbGF5ZXJD b250cm9sbGVyLmhhc0VuYWJsZWRBdWRpbyA9IE5POworICAgIHBsYXllckNvbnRyb2xsZXIuaGFz VmlkZW8gPSBOTzsKICAgICBwbGF5ZXJDb250cm9sbGVyLmNhblNlZWsgPSBOTzsKICAgICBwbGF5 ZXJDb250cm9sbGVyLm1pblRpbWUgPSAwOwogICAgIHBsYXllckNvbnRyb2xsZXIuc3RhdHVzID0g QVZQbGF5ZXJDb250cm9sbGVyU3RhdHVzVW5rbm93bjsKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJm YWNlQVZLaXQubW0JKHJldmlzaW9uIDIxNDk5MSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQkod29ya2luZyBjb3B5KQpA QCAtNTM2LDYgKzUzNiw5IEBAIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6 OnMKIHZvaWQgV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6Omhhc1ZpZGVvQ2hhbmdl ZChib29sIGhhc1ZpZGVvKQogewogICAgIFtwbGF5ZXJDb250cm9sbGVyKCkgc2V0SGFzRW5hYmxl ZFZpZGVvOmhhc1ZpZGVvXTsKKyAgICAKKyAgICBpZiAoaGFzVmlkZW8pCisgICAgICAgIFtwbGF5 ZXJDb250cm9sbGVyKCkgc2V0SGFzVmlkZW86aGFzVmlkZW9dOwogfQogCiB2b2lkIFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojp2aWRlb0RpbWVuc2lvbnNDaGFuZ2VkKGNvbnN0IEZs b2F0U2l6ZSYgdmlkZW9EaW1lbnNpb25zKQpAQCAtNTQ5LDcgKzU1Miw3IEBAIHZvaWQgV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnYKICAgICBXZWJBVlBpY3R1cmVJblBpY3R1cmVQ bGF5ZXJMYXllclZpZXcgKnBpcFZpZXcgPSAoV2ViQVZQaWN0dXJlSW5QaWN0dXJlUGxheWVyTGF5 ZXJWaWV3ICopW21fcGxheWVyTGF5ZXJWaWV3IHBpY3R1cmVJblBpY3R1cmVQbGF5ZXJMYXllclZp ZXddOwogICAgIFdlYkFWUGxheWVyTGF5ZXIgKnBpcFBsYXllckxheWVyID0gKFdlYkFWUGxheWVy TGF5ZXIgKilbcGlwVmlldyBsYXllcl07CiAgICAgW3BpcFBsYXllckxheWVyIHNldFZpZGVvRGlt ZW5zaW9uczpwbGF5ZXJMYXllci52aWRlb0RpbWVuc2lvbnNdOwotICAgIFtwaXBWaWV3IHNldE5l ZWRzTGF5b3V0XTsgICAgCisgICAgW3BpcFZpZXcgc2V0TmVlZHNMYXlvdXRdOwogfQogCiB2b2lk IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpleHRlcm5hbFBsYXliYWNrQ2hhbmdl ZChib29sIGVuYWJsZWQsIFdlYlBsYXliYWNrU2Vzc2lvbk1vZGVsOjpFeHRlcm5hbFBsYXliYWNr VGFyZ2V0VHlwZSwgY29uc3QgU3RyaW5nJikK 306489 2017-04-07 05:23:49 -0700 2017-04-07 06:43:41 -0700 Patch bug-170545-20170407052348.patch text/plain 2763 pvollan SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNTAzNSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTA2ICBQZXIgQXJu ZSBWb2xsYW4gIDxwdm9sbGFuQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgaGFzVmlkZW8gcHJv cGVydHkgdG8gV2ViQVZQbGF5ZXJDb250cm9sbGVyLgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTQ1CisgICAgICAgIHJkYXI6Ly9wcm9ibGVtLzMx MzI1MTgyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg QWRkIGEgbmV3ICJoYXNWaWRlbyIgcHJvcGVydHkgd2hpY2ggY2FuIGJlIHVzZWQgdG8gZGlzY292 ZXIgaWYgYW55IHZpZGVvIGNvbnRlbnQgaXMgcHJlc2VudCBpbiB0aGUgcGxheWJhY2sgaXRlbSwK KyAgICAgICAgd2hldGhlciB2aWRlbyBjb250ZW50IGlzIGN1cnJlbnRseSBlbmFibGVkIG9yIG5v dC4KKworICAgICAgICAqIHBsYXRmb3JtL2lvcy9XZWJBVlBsYXllckNvbnRyb2xsZXIuaDoKKyAg ICAgICAgKiBwbGF0Zm9ybS9pb3MvV2ViVmlkZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQubW06 CisgICAgICAgIChXZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6aGFzVmlkZW9DaGFu Z2VkKToKKwogMjAxNy0wNC0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNv bT4KIAogICAgICAgICBTZXQgbGFzdEhhbmRsZWRVc2VyR2VzdHVyZVRpbWVzdGFtcCBvbiBhbGwg YW5jZXN0b3IgZG9jdW1lbnRzLCBub3QganVzdCB0aGUgdG9wIGRvY3VtZW50CkluZGV4OiBTb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQVZQbGF5ZXJDb250cm9sbGVyLmgKPT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PQotLS0gU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYkFWUGxheWVyQ29udHJvbGxlci5o CShyZXZpc2lvbiAyMTQ5OTEpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvV2ViQVZQ bGF5ZXJDb250cm9sbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTYxLDYgKzYxLDcgQEAgY2xhc3Mg V2ViUGxheWJhY2tTZXNzaW9uSW50ZXJmYWNlQVZLaXQ7CiBAcHJvcGVydHkgQ0dTaXplIGNvbnRl bnREaW1lbnNpb25zOwogQHByb3BlcnR5IEJPT0wgaGFzRW5hYmxlZEF1ZGlvOwogQHByb3BlcnR5 IEJPT0wgaGFzRW5hYmxlZFZpZGVvOworQHByb3BlcnR5IEJPT0wgaGFzVmlkZW87CiBAcHJvcGVy dHkgTlNUaW1lSW50ZXJ2YWwgbWluVGltZTsKIEBwcm9wZXJ0eSBOU1RpbWVJbnRlcnZhbCBtYXhU aW1lOwogQHByb3BlcnR5IE5TVGltZUludGVydmFsIGNvbnRlbnREdXJhdGlvbldpdGhpbkVuZFRp bWVzOwpJbmRleDogU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVl bkludGVyZmFjZUFWS2l0Lm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2lvcy9XZWJWaWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdC5tbQkocmV2aXNpb24gMjE0OTkx KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1dlYlZpZGVvRnVsbHNjcmVlbkludGVy ZmFjZUFWS2l0Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC01MzYsNiArNTM2LDcgQEAgdm9pZCBXZWJW aWRlb0Z1bGxzY3JlZW5JbnRlcmZhY2VBVktpdDo6cwogdm9pZCBXZWJWaWRlb0Z1bGxzY3JlZW5J bnRlcmZhY2VBVktpdDo6aGFzVmlkZW9DaGFuZ2VkKGJvb2wgaGFzVmlkZW8pCiB7CiAgICAgW3Bs YXllckNvbnRyb2xsZXIoKSBzZXRIYXNFbmFibGVkVmlkZW86aGFzVmlkZW9dOworICAgIFtwbGF5 ZXJDb250cm9sbGVyKCkgc2V0SGFzVmlkZW86aGFzVmlkZW9dOwogfQogCiB2b2lkIFdlYlZpZGVv RnVsbHNjcmVlbkludGVyZmFjZUFWS2l0Ojp2aWRlb0RpbWVuc2lvbnNDaGFuZ2VkKGNvbnN0IEZs b2F0U2l6ZSYgdmlkZW9EaW1lbnNpb25zKQpAQCAtNTQ5LDcgKzU1MCw3IEBAIHZvaWQgV2ViVmlk ZW9GdWxsc2NyZWVuSW50ZXJmYWNlQVZLaXQ6OnYKICAgICBXZWJBVlBpY3R1cmVJblBpY3R1cmVQ bGF5ZXJMYXllclZpZXcgKnBpcFZpZXcgPSAoV2ViQVZQaWN0dXJlSW5QaWN0dXJlUGxheWVyTGF5 ZXJWaWV3ICopW21fcGxheWVyTGF5ZXJWaWV3IHBpY3R1cmVJblBpY3R1cmVQbGF5ZXJMYXllclZp ZXddOwogICAgIFdlYkFWUGxheWVyTGF5ZXIgKnBpcFBsYXllckxheWVyID0gKFdlYkFWUGxheWVy TGF5ZXIgKilbcGlwVmlldyBsYXllcl07CiAgICAgW3BpcFBsYXllckxheWVyIHNldFZpZGVvRGlt ZW5zaW9uczpwbGF5ZXJMYXllci52aWRlb0RpbWVuc2lvbnNdOwotICAgIFtwaXBWaWV3IHNldE5l ZWRzTGF5b3V0XTsgICAgCisgICAgW3BpcFZpZXcgc2V0TmVlZHNMYXlvdXRdOwogfQogCiB2b2lk IFdlYlZpZGVvRnVsbHNjcmVlbkludGVyZmFjZUFWS2l0OjpleHRlcm5hbFBsYXliYWNrQ2hhbmdl ZChib29sIGVuYWJsZWQsIFdlYlBsYXliYWNrU2Vzc2lvbk1vZGVsOjpFeHRlcm5hbFBsYXliYWNr VGFyZ2V0VHlwZSwgY29uc3QgU3RyaW5nJikK