170539 2017-04-06 00:21:45 -0700 [GTK] Fix build with MEDIA_CAPTURE enabled 2017-04-06 02:58:23 -0700 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez bugs-noreply cgarcia clopez commit-queue darin mcatanzaro rniwa sam xan.lopez oldest_to_newest 1294819 0 aperez 2017-04-06 00:21:45 -0700 Enabling MEDIA_CAPTURE (for exaple with “build-webkit --media-capture”) causes compilation to fail with the following error. .../Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp: In function ‘gboolean webkit_dom_html_input_element_get_capture(WebKitDOMHTMLInputElement*)’: .../Source/WebKit2/WebProcess/InjectedBundle/API/gtk/DOM/WebKitDOMDeprecated.cpp:168:40: error: ‘MediaCaptureTypeNone’ was not declared in this scope return item->mediaCaptureType() != MediaCaptureTypeNone; ^~~~~~~~~~~~~~~~~~~~ The definition is still around, but this code should be using “WebCore::MediaCaptureTypeNone”. I'll be posting a patch soon. 1294830 1 306370 aperez 2017-04-06 02:08:21 -0700 Created attachment 306370 Patch 1294840 2 cgarcia 2017-04-06 02:57:16 -0700 *** Bug 170542 has been marked as a duplicate of this bug. *** 1294841 3 306370 commit-queue 2017-04-06 02:58:21 -0700 Comment on attachment 306370 Patch Clearing flags on attachment: 306370 Committed r215009: <http://trac.webkit.org/changeset/215009> 1294842 4 commit-queue 2017-04-06 02:58:23 -0700 All reviewed patches have been landed. Closing bug. 306370 2017-04-06 02:08:21 -0700 2017-04-06 02:58:21 -0700 Patch bug-170539-20170406120820.patch text/plain 1668 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0OTkwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTc0ZjJiMWFmNjdiYjky NjkwN2E3MjNjY2Q3OGI4NmI0NjMzMjhkOS4uOTk2OGY4ZTRjOTg4N2FhMTY3MjA5NGFjYjljOTc0 OTNmMDAxMzIwNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE3LTA0LTA2ICBBZHJp YW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS10g Rml4IGJ1aWxkIHdpdGggTUVESUFfQ0FQVFVSRSBlbmFibGVkCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA1MzkKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFdlYlByb2Nlc3MvSW5qZWN0ZWRCdW5kbGUv QVBJL2d0ay9ET00vV2ViS2l0RE9NRGVwcmVjYXRlZC5jcHA6CisgICAgICAgICh3ZWJraXRfZG9t X2h0bWxfaW5wdXRfZWxlbWVudF9nZXRfY2FwdHVyZSk6IEFkZCBtaXNzaW5nIG5hbWVzcGFjZSBp biB1c2FnZSBvZiBXZWJDb3JlOjpNZWRpYUNhcHR1cmVUeXBlTm9uZS4KKwogMjAxNy0wNC0wNSAg QnJlbnQgRnVsZ2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV0syXVtpT1Nd IFJlbW92ZSBhY2Nlc3MgdG8gZmVhdHVyZXMgbm90IHByZXNlbnQgb24gaU9TIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vzcy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9X ZWJLaXRET01EZXByZWNhdGVkLmNwcCBiL1NvdXJjZS9XZWJLaXQyL1dlYlByb2Nlc3MvSW5qZWN0 ZWRCdW5kbGUvQVBJL2d0ay9ET00vV2ViS2l0RE9NRGVwcmVjYXRlZC5jcHAKaW5kZXggZmMxNWQ4 M2RjN2JlNWVmOTU2OWU2YzI0MDRmNTdmYzMwNTIwNmQ1Mi4uM2M4ZjYxNTBiM2U5ZjIwOTYxYzhl MWIyYjcxOTM5NzBiYTAwNmZkYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvV2ViUHJvY2Vz cy9JbmplY3RlZEJ1bmRsZS9BUEkvZ3RrL0RPTS9XZWJLaXRET01EZXByZWNhdGVkLmNwcAorKysg Yi9Tb3VyY2UvV2ViS2l0Mi9XZWJQcm9jZXNzL0luamVjdGVkQnVuZGxlL0FQSS9ndGsvRE9NL1dl YktpdERPTURlcHJlY2F0ZWQuY3BwCkBAIC0xNjUsNyArMTY1LDcgQEAgZ2Jvb2xlYW4gd2Via2l0 X2RvbV9odG1sX2lucHV0X2VsZW1lbnRfZ2V0X2NhcHR1cmUoV2ViS2l0RE9NSFRNTElucHV0RWxl bWVudCogc2UKICNpZiBFTkFCTEUoTUVESUFfQ0FQVFVSRSkKICAgICBXZWJDb3JlOjpKU01haW5U aHJlYWROdWxsU3RhdGUgc3RhdGU7CiAgICAgV2ViQ29yZTo6SFRNTElucHV0RWxlbWVudCogaXRl bSA9IFdlYktpdDo6Y29yZShzZWxmKTsKLSAgICByZXR1cm4gaXRlbS0+bWVkaWFDYXB0dXJlVHlw ZSgpICE9IE1lZGlhQ2FwdHVyZVR5cGVOb25lOworICAgIHJldHVybiBpdGVtLT5tZWRpYUNhcHR1 cmVUeXBlKCkgIT0gV2ViQ29yZTo6TWVkaWFDYXB0dXJlVHlwZU5vbmU7CiAjZWxzZQogICAgIFVO VVNFRF9QQVJBTShzZWxmKTsKICAgICBXRUJLSVRfV0FSTl9GRUFUVVJFX05PVF9QUkVTRU5UKCJN ZWRpYSBDYXB0dXJlIikK