170527 2017-04-05 16:34:02 -0700 Remove run-jsc-stress-tests benign warning about otool '-S' switch 2017-04-05 17:13:56 -0700 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck aakash_jain commit-queue joepeck oldest_to_newest 1294705 0 joepeck 2017-04-05 16:34:02 -0700 Summary: Remove run-jsc-stress-tests benign warning about otool '-S' switch. The switch appears to not be necessary, since jscPath is a binary not a library: -S print the table of contents of a library Steps to reproduce: 1. $ run-jsc-stress-tests --release JSCTests/wasm.yaml => Output includes an error: Using the following jsc path: /Users/pecoraro/Build/Release/jsc error: /Users/pecoraro/Desktop/Xcode8.0.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/otool: for -S functionality, use llvm-nm with -print-armap Notes: - Dropping -S I see the same output but get a successful exit code. run-jsc-stress-tests still works. 1294708 1 306335 joepeck 2017-04-05 16:35:04 -0700 Created attachment 306335 [PATCH] Proposed Fix 1294712 2 306335 aakash_jain 2017-04-05 16:37:07 -0700 Comment on attachment 306335 [PATCH] Proposed Fix looks good to me. 1294723 3 306335 commit-queue 2017-04-05 17:13:55 -0700 Comment on attachment 306335 [PATCH] Proposed Fix Clearing flags on attachment: 306335 Committed r214981: <http://trac.webkit.org/changeset/214981> 1294724 4 commit-queue 2017-04-05 17:13:56 -0700 All reviewed patches have been landed. Closing bug. 306335 2017-04-05 16:35:04 -0700 2017-04-05 17:13:55 -0700 [PATCH] Proposed Fix switch-1.patch text/plain 1325 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCAzNDhk MjdlODI2Ny4uN2MxMzg5ODNiNWYgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNC0wNSAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFJlbW92ZSBydW4tanNjLXN0cmVz cy10ZXN0cyBiZW5pZ24gd2FybmluZyBhYm91dCBvdG9vbCAnLVMnIHN3aXRjaAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNTI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qc2Mt c3RyZXNzLXRlc3RzOgorICAgICAgICBUaGUgc3dpdGNoIGlzIG5vdCBuZWNlc3NhcnkgYW5kIHBy b2R1Y2VzIGFuIGVycm9yLgorCiAyMDE3LTA0LTA0ICBUaW0gSG9ydG9uICA8dGltb3RoeV9ob3J0 b25AYXBwbGUuY29tPgogCiAgICAgICAgIFtNYWNdIC1bV0tXZWJWaWV3IGZpbmRNYXRjaGVzRm9y U3RyaW5nOnJlbGF0aXZlVG9NYXRjaDpmaW5kT3B0aW9uczptYXhSZXN1bHRzOnJlc3VsdENvbGxl Y3RvcjpdIGludm9rZXMgdGhlIHJlc3VsdENvbGxlY3RvciB3aXRoIGRpZFdyYXAgPSBOTyBldmVu IHdoZW4gaXQgd3JhcHMKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvcnVuLWpzYy1zdHJlc3Mt dGVzdHMgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCmluZGV4IDBkODg5MGFi OWJjLi5jNjU5ZGM1MTI1YiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjLXN0cmVz cy10ZXN0cworKysgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2Mtc3RyZXNzLXRlc3RzCkBAIC0yOTQs NyArMjk0LDcgQEAgZW5kCiAjIFRyeSB0byBkZXRlcm1pbmUgYXJjaGl0ZWN0dXJlLiBSZXR1cm4g bmlsIG9uIGZhaWx1cmUuCiBkZWYgbWFjaE9BcmNoaXRlY3R1cmVDb2RlCiAgICAgYmVnaW4gCi0g ICAgICAgIG90b29sTGluZXMgPSBgb3Rvb2wgLWFTZmggI3tTaGVsbHdvcmRzLnNoZWxsZXNjYXBl KCRqc2NQYXRoLnRvX3MpfWAuc3BsaXQoIlxuIikKKyAgICAgICAgb3Rvb2xMaW5lcyA9IGBvdG9v bCAtYWZoICN7U2hlbGx3b3Jkcy5zaGVsbGVzY2FwZSgkanNjUGF0aC50b19zKX1gLnNwbGl0KCJc biIpCiAgICAgICAgIG90b29sTGluZXMuZWFjaF93aXRoX2luZGV4IHsKICAgICAgICAgICAgIHwg dmFsdWUsIGluZGV4IHwKICAgICAgICAgICAgIGlmIHZhbHVlID1+IC9tYWdpYy8gYW5kIHZhbHVl ID1+IC9jcHV0eXBlLwo=