170503 2017-04-05 06:16:38 -0700 Add debug option to run-jsc script 2017-04-07 11:45:55 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller commit-queue saam ysuzuki oldest_to_newest 1294474 0 keith_miller 2017-04-05 06:16:38 -0700 Add debug option to run-jsc script 1294480 1 306280 keith_miller 2017-04-05 06:46:44 -0700 Created attachment 306280 Patch 1294481 2 306280 ysuzuki 2017-04-05 06:48:38 -0700 Comment on attachment 306280 Patch r=me 1294488 3 306280 commit-queue 2017-04-05 07:29:01 -0700 Comment on attachment 306280 Patch Clearing flags on attachment: 306280 Committed r214945: <http://trac.webkit.org/changeset/214945> 1294489 4 commit-queue 2017-04-05 07:29:02 -0700 All reviewed patches have been landed. Closing bug. 1295413 5 saam 2017-04-07 11:44:37 -0700 This broke run-jsc --debug. It now launches a release build under lldb. It seems wrong to change the meaning of --debug. Why not just add a new option to launch under lldb? 1295414 6 ysuzuki 2017-04-07 11:45:55 -0700 (In reply to Saam Barati from comment #5) > This broke run-jsc --debug. It now launches a release build under lldb. It > seems wrong to change the meaning of --debug. Why not just add a new option > to launch under lldb? https://bugs.webkit.org/show_bug.cgi?id=170587 this will fix the issue. 306280 2017-04-05 06:46:44 -0700 2017-04-05 07:29:01 -0700 Patch bug-170503-20170405064644.patch text/plain 2117 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODMwCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggY2ZhNzRiNWRhNzlkMWQwNTU4YmE0OGQ4NGZmZmNkZTE0 ZmUwYzE2OS4uNTEzN2NhODQyM2FhYzI5ZWU2NzUxM2ExOGFmZGViZGQ5YWJjNDQxZCAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE3LTA0LTA1ICBLZWl0aCBNaWxsZXIgIDxrZWl0aF9taWxsZXJAYXBwbGUuY29tPgor CisgICAgICAgIEFkZCBkZWJ1ZyBvcHRpb24gdG8gcnVuLWpzYyBzY3JpcHQKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDUwMworCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZHMgYSBuZXcgb3B0aW9uIHRv IHRoZSBydW4tanNjIHNjcmlwdCBzbyB0aGF0IHdoZW4gcGFzc2VkCisgICAgICAgICItLWRlYnVn IiBpdCB3aWxsIHdyYXAgdGhlIGpzYyBjYWxsIHdpdGggYW4gbGxkYiBpbnZvY2F0aW9uLiBJZgor ICAgICAgICBzb21lb25lIHdpc2hlcyB0byB1c2UgYSBkaWZmZXJlbnQgZGVidWdnZXIgdGhleSBj YW4gc2V0IHRoZQorICAgICAgICBERUJVR0dFUiBlbnZpcm9ubWVudCB2YXJpYWJsZS4gQWRkaXRp b25hbGx5LCBydW4tanNjIG5vdyBleGl0cworICAgICAgICB3aXRoIHRoZSBleGl0IHN0YXR1cyBv ZiB0aGUganNjIGNhbGwuCisKKyAgICAgICAgKiBTY3JpcHRzL3J1bi1qc2M6CisKIDIwMTctMDQt MDMgIEtlaXRoIE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgV2Vi QXNzZW1ibHk6IFVwZGF0ZSBzcGVjIHRlc3RzCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3J1 bi1qc2MgYi9Ub29scy9TY3JpcHRzL3J1bi1qc2MKaW5kZXggODQ0MWEyOTZiMWY0OWRmMDI4ZWYy OGZiOWVkYWQ5Njg1OWQ3NGZjNS4uMzk2NDM2YWNjNDU1ZWMwYjAzYTk3OWEyN2EwNDI5MDA5MzJj NTRlOSAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9ydW4tanNjCisrKyBiL1Rvb2xzL1Njcmlw dHMvcnVuLWpzYwpAQCAtMzcsMjIgKzM3LDMwIEBAIHVzZSBHZXRvcHQ6Okxvbmc7CiB1c2Ugd2Vi a2l0ZGlyczsKIEdldG9wdDo6TG9uZzo6Q29uZmlndXJlKCJwYXNzX3Rocm91Z2giKTsKIAotbXkg JHVzYWdlID0gIlVzYWdlOiBydW4tanNjIFstLWNvdW50IHJ1bl9jb3VudF0gc2hlbGxfZmlsZSBb ZmlsZTIuLi5dIjsKK215ICR1c2FnZSA9ICJVc2FnZTogcnVuLWpzYyBbLS1jb3VudCBydW5fY291 bnRdIFstLWRlYnVnXSBzaGVsbF9maWxlIFtmaWxlMi4uLl0iOwogCiBteSAkY291bnQgPSAxOwor bXkgJGRlYnVnID0gMDsKKwogR2V0T3B0aW9ucygiY291bnR8Yz1pIiA9PiBcJGNvdW50KTsKK0dl dE9wdGlvbnMoImRlYnVnIiA9PiBcJGRlYnVnKTsKIAogc2V0Q29uZmlndXJhdGlvbigpOwogCi1t eSAkanNjID0gRmlsZTo6U3BlYy0+Y2F0ZmlsZShqc2NQcm9kdWN0RGlyKCksICJqc2MgIikgLiAi QEFSR1YiOworbXkgJGpzYzsKK2lmICgkZGVidWcpIHsKKyAgICBteSAkZGVidWdnZXIgPSBkZWZp bmVkKCRFTlZ7IkRFQlVHR0VSIn0pID8gJEVOVnsiREVCVUdHRVIifSA6ICJsbGRiIjsKKyAgICAk anNjID0gJGRlYnVnZ2VyIC4gIiAiIC4gRmlsZTo6U3BlYy0+Y2F0ZmlsZShqc2NQcm9kdWN0RGly KCksICJqc2MgLS0gIikgLiAiQEFSR1YiOworfSBlbHNlIHsKKyAgICAkanNjID0gRmlsZTo6U3Bl Yy0+Y2F0ZmlsZShqc2NQcm9kdWN0RGlyKCksICJqc2MgIikgLiAiQEFSR1YiOworfQogCiBteSAk ZHlsZCA9IGpzY1Byb2R1Y3REaXIoKTsKIAogJEVOVnsiRFlMRF9GUkFNRVdPUktfUEFUSCJ9ID0g JGR5bGQ7CiBwcmludCBTVERFUlIgIlJ1bm5pbmcgJGNvdW50IHRpbWUocyk6IERZTERfRlJBTUVX T1JLX1BBVEg9JGR5bGQgJGpzY1xuIjsKKwogd2hpbGUgKCRjb3VudC0tKSB7Ci0gICAgaWYgKHN5 c3RlbSgiJGpzYyIpICE9IDApIHsKLSAgICAgICAgbGFzdDsKLSAgICB9CisgICAgbXkgJHN0YXR1 cyA9IHN5c3RlbSgiJGpzYyIpID4+IDg7CisgICAgZXhpdCAkc3RhdHVzIGlmICRzdGF0dXMgIT0g MDsKIH0KLQo=