170496 2017-04-04 23:06:52 -0700 [iOS] DDQueryOffset is the wrong size in Public SDK builds 2017-04-05 00:09:47 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED DUPLICATE 161967 https://bugs.webkit.org/show_bug.cgi?id=167594 https://bugs.webkit.org/show_bug.cgi?id=161967 P2 Normal --- 1 aestes aestes ap bfulgham buildbot cdumez enrica koivisto mitz sam thorton oldest_to_newest 1294392 0 aestes 2017-04-04 23:06:52 -0700 [iOS] DDQueryOffset is the wrong size in Public SDK builds 1294400 1 306262 aestes 2017-04-04 23:16:48 -0700 Created attachment 306262 Patch 1294401 2 buildbot 2017-04-04 23:19:38 -0700 Attachment 306262 did not pass style-queue: ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:109: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] ERROR: Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:110: Please declare enum bitfields as unsigned integral types. [runtime/enum_bitfields] [5] Total errors found: 2 in 4 files If any of these errors are false positives, please file a bug against check-webkit-style. 1294402 3 mitz 2017-04-04 23:23:14 -0700 I think this might be the cause of bug 167594! 1294403 4 306262 ap 2017-04-04 23:23:31 -0700 Comment on attachment 306262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306262&action=review Neat. > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=170496 https://bugs.webkit.org/show_bug.cgi?id=161967 ? > Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:120 > +static_assert(sizeof(DDQueryOffset) == 8, "DDQueryOffset is defined to be 8 bytes in the Public SDK build."); The message doesn't sound quite right - the assert can potentially fail in non-public build too (and that's a good thing). 1294405 5 aestes 2017-04-04 23:30:44 -0700 (In reply to Alexey Proskuryakov from comment #4) > Comment on attachment 306262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306262&action=review > > Neat. > > > Source/WebCore/ChangeLog:4 > > + https://bugs.webkit.org/show_bug.cgi?id=170496 > > https://bugs.webkit.org/show_bug.cgi?id=161967 ? > > > Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h:120 > > +static_assert(sizeof(DDQueryOffset) == 8, "DDQueryOffset is defined to be 8 bytes in the Public SDK build."); > > The message doesn't sound quite right - the assert can potentially fail in > non-public build too (and that's a good thing). The message isn't saying in which build the assertion is failing, it's saying what size our SPI header defines the struct to be in the Public SDK build; it's just restating the assertion in English. I'll reword it as an error. Thanks for the review! 1294411 6 aestes 2017-04-04 23:41:45 -0700 *** This bug has been marked as a duplicate of bug 167594 *** 1294413 7 aestes 2017-04-04 23:42:10 -0700 *** This bug has been marked as a duplicate of bug 161967 *** 306262 2017-04-04 23:16:48 -0700 2017-04-05 00:09:47 -0700 Patch bug-170496-20170404231647.patch text/plain 3500 aestes U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODM5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZhMWRhNDdhNWJkMGQ5 NzdmYWQ1NmQ1OGE1ZWU1ZDQxZGRjZTM5ZS4uNGE0YTQ4MTJhZTNhYzg2ODg3OGExZjQ4MmJjZWM3 NTBmZTc3MTQyOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTA0LTA0ICBBbmR5 IEVzdGVzICA8YWVzdGVzQGFwcGxlLmNvbT4KKworICAgICAgICBbaU9TXSBERFF1ZXJ5T2Zmc2V0 IGlzIHRoZSB3cm9uZyBzaXplIGluIFB1YmxpYyBTREsgYnVpbGRzCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0OTYKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBEYXRhRGV0ZWN0b3JzQ29yZVNQSS5oIGRl ZmluZWQgRERRdWVyeU9mZnNldCBhcyBhIHN0cnVjdCBvZiB0d28gQ0ZJbmRleGVzLCB3aGljaCBp cyAxNiBiaXRzCisgICAgICAgIG9uIExQNjQsIGJ1dCB0aGUgc3RydWN0IGlzIGFjdHVhbGx5IGRl ZmluZWQgYXMgdHdvIENGSW5kZXgtdHlwZWQgMzItYml0IGJpdGZpZWxkcywgd2hpY2ggaXMKKyAg ICAgICAgOCBieXRlcyBvbiBMUDY0LiBUaGlzIGJyZWFrcyB0aGUgQUJJIG9uIFB1YmxpYyBTREsg YnVpbGRzIHdoZW4gY2FsbGluZyBmdW5jdGlvbnMgdGhhdCB0YWtlCisgICAgICAgIG9yIHJldHVy biBERFF1ZXJ5T2Zmc2V0cy4KKworICAgICAgICAqIHBsYXRmb3JtL3NwaS9jb2NvYS9EYXRhRGV0 ZWN0b3JzQ29yZVNQSS5oOiBVcGRhdGVkIHRoZSBERFF1ZXJ5T2Zmc2V0IGRlZmluaXRpb24gZm9y CisgICAgICAgIFB1YmxpYyBTREsgYnVpbGRzLCBhbmQgYWRkZWQgYSBzdGF0aWNfYXNzZXJ0IHRv IGRldGVjdCBmdXR1cmUgc2l6ZSBjaGFuZ2VzIGF0IGNvbXBpbGUgdGltZS4KKwogMjAxNy0wNC0w MyAgSmVyZW15IEpvbmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgRG8gbm90IHNl dCBXZWJBVlBsYXllckxheWVyVmlldyBiYWNrZ3JvdW5kIHRvIGJsYWNrIGluIGZ1bGxzY3JlZW4u CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9zcGkvY29jb2EvRGF0YURldGVj dG9yc0NvcmVTUEkuaCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jb2NvYS9EYXRhRGV0 ZWN0b3JzQ29yZVNQSS5oCmluZGV4IGEwYzM2OTdkMGUyZTg5YzE2NmNlNzM4NmY1YzA3YzExNWNm NzczMWQuLjI5YjEzNzEzZGQ0ZWRmYWI5NDUzNmVhNDQ3YmJlNWViMjU4NjdjNDcgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jb2NvYS9EYXRhRGV0ZWN0b3JzQ29yZVNQ SS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL3NwaS9jb2NvYS9EYXRhRGV0ZWN0b3Jz Q29yZVNQSS5oCkBAIC0xMDYsOCArMTA2LDggQEAgZXh0ZXJuIE5TU3RyaW5nICogY29uc3QgRERV UkxTY2hlbWU7CiAjZGVmaW5lIEREUmVzdWx0UHJvcGVydHlQYXNzaXZlRGlzcGxheSAgICgxIDw8 IDApCiAKIHR5cGVkZWYgc3RydWN0IF9fRERRdWVyeU9mZnNldCB7Ci0gICAgQ0ZJbmRleCBxdWVy eUluZGV4OwotICAgIENGSW5kZXggb2Zmc2V0OworICAgIENGSW5kZXggcXVlcnlJbmRleDozMjsK KyAgICBDRkluZGV4IG9mZnNldDozMjsKIH0gRERRdWVyeU9mZnNldDsKIAogdHlwZWRlZiBzdHJ1 Y3QgX19ERFF1ZXJ5UmFuZ2UgewpAQCAtMTE3LDYgKzExNyw4IEBAIHR5cGVkZWYgc3RydWN0IF9f RERRdWVyeVJhbmdlIHsKIAogI2VuZGlmIC8vICFVU0UoQVBQTEVfSU5URVJOQUxfU0RLKQogCitz dGF0aWNfYXNzZXJ0KHNpemVvZihERFF1ZXJ5T2Zmc2V0KSA9PSA4LCAiRERRdWVyeU9mZnNldCBp cyBkZWZpbmVkIHRvIGJlIDggYnl0ZXMgaW4gdGhlIFB1YmxpYyBTREsgYnVpbGQuIik7CisKIHR5 cGVkZWYgc3RydWN0IF9fRERTY2FuUXVlcnkgKkREU2NhblF1ZXJ5UmVmOwogdHlwZWRlZiBzdHJ1 Y3QgX19ERFNjYW5uZXIgKkREU2Nhbm5lclJlZjsKIApkaWZmIC0tZ2l0IGEvVG9vbHMvQ2hhbmdl TG9nIGIvVG9vbHMvQ2hhbmdlTG9nCmluZGV4IGQ1NmU3NGQyNThmZWYyMWVlZmU5NTgwNjJmYTg5 NmUxMzNjYTM1NDYuLmZjYmNkMzRiOTE2N2Y3NmJmMzI5ODRhNWNiOTI4ZTBlNjM5YmJhZmYgMTAw NjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyAr MSwxMyBAQAorMjAxNy0wNC0wNCAgQW5keSBFc3RlcyAgPGFlc3Rlc0BhcHBsZS5jb20+CisKKyAg ICAgICAgW2lPU10gRERRdWVyeU9mZnNldCBpcyB0aGUgd3Jvbmcgc2l6ZSBpbiBQdWJsaWMgU0RL IGJ1aWxkcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcwNDk2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg KiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9EYXRhRGV0ZWN0aW9uLm1tOgorICAg ICAgICAoVEVTVCk6IFJlLWVuYWJsZWQgV2ViS2l0Mi5EYXRhRGV0ZWN0aW9uUmVmZXJlbmNlRGF0 ZS4KKwogMjAxNy0wNC0wMyAgQnJpYW4gQnVyZyAgPGJidXJnQGFwcGxlLmNvbT4KIAogICAgICAg ICBydW4tc2FmYXJpIHNob3VsZCBzdXBwb3J0IGxhdW5jaGluZyB3aXRoIGN1c3RvbSBsYW5ndWFn ZSBhbmQgbG9jYWxlCmRpZmYgLS1naXQgYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktp dDJDb2NvYS9EYXRhRGV0ZWN0aW9uLm1tIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJL aXQyQ29jb2EvRGF0YURldGVjdGlvbi5tbQppbmRleCA3MGQyOGNkMGNmMTU4YTU1MjBjNDIwNzA4 OGU5ZDU5ZjFiZjExNjU4Li44NWU4MjUyZDhjMTAyNTg2YTA4ZmU0NjBiNTQ1M2Y4Njg2MDI0OTc5 IDEwMDY0NAotLS0gYS9Ub29scy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdDJDb2NvYS9EYXRh RGV0ZWN0aW9uLm1tCisrKyBiL1Rvb2xzL1Rlc3RXZWJLaXRBUEkvVGVzdHMvV2ViS2l0MkNvY29h L0RhdGFEZXRlY3Rpb24ubW0KQEAgLTY5LDcgKzY5LDcgQEAgdm9pZCBleHBlY3RMaW5rQ291bnQo V0tXZWJWaWV3ICp3ZWJWaWV3LCBOU1N0cmluZyAqSFRNTFN0cmluZywgdW5zaWduZWQgbGlua0Nv dW4KICAgICByYW5TY3JpcHQgPSBmYWxzZTsKIH0KIAotVEVTVChXZWJLaXQyLCBESVNBQkxFRF9E YXRhRGV0ZWN0aW9uUmVmZXJlbmNlRGF0ZSkKK1RFU1QoV2ViS2l0MiwgRGF0YURldGVjdGlvblJl ZmVyZW5jZURhdGUpCiB7CiAgICAgUmV0YWluUHRyPFdLV2ViVmlld0NvbmZpZ3VyYXRpb24+IGNv bmZpZ3VyYXRpb24gPSBhZG9wdE5TKFtbV0tXZWJWaWV3Q29uZmlndXJhdGlvbiBhbGxvY10gaW5p dF0pOwogICAgIFtjb25maWd1cmF0aW9uIHNldERhdGFEZXRlY3RvclR5cGVzOldLRGF0YURldGVj dG9yVHlwZUNhbGVuZGFyRXZlbnRdOwo=