170480 2017-04-04 15:36:02 -0700 Fix leaks in WebUITextIndicatorData 2017-04-04 15:58:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner megan_gardner bdakin thorton wenson_hsieh oldest_to_newest 1294225 0 megan_gardner 2017-04-04 15:36:02 -0700 Fix leaks in WebUITextIndicatorData 1294228 1 306220 megan_gardner 2017-04-04 15:38:40 -0700 Created attachment 306220 Patch 1294231 2 306220 wenson_hsieh 2017-04-04 15:41:54 -0700 Comment on attachment 306220 Patch r=me 1294239 3 megan_gardner 2017-04-04 15:58:21 -0700 https://trac.webkit.org/r214910 306220 2017-04-04 15:38:40 -0700 2017-04-04 15:41:54 -0700 Patch bug-170480-20170404153839.patch text/plain 3754 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQvbWFjL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L21hYy9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDkwNykKKysrIFNvdXJjZS9XZWJLaXQv bWFjL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTA0 ICBNZWdhbiBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgRml4 IGxlYWtzIGluIFdlYlVJVGV4dEluZGljYXRvckRhdGEKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDQ4MAorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlbW92ZXMgZXh0cmFuZW91cyByZXRhaW5zLgorCisg ICAgICAgICogV2ViVmlldy9XZWJWaWV3Lm1tOgorICAgICAgICAoLVtXZWJVSVRleHRJbmRpY2F0 b3JEYXRhIGluaXRXaXRoSW1hZ2U6dGV4dEluZGljYXRvckRhdGE6c2NhbGU6XSk6CisKIDIwMTct MDQtMDQgIFRpbSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAg W01hY10gLVtXS1dlYlZpZXcgZmluZE1hdGNoZXNGb3JTdHJpbmc6cmVsYXRpdmVUb01hdGNoOmZp bmRPcHRpb25zOm1heFJlc3VsdHM6cmVzdWx0Q29sbGVjdG9yOl0gaW52b2tlcyB0aGUgcmVzdWx0 Q29sbGVjdG9yIHdpdGggZGlkV3JhcCA9IE5PIGV2ZW4gd2hlbiBpdCB3cmFwcwpJbmRleDogU291 cmNlL1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9X ZWJLaXQvbWFjL1dlYlZpZXcvV2ViVmlldy5tbQkocmV2aXNpb24gMjE0ODk1KQorKysgU291cmNl L1dlYktpdC9tYWMvV2ViVmlldy9XZWJWaWV3Lm1tCSh3b3JraW5nIGNvcHkpCkBAIC02NDksNyAr NjQ5LDcgQEAgLSAoV2ViVUlUZXh0SW5kaWNhdG9yRGF0YSAqKWluaXRXaXRoSW1hZwogICAgIGlm ICghKHNlbGYgPSBbc3VwZXIgaW5pdF0pKQogICAgICAgICByZXR1cm4gbmlsOwogICAgIAotICAg IF9kYXRhSW50ZXJhY3Rpb25JbWFnZSA9IFtbW2dldFVJSW1hZ2VDbGFzcygpIGFsbG9jXSBpbml0 V2l0aENHSW1hZ2U6aW1hZ2Ugc2NhbGU6c2NhbGUgb3JpZW50YXRpb246VUlJbWFnZU9yaWVudGF0 aW9uRG93bk1pcnJvcmVkXSByZXRhaW5dOworICAgIF9kYXRhSW50ZXJhY3Rpb25JbWFnZSA9IFtb Z2V0VUlJbWFnZUNsYXNzKCkgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTppbWFnZSBzY2FsZTpzY2Fs ZSBvcmllbnRhdGlvbjpVSUltYWdlT3JpZW50YXRpb25Eb3duTWlycm9yZWRdOwogICAgIF9zZWxl Y3Rpb25SZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzID0gaW5kaWNhdG9yRGF0YS5zZWxlY3Rpb25S ZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzOwogICAgIF90ZXh0Qm91bmRpbmdSZWN0SW5Sb290Vmll d0Nvb3JkaW5hdGVzID0gaW5kaWNhdG9yRGF0YS50ZXh0Qm91bmRpbmdSZWN0SW5Sb290Vmlld0Nv b3JkaW5hdGVzOwogICAgIApAQCAtNjU5LDIwICs2NTksMjAgQEAgLSAoV2ViVUlUZXh0SW5kaWNh dG9yRGF0YSAqKWluaXRXaXRoSW1hZwogICAgIF90ZXh0UmVjdHNJbkJvdW5kaW5nUmVjdENvb3Jk aW5hdGVzID0gW1tOU0FycmF5IGFycmF5V2l0aEFycmF5OnRleHRSZWN0c0luQm91bmRpbmdSZWN0 Q29vcmRpbmF0ZXNdIHJldGFpbl07CiAgICAgX2NvbnRlbnRJbWFnZVNjYWxlRmFjdG9yID0gaW5k aWNhdG9yRGF0YS5jb250ZW50SW1hZ2VTY2FsZUZhY3RvcjsKICAgICBpZiAoaW5kaWNhdG9yRGF0 YS5jb250ZW50SW1hZ2VXaXRoSGlnaGxpZ2h0KQotICAgICAgICBfY29udGVudEltYWdlV2l0aEhp Z2hsaWdodCA9IFtbW2dldFVJSW1hZ2VDbGFzcygpIGFsbG9jXSBpbml0V2l0aENHSW1hZ2U6aW5k aWNhdG9yRGF0YS5jb250ZW50SW1hZ2VXaXRoSGlnaGxpZ2h0LmdldCgpLT5uYXRpdmVJbWFnZSgp LmdldCgpIHNjYWxlOnNjYWxlIG9yaWVudGF0aW9uOlVJSW1hZ2VPcmllbnRhdGlvbkRvd25NaXJy b3JlZF0gcmV0YWluXTsKKyAgICAgICAgX2NvbnRlbnRJbWFnZVdpdGhIaWdobGlnaHQgPSBbW2dl dFVJSW1hZ2VDbGFzcygpIGFsbG9jXSBpbml0V2l0aENHSW1hZ2U6aW5kaWNhdG9yRGF0YS5jb250 ZW50SW1hZ2VXaXRoSGlnaGxpZ2h0LmdldCgpLT5uYXRpdmVJbWFnZSgpLmdldCgpIHNjYWxlOnNj YWxlIG9yaWVudGF0aW9uOlVJSW1hZ2VPcmllbnRhdGlvbkRvd25NaXJyb3JlZF07CiAgICAgaWYg KGluZGljYXRvckRhdGEuY29udGVudEltYWdlKQotICAgICAgICBfY29udGVudEltYWdlID0gW1tb Z2V0VUlJbWFnZUNsYXNzKCkgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTppbmRpY2F0b3JEYXRhLmNv bnRlbnRJbWFnZS5nZXQoKS0+bmF0aXZlSW1hZ2UoKS5nZXQoKSBzY2FsZTpzY2FsZSBvcmllbnRh dGlvbjpVSUltYWdlT3JpZW50YXRpb25VcF0gcmV0YWluXTsKKyAgICAgICAgX2NvbnRlbnRJbWFn ZSA9IFtbZ2V0VUlJbWFnZUNsYXNzKCkgYWxsb2NdIGluaXRXaXRoQ0dJbWFnZTppbmRpY2F0b3JE YXRhLmNvbnRlbnRJbWFnZS5nZXQoKS0+bmF0aXZlSW1hZ2UoKS5nZXQoKSBzY2FsZTpzY2FsZSBv cmllbnRhdGlvbjpVSUltYWdlT3JpZW50YXRpb25VcF07CiAKICAgICBpZiAoaW5kaWNhdG9yRGF0 YS5jb250ZW50SW1hZ2VXaXRob3V0U2VsZWN0aW9uKSB7CiAgICAgICAgIGF1dG8gbmF0aXZlSW1h Z2UgPSBpbmRpY2F0b3JEYXRhLmNvbnRlbnRJbWFnZVdpdGhvdXRTZWxlY3Rpb24uZ2V0KCktPm5h dGl2ZUltYWdlKCk7CiAgICAgICAgIGlmIChuYXRpdmVJbWFnZSkgewotICAgICAgICAgICAgX2Nv bnRlbnRJbWFnZVdpdGhvdXRTZWxlY3Rpb24gPSBbW1tnZXRVSUltYWdlQ2xhc3MoKSBhbGxvY10g aW5pdFdpdGhDR0ltYWdlOm5hdGl2ZUltYWdlLmdldCgpIHNjYWxlOnNjYWxlIG9yaWVudGF0aW9u OlVJSW1hZ2VPcmllbnRhdGlvblVwXSByZXRhaW5dOworICAgICAgICAgICAgX2NvbnRlbnRJbWFn ZVdpdGhvdXRTZWxlY3Rpb24gPSBbW2dldFVJSW1hZ2VDbGFzcygpIGFsbG9jXSBpbml0V2l0aENH SW1hZ2U6bmF0aXZlSW1hZ2UuZ2V0KCkgc2NhbGU6c2NhbGUgb3JpZW50YXRpb246VUlJbWFnZU9y aWVudGF0aW9uVXBdOwogICAgICAgICAgICAgX2NvbnRlbnRJbWFnZVdpdGhvdXRTZWxlY3Rpb25S ZWN0SW5Sb290Vmlld0Nvb3JkaW5hdGVzID0gaW5kaWNhdG9yRGF0YS5jb250ZW50SW1hZ2VXaXRo b3V0U2VsZWN0aW9uUmVjdEluUm9vdFZpZXdDb29yZGluYXRlczsKICAgICAgICAgfQogICAgIH0K IAogICAgIGlmIChpbmRpY2F0b3JEYXRhLm9wdGlvbnMgJiBUZXh0SW5kaWNhdG9yT3B0aW9uQ29t cHV0ZUVzdGltYXRlZEJhY2tncm91bmRDb2xvcikKLSAgICAgICAgX2VzdGltYXRlZEJhY2tncm91 bmRDb2xvciA9IFtbW2dldFVJQ29sb3JDbGFzcygpIGFsbG9jXSBpbml0V2l0aENHQ29sb3I6Y2Fj aGVkQ0dDb2xvcihpbmRpY2F0b3JEYXRhLmVzdGltYXRlZEJhY2tncm91bmRDb2xvcildIHJldGFp bl07CisgICAgICAgIF9lc3RpbWF0ZWRCYWNrZ3JvdW5kQ29sb3IgPSBbW2dldFVJQ29sb3JDbGFz cygpIGFsbG9jXSBpbml0V2l0aENHQ29sb3I6Y2FjaGVkQ0dDb2xvcihpbmRpY2F0b3JEYXRhLmVz dGltYXRlZEJhY2tncm91bmRDb2xvcildOwogCiAgICAgcmV0dXJuIHNlbGY7CiB9Cg==