170468 2017-04-04 13:48:50 -0700 Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime 2017-04-04 14:32:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser buildbot cdumez dbates esprehn+autocc gyuyoung.kim japhet kangil.han simon.fraser zalan oldest_to_newest 1294147 0 simon.fraser 2017-04-04 13:48:50 -0700 Change Document's lastHandledUserGestureTimestamp to be a MonotonicTime 1294148 1 306196 simon.fraser 2017-04-04 13:49:31 -0700 Created attachment 306196 Patch 1294188 2 simon.fraser 2017-04-04 14:32:58 -0700 https://trac.webkit.org/r214900 1294189 3 306196 cdumez 2017-04-04 14:32:59 -0700 Comment on attachment 306196 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306196&action=review > Source/WebCore/loader/FrameLoader.cpp:3039 > + bool userDidInteractWithPage = static_cast<bool>(document.topDocument().lastHandledUserGestureTimestamp()); I personally like: !!document.topDocument().lastHandledUserGestureTimestamp() for this sort of things as it is shorter than a cast. 306196 2017-04-04 13:49:31 -0700 2017-04-04 13:55:46 -0700 Patch bug-170468-20170404134930.patch text/plain 5401 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODU1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGQ2NWMwMzYzMzE2YjBj YzIyMzQ5MTgzMmRjMWZmMzI0OTg2OTEzNi4uYzllZGI1MWZmNTdjZjk5YjVmMTFhN2NhNGJlNzI5 ODgwN2VmMWFkMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDE3LTA0LTA0ICBTaW1v biBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgorCisgICAgICAgIENoYW5nZSBEb2N1 bWVudCdzIGxhc3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAgdG8gYmUgYSBNb25vdG9uaWNU aW1lCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0 NjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKyAgICAgICAgCisgICAg ICAgIENoYW5nZSB0aGUgZG91YmxlIHRvIE1vbm90b25pY1RpbWUuIE5vIGJlaGF2aW9yIGNoYW5n ZS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1 bWVudDo6dXBkYXRlTGFzdEhhbmRsZWRVc2VyR2VzdHVyZVRpbWVzdGFtcCk6CisgICAgICAgICog ZG9tL0RvY3VtZW50Lmg6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6bGFzdEhhbmRsZWRV c2VyR2VzdHVyZVRpbWVzdGFtcCk6CisgICAgICAgICogaHRtbC9IVE1MUGx1Z0luSW1hZ2VFbGVt ZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRvY3VtZW50SGFkUmVjZW50VXNlckdlc3R1cmUp OgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpz aG91bGRBc2tGb3JOYXZpZ2F0aW9uQ29uZmlybWF0aW9uKToKKwogMjAxNy0wNC0wMyAgSmF2aWVy IEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbY3NzLWFsaWdu XSBBZGFwdCBwbGFjZS1jb250ZW50IGFsaWdubWVudCBzaG9ydGhhbmQgdG8gdGhlIG5ldyBiYXNl bGluZSBzeW50YXgKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAg Yi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCmluZGV4IDhkYWMwOTUzMDE4NmQ4Njc4 N2I1YWFlNTRhYTlmZGU1NDkzMmUzMWMuLjk0YTY3MWMwM2Y4NGI4NDI5MmNkNjNmMjk2ZWI0MTNi MTgwZjNlNWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcApAQCAtNjMxMCw3ICs2MzEwLDcgQEAg RG9jdW1lbnQ6OlJlZ2lvbkZpeGVkUGFpciBEb2N1bWVudDo6YWJzb2x1dGVSZWdpb25Gb3JFdmVu dFRhcmdldHMoY29uc3QgRXZlbnRUYXIKIAogdm9pZCBEb2N1bWVudDo6dXBkYXRlTGFzdEhhbmRs ZWRVc2VyR2VzdHVyZVRpbWVzdGFtcCgpCiB7Ci0gICAgbV9sYXN0SGFuZGxlZFVzZXJHZXN0dXJl VGltZXN0YW1wID0gbW9ub3RvbmljYWxseUluY3JlYXNpbmdUaW1lKCk7CisgICAgbV9sYXN0SGFu ZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wID0gTW9ub3RvbmljVGltZTo6bm93KCk7CiAgICAgUmVz b3VyY2VMb2FkT2JzZXJ2ZXI6OnNoYXJlZE9ic2VydmVyKCkubG9nVXNlckludGVyYWN0aW9uV2l0 aFJlZHVjZWRUaW1lUmVzb2x1dGlvbigqdGhpcyk7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2RvbS9Eb2N1bWVudC5oIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKaW5k ZXggYmZkNjdiODFlMDkzZDk1MTAyOGQ5OGQ0ZjdiNzdmOWQ1NGJkYzQ5Ny4uMGIxOWYzY2M0OGJi N2NhNjkzYmVhMzYxY2FjYzVmNGMxZWUyM2VlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv ZG9tL0RvY3VtZW50LmgKKysrIGIvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmgKQEAgLTEx NDMsNyArMTE0Myw3IEBAIHB1YmxpYzoKICAgICB2b2lkIGRpZEFkZFdoZWVsRXZlbnRIYW5kbGVy KE5vZGUmKTsKICAgICB2b2lkIGRpZFJlbW92ZVdoZWVsRXZlbnRIYW5kbGVyKE5vZGUmLCBFdmVu dEhhbmRsZXJSZW1vdmFsID0gRXZlbnRIYW5kbGVyUmVtb3ZhbDo6T25lKTsKIAotICAgIGRvdWJs ZSBsYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wKCkgY29uc3QgeyByZXR1cm4gbV9sYXN0 SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wOyB9CisgICAgTW9ub3RvbmljVGltZSBsYXN0SGFu ZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wKCkgY29uc3QgeyByZXR1cm4gbV9sYXN0SGFuZGxlZFVz ZXJHZXN0dXJlVGltZXN0YW1wOyB9CiAgICAgdm9pZCB1cGRhdGVMYXN0SGFuZGxlZFVzZXJHZXN0 dXJlVGltZXN0YW1wKCk7CiAKICAgICAvLyBVc2VkIGZvciB0ZXN0aW5nLiBDb3VudCBoYW5kbGVy cyBpbiB0aGUgbWFpbiBkb2N1bWVudCwgYW5kIG9uZSBwZXIgZnJhbWUgd2hpY2ggY29udGFpbnMg aGFuZGxlcnMuCkBAIC0xNTcyLDcgKzE1NzIsNyBAQCBwcml2YXRlOgogI2VuZGlmCiAgICAgc3Rk Ojp1bmlxdWVfcHRyPEV2ZW50VGFyZ2V0U2V0PiBtX3doZWVsRXZlbnRUYXJnZXRzOwogCi0gICAg ZG91YmxlIG1fbGFzdEhhbmRsZWRVc2VyR2VzdHVyZVRpbWVzdGFtcCB7IDAgfTsKKyAgICBNb25v dG9uaWNUaW1lIG1fbGFzdEhhbmRsZWRVc2VyR2VzdHVyZVRpbWVzdGFtcDsKIAogICAgIHZvaWQg Y2xlYXJTY3JpcHRlZEFuaW1hdGlvbkNvbnRyb2xsZXIoKTsKICAgICBSZWZQdHI8U2NyaXB0ZWRB bmltYXRpb25Db250cm9sbGVyPiBtX3NjcmlwdGVkQW5pbWF0aW9uQ29udHJvbGxlcjsKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTFBsdWdJbkltYWdlRWxlbWVudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9odG1sL0hUTUxQbHVnSW5JbWFnZUVsZW1lbnQuY3BwCmluZGV4IDNmZGVk NWNjZTg0MDhiNWJhODI3NzA1YzY3YmNiMDk3OGM1YWFhOGEuLjlmNTZkNjZlODMxM2EzN2U1YzQx YWI4ZWE2MjU2NDE1Y2ViYTRiZDIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRN TFBsdWdJbkltYWdlRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaHRtbC9IVE1MUGx1 Z0luSW1hZ2VFbGVtZW50LmNwcApAQCAtNTIsNyArNTIsNyBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7 CiAKIHN0YXRpYyBjb25zdCBpbnQgc2l6aW5nVGlueURpbWVuc2lvblRocmVzaG9sZCA9IDQwOwog c3RhdGljIGNvbnN0IGZsb2F0IHNpemluZ0Z1bGxQYWdlQXJlYVJhdGlvVGhyZXNob2xkID0gMC45 NjsKLXN0YXRpYyBjb25zdCBmbG9hdCBhdXRvc3RhcnRTb29uQWZ0ZXJVc2VyR2VzdHVyZVRocmVz aG9sZCA9IDUuMDsKK3N0YXRpYyBjb25zdCBTZWNvbmRzIGF1dG9zdGFydFNvb25BZnRlclVzZXJH ZXN0dXJlVGhyZXNob2xkID0gNV9zOwogCiAvLyBUaGlzIGRlbGF5IHNob3VsZCBub3QgZXhjZWVk IHRoZSBzbmFwc2hvdCBkZWxheSBpbiBQbHVnaW5WaWV3LmNwcAogc3RhdGljIGNvbnN0IGF1dG8g c2ltdWxhdGVkTW91c2VDbGlja1RpbWVyRGVsYXkgPSBzdGQ6OmNocm9ubzo6bWlsbGlzZWNvbmRz IHsgNzUwIH07CkBAIC00OTksMTEgKzQ5OSwxMSBAQCB2b2lkIEhUTUxQbHVnSW5JbWFnZUVsZW1l bnQ6OnNpbXVsYXRlZE1vdXNlQ2xpY2tUaW1lckZpcmVkKCkKIAogc3RhdGljIGJvb2wgZG9jdW1l bnRIYWRSZWNlbnRVc2VyR2VzdHVyZShEb2N1bWVudCYgZG9jdW1lbnQpCiB7Ci0gICAgZG91Ymxl IGxhc3RLbm93blVzZXJHZXN0dXJlVGltZXN0YW1wID0gZG9jdW1lbnQubGFzdEhhbmRsZWRVc2Vy R2VzdHVyZVRpbWVzdGFtcCgpOworICAgIE1vbm90b25pY1RpbWUgbGFzdEtub3duVXNlckdlc3R1 cmVUaW1lc3RhbXAgPSBkb2N1bWVudC5sYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wKCk7 CiAgICAgaWYgKGRvY3VtZW50LmZyYW1lKCkgIT0gJmRvY3VtZW50LnBhZ2UoKS0+bWFpbkZyYW1l KCkgJiYgZG9jdW1lbnQucGFnZSgpLT5tYWluRnJhbWUoKS5kb2N1bWVudCgpKQogICAgICAgICBs YXN0S25vd25Vc2VyR2VzdHVyZVRpbWVzdGFtcCA9IHN0ZDo6bWF4KGxhc3RLbm93blVzZXJHZXN0 dXJlVGltZXN0YW1wLCBkb2N1bWVudC5wYWdlKCktPm1haW5GcmFtZSgpLmRvY3VtZW50KCktPmxh c3RIYW5kbGVkVXNlckdlc3R1cmVUaW1lc3RhbXAoKSk7CiAKLSAgICByZXR1cm4gbW9ub3Rvbmlj YWxseUluY3JlYXNpbmdUaW1lKCkgLSBsYXN0S25vd25Vc2VyR2VzdHVyZVRpbWVzdGFtcCA8IGF1 dG9zdGFydFNvb25BZnRlclVzZXJHZXN0dXJlVGhyZXNob2xkOworICAgIHJldHVybiBNb25vdG9u aWNUaW1lOjpub3coKSAtIGxhc3RLbm93blVzZXJHZXN0dXJlVGltZXN0YW1wIDwgYXV0b3N0YXJ0 U29vbkFmdGVyVXNlckdlc3R1cmVUaHJlc2hvbGQ7CiB9CiAKIHZvaWQgSFRNTFBsdWdJbkltYWdl RWxlbWVudDo6Y2hlY2tTaXplQ2hhbmdlRm9yU25hcHNob3R0aW5nKCkKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2Fk ZXIvRnJhbWVMb2FkZXIuY3BwCmluZGV4IGJkMWU5OWY4ZjA3MzQwNGNmMDU0OTcwM2M5Y2MzYWM5 MTRiZjM2MDEuLjJjNTc1MzU2YmExOGMxOGI4NDdhMTgwZGUxYWY1NDY1Mzc0NjY1MTkgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNl L1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApAQCAtMzAzNiw3ICszMDM2LDcgQEAgdm9p ZCBGcmFtZUxvYWRlcjo6ZGlzcGF0Y2hVbmxvYWRFdmVudHMoVW5sb2FkRXZlbnRQb2xpY3kgdW5s b2FkRXZlbnRQb2xpY3kpCiAKIHN0YXRpYyBib29sIHNob3VsZEFza0Zvck5hdmlnYXRpb25Db25m aXJtYXRpb24oRG9jdW1lbnQmIGRvY3VtZW50LCBjb25zdCBCZWZvcmVVbmxvYWRFdmVudCYgZXZl bnQpCiB7Ci0gICAgYm9vbCB1c2VyRGlkSW50ZXJhY3RXaXRoUGFnZSA9IGRvY3VtZW50LnRvcERv Y3VtZW50KCkubGFzdEhhbmRsZWRVc2VyR2VzdHVyZVRpbWVzdGFtcCgpID4gMDsKKyAgICBib29s IHVzZXJEaWRJbnRlcmFjdFdpdGhQYWdlID0gc3RhdGljX2Nhc3Q8Ym9vbD4oZG9jdW1lbnQudG9w RG9jdW1lbnQoKS5sYXN0SGFuZGxlZFVzZXJHZXN0dXJlVGltZXN0YW1wKCkpOwogICAgIC8vIFdl YiBwYWdlcyBjYW4gcmVxdWVzdCB3ZSBhc2sgZm9yIGNvbmZpcm1hdGlvbiBiZWZvcmUgbmF2aWdh dGluZyBieToKICAgICAvLyAtIENhbmNlbGxpbmcgdGhlIEJlZm9yZVVubG9hZEV2ZW50IChtb2Rl cm4gd2F5KQogICAgIC8vIC0gU2V0dGluZyB0aGUgcmV0dXJuVmFsdWUgYXR0cmlidXRlIG9uIHRo ZSBCZWZvcmVVbmxvYWRFdmVudCB0byBhIG5vbi1lbXB0eSBzdHJpbmcuCg==