170452 2017-04-04 08:58:37 -0700 Setting url.search="??" (two questionmarks) has incorrect behavior 2020-06-28 22:20:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. Safari Technology Preview Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 zcorpan rbuis achristensen annevk cdumez changseok darin esprehn+autocc ews-watchlist gyuyoung.kim rbuis webkit-bug-importer oldest_to_newest 1294039 0 zcorpan 2017-04-04 08:58:37 -0700 From https://bugs.webkit.org/show_bug.cgi?id=161191 +FAIL Setting <https://example.net?lang=en-US#nav>.search = '??lang=fr' assert_equals: expected "https://example.net/??lang=fr#nav" but got "https://example.net/?lang=fr#nav" I noticed today that http://software.hixie.ch/utilities/js/live-dom-viewer/saved/5000 has different results in webkit, chromium, and gecko. :-( <!DOCTYPE html> <a href id=a></a> <script> a.search='?'; w(a.href); a.search='??'; w(a.href); var u = new URL('https://test/'); u.search = '?'; w(u.href); u.search = '??'; w(u.href); </script> Result in Safari TP: log: http://software.hixie.ch/utilities/js/live-dom-viewer/? log: http://software.hixie.ch/utilities/js/live-dom-viewer/? log: https://test/? log: https://test/? Expected (per URL standard and as in Gecko): log: http://software.hixie.ch/utilities/js/live-dom-viewer/? log: http://software.hixie.ch/utilities/js/live-dom-viewer/?? log: https://test/? log: https://test/?? (Issue for chromium which has incorrect behavior for url.search = '?' instead: https://bugs.chromium.org/p/chromium/issues/detail?id=682150#c7 ) 1294560 1 achristensen 2017-04-05 10:49:01 -0700 We match the behavior of Chromium when setting the query to "??", and if I interpret https://url.spec.whatwg.org/#dom-url-search correctly, then Firefox and the web platform tests are not following the specification: "Let input be the given value with a single leading U+003F (?) removed, if any." I interpret this to mean that if the given value starts with one or more '?' then one will be removed. Firefox seems to interpret this to mean that the leading '?' is only to be removed if it is followed by a non-question-mark character, which I don't think makes any sense. I'm interested in Anne's interpretation. With the setting of the query to "?" I believe Firefox, WebKit, and the specification are "correct" and Chromium needs to change. 1294568 2 annevk 2017-04-05 11:09:12 -0700 I think you are correct. I created https://github.com/w3c/web-platform-tests/pull/5387 to fix web-platform-tests. Haven't filed a bug against the other browsers thus far. 1294825 3 annevk 2017-04-06 01:10:21 -0700 Actually, as Simon pointed out in web-platform-tests review, while a leading "?" is removed, the search getter adds it back. So therefore you'd still see two of them. So this is bug in WebKit after all. 1666788 4 402961 rbuis 2020-06-27 10:07:56 -0700 Created attachment 402961 Patch 1666922 5 ews-feeder 2020-06-28 14:36:10 -0700 Committed r263637: <https://trac.webkit.org/changeset/263637> All reviewed patches have been landed. Closing bug and clearing flags on attachment 402961. 1666923 6 webkit-bug-importer 2020-06-28 14:37:13 -0700 <rdar://problem/64867705> 1666927 7 darin 2020-06-28 14:54:32 -0700 Is URLDecomposition used anywhere else besides the URL, <a>, and <area> cases that are covered by WPT? 1666987 8 rbuis 2020-06-28 22:20:03 -0700 (In reply to Darin Adler from comment #7) > Is URLDecomposition used anywhere else besides the URL, <a>, and <area> > cases that are covered by WPT? It is only web exposed to URL, <a>, and <area>. The derived DOMURL is used in internals API and editing/. 402961 2020-06-27 10:07:56 -0700 2020-06-28 14:36:11 -0700 Patch bug-170452-20200627190755.patch text/plain 4246 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjYzNjI0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDZmNzI3ZWVkZjFlZjhi NjBkODNmMmFiMDMyYjdmMDQ4Mjc2ZjZjOC4uMDE5OTYxNjZhOWVlODk3M2UyYzAwMGY4ZjIzMDcw MDhmY2QwMjFkZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIwLTA2LTI3ICBSb2Ig QnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU2V0dGluZyB1cmwuc2VhcmNoPSI/ PyIgKHR3byBxdWVzdGlvbm1hcmtzKSBoYXMgaW5jb3JyZWN0IGJlaGF2aW9yCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0NTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGVyZSBpcyBubyBuZWVkIHRv IHN0cmlwIGxlYWRpbmcgIj8iIGNoYXJhY3RlciBzaW5jZQorICAgICAgICBVUkxQYXJzZXIgZXhw ZWN0cyBpdCB0byBiZSB0aGVyZS4gVGhpcyBkaWZmZXJzIGZyb20gdGhlCisgICAgICAgIHNwZWNp ZmljYXRpb24gYWxnb3JpdGhtIFsxXSwgd2hpY2ggcmVsaWVzIG9uIHN0YXRlIG92ZXJyaWRlLAor ICAgICAgICB3aGljaCBVUkxQYXJzZXIgZG9lcyBub3Qgc3VwcG9ydC4KKworICAgICAgICBCZWhh dmlvciBtYXRjaGVzIEZpcmVmb3ggYW5kIENocm9tZS4KKworICAgICAgICBUZXN0OiBpbXBvcnRl ZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3VybC91cmwtc2V0dGVycy5odG1sCisKKyAgICAgICAg WzFdIGh0dHBzOi8vdXJsLnNwZWMud2hhdHdnLm9yZy8jZG9tLXVybC1zZWFyY2gKKworICAgICAg ICAqIGh0bWwvVVJMRGVjb21wb3NpdGlvbi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVUkxEZWNv bXBvc2l0aW9uOjpzZXRTZWFyY2gpOgorCiAyMDIwLTA2LTI3ICBSb2IgQnVpcyAgPHJidWlzQGln YWxpYS5jb20+CiAKICAgICAgICAgUmVxdWlyZSA8Zm9ybT4gdG8gYmUgY29ubmVjdGVkCmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTERlY29tcG9zaXRpb24uY3BwIGIvU291cmNl L1dlYkNvcmUvaHRtbC9VUkxEZWNvbXBvc2l0aW9uLmNwcAppbmRleCA2ZjM2YWZmMzJkY2VlZmI4 ODExOGZiNDQ0MDFhYjE5MzVkMjdlYjVkLi41Y2M0OTMyNTEyOTI5ZjIxYTQ2NDU3ZjQ4NzE4MWUx ZGM2YzQ0ZDNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL1VSTERlY29tcG9zaXRp b24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvVVJMRGVjb21wb3NpdGlvbi5jcHAKQEAg LTIyMSw3ICsyMjEsNyBAQCB2b2lkIFVSTERlY29tcG9zaXRpb246OnNldFNlYXJjaChjb25zdCBT dHJpbmcmIHZhbHVlKQogICAgICAgICAvLyBJZiB0aGUgZ2l2ZW4gdmFsdWUgaXMgdGhlIGVtcHR5 IHN0cmluZywgc2V0IHVybCdzIHF1ZXJ5IHRvIG51bGwuCiAgICAgICAgIGZ1bGxVUkwuc2V0UXVl cnkoeyB9KTsKICAgICB9IGVsc2UgewotICAgICAgICBTdHJpbmcgbmV3U2VhcmNoID0gdmFsdWUu c3RhcnRzV2l0aCgnPycpID8gdmFsdWUuc3Vic3RyaW5nKDEpIDogdmFsdWU7CisgICAgICAgIFN0 cmluZyBuZXdTZWFyY2ggPSB2YWx1ZTsKICAgICAgICAgLy8gTWFrZSBzdXJlIHRoYXQgJyMnIGlu IHRoZSBxdWVyeSBkb2VzIG5vdCBsZWFrIHRvIHRoZSBoYXNoLgogICAgICAgICBmdWxsVVJMLnNl dFF1ZXJ5KG5ld1NlYXJjaC5yZXBsYWNlV2l0aExpdGVyYWwoJyMnLCAiJTIzIikpOwogICAgIH0K ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cgYi9MYXlvdXRU ZXN0cy9pbXBvcnRlZC93M2MvQ2hhbmdlTG9nCmluZGV4IDUzNTdkOTg1OWM3ZGM0YzBjNzcxZTY3 MDJmM2M1MWZiN2YwYjlmYWYuLjUzZDM1NGMwYTBhYjgzZDJmNzY5MDZhMDk3MTIxMTg3ZTg3OGQ3 NDAgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3czYy9DaGFuZ2VMb2cKKysrIGIv TGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIw LTA2LTI3ICBSb2IgQnVpcyAgPHJidWlzQGlnYWxpYS5jb20+CisKKyAgICAgICAgU2V0dGluZyB1 cmwuc2VhcmNoPSI/PyIgKHR3byBxdWVzdGlvbm1hcmtzKSBoYXMgaW5jb3JyZWN0IGJlaGF2aW9y CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0NTIK KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBVcGRhdGUg aW1wcm92ZWQgdGVzdCByZXN1bHQuCisKKyAgICAgICAgKiB3ZWItcGxhdGZvcm0tdGVzdHMvdXJs L3VybC1zZXR0ZXJzLWV4cGVjdGVkLnR4dDoKKwogMjAyMC0wNi0yNyAgUm9iIEJ1aXMgIDxyYnVp c0BpZ2FsaWEuY29tPgogCiAgICAgICAgIFJlcXVpcmUgPGZvcm0+IHRvIGJlIGNvbm5lY3RlZApk aWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dlYi1wbGF0Zm9ybS10ZXN0cy91 cmwvdXJsLXNldHRlcnMtZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvaW1wb3J0ZWQvdzNjL3dl Yi1wbGF0Zm9ybS10ZXN0cy91cmwvdXJsLXNldHRlcnMtZXhwZWN0ZWQudHh0CmluZGV4IGE1ODlh OWU3ODFlNDc5NDc0MTE3MzcwNmVmZDljMjk3ZjBmN2I5ZjQuLjdlNjhmYzI5ZDBhNjg5MDhiMThm MDM0OTMwMmI0N2I3MjNmOTA4YzcgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2ltcG9ydGVkL3cz Yy93ZWItcGxhdGZvcm0tdGVzdHMvdXJsL3VybC1zZXR0ZXJzLWV4cGVjdGVkLnR4dAorKysgYi9M YXlvdXRUZXN0cy9pbXBvcnRlZC93M2Mvd2ViLXBsYXRmb3JtLXRlc3RzL3VybC91cmwtc2V0dGVy cy1leHBlY3RlZC50eHQKQEAgLTU0MCw5ICs1NDAsOSBAQCBQQVNTIDxhcmVhPjogU2V0dGluZyA8 aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2VhcmNoID0gJ2xhbmc9ZnInCiBQ QVNTIFVSTDogU2V0dGluZyA8aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2Vh cmNoID0gJz9sYW5nPWZyJyAKIFBBU1MgPGE+OiBTZXR0aW5nIDxodHRwczovL2V4YW1wbGUubmV0 P2xhbmc9ZW4tVVMjbmF2Pi5zZWFyY2ggPSAnP2xhbmc9ZnInIAogUEFTUyA8YXJlYT46IFNldHRp bmcgPGh0dHBzOi8vZXhhbXBsZS5uZXQ/bGFuZz1lbi1VUyNuYXY+LnNlYXJjaCA9ICc/bGFuZz1m cicgCi1GQUlMIFVSTDogU2V0dGluZyA8aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25h dj4uc2VhcmNoID0gJz8/bGFuZz1mcicgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQgImh0dHBzOi8v ZXhhbXBsZS5uZXQvPz9sYW5nPWZyI25hdiIgYnV0IGdvdCAiaHR0cHM6Ly9leGFtcGxlLm5ldC8/ bGFuZz1mciNuYXYiCi1GQUlMIDxhPjogU2V0dGluZyA8aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5n PWVuLVVTI25hdj4uc2VhcmNoID0gJz8/bGFuZz1mcicgYXNzZXJ0X2VxdWFsczogZXhwZWN0ZWQg Imh0dHBzOi8vZXhhbXBsZS5uZXQvPz9sYW5nPWZyI25hdiIgYnV0IGdvdCAiaHR0cHM6Ly9leGFt cGxlLm5ldC8/bGFuZz1mciNuYXYiCi1GQUlMIDxhcmVhPjogU2V0dGluZyA8aHR0cHM6Ly9leGFt cGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2VhcmNoID0gJz8/bGFuZz1mcicgYXNzZXJ0X2VxdWFs czogZXhwZWN0ZWQgImh0dHBzOi8vZXhhbXBsZS5uZXQvPz9sYW5nPWZyI25hdiIgYnV0IGdvdCAi aHR0cHM6Ly9leGFtcGxlLm5ldC8/bGFuZz1mciNuYXYiCitQQVNTIFVSTDogU2V0dGluZyA8aHR0 cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2VhcmNoID0gJz8/bGFuZz1mcicgCitQ QVNTIDxhPjogU2V0dGluZyA8aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2Vh cmNoID0gJz8/bGFuZz1mcicgCitQQVNTIDxhcmVhPjogU2V0dGluZyA8aHR0cHM6Ly9leGFtcGxl Lm5ldD9sYW5nPWVuLVVTI25hdj4uc2VhcmNoID0gJz8/bGFuZz1mcicgCiBQQVNTIFVSTDogU2V0 dGluZyA8aHR0cHM6Ly9leGFtcGxlLm5ldD9sYW5nPWVuLVVTI25hdj4uc2VhcmNoID0gJz8nIAog UEFTUyA8YT46IFNldHRpbmcgPGh0dHBzOi8vZXhhbXBsZS5uZXQ/bGFuZz1lbi1VUyNuYXY+LnNl YXJjaCA9ICc/JyAKIFBBU1MgPGFyZWE+OiBTZXR0aW5nIDxodHRwczovL2V4YW1wbGUubmV0P2xh bmc9ZW4tVVMjbmF2Pi5zZWFyY2ggPSAnPycgCg==