170448 2017-04-04 04:10:10 -0700 AX: Don't crash if no renderer is available for AccessibilityRenderObject 2017-04-07 04:59:42 -0700 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 tpopela tpopela aboxhall apinheiro buildbot cfleizach dmazzoni jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1294016 0 tpopela 2017-04-04 04:10:10 -0700 Don't crash or assert if no renderer is available, but early return gracefully (as in other places in the AccessibilityRenderObject.cpp). Spotted by running some tests through dogtail. 1294020 1 306170 tpopela 2017-04-04 04:21:55 -0700 Created attachment 306170 Patch 1294021 2 webkit-bug-importer 2017-04-04 04:22:40 -0700 <rdar://problem/31425088> 1294028 3 306170 cfleizach 2017-04-04 07:01:54 -0700 Comment on attachment 306170 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306170&action=review > Source/WebCore/accessibility/AccessibilityRenderObject.cpp:535 > + return false; I think if this was true I would be more accurate 1294838 4 306372 tpopela 2017-04-06 02:48:47 -0700 Created attachment 306372 Patch 1295274 5 306372 tpopela 2017-04-07 04:59:36 -0700 Comment on attachment 306372 Patch Clearing flags on attachment: 306372 Committed r215089: <http://trac.webkit.org/changeset/215089> 1295275 6 tpopela 2017-04-07 04:59:42 -0700 All reviewed patches have been landed. Closing bug. 306170 2017-04-04 04:21:55 -0700 2017-04-06 02:48:43 -0700 Patch bug-170448-20170404132154.patch text/plain 2548 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODY4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYmFjYTUwNTE2M2M1MTk4 ODNjN2VmZWE3MDFkYmQzMjVkNWU4NTMzMi4uZGQwNjY4MzZmMzFmNDA4MDg5Nzg1M2NkNDBjZmUw MzNjNWQ4OWU4YyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTA0ICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgQVg6IERvbid0IGNyYXNo IGlmIG5vIHJlbmRlcmVyIGlzIGF2YWlsYWJsZSBmb3IgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNDQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qg Y3Jhc2ggb3IgYXNzZXJ0IGlmIG5vIHJlbmRlcmVyIGlzIGF2YWlsYWJsZSwgYnV0IGVhcmx5IHJl dHVybgorICAgICAgICBncmFjZWZ1bGx5IChhcyBpbiBvdGhlciBwbGFjZXMgaW4gdGhlIEFjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuY3BwKS4KKyAgICAgICAgU3BvdHRlZCBieSBydW5uaW5nIHNv bWUgdGVzdHMgdGhyb3VnaCBkb2d0YWlsLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3Q6OmlzT2ZmU2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3Q6OmlzVW52aXNpdGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3Q6OmlzVmlzaXRlZCk6CisKIDIwMTctMDQtMDQgIFBlciBBcm5l IFZvbGxhbiAgPHB2b2xsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIFVucmV2aWV3ZWQgV2luZG93 cyBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAppbmRleCAzNmY5YWVkNTAwOTdjMWNlYTU3 NjAxMWMzYjdiMTViYTEwNjIzZjVlLi44MDhjZDM2YWRmNzFiMjE2ZTdjOWM0NDVlNzFhNzdjMGM5 ODU3NDViIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3QuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv QWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKQEAgLTUzMSw3ICs1MzEsOSBAQCBib29sIEFj Y2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmlzRmlsZVVwbG9hZEJ1dHRvbigpIGNvbnN0CiAKIGJv b2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6aXNPZmZTY3JlZW4oKSBjb25zdAogewotICAg IEFTU0VSVChtX3JlbmRlcmVyKTsKKyAgICBpZiAoIW1fcmVuZGVyZXIpCisgICAgICAgIHJldHVy biBmYWxzZTsKKwogICAgIEludFJlY3QgY29udGVudFJlY3QgPSBzbmFwcGVkSW50UmVjdChtX3Jl bmRlcmVyLT5hYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKSk7CiAgICAgLy8gRklYTUU6IHVu Y2xlYXIgaWYgd2UgbmVlZCBMZWdhY3lJT1NEb2N1bWVudFZpc2libGVSZWN0LgogICAgIEludFJl Y3Qgdmlld1JlY3QgPSBtX3JlbmRlcmVyLT52aWV3KCkuZnJhbWVWaWV3KCkudmlzaWJsZUNvbnRl bnRSZWN0KFNjcm9sbGFibGVBcmVhOjpMZWdhY3lJT1NEb2N1bWVudFZpc2libGVSZWN0KTsKQEAg LTE1NjksMTIgKzE1NzEsMTggQEAgVVJMIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnVybCgp IGNvbnN0CiAKIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6aXNVbnZpc2l0ZWQoKSBj b25zdAogeworICAgIGlmICghbV9yZW5kZXJlcikKKyAgICAgICAgcmV0dXJuIHRydWU7CisKICAg ICAvLyBGSVhNRTogSXMgaXQgYSBwcml2YWN5IHZpb2xhdGlvbiB0byBleHBvc2UgdW52aXNpdGVk IGluZm9ybWF0aW9uIHRvIGFjY2Vzc2liaWxpdHkgQVBJcz8KICAgICByZXR1cm4gbV9yZW5kZXJl ci0+c3R5bGUoKS5pc0xpbmsoKSAmJiBtX3JlbmRlcmVyLT5zdHlsZSgpLmluc2lkZUxpbmsoKSA9 PSBJbnNpZGVVbnZpc2l0ZWRMaW5rOwogfQogCiBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmpl Y3Q6OmlzVmlzaXRlZCgpIGNvbnN0CiB7CisgICAgaWYgKCFtX3JlbmRlcmVyKQorICAgICAgICBy ZXR1cm4gZmFsc2U7CisKICAgICAvLyBGSVhNRTogSXMgaXQgYSBwcml2YWN5IHZpb2xhdGlvbiB0 byBleHBvc2UgdmlzaXRlZCBpbmZvcm1hdGlvbiB0byBhY2Nlc3NpYmlsaXR5IEFQSXM/CiAgICAg cmV0dXJuIG1fcmVuZGVyZXItPnN0eWxlKCkuaXNMaW5rKCkgJiYgbV9yZW5kZXJlci0+c3R5bGUo KS5pbnNpZGVMaW5rKCkgPT0gSW5zaWRlVmlzaXRlZExpbms7CiB9Cg== 306372 2017-04-06 02:48:47 -0700 2017-04-07 04:59:36 -0700 Patch bug-170448-20170406114845.patch text/plain 2608 tpopela U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MDAxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODYyNTg0MTc2Y2U3Y2Nm ZmUzNmFhNGJkZWNjOTFhNGRiMDM4OTRiNS4uNTc1N2RjNmY1YzNlZjk2NzFmN2MwZTg2NjM4MTRl MGNmMzQ4NjM5OSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE3LTA0LTA2ICBUb21h cyBQb3BlbGEgIDx0cG9wZWxhQHJlZGhhdC5jb20+CisKKyAgICAgICAgQVg6IERvbid0IGNyYXNo IGlmIG5vIHJlbmRlcmVyIGlzIGF2YWlsYWJsZSBmb3IgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVj dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNDQ4 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRG9uJ3Qg Y3Jhc2ggb3IgYXNzZXJ0IGlmIG5vIHJlbmRlcmVyIGlzIGF2YWlsYWJsZSwgYnV0IGVhcmx5IHJl dHVybgorICAgICAgICBncmFjZWZ1bGx5IChhcyBpbiBvdGhlciBwbGFjZXMgaW4gdGhlIEFjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3QuY3BwKS4KKyAgICAgICAgU3BvdHRlZCBieSBydW5uaW5nIHNv bWUgdGVzdHMgdGhyb3VnaCBkb2d0YWlsLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxp dHlSZW5kZXJPYmplY3Q6OmlzT2ZmU2NyZWVuKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li aWxpdHlSZW5kZXJPYmplY3Q6OmlzVW52aXNpdGVkKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vz c2liaWxpdHlSZW5kZXJPYmplY3Q6OmlzVmlzaXRlZCk6CisKIDIwMTctMDQtMDUgIFNpbW9uIEZy YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgU2V0IGxhc3RIYW5kbGVk VXNlckdlc3R1cmVUaW1lc3RhbXAgb24gYWxsIGFuY2VzdG9yIGRvY3VtZW50cywgbm90IGp1c3Qg dGhlIHRvcCBkb2N1bWVudApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9BY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2li aWxpdHkvQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdC5jcHAKaW5kZXggMzZmOWFlZDUwMDk3YzFj ZWE1NzYwMTFjM2I3YjE1YmExMDYyM2Y1ZS4uOTM0OTIzYjQwZjQwYzBkY2QzNWNhYTVmNTg1NmEx ZGY0MDcyZTdlMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BY2Nl c3NpYmlsaXR5UmVuZGVyT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmls aXR5L0FjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3QuY3BwCkBAIC01MzEsNyArNTMxLDkgQEAgYm9v bCBBY2Nlc3NpYmlsaXR5UmVuZGVyT2JqZWN0Ojppc0ZpbGVVcGxvYWRCdXR0b24oKSBjb25zdAog CiBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OmlzT2ZmU2NyZWVuKCkgY29uc3QKIHsK LSAgICBBU1NFUlQobV9yZW5kZXJlcik7CisgICAgaWYgKCFtX3JlbmRlcmVyKQorICAgICAgICBy ZXR1cm4gdHJ1ZTsKKwogICAgIEludFJlY3QgY29udGVudFJlY3QgPSBzbmFwcGVkSW50UmVjdCht X3JlbmRlcmVyLT5hYnNvbHV0ZUNsaXBwZWRPdmVyZmxvd1JlY3QoKSk7CiAgICAgLy8gRklYTUU6 IHVuY2xlYXIgaWYgd2UgbmVlZCBMZWdhY3lJT1NEb2N1bWVudFZpc2libGVSZWN0LgogICAgIElu dFJlY3Qgdmlld1JlY3QgPSBtX3JlbmRlcmVyLT52aWV3KCkuZnJhbWVWaWV3KCkudmlzaWJsZUNv bnRlbnRSZWN0KFNjcm9sbGFibGVBcmVhOjpMZWdhY3lJT1NEb2N1bWVudFZpc2libGVSZWN0KTsK QEAgLTE1NjksMTIgKzE1NzEsMTggQEAgVVJMIEFjY2Vzc2liaWxpdHlSZW5kZXJPYmplY3Q6OnVy bCgpIGNvbnN0CiAKIGJvb2wgQWNjZXNzaWJpbGl0eVJlbmRlck9iamVjdDo6aXNVbnZpc2l0ZWQo KSBjb25zdAogeworICAgIGlmICghbV9yZW5kZXJlcikKKyAgICAgICAgcmV0dXJuIHRydWU7CisK ICAgICAvLyBGSVhNRTogSXMgaXQgYSBwcml2YWN5IHZpb2xhdGlvbiB0byBleHBvc2UgdW52aXNp dGVkIGluZm9ybWF0aW9uIHRvIGFjY2Vzc2liaWxpdHkgQVBJcz8KICAgICByZXR1cm4gbV9yZW5k ZXJlci0+c3R5bGUoKS5pc0xpbmsoKSAmJiBtX3JlbmRlcmVyLT5zdHlsZSgpLmluc2lkZUxpbmso KSA9PSBJbnNpZGVVbnZpc2l0ZWRMaW5rOwogfQogCiBib29sIEFjY2Vzc2liaWxpdHlSZW5kZXJP YmplY3Q6OmlzVmlzaXRlZCgpIGNvbnN0CiB7CisgICAgaWYgKCFtX3JlbmRlcmVyKQorICAgICAg ICByZXR1cm4gZmFsc2U7CisKICAgICAvLyBGSVhNRTogSXMgaXQgYSBwcml2YWN5IHZpb2xhdGlv biB0byBleHBvc2UgdmlzaXRlZCBpbmZvcm1hdGlvbiB0byBhY2Nlc3NpYmlsaXR5IEFQSXM/CiAg ICAgcmV0dXJuIG1fcmVuZGVyZXItPnN0eWxlKCkuaXNMaW5rKCkgJiYgbV9yZW5kZXJlci0+c3R5 bGUoKS5pbnNpZGVMaW5rKCkgPT0gSW5zaWRlVmlzaXRlZExpbms7CiB9Cg==