170442 2017-04-04 01:49:25 -0700 Safari 10.1 JSON.parse returns incorrect object for numeric keys with decimal values 2017-04-26 11:49:32 -0700 1 1 1 Unclassified WebKit JavaScriptCore Safari 10 Mac macOS 10.12 RESOLVED FIXED InRadar P2 Normal --- 1 martin webkit-unassigned commit-queue fpizlo gskachkov mark.lam saam webkit-bug-importer webkit ysuzuki oldest_to_newest 1294007 0 martin 2017-04-04 01:49:25 -0700 Additional invalid key/value pairs are added if the object contains numeric keys with a decimal number for the first two keys whose 1st decimal place isn't 0. JSON.parse('{"0":97.1,"1000":96.5,"2000":96.1,"3000":97.4,"4000":90.4}') > {0: 97.1, 1: NaN, 2: NaN, 1000: 96.5, 2000: 96.1, 3000: 97.4, 4000: 90.4} If these are parseable to integers, this doesn't happen. JSON.parse('{"0":97.0,"1000":96.0,"2000":96.1,"3000":97.4,"4000":90.4}') > {0: 97, 1000: 96, 2000: 96.1, 3000: 97.4, 4000: 90.4} Nor does the problem occur if we replace the numeric values with strings. JSON.parse('{"0":"97.1","1000":"96.5","2000":"96.1","3000":"97.4","4000":"90.4"}') > {0: "97.1", 1000: "96.5", 2000: "96.1", 3000: "97.4", 4000: "90.4"} 1294306 1 ap 2017-04-04 17:39:02 -0700 <rdar://problems/31442949> 1297115 2 gskachkov 2017-04-13 13:30:14 -0700 I can't reproduce this issue on current version of JSC, and it looks like duplicate of the fixed https://bugs.webkit.org/show_bug.cgi?id=164412 1297266 3 saam 2017-04-13 19:03:23 -0700 (In reply to GSkachkov from comment #2) > I can't reproduce this issue on current version of JSC, and it looks like > duplicate of the fixed https://bugs.webkit.org/show_bug.cgi?id=164412 Could you add a test for this to make sure we don't regress it in the future? 1297348 4 307100 gskachkov 2017-04-14 00:19:59 -0700 Created attachment 307100 Patch Added additional tests 1297363 5 307100 ysuzuki 2017-04-14 01:28:56 -0700 Comment on attachment 307100 Patch r=me 1297367 6 307100 commit-queue 2017-04-14 02:08:55 -0700 Comment on attachment 307100 Patch Clearing flags on attachment: 307100 Committed r215360: <http://trac.webkit.org/changeset/215360> 1297368 7 commit-queue 2017-04-14 02:08:57 -0700 All reviewed patches have been landed. Closing bug. 1301605 8 webkit 2017-04-26 09:01:27 -0700 It's the same problem even when the first key isn't 0, for JSON.parse and JSON.stringify. JSON.stringify({ 8: 13.2, 111544: 132}) > "{\"0\":null,\"1\":null,\"2\":null,\"3\":null,\"4\":null,\"5\":null,\"6\":null,\"7\":null,\"8\":13.2,\"111544\":132}" If these are parseable to integers, this doesn't happen either. JSON.stringify({ 8: 132, 111544: 132}) > "{\"8\":132,\"111544\":132}" And in the other way : JSON.parse("{\"8\":13.2,\"111544\":132}"); > {0: NaN, 1: NaN, 2: NaN, 3: NaN, 4: NaN, 5: NaN, 6: NaN, 7: NaN, 8: 13.2, 111544: 132} I guess tests for theses cases should also be added, but I'm sorry, I'm new here and I don't know how to do it. 1301710 9 saam 2017-04-26 11:49:32 -0700 (In reply to PiwEL from comment #8) > It's the same problem even when the first key isn't 0, for JSON.parse and > JSON.stringify. > > JSON.stringify({ 8: 13.2, 111544: 132}) > > "{\"0\":null,\"1\":null,\"2\":null,\"3\":null,\"4\":null,\"5\":null,\"6\":null,\"7\":null,\"8\":13.2,\"111544\":132}" > > If these are parseable to integers, this doesn't happen either. > JSON.stringify({ 8: 132, 111544: 132}) > > "{\"8\":132,\"111544\":132}" > > > And in the other way : > JSON.parse("{\"8\":13.2,\"111544\":132}"); > > {0: NaN, 1: NaN, 2: NaN, 3: NaN, 4: NaN, 5: NaN, 6: NaN, 7: NaN, 8: 13.2, 111544: 132} > > I guess tests for theses cases should also be added, but I'm sorry, I'm new > here and I don't know how to do it. Thanks for giving us this test case. We already added a test similar to this. 307100 2017-04-14 00:19:59 -0700 2017-04-14 02:08:55 -0700 Patch bug-170442-20170414101957.patch text/plain 2910 gskachkov U3VidmVyc2lvbiBSZXZpc2lvbjogMjE1MzU3CmRpZmYgLS1naXQgYS9KU1Rlc3RzL0NoYW5nZUxv ZyBiL0pTVGVzdHMvQ2hhbmdlTG9nCmluZGV4IDNkZWJlZTk2MmM2ZTI3ZDNmZWFkOTQ1YTgxYzA1 MmM4ZWQzNGFlNjUuLjMwOTQ4YWFjNjQ0YzIzMDEzZDlkY2U2YTRjZjdkZTA5Nzg3ODFlMzEgMTAw NjQ0Ci0tLSBhL0pTVGVzdHMvQ2hhbmdlTG9nCisrKyBiL0pTVGVzdHMvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTIgQEAKKzIwMTctMDQtMTQgIE9sZWtzYW5kciBTa2FjaGtvdiAgPGdza2FjaGtvdkBn bWFpbC5jb20+CisKKyAgICAgICAgU2FmYXJpIDEwLjEgSlNPTi5wYXJzZSByZXR1cm5zIGluY29y cmVjdCBvYmplY3QgZm9yIG51bWVyaWMga2V5cyB3aXRoIGRlY2ltYWwgdmFsdWVzCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0NDIKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHN0cmVzcy9vYmplY3Qt bnVtYmVyLXByb3BlcnRpZXMuanM6CisKIDIwMTctMDQtMTMgIE1hcmsgTGFtICA8bWFyay5sYW1A YXBwbGUuY29tPgogCiAgICAgICAgIFNob3VsZCB1c2UgZmx1c2hEaXJlY3QoKSB3aGVuIGZsdXNo aW5nIHRoZSBzY29wZVJlZ2lzdGVyIGR1ZSB0byBuZWVkc1Njb3BlUmVnaXN0ZXIoKS4KZGlmZiAt LWdpdCBhL0pTVGVzdHMvc3RyZXNzL29iamVjdC1udW1iZXItcHJvcGVydGllcy5qcyBiL0pTVGVz dHMvc3RyZXNzL29iamVjdC1udW1iZXItcHJvcGVydGllcy5qcwppbmRleCA3MTQyZWYxYmQxMzFj MDU4MTE2YjkzMWUyMjBjMGYyOWVmNDUxODc1Li4yYzBkYWNjZDljYmJjMTI1NWExNjRjZTZjZWUw YWFhMTRlNjdlZTFlIDEwMDY0NAotLS0gYS9KU1Rlc3RzL3N0cmVzcy9vYmplY3QtbnVtYmVyLXBy b3BlcnRpZXMuanMKKysrIGIvSlNUZXN0cy9zdHJlc3Mvb2JqZWN0LW51bWJlci1wcm9wZXJ0aWVz LmpzCkBAIC03OSw0ICs3OSw3MCBAQCB2YXIgYmF6ID0gewogYXNzZXJ0KE9iamVjdC5rZXlzKGJh eikubGVuZ3RoLCAyKTsKIGFzc2VydChPYmplY3QudmFsdWVzKGJheikubGVuZ3RoLCAyKTsKIGFz c2VydChiYXpbMjUwXSwgIkEiKTsKLWFzc2VydChiYXpbMTAwMV0sICJCIik7ClwgTm8gbmV3bGlu ZSBhdCBlbmQgb2YgZmlsZQorYXNzZXJ0KGJhelsxMDAxXSwgIkIiKTsKKwordmFyIGJhciA9IEpT T04ucGFyc2UoJ3siMCI6OTcuMSwiMTAwMCI6OTYuNSwiMjAwMCI6OTYuMSwiMzAwMCI6OTcuNCwi NDAwMCI6OTAuNH0nKTsKKworYXNzZXJ0KE9iamVjdC5rZXlzKGJhcikubGVuZ3RoLCA1KTsKK2Fz c2VydChiYXJbMF0sIDk3LjEpOworYXNzZXJ0KGJhclsxMDAwXSwgOTYuNSk7Cithc3NlcnQoYmFy WzIwMDBdLCA5Ni4xKTsKK2Fzc2VydChiYXJbMzAwMF0sIDk3LjQpOworYXNzZXJ0KGJhcls0MDAw XSwgOTAuNCk7CisKK2JhciA9IEpTT04ucGFyc2UoJ3siMCI6OTcuMSwgIjI1MCI6IDY1LjMsICIx MDAwIjo5Ni41LCIyMDAwIjo5Ni4xLCIzMDAwIjo5Ny40LCI0MDAwIjo5MC40fScpOworCithc3Nl cnQoT2JqZWN0LmtleXMoYmFyKS5sZW5ndGgsIDYpOworCithc3NlcnQoYmFyWzBdLCA5Ny4xKTsK K2Fzc2VydChiYXJbMjUwXSwgNjUuMyk7Cithc3NlcnQoYmFyWzEwMDBdLCA5Ni41KTsKK2Fzc2Vy dChiYXJbMjAwMF0sIDk2LjEpOworYXNzZXJ0KGJhclszMDAwXSwgOTcuNCk7Cithc3NlcnQoYmFy WzQwMDBdLCA5MC40KTsKKworYmFyID0gSlNPTi5wYXJzZSgneyIwIjo5Ny4xLCAiMjUwIjogbnVs bCwgIjEwMDAiOjk2LjUsIjIwMDAiOjk2LjEsIjMwMDAiOjk3LjQsIjQwMDAiOjkwLjR9Jyk7CisK K2Fzc2VydChPYmplY3Qua2V5cyhiYXIpLmxlbmd0aCwgNik7CisKK2Fzc2VydChiYXJbMF0sIDk3 LjEpOworYXNzZXJ0KGJhclsyNTBdLCBudWxsKTsKK2Fzc2VydChiYXJbMTAwMF0sIDk2LjUpOwor YXNzZXJ0KGJhclsyMDAwXSwgOTYuMSk7Cithc3NlcnQoYmFyWzMwMDBdLCA5Ny40KTsKK2Fzc2Vy dChiYXJbNDAwMF0sIDkwLjQpOworCisKK2JhciA9IGV2YWwoJygoKT0+KHsiMCI6OTcuMSwgIjI1 MCI6IDY1LjMsICIxMDAwIjo5Ni41LCIyMDAwIjo5Ni4xLCIzMDAwIjo5Ny40LCI0MDAwIjo5MC40 fSkpKCk7Jyk7CisKK2Fzc2VydChPYmplY3Qua2V5cyhiYXIpLmxlbmd0aCwgNik7CisKK2Fzc2Vy dChiYXJbMF0sIDk3LjEpOworYXNzZXJ0KGJhclsyNTBdLCA2NS4zKTsKK2Fzc2VydChiYXJbMTAw MF0sIDk2LjUpOworYXNzZXJ0KGJhclsyMDAwXSwgOTYuMSk7Cithc3NlcnQoYmFyWzMwMDBdLCA5 Ny40KTsKK2Fzc2VydChiYXJbNDAwMF0sIDkwLjQpOworCitiYXIgPSBldmFsKCcoKCk9Pih7IjAi Ojk3LjEsICIyNTAiOiBudWxsLCAiMTAwMCI6OTYuNSwiMjAwMCI6OTYuMSwiMzAwMCI6OTcuNCwi NDAwMCI6OTAuNH0pKSgpOycpOworCithc3NlcnQoT2JqZWN0LmtleXMoYmFyKS5sZW5ndGgsIDYp OworCithc3NlcnQoYmFyWzBdLCA5Ny4xKTsKK2Fzc2VydChiYXJbMjUwXSwgbnVsbCk7Cithc3Nl cnQoYmFyWzEwMDBdLCA5Ni41KTsKK2Fzc2VydChiYXJbMjAwMF0sIDk2LjEpOworYXNzZXJ0KGJh clszMDAwXSwgOTcuNCk7Cithc3NlcnQoYmFyWzQwMDBdLCA5MC40KTsKKworCitiYXIgPSBldmFs KCcoKCk9Pih7IjAiOjk3LjEsICIyNTAiOiBOYU4sICIxMDAwIjo5Ni41LCIyMDAwIjo5Ni4xLCIz MDAwIjo5Ny40LCI0MDAwIjo5MC40fSkpKCk7Jyk7CisKK2Fzc2VydChPYmplY3Qua2V5cyhiYXIp Lmxlbmd0aCwgNik7CisKK2Fzc2VydChiYXJbMF0sIDk3LjEpOworYXNzZXJ0KGlzTmFOKGJhclsy NTBdKSwgdHJ1ZSk7Cithc3NlcnQoYmFyWzEwMDBdLCA5Ni41KTsKK2Fzc2VydChiYXJbMjAwMF0s IDk2LjEpOworYXNzZXJ0KGJhclszMDAwXSwgOTcuNCk7Cithc3NlcnQoYmFyWzQwMDBdLCA5MC40 KTsK