170439 2017-04-03 19:14:07 -0700 [CMake] Enforce Python 2 2017-04-05 11:10:08 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ross.kirsling webkit-unassigned achristensen bfulgham commit-queue dbates dburkart don.olmstead fujii jbedard lforschler oldest_to_newest 1293963 0 ross.kirsling 2017-04-03 19:14:07 -0700 Since WebKit's Python scripts only support 2.7.x, CMake should fail immediately upon discovering 3.x.x -- we shouldn't let the build run for potentially tens of minutes before a syntax error is finally encountered. 1293965 1 306156 ross.kirsling 2017-04-03 19:23:20 -0700 Created attachment 306156 Patch 1294086 2 306156 bfulgham 2017-04-04 11:38:54 -0700 Comment on attachment 306156 Patch This seems like a good idea! r=me. 1294096 3 306156 commit-queue 2017-04-04 12:06:49 -0700 Comment on attachment 306156 Patch Clearing flags on attachment: 306156 Committed r214886: <http://trac.webkit.org/changeset/214886> 1294097 4 commit-queue 2017-04-04 12:06:51 -0700 All reviewed patches have been landed. Closing bug. 1294485 5 achristensen 2017-04-05 07:05:10 -0700 Why don't we just fix the problems with python 3 and support it? I think that's a better plan long-term. 1294546 6 ross.kirsling 2017-04-05 10:22:44 -0700 For sure. I figured this was a less controversial change to start with though, and might get more people to ask the question you just asked. :P I'd be happy to update the scripts as a follow-up task, but I'm worried about how to ensure they *stay* compatible thereafter...? 1294547 7 achristensen 2017-04-05 10:24:27 -0700 I could uninstall python2 and install python3 on at least my bot on build.webkit.org once it works, and then if it breaks the breakage would be noticed. 1294555 8 don.olmstead 2017-04-05 10:40:43 -0700 (In reply to Alex Christensen from comment #7) > I could uninstall python2 and install python3 on at least my bot on > build.webkit.org once it works, and then if it breaks the breakage would be > noticed. There are automated tools we can run scripts through https://docs.python.org/3/howto/pyporting.html. There is a bug for Python 3 support at https://bugs.webkit.org/show_bug.cgi?id=156674 1294562 9 achristensen 2017-04-05 10:50:52 -0700 Could it be sustainable to support python2 and python3? If not, then we should just require python2 1294569 10 don.olmstead 2017-04-05 11:10:08 -0700 (In reply to Alex Christensen from comment #9) > Could it be sustainable to support python2 and python3? If not, then we > should just require python2 It sounds like its doable. I'm just not sure how much of a change it will be in the existing python code base. We can try running some of the automated tools over the tests and see how much the code changes. 306156 2017-04-03 19:23:20 -0700 2017-04-04 12:06:49 -0700 Patch bug-170439-20170403192319.patch text/plain 1377 ross.kirsling U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0ODI3CmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvV2Vi S2l0Q29tbW9uLmNtYWtlIGIvU291cmNlL2NtYWtlL1dlYktpdENvbW1vbi5jbWFrZQppbmRleCA4 YjUwYzlkOTRjMGI5ODM3Nzk0MjQ5MzlkMGMzMjY5NWIxZGVlYzVmLi5iMGFlNTE0MGY4YTkwYmM3 MjI2YzdjMzMwYWZmYzE3ZjdmZmZjZmIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvY21ha2UvV2ViS2l0 Q29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2UKQEAgLTIw LDYgKzIwLDkgQEAgaWYgKE5PVCBIQVNfUlVOX1dFQktJVF9DT01NT04pCiAgICAgZmluZF9wYWNr YWdlKFBlcmwgNS4xMC4wIFJFUVVJUkVEKQogCiAgICAgZmluZF9wYWNrYWdlKFB5dGhvbkludGVy cCAyLjcuMCBSRVFVSVJFRCkKKyAgICBpZiAoUFlUSE9OX1ZFUlNJT05fTUFKT1IgR1JFQVRFUiAy KQorICAgICAgICBtZXNzYWdlKEZBVEFMX0VSUk9SICJQeXRob24gMiBpcyByZXF1aXJlZCwgYnV0 IFB5dGhvbiAke1BZVEhPTl9WRVJTSU9OX01BSk9SfSB3YXMgZm91bmQuIikKKyAgICBlbmRpZiAo KQogCiAgICAgIyBXZSBjYW5ub3QgY2hlY2sgZm9yIFJVQllfRk9VTkQgYmVjYXVzZSBpdCBpcyBz ZXQgb25seSB3aGVuIHRoZSBmdWxsIHBhY2thZ2UgaXMgaW5zdGFsbGVkIGFuZAogICAgICMgdGhl IG9ubHkgdGhpbmcgd2UgbmVlZCBpcyB0aGUgaW50ZXJwcmV0ZXIuIFVubGlrZSBQeXRob24sIGNt YWtlIGRvZXMgbm90IHByb3ZpZGUgYSBtYWNybwpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hh bmdlTG9nCmluZGV4IDRkOGNkNzNjMTZiZDZiNTE0ZDhjNDg1OTBiMWNjOGU3MmU4MWRjODEuLjM2 ODM2ODgwNzE4ZGJlZTU5MTAxZTU4Yjc5MGVhZWNmNjNmZTUzODIgMTAwNjQ0Ci0tLSBhL0NoYW5n ZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMiBAQAorMjAxNy0wNC0wMyAgUm9zcyBL aXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CisKKyAgICAgICAgW0NNYWtlXSBFbmZv cmNlIFB5dGhvbiAyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzA0MzkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIFNvdXJjZS9jbWFrZS9XZWJLaXRDb21tb24uY21ha2U6IEZhaWwgYnVpbGQgaW1tZWRp YXRlbHkgaWYgUHl0aG9uIDMgaXMgZGV0ZWN0ZWQuCisKIDIwMTctMDMtMjQgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIEFkZCBNSU1F VHlwZVJlZ2lzdHJ5IGltcGxlbWVudGF0aW9uIHVzaW5nIHhkZ21pbWUgYW5kIHJlbW92ZSB0aGUg R1RLKyBvbmUK