170429 2017-04-03 15:46:42 -0700 Add some new patterns to filter-build-webkit 2017-04-03 23:52:36 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue dino joepeck lforschler mitz simon.fraser thorton oldest_to_newest 1293880 0 joepeck 2017-04-03 15:46:42 -0700 Add some new patterns to filter-build-webkit The following show up as STYLE_ALERT (red) and should be STYLE_PLAIN (white) + simplified / skipped: CompileStoryboard ios/Launch.storyboard => CompileStoryboard Launch.storyboard LinkStoryboards => LinkStoryboards Validate /Build/Release-iphoneos/DumpRenderTree.app => Validate DumpRenderTree.app GenerateTAPI /Build/Release-iphoneos/WebKit.framework/WebKit.tbd normal arm64 => GenerateTAPI WebKit.tbd make[2]: Nothing to be done for `all'. => Skipped. 1293881 1 306133 joepeck 2017-04-03 15:47:17 -0700 Created attachment 306133 [PATCH] Proposed Fix 1294000 2 306133 commit-queue 2017-04-03 23:52:34 -0700 Comment on attachment 306133 [PATCH] Proposed Fix Clearing flags on attachment: 306133 Committed r214866: <http://trac.webkit.org/changeset/214866> 1294001 3 commit-queue 2017-04-03 23:52:36 -0700 All reviewed patches have been landed. Closing bug. 306133 2017-04-03 15:47:17 -0700 2017-04-03 23:52:34 -0700 [PATCH] Proposed Fix patterns-1.patch text/plain 3057 joepeck ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5MzY4 NjZmNmI5ZS4uOTVlMzY0OTNkYjQgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysgYi9U b29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNC0wMyAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIEFkZCBzb21lIG5ldyBwYXR0ZXJu cyB0byBmaWx0ZXItYnVpbGQtd2Via2l0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0xNzA0MjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICAqIFNjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdDoKKyAgICAgICAg KHNldE91dHB1dEZvcm1hdE9wdGlvbik6CisKIDIwMTctMDQtMDEgIEFsZXhleSBQcm9za3VyeWFr b3YgIDxhcEBhcHBsZS5jb20+CiAKICAgICAgICAgUm9sbGluZyBiYWNrIDxodHRwczovL3RyYWMu d2Via2l0Lm9yZy9yMjE0Njk3PiwgYXMgaXQgbWFkZSBXZWJLaXQyLkRhdGFEZXRlY3Rpb25SZWZl cmVuY2VEYXRlIHRpbWUgb3V0LgpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVp bGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVpbGQtd2Via2l0CmluZGV4IDkyMGQw YWQyODY5Li40MWNlMDE3ZTJhYiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9maWx0ZXItYnVp bGQtd2Via2l0CisrKyBiL1Rvb2xzL1NjcmlwdHMvZmlsdGVyLWJ1aWxkLXdlYmtpdApAQCAtMTM4 LDExICsxMzgsMTEgQEAgZm9yIChteSAkcHJldmlvdXNMaW5lID0gIiIsIG15ICRsaW5lID0gPD47 ICRsaW5lOyAkcHJldmlvdXNMaW5lID0gJGxpbmUsICRsaW5lID0KICAgICAgICAgJGJ1aWxkRmlu aXNoZWQgPSAxOwogICAgIH0gZWxzaWYgKCRsaW5lID1+IC9ePT09LykgewogICAgICAgICBwcmlu dExpbmUoJGxpbmUsIFNUWUxFX0hFQURFUik7Ci0gICAgfSBlbHNpZiAoJGxpbmUgPX4gL0NoZWNr aW5nIERlcGVuZGVuY2llc3xDaGVjayBkZXBlbmRlbmNpZXN8Q3JlYXRlIHByb2R1Y3Qgc3RydWN0 dXJlfFdyaXRlIGF1eGlsaWFyeSBmaWxlcy8pIHsKKyAgICB9IGVsc2lmICgkbGluZSA9fiAvQ2hl Y2tpbmcgRGVwZW5kZW5jaWVzfENoZWNrIGRlcGVuZGVuY2llc3xDcmVhdGUgcHJvZHVjdCBzdHJ1 Y3R1cmV8V3JpdGUgYXV4aWxpYXJ5IGZpbGVzfExpbmtTdG9yeWJvYXJkcy8pIHsKICAgICAgICAg cHJpbnRMaW5lKCRsaW5lLCBTVFlMRV9QTEFJTik7CiAgICAgfSBlbHNpZiAoJGxpbmUgPX4gL1wq XCogQlVJTEQgU1VDQ0VFREVEIFwqXCovKSB7CiAgICAgICAgIHByaW50TGluZSgiQnVpbGQgU3Vj Y2VlZGVkIiwgU1RZTEVfU1VDQ0VTUyk7Ci0gICAgfSBlbHNpZiAoJGxpbmUgPX4gL14oXGVcWzFt KT8oUGhhc2VTY3JpcHRFeGVjdXRpb258Q2xDb21waWxlfENvbXBpbGVDfERpc3RyaWJ1dGVkLUNv bXBpbGVDfExkfFBCWENwfENwUmVzb3VyY2V8Q29weVBOR0ZpbGV8Q29weVRpZmZGaWxlfENwSGVh ZGVyfFByZXByb2Nlc3N8UHJvY2Vzc2luZ3xQcm9jZXNzSW5mb1BsaXN0RmlsZXxQcm9jZXNzUENI fFByb2Nlc3NQQ0hcK1wrfFRvdWNofExpYnRvb2x8Q29weVN0cmluZ3NGaWxlfE1pZ3xDcmVhdGVV bml2ZXJzYWxCaW5hcnl8QW5hbHl6ZXxBbmFseXplU2hhbGxvd3xQcm9jZXNzUHJvZHVjdFBhY2th Z2luZ3xDb2RlU2lnbnxTeW1MaW5rfFVwZGF0aW5nfENvbXBpbGVEVHJhY2VTY3JpcHR8Q29tcGls ZVhJQnxTdHJpcE5JQnxDb3B5UGxpc3RGaWxlfEdlbmVyYXRlRFNZTUZpbGV8RXh0ZXJuYWxCdWls ZFRvb2xFeGVjdXRpb24pKFxlXFswbSk/ICgiW14iXSsifChcXHwoPzw9XFwpXHN8XFMpKyk/Lykg eworICAgIH0gZWxzaWYgKCRsaW5lID1+IC9eKFxlXFsxbSk/KFBoYXNlU2NyaXB0RXhlY3V0aW9u fENsQ29tcGlsZXxDb21waWxlQ3xEaXN0cmlidXRlZC1Db21waWxlQ3xMZHxQQlhDcHxDcFJlc291 cmNlfENvcHlQTkdGaWxlfENvcHlUaWZmRmlsZXxDcEhlYWRlcnxQcmVwcm9jZXNzfFByb2Nlc3Np bmd8UHJvY2Vzc0luZm9QbGlzdEZpbGV8UHJvY2Vzc1BDSHxQcm9jZXNzUENIXCtcK3xUb3VjaHxM aWJ0b29sfENvcHlTdHJpbmdzRmlsZXxNaWd8Q3JlYXRlVW5pdmVyc2FsQmluYXJ5fEFuYWx5emV8 QW5hbHl6ZVNoYWxsb3d8UHJvY2Vzc1Byb2R1Y3RQYWNrYWdpbmd8Q29kZVNpZ258VmFsaWRhdGV8 U3ltTGlua3xVcGRhdGluZ3xDb21waWxlRFRyYWNlU2NyaXB0fENvbXBpbGVYSUJ8U3RyaXBOSUJ8 Q29weVBsaXN0RmlsZXxHZW5lcmF0ZURTWU1GaWxlfEdlbmVyYXRlVEFQSXxDb21waWxlU3Rvcnli b2FyZHxFeHRlcm5hbEJ1aWxkVG9vbEV4ZWN1dGlvbikoXGVcWzBtKT8gKCJbXiJdKyJ8KFxcfCg/ PD1cXClcc3xcUykrKT8vKSB7CiAgICAgICAgIG15ICgkY29tbWFuZCwgJHBhdGgpID0gKCQyLCBi YXNlbmFtZSgkNCkpOwogICAgICAgICAkcGF0aCA9fiBzLygifFxcfFwuW2FoXSQpLy9nOwogICAg ICAgICBwcmludExpbmUoIiRjb21tYW5kICRwYXRoIiwgU1RZTEVfUExBSU4pOwpAQCAtMjM1LDcg KzIzNSw3IEBAIHN1YiBzaG91bGRJZ25vcmVMaW5lKCQkKQogCiAgICAgcmV0dXJuIDEgaWYgJGxp bmUgPX4gL15ccyokLzsKICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvXkJ1aWxkIHNldHRpbmdz IGZyb20gY29tbWFuZCBsaW5lOi87Ci0gICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4gL21ha2U6IE5v dGhpbmcgdG8gYmUgZG9uZSBmb3IgYGFsbCdcLi87CisgICAgcmV0dXJuIDEgaWYgJGxpbmUgPX4g L21ha2UoXFtcZCtcXSk/OiBOb3RoaW5nIHRvIGJlIGRvbmUgZm9yIGBhbGwnXC4vOwogICAgIHJl dHVybiAxIGlmICRsaW5lID1+IC9eSmF2YVNjcmlwdENvcmVcL2NyZWF0ZV9oYXNoX3RhYmxlLzsK ICAgICByZXR1cm4gMSBpZiAkbGluZSA9fiAvSmF2YVNjcmlwdENvcmUuZnJhbWV3b3JrXC9Qcml2 YXRlSGVhZGVyc1wvY3JlYXRlX2hhc2hfdGFibGUvOwogICAgIHJldHVybiAxIGlmICRsaW5lID1+ IC9eSmF2YVNjcmlwdENvcmVcL3BjcmVcL2RmdGFibGVzLzsK