170420 2017-04-03 14:23:17 -0700 Web Inspector: "Space" is not localizable in Timelines record button tooltips 2017-04-03 15:06:29 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck bburg commit-queue inspector-bugzilla-changes joepeck timothy webkit-bug-importer oldest_to_newest 1293801 0 joepeck 2017-04-03 14:23:17 -0700 Summary: "Space" is not localizable in Timelines record button tooltips Steps to Reproduce: 1. Inspect this page 2. Show Timelines tab 3. Show Tooltip for Record button => "Start Recording (Space)" Notes: The "Start Recording" part is localizable, but the keyboard shortcut part "Space" is not. It should be. 1293804 1 joepeck 2017-04-03 14:23:30 -0700 <rdar://problem/30871371> 1293808 2 306116 joepeck 2017-04-03 14:26:34 -0700 Created attachment 306116 [PATCH] Proposed Fix 1293823 3 306116 bburg 2017-04-03 14:50:12 -0700 Comment on attachment 306116 [PATCH] Proposed Fix r=me too :) 1293836 4 306116 commit-queue 2017-04-03 15:06:27 -0700 Comment on attachment 306116 [PATCH] Proposed Fix Clearing flags on attachment: 306116 Committed r214841: <http://trac.webkit.org/changeset/214841> 1293837 5 commit-queue 2017-04-03 15:06:29 -0700 All reviewed patches have been landed. Closing bug. 306116 2017-04-03 14:26:34 -0700 2017-04-03 15:06:27 -0700 [PATCH] Proposed Fix space-1.patch text/plain 6109 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFjNDJiNDUwMGVmLi5kZWZkNGU5NzUxYSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjggQEAKIDIwMTctMDQtMDMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KIAorICAgICAgICBXZWIgSW5zcGVjdG9y OiAiU3BhY2UiIGlzIG5vdCBsb2NhbGl6YWJsZSBpbiBUaW1lbGluZXMgcmVjb3JkIGJ1dHRvbiB0 b29sdGlwcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTcwNDIwCisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDg3MTM3MT4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvQmFzZS9M b2FkTG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci51bmxvY2FsaXpl ZFN0cmluZyk6CisgICAgICAgIChXZWJJbnNwZWN0b3IuVUlTdHJpbmcpOgorICAgICAgICAqIFVz ZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzOgorICAgICAgICBNb3ZlIFVJU3RyaW5nIC8gdW5sb2Nh bGl6ZWRTdHJpbmcgdG8gTG9hZExvY2FsaXplZFN0cmluZy5qcy4KKyAgICAgICAgVGhleSBtYXkg YmUgbmVlZGVkIGJlZm9yZSBNYWluLmpzIGhhcyBpbnRyb2R1Y2VkIGl0LgorCisgICAgICAgICog VXNlckludGVyZmFjZS9UZXN0L1Rlc3QuanM6CisgICAgICAgIFByb3ZpZGUgYSBkZWZhdWx0IGlt cGxlbWVudGFpdG9uIG9mIHVubG9jYWxpemVkU3RyaW5nLgorCisgICAgICAgICogTG9jYWxpemF0 aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzOgorICAgICAgICAqIFVzZXJJbnRlcmZh Y2UvTW9kZWxzL0tleWJvYXJkU2hvcnRjdXQuanM6CisgICAgICAgIE1vc3Qga2V5cyB1c2UgYSBz eW1ib2wgdG8gcmVwcmVzZW50IHRoZSBrZXkuICJTcGFjZSIgd2FzIHRoZSBvbmUKKyAgICAgICAg ZXhjZXB0aW9uLCBzbyB1c2UgYSBsb2NhbGl6ZWQgc3RyaW5nLgorCisyMDE3LTA0LTAzICBKb3Nl cGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKICAgICAgICAgV2ViIEluc3BlY3Rv cjogVG9vbHRpcCBmb3IgY2xvc2UgdGFiIGJ1dHRvbiBzaG91bGQgbWF0Y2ggU2FmYXJpCiAgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzA0MTcKICAgICAg ICAgPHJkYXI6Ly9wcm9ibGVtLzMxMzc4NDIzPgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJj ZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3Mu anMKaW5kZXggMmNlOTFmNmEzMzcuLmM1YjEzNzNiYTAwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCisr KyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXpl ZFN0cmluZ3MuanMKQEAgLTc2Nyw2ICs3NjcsNyBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJTb3J0IEFz Y2VuZGluZyJdID0gIlNvcnQgQXNjZW5kaW5nIjsKIGxvY2FsaXplZFN0cmluZ3NbIlNvcnQgRGVz Y2VuZGluZyJdID0gIlNvcnQgRGVzY2VuZGluZyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJTb3VyY2Ui XSA9ICJTb3VyY2UiOwogbG9jYWxpemVkU3RyaW5nc1siU291cmNlcyJdID0gIlNvdXJjZXMiOwor bG9jYWxpemVkU3RyaW5nc1siU3BhY2UiXSA9ICJTcGFjZSI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJT cGFjZXMiXSA9ICJTcGFjZXMiOwogbG9jYWxpemVkU3RyaW5nc1siU3BhY2luZyJdID0gIlNwYWNp bmciOwogbG9jYWxpemVkU3RyaW5nc1siU3BlY2lmaWNpdHk6ICglZCwgJWQsICVkKSJdID0gIlNw ZWNpZmljaXR5OiAoJWQsICVkLCAlZCkiOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9Mb2FkTG9jYWxpemVkU3RyaW5ncy5qcyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTG9hZExvY2FsaXplZFN0cmluZ3MuanMK aW5kZXggODRjNmUwOGZlZTguLmFmZDlkODJiNzg2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL0xvYWRMb2NhbGl6ZWRTdHJpbmdzLmpzCisrKyBi L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvTG9hZExvY2FsaXplZFN0 cmluZ3MuanMKQEAgLTMyLDMgKzMyLDMwIEBACiAgICAgaWYgKGxvY2FsaXplZFN0cmluZ3NVUkwp CiAgICAgICAgIGRvY3VtZW50LndyaXRlKCI8c2NyaXB0IHNyYz1cIiIgKyBsb2NhbGl6ZWRTdHJp bmdzVVJMICsgIlwiPjwvc2NyaXB0PiIpOwogfSkoKTsKKworV2ViSW5zcGVjdG9yLnVubG9jYWxp emVkU3RyaW5nID0gZnVuY3Rpb24oc3RyaW5nKQoreworICAgIC8vIEludGVudGlvbmFsbHkgZG8g bm90aGluZywgc2luY2UgdGhpcyBpcyBmb3IgZW5naW5lZXJpbmcgYnVpbGRzCisgICAgLy8gKHN1 Y2ggYXMgaW4gRGVidWcgVUkpIG9yIGluIHRleHQgdGhhdCBpcyBzdGFuZGFyZGl6ZWQgaW4gRW5n bGlzaC4KKyAgICAvLyBGb3IgZXhhbXBsZSwgQ1NTIHByb3BlcnR5IG5hbWVzIGFuZCB2YWx1ZXMg YXJlIG5ldmVyIGxvY2FsaXplZC4KKyAgICByZXR1cm4gc3RyaW5nOworfTsKKworV2ViSW5zcGVj dG9yLlVJU3RyaW5nID0gZnVuY3Rpb24oc3RyaW5nLCB2YXJhcmcpCit7CisgICAgaWYgKFdlYklu c3BlY3Rvci5kb250TG9jYWxpemVVc2VySW50ZXJmYWNlKQorICAgICAgICByZXR1cm4gc3RyaW5n OworCisgICAgaWYgKHdpbmRvdy5sb2NhbGl6ZWRTdHJpbmdzICYmIHN0cmluZyBpbiB3aW5kb3cu bG9jYWxpemVkU3RyaW5ncykKKyAgICAgICAgcmV0dXJuIHdpbmRvdy5sb2NhbGl6ZWRTdHJpbmdz W3N0cmluZ107CisKKyAgICBpZiAoIXRoaXMuX21pc3NpbmdMb2NhbGl6ZWRTdHJpbmdzKQorICAg ICAgICB0aGlzLl9taXNzaW5nTG9jYWxpemVkU3RyaW5ncyA9IHt9OworCisgICAgaWYgKCEoc3Ry aW5nIGluIHRoaXMuX21pc3NpbmdMb2NhbGl6ZWRTdHJpbmdzKSkgeworICAgICAgICBjb25zb2xl LmVycm9yKCJMb2NhbGl6ZWQgc3RyaW5nIFwiIiArIHN0cmluZyArICJcIiB3YXMgbm90IGZvdW5k LiIpOworICAgICAgICB0aGlzLl9taXNzaW5nTG9jYWxpemVkU3RyaW5nc1tzdHJpbmddID0gdHJ1 ZTsKKyAgICB9CisKKyAgICByZXR1cm4gIkxPQ0FMSVpFRCBTVFJJTkcgTk9UIEZPVU5EIjsKK307 CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01h aW4uanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMK aW5kZXggODcwMWE4Mzk5YzEuLmYwYTIwZDQzMzY3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5z cGVjdG9yVUkvVXNlckludGVyZmFjZS9CYXNlL01haW4uanMKKysrIGIvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvQmFzZS9NYWluLmpzCkBAIC0xMDY0LDMzICsxMDY0LDYgQEAg V2ViSW5zcGVjdG9yLnNob3dUaW1lbGluZVRhYiA9IGZ1bmN0aW9uKCkKICAgICB0aGlzLnRhYkJy b3dzZXIuc2hvd1RhYkZvckNvbnRlbnRWaWV3KHRhYkNvbnRlbnRWaWV3KTsKIH07CiAKLVdlYklu c3BlY3Rvci51bmxvY2FsaXplZFN0cmluZyA9IGZ1bmN0aW9uKHN0cmluZykKLXsKLSAgICAvLyBJ bnRlbnRpb25hbGx5IGRvIG5vdGhpbmcsIHNpbmNlIHRoaXMgaXMgZm9yIGVuZ2luZWVyaW5nIGJ1 aWxkcwotICAgIC8vIChzdWNoIGFzIGluIERlYnVnIFVJKSBvciBpbiB0ZXh0IHRoYXQgaXMgc3Rh bmRhcmRpemVkIGluIEVuZ2xpc2guCi0gICAgLy8gRm9yIGV4YW1wbGUsIENTUyBwcm9wZXJ0eSBu YW1lcyBhbmQgdmFsdWVzIGFyZSBuZXZlciBsb2NhbGl6ZWQuCi0gICAgcmV0dXJuIHN0cmluZzsK LX07Ci0KLVdlYkluc3BlY3Rvci5VSVN0cmluZyA9IGZ1bmN0aW9uKHN0cmluZywgdmFyYXJnKQot ewotICAgIGlmIChXZWJJbnNwZWN0b3IuZG9udExvY2FsaXplVXNlckludGVyZmFjZSkKLSAgICAg ICAgcmV0dXJuIHN0cmluZzsKLQotICAgIGlmICh3aW5kb3cubG9jYWxpemVkU3RyaW5ncyAmJiBz dHJpbmcgaW4gd2luZG93LmxvY2FsaXplZFN0cmluZ3MpCi0gICAgICAgIHJldHVybiB3aW5kb3cu bG9jYWxpemVkU3RyaW5nc1tzdHJpbmddOwotCi0gICAgaWYgKCF0aGlzLl9taXNzaW5nTG9jYWxp emVkU3RyaW5ncykKLSAgICAgICAgdGhpcy5fbWlzc2luZ0xvY2FsaXplZFN0cmluZ3MgPSB7fTsK LQotICAgIGlmICghKHN0cmluZyBpbiB0aGlzLl9taXNzaW5nTG9jYWxpemVkU3RyaW5ncykpIHsK LSAgICAgICAgY29uc29sZS5lcnJvcigiTG9jYWxpemVkIHN0cmluZyBcIiIgKyBzdHJpbmcgKyAi XCIgd2FzIG5vdCBmb3VuZC4iKTsKLSAgICAgICAgdGhpcy5fbWlzc2luZ0xvY2FsaXplZFN0cmlu Z3Nbc3RyaW5nXSA9IHRydWU7Ci0gICAgfQotCi0gICAgcmV0dXJuICJMT0NBTElaRUQgU1RSSU5H IE5PVCBGT1VORCI7Ci19OwotCiBXZWJJbnNwZWN0b3IuaW5kZW50U3RyaW5nID0gZnVuY3Rpb24o KQogewogICAgIGlmIChXZWJJbnNwZWN0b3Iuc2V0dGluZ3MuaW5kZW50V2l0aFRhYnMudmFsdWUp CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9Nb2RlbHMv S2V5Ym9hcmRTaG9ydGN1dC5qcyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L01vZGVscy9LZXlib2FyZFNob3J0Y3V0LmpzCmluZGV4IDQzZThhNzQyMzZjLi5mMTQyYWZmZThi NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvTW9kZWxz L0tleWJvYXJkU2hvcnRjdXQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvTW9kZWxzL0tleWJvYXJkU2hvcnRjdXQuanMKQEAgLTIzMiw3ICsyMzIsNyBAQCBXZWJJ bnNwZWN0b3IuS2V5Ym9hcmRTaG9ydGN1dC5LZXkgPSB7CiAgICAgVGFiOiBuZXcgV2ViSW5zcGVj dG9yLktleSg5LCAiXHUyMWU1IiksCiAgICAgRW50ZXI6IG5ldyBXZWJJbnNwZWN0b3IuS2V5KDEz LCAiXHUyMWE5IiksCiAgICAgRXNjYXBlOiBuZXcgV2ViSW5zcGVjdG9yLktleSgyNywgIlx1MjM4 YiIpLAotICAgIFNwYWNlOiBuZXcgV2ViSW5zcGVjdG9yLktleSgzMiwgIlNwYWNlIiksCisgICAg U3BhY2U6IG5ldyBXZWJJbnNwZWN0b3IuS2V5KDMyLCBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoIlNw YWNlIikpLAogICAgIFBhZ2VVcDogbmV3IFdlYkluc3BlY3Rvci5LZXkoMzMsICJcdTIxZGUiKSwK ICAgICBQYWdlRG93bjogbmV3IFdlYkluc3BlY3Rvci5LZXkoMzQsICJcdTIxZGYiKSwKICAgICBF bmQ6IG5ldyBXZWJJbnNwZWN0b3IuS2V5KDM1LCAiXHUyMTk4IiksCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0L1Rlc3QuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9UZXN0L1Rlc3QuanMKaW5kZXggYmIwYzhlYWEyYWYu Ljc5NTc1Nzg1YmI5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9UZXN0L1Rlc3QuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZh Y2UvVGVzdC9UZXN0LmpzCkBAIC0xMDIsNiArMTAyLDcgQEAgV2ViSW5zcGVjdG9yLmFzc3VtaW5n TWFpblRhcmdldCA9ICgpID0+IFdlYkluc3BlY3Rvci5tYWluVGFyZ2V0OwogCiBXZWJJbnNwZWN0 b3IuaXNEZWJ1Z1VJRW5hYmxlZCA9ICgpID0+IGZhbHNlOwogCitXZWJJbnNwZWN0b3IudW5sb2Nh bGl6ZWRTdHJpbmcgPSAoc3RyaW5nKSA9PiBzdHJpbmc7CiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcg PSAoc3RyaW5nKSA9PiBzdHJpbmc7CiAKIFdlYkluc3BlY3Rvci5pbmRlbnRTdHJpbmcgPSAoKSA9 PiAiICAgICI7Cg==