170417 2017-04-03 13:32:33 -0700 Web Inspector: Tooltip for close tab button should match Safari 2017-04-03 15:05:08 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker oldest_to_newest 1293770 0 joepeck 2017-04-03 13:32:33 -0700 Summary: Tooltip for close tab button should match Safari Steps to Reproduce: 1. Inspect this page 2. Mouseover the close tab button for any Web Inspector tab 3. Review tooltip Expected: Safari: “Click to close this tab; Option-click to close all tabs except this one” Web Inspector: “Close tab” 1293771 1 joepeck 2017-04-03 13:32:41 -0700 <rdar://problem/31378423> 1293772 2 306101 joepeck 2017-04-03 13:33:25 -0700 Created attachment 306101 [PATCH] Proposed Fix 1293784 3 306101 mattbaker 2017-04-03 13:54:02 -0700 Comment on attachment 306101 [PATCH] Proposed Fix r=me 1293833 4 306101 commit-queue 2017-04-03 15:05:07 -0700 Comment on attachment 306101 [PATCH] Proposed Fix Clearing flags on attachment: 306101 Committed r214840: <http://trac.webkit.org/changeset/214840> 1293834 5 commit-queue 2017-04-03 15:05:08 -0700 All reviewed patches have been landed. Closing bug. 306101 2017-04-03 13:33:25 -0700 2017-04-03 15:05:07 -0700 [PATCH] Proposed Fix tooltip-1.patch text/plain 3269 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGNjNmE4MDMwYWJiLi4xYzQyYjQ1MDBlZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTctMDQtMDMgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBUb29sdGlwIGZvciBjbG9zZSB0YWIgYnV0dG9uIHNob3VsZCBtYXRjaCBTYWZhcmkKKyAgICAg ICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDQxNworICAgICAg ICA8cmRhcjovL3Byb2JsZW0vMzEzNzg0MjM+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBMb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0 cmluZ3MuanM6CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVGFiQmFySXRl bS5qczoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5HZW5lcmFsVGFiQmFySXRlbSk6CisgICAgICAg IFVwZGF0ZWQgdG9vbHRpcCB0byBtYXRjaCBTYWZhcmkncyBtb3N0IGRlc2NyaXB0aXZlIHRvb2x0 aXAuCisKIDIwMTctMDQtMDEgIEpvbiBMZWUgIDxqb25sZWVAYXBwbGUuY29tPgogCiAgICAgICAg IEFkZCBtaXNzaW5nIHRleHQgc3R5bGVzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9y VUkvTG9jYWxpemF0aW9ucy9lbi5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcwpp bmRleCBlNDMwMzFhODY3My4uMmNlOTFmNmEzMzcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNw ZWN0b3JVSS9Mb2NhbGl6YXRpb25zL2VuLmxwcm9qL2xvY2FsaXplZFN0cmluZ3MuanMKKysrIGIv U291cmNlL1dlYkluc3BlY3RvclVJL0xvY2FsaXphdGlvbnMvZW4ubHByb2ovbG9jYWxpemVkU3Ry aW5ncy5qcwpAQCAtMTY3LDYgKzE2Nyw3IEBAIGxvY2FsaXplZFN0cmluZ3NbIkNsZWFyIHNhbXBs ZXMiXSA9ICJDbGVhciBzYW1wbGVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkNsZWFyIHdhdGNoIGV4 cHJlc3Npb25zIl0gPSAiQ2xlYXIgd2F0Y2ggZXhwcmVzc2lvbnMiOwogbG9jYWxpemVkU3RyaW5n c1siQ2xlYXIgd2hlbiBwYWdlIG5hdmlnYXRlcyJdID0gIkNsZWFyIHdoZW4gcGFnZSBuYXZpZ2F0 ZXMiOwogbG9jYWxpemVkU3RyaW5nc1siQ2xpY2sgTGlzdGVuZXIiXSA9ICJDbGljayBMaXN0ZW5l ciI7Citsb2NhbGl6ZWRTdHJpbmdzWyJDbGljayB0byBjbG9zZSB0aGlzIHRhYjsgT3B0aW9uLWNs aWNrIHRvIGNsb3NlIGFsbCB0YWJzIGV4Y2VwdCB0aGlzIG9uZSJdID0gIkNsaWNrIHRvIGNsb3Nl IHRoaXMgdGFiOyBPcHRpb24tY2xpY2sgdG8gY2xvc2UgYWxsIHRhYnMgZXhjZXB0IHRoaXMgb25l IjsKIGxvY2FsaXplZFN0cmluZ3NbIkNsaWNrIHRvIGxpbmsgcHJvcGVydHkgdmFsdWVzIl0gPSAi Q2xpY2sgdG8gbGluayBwcm9wZXJ0eSB2YWx1ZXMiOwogbG9jYWxpemVkU3RyaW5nc1siQ2xpY2sg dG8gc2VsZWN0IGEgY29sb3IuIFNoaWZ0LWNsaWNrIHRvIHN3aXRjaCBjb2xvciBmb3JtYXRzLiJd ID0gIkNsaWNrIHRvIHNlbGVjdCBhIGNvbG9yLiBTaGlmdC1jbGljayB0byBzd2l0Y2ggY29sb3Ig Zm9ybWF0cy4iOwogbG9jYWxpemVkU3RyaW5nc1siQ2xpY2thYmxlIl0gPSAiQ2xpY2thYmxlIjsK QEAgLTE3Niw3ICsxNzcsNiBAQCBsb2NhbGl6ZWRTdHJpbmdzWyJDbG9zZSAlcyB0aW1lbGluZSB2 aWV3Il0gPSAiQ2xvc2UgJXMgdGltZWxpbmUgdmlldyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDbG9z ZSBPdGhlciBUYWJzIl0gPSAiQ2xvc2UgT3RoZXIgVGFicyI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJD bG9zZSBUYWIiXSA9ICJDbG9zZSBUYWIiOwogbG9jYWxpemVkU3RyaW5nc1siQ2xvc2UgcmVzb3Vy Y2UgdmlldyJdID0gIkNsb3NlIHJlc291cmNlIHZpZXciOwotbG9jYWxpemVkU3RyaW5nc1siQ2xv c2UgdGFiIl0gPSAiQ2xvc2UgdGFiIjsKIGxvY2FsaXplZFN0cmluZ3NbIkNsb3NlZCJdID0gIkNs b3NlZCI7CiBsb2NhbGl6ZWRTdHJpbmdzWyJDbG9zdXJlIFZhcmlhYmxlcyJdID0gIkNsb3N1cmUg VmFyaWFibGVzIjsKIGxvY2FsaXplZFN0cmluZ3NbIkNsb3N1cmUgVmFyaWFibGVzICglcykiXSA9 ICJDbG9zdXJlIFZhcmlhYmxlcyAoJXMpIjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0dlbmVyYWxUYWJCYXJJdGVtLmpzIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR2VuZXJhbFRhYkJhckl0ZW0uanMKaW5k ZXggMWM0ZWQ4M2M5MjMuLjg2NjJhZmQ3Y2Y5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVGFiQmFySXRlbS5qcworKysgYi9Tb3Vy Y2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9HZW5lcmFsVGFiQmFySXRlbS5q cwpAQCAtMzIsNyArMzIsNyBAQCBXZWJJbnNwZWN0b3IuR2VuZXJhbFRhYkJhckl0ZW0gPSBjbGFz cyBHZW5lcmFsVGFiQmFySXRlbSBleHRlbmRzIFdlYkluc3BlY3Rvci5UYQogCiAgICAgICAgIGxl dCBjbG9zZUJ1dHRvbkVsZW1lbnQgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJkaXYiKTsKICAg ICAgICAgY2xvc2VCdXR0b25FbGVtZW50LmNsYXNzTGlzdC5hZGQoV2ViSW5zcGVjdG9yLlRhYkJh ckl0ZW0uQ2xvc2VCdXR0b25TdHlsZUNsYXNzTmFtZSk7Ci0gICAgICAgIGNsb3NlQnV0dG9uRWxl bWVudC50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2xvc2UgdGFiIik7CisgICAgICAg IGNsb3NlQnV0dG9uRWxlbWVudC50aXRsZSA9IFdlYkluc3BlY3Rvci5VSVN0cmluZygiQ2xpY2sg dG8gY2xvc2UgdGhpcyB0YWI7IE9wdGlvbi1jbGljayB0byBjbG9zZSBhbGwgdGFicyBleGNlcHQg dGhpcyBvbmUiKTsKICAgICAgICAgdGhpcy5lbGVtZW50Lmluc2VydEJlZm9yZShjbG9zZUJ1dHRv bkVsZW1lbnQsIHRoaXMuZWxlbWVudC5maXJzdENoaWxkKTsKIAogICAgICAgICB0aGlzLmVsZW1l bnQuYWRkRXZlbnRMaXN0ZW5lcigiY29udGV4dG1lbnUiLCB0aGlzLl9oYW5kbGVDb250ZXh0TWVu dUV2ZW50LmJpbmQodGhpcykpOwo=