170410 2017-04-03 12:48:45 -0700 REGRESSION: fast/images/animated-gif-webkit-transform.html is flaky 2017-06-08 15:12:39 -0700 1 1 1 Unclassified WebKit Images Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=170203 InRadar P2 Normal --- 1 ap cdumez cdumez commit-queue ggaren jonlee kling koivisto ryanhaddad sabouhallawa simon.fraser webkit-bug-importer oldest_to_newest 1293750 0 ap 2017-04-03 12:48:45 -0700 fast/images/animated-gif-webkit-transform.html has become flaky on multiple bots recently (2017-03-28). @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS isFirstImagePaused() is false +FAIL isFirstImagePaused() should be false. Was true. PASS isSecondImagePaused() became true PASS isFirstImagePaused() is false Translating images left so that first image is no longer visible, but second image is. 1293751 1 webkit-bug-importer 2017-04-03 12:52:09 -0700 <rdar://problem/31409381> 1293752 2 ap 2017-04-03 12:52:20 -0700 https://webkit-test-results.webkit.org/dashboards/flakiness_dashboard.html#showAllRuns=true&tests=fast%2Fimages%2Fanimated-gif-webkit-transform.html 1294069 3 ryanhaddad 2017-04-04 10:53:22 -0700 Marked test as flaky in https://trac.webkit.org/changeset/214884/webkit 1316976 4 ryanhaddad 2017-06-08 10:54:47 -0700 According to the flakiness dashboard, this test is no longer flaky. 1316982 5 cdumez 2017-06-08 10:59:24 -0700 I can reproduce with: Tools/Scripts/run-webkit-tests --repeat-each=200 fast/images/animated-gif-webkit-transform.html -gf --child-processes=10 (Need to update TestExpections first as the test has been marked as flaky) Result: --- /Volumes/Data/cdumez/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/fast/images/animated-gif-webkit-transform-expected.txt +++ /Volumes/Data/cdumez/WebKit/OpenSource/WebKitBuild/Release/layout-test-results/fast/images/animated-gif-webkit-transform-actual.txt @@ -3,7 +3,7 @@ On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE". -PASS isFirstImagePaused() is false +FAIL isFirstImagePaused() should be false. Was true. PASS isSecondImagePaused() became true PASS isFirstImagePaused() is false Translating images left so that first image is no longer visible, but second image is. 1316984 6 cdumez 2017-06-08 11:02:37 -0700 I have a fix. Will upload after lunch. 1316991 7 312324 cdumez 2017-06-08 11:10:22 -0700 Created attachment 312324 Patch 1317082 8 312324 cdumez 2017-06-08 15:12:36 -0700 Comment on attachment 312324 Patch Clearing flags on attachment: 312324 Committed r217950: <http://trac.webkit.org/changeset/217950> 1317083 9 cdumez 2017-06-08 15:12:39 -0700 All reviewed patches have been landed. Closing bug. 312324 2017-06-08 11:10:22 -0700 2017-06-08 15:12:36 -0700 Patch bug-170410-20170608111021.patch text/plain 3170 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMjE3OTMwCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggOWFkNjk4Mzk2NjBkY2NhNWJkNTg0 MGM2NmExY2VlNGYwZmQwN2FmOS4uODk0ZGE0ZGJlM2Q5Nzc4YjcyZTE2YzBlNGVkYTc2MmVjZTkz Mzg5MCAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDE3LTA2LTA4ICBDaHJpcyBEdW1leiAgPGNk dW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgUkVHUkVTU0lPTjogZmFzdC9pbWFnZXMvYW5pbWF0 ZWQtZ2lmLXdlYmtpdC10cmFuc2Zvcm0uaHRtbCBpcyBmbGFreQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwNDEwCisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS8zMTQwOTM4MT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBGaXggZmxha2luZXNzIGFuZCB1bnNraXAgdGVzdC4KKworICAgICAgICAqIGZhc3Qv aW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJhbnNmb3JtLWV4cGVjdGVkLnR4dDoKKyAgICAg ICAgKiBmYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtd2Via2l0LXRyYW5zZm9ybS5odG1sOgorICAg ICAgICAqIHBsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9uczoKKwogMjAxNy0wNi0wOCAg WW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgZ2V0VXNlck1lZGlh IHJlcXVlc3Qgc2hvdWxkIG5vdCBiZSBhbGxvd2VkIGZvciBiYWNrZ3JvdW5kIHRhYnMgdW5sZXNz IHRoZSB0YWIgaXMgYWxyZWFkeSBjYXB0dXJpbmcKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zh c3QvaW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJhbnNmb3JtLWV4cGVjdGVkLnR4dCBiL0xh eW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJhbnNmb3JtLWV4cGVj dGVkLnR4dAppbmRleCA1ZTJjODNkYTY1NWVjZmRkY2RkMWNkZDg0MjIwMmEwOWMwODhjY2Y1Li5l OWE3ZTNkMDI3M2RhMDlmZjg3ZjYxMWJlM2QyNDAxOTEwYjUxMjgzIDEwMDY0NAotLS0gYS9MYXlv dXRUZXN0cy9mYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtd2Via2l0LXRyYW5zZm9ybS1leHBlY3Rl ZC50eHQKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lmLXdlYmtpdC10 cmFuc2Zvcm0tZXhwZWN0ZWQudHh0CkBAIC0zLDcgKzMsNyBAQCBUZXN0IHRoYXQgYW5pbWF0ZWQg aW1hZ2VzIGFyZSBjb3JyZWN0bHkgcGF1c2VkIC8gcmVzdW1lZCB3aGVuIHRyYW5zbGF0ZWQgaW4g YW5kCiBPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1MiIG1lc3NhZ2Vz LCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCiAKIAotUEFTUyBpc0ZpcnN0SW1hZ2VQYXVz ZWQoKSBpcyBmYWxzZQorUEFTUyBpc0ZpcnN0SW1hZ2VQYXVzZWQoKSBiZWNhbWUgZmFsc2UKIFBB U1MgaXNTZWNvbmRJbWFnZVBhdXNlZCgpIGJlY2FtZSB0cnVlCiBQQVNTIGlzRmlyc3RJbWFnZVBh dXNlZCgpIGlzIGZhbHNlCiBUcmFuc2xhdGluZyBpbWFnZXMgbGVmdCBzbyB0aGF0IGZpcnN0IGlt YWdlIGlzIG5vIGxvbmdlciB2aXNpYmxlLCBidXQgc2Vjb25kIGltYWdlIGlzLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lmLXdlYmtpdC10cmFuc2Zvcm0u aHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvaW1hZ2VzL2FuaW1hdGVkLWdpZi13ZWJraXQtdHJhbnNm b3JtLmh0bWwKaW5kZXggZWVjMGYyZjI2OTUwYTQ3ZThjOTg2ZjU3ODQ0N2M4MTUyZTFkODA2Zi4u NzQ5M2JkZThiZDBlYjA3NWZiZGFkOThiYTM0MzBhZWRkMTUzMThhZiAxMDA2NDQKLS0tIGEvTGF5 b3V0VGVzdHMvZmFzdC9pbWFnZXMvYW5pbWF0ZWQtZ2lmLXdlYmtpdC10cmFuc2Zvcm0uaHRtbAor KysgYi9MYXlvdXRUZXN0cy9mYXN0L2ltYWdlcy9hbmltYXRlZC1naWYtd2Via2l0LXRyYW5zZm9y bS5odG1sCkBAIC01NCw4ICs1NCw5IEBAIGZ1bmN0aW9uIHRyYW5zbGF0ZUltYWdlc1JpZ2h0KCkg ewogfQogCiBmdW5jdGlvbiBydW5UZXN0KCkgewotICBzaG91bGRCZUZhbHNlKCJpc0ZpcnN0SW1h Z2VQYXVzZWQoKSIpOwotICBzaG91bGRCZWNvbWVFcXVhbCgiaXNTZWNvbmRJbWFnZVBhdXNlZCgp IiwgInRydWUiLCB0cmFuc2xhdGVJbWFnZXNMZWZ0KTsKKyAgc2hvdWxkQmVjb21lRXF1YWwoImlz Rmlyc3RJbWFnZVBhdXNlZCgpIiwgImZhbHNlIiwgZnVuY3Rpb24oKSB7CisgICAgICBzaG91bGRC ZWNvbWVFcXVhbCgiaXNTZWNvbmRJbWFnZVBhdXNlZCgpIiwgInRydWUiLCB0cmFuc2xhdGVJbWFn ZXNMZWZ0KTsKKyAgfSk7CiB9CiAKIDwvc2NyaXB0PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv cGxhdGZvcm0vbWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0v bWFjLXdrMi9UZXN0RXhwZWN0YXRpb25zCmluZGV4IGRkYjhiNmM4ZDJjMjEwMmZhY2ZhYzk5Y2Nj NTIwNzA0ODE5M2Y0MWEuLmE4YTE4ZmFkZWYyMjI0ZDFkMzY0ZDIxMDc3OGU4ZDgzMzhkNDFhNDMg MTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL21hYy13azIvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9tYWMtd2syL1Rlc3RFeHBlY3RhdGlvbnMKQEAg LTYzOCw4ICs2MzgsNiBAQCB3ZWJraXQub3JnL2IvMTY5NjQwIGltcG9ydGVkL3czYy93ZWItcGxh dGZvcm0tdGVzdHMvaHRtbC93ZWJhcHBhcGlzL3NjcmlwdGluZy9ldgogCiB3ZWJraXQub3JnL2Iv MTcwMjAzIGZhc3QvaW1hZ2VzL2FuaW1hdGVkLWltYWdlLWRpZmZlcmVudC1kZXN0LXNpemUuaHRt bCBbIFBhc3MgSW1hZ2VPbmx5RmFpbHVyZSBdCiAKLXdlYmtpdC5vcmcvYi8xNzA0MTAgZmFzdC9p bWFnZXMvYW5pbWF0ZWQtZ2lmLXdlYmtpdC10cmFuc2Zvcm0uaHRtbCBbIFBhc3MgRmFpbHVyZSBd Ci0KICMgTWVkaWEgbG9hZGluZyB2aWEgbmV0d29yayBjYWNoZSByZXF1aXJlcyBTaWVycmEgb3Ig bmV3ZXIuCiBbIEVsQ2FwaXRhbiBdIGh0dHAvdGVzdHMvY2FjaGUvZGlzay1jYWNoZS9kaXNrLWNh Y2hlLW1lZGlhLXNtYWxsLmh0bWwgWyBGYWlsdXJlIF0KIAo=