170397 2017-04-02 15:41:13 -0700 run-safari should support launching with custom language and locale 2017-04-03 13:44:59 -0700 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bburg bburg ap bburg buildbot commit-queue dbates joepeck lforschler rmondello oldest_to_newest 1293564 0 bburg 2017-04-02 15:41:13 -0700 This would be nice. 1293566 1 ap 2017-04-02 17:32:19 -0700 With system Safari and WebKit, this can be achieved to some degree of fidelity with command line options: /Applications/Safari.app/Contents/MacOS/Safari -AppleLanguages '(fr)' -AppleLocale 'fr_FR' However, locally built WebKit does not have resources other than English, so overriding language would be no-op for most part. Overriding locale may be more useful, but I'm not sure if we inherit AppleLocale override to WebContent process. 1293737 2 306094 bburg 2017-04-03 12:23:25 -0700 Created attachment 306094 Patch 1293748 3 306094 ap 2017-04-03 12:39:54 -0700 Comment on attachment 306094 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306094&action=review OK. I'm still unsure if this won't cause more confusion than good though. > Tools/Scripts/webkitdirs.pm:-2179 > - -g|--guard-malloc Enable Guard Malloc (OS X only) Surely this still doesn't work on Linux or Windows. > Tools/Scripts/webkitdirs.pm:2180 > + --lang=LANGUAGE Use a specific language instead of system language. Why abbreviate? > Tools/Scripts/webkitdirs.pm:2182 > + --locale=LOCALE Useg a specific locale instead of the system region. Typo: Useg. Also, these won't work on Linux either. 1293755 4 bburg 2017-04-03 13:02:42 -0700 (In reply to Alexey Proskuryakov from comment #3) > Comment on attachment 306094 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306094&action=review > > OK. I'm still unsure if this won't cause more confusion than good though. > > > Tools/Scripts/webkitdirs.pm:-2179 > > - -g|--guard-malloc Enable Guard Malloc (OS X only) > > Surely this still doesn't work on Linux or Windows. > > > Tools/Scripts/webkitdirs.pm:2180 > > + --lang=LANGUAGE Use a specific language instead of system language. > > Why abbreviate? It matches the LANG environment variable. And since it's unambiguous, when type more than necessary? > > Tools/Scripts/webkitdirs.pm:2182 > > + --locale=LOCALE Useg a specific locale instead of the system region. > > Typo: Useg. Ooops. > > Also, these won't work on Linux either. I'll add a header back to state that these are specific to macOS. 1293757 5 306097 bburg 2017-04-03 13:05:15 -0700 Created attachment 306097 For Landing 1293775 6 306097 commit-queue 2017-04-03 13:44:57 -0700 Comment on attachment 306097 For Landing Clearing flags on attachment: 306097 Committed r214835: <http://trac.webkit.org/changeset/214835> 1293776 7 commit-queue 2017-04-03 13:44:59 -0700 All reviewed patches have been landed. Closing bug. 306094 2017-04-03 12:23:25 -0700 2017-04-03 13:05:11 -0700 Patch bug-170397-20170403122325.patch text/plain 2360 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NzA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2E5NTI0ZmRhZDkxMzM1NWY0OWEwOTc5MDFmNjFmNzE3 YTVlYTFkNC4uMzdiZDc4MmUzNzNmOGE5NGYyZDE3NGY2MGU4NjFjMmRkNTBkZTU1YyAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTA0LTAzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IHJ1bi1zYWZhcmkgc2hvdWxkIHN1cHBvcnQgbGF1bmNoaW5nIHdpdGggY3VzdG9tIGxhbmd1YWdl IGFuZCBsb2NhbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MDM5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIEhvb2sgdXAgLUFwcGxlTGFuZ3VhZ2VzIGFuZCAtQXBwbGVMb2NhbGUgdG8gY29tbWFuZCBs aW5lIG9wdGlvbnMuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdGRpcnMucG06CisgICAgICAg IChwcmludEhlbHBBbmRFeGl0Rm9yUnVuQW5kRGVidWdXZWJLaXRBcHBJZk5lZWRlZCk6CisgICAg ICAgIChhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dlYktpdEFwcCk6CisKIDIwMTctMDMtMzEg IEpvbmF0aGFuIEJlZGFyZCAgPGpiZWRhcmRAYXBwbGUuY29tPgogCiAgICAgICAgIHdlYmtpdHB5 OiBBZGQgdGFyZ2V0IGhvc3QgY29uY2VwdApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDA1MzQ5YTFhMmIz Yjg3ZTc1MTNmN2UzZTAzZDI1NDJiNTAxZGI3ZTAuLjU4NmExOTM5YWZhNTAyMTJlNjY5MTQ5OWUz MjEyYTAyNzY4ODQ3YmQgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQor KysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTIxNzYsNyArMjE3NiwxMCBAQCBz dWIgcHJpbnRIZWxwQW5kRXhpdEZvclJ1bkFuZERlYnVnV2ViS2l0QXBwSWZOZWVkZWQKIFVzYWdl OiBAe1tiYXNlbmFtZSgkMCldfSBbb3B0aW9uc10gW2FyZ3MgLi4uXQogICAtLWhlbHAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgU2hvdyB0aGlzIGhlbHAgbWVzc2FnZQogICAtLW5vLXNhdmVk LXN0YXRlICAgICAgICAgICAgICAgICAgTGF1bmNoIHRoZSBhcHBsaWNhdGlvbiB3aXRob3V0IHN0 YXRlIHJlc3RvcmF0aW9uCi0gIC1nfC0tZ3VhcmQtbWFsbG9jICAgICAgICAgICAgICAgICBFbmFi bGUgR3VhcmQgTWFsbG9jIChPUyBYIG9ubHkpCisgIC1nfC0tZ3VhcmQtbWFsbG9jICAgICAgICAg ICAgICAgICBFbmFibGUgR3VhcmQgTWFsbG9jCisgIC0tbGFuZz1MQU5HVUFHRSAgICAgICAgICAg ICAgICAgICBVc2UgYSBzcGVjaWZpYyBsYW5ndWFnZSBpbnN0ZWFkIG9mIHN5c3RlbSBsYW5ndWFn ZS4KKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFRoaXMgYWNjZXB0cyBhIGxh bmd1YWdlIG5hbWUgKEdlcm1hbikgb3IgYSBsYW5ndWFnZSBjb2RlIChkZSwgYXIsIHB0X0JSLCBl dGMpLgorICAtLWxvY2FsZT1MT0NBTEUgICAgICAgICAgICAgICAgICAgVXNlZyBhIHNwZWNpZmlj IGxvY2FsZSBpbnN0ZWFkIG9mIHRoZSBzeXN0ZW0gcmVnaW9uLgogRU9GCiAKICAgICBleGl0KDEp OwpAQCAtMjE5MCw2ICsyMTkzLDE3IEBAIHN1YiBhcmd1bWVudHNGb3JSdW5BbmREZWJ1Z01hY1dl YktpdEFwcCgpCiAgICAgICAgICMgRklYTUU6IERvbid0IHNldCBBcHBsZVBlcnNpc3RlbmNlSWdu b3JlU3RhdGUgb25jZSBhbGwgc3VwcG9ydGVkIE9TIHZlcnNpb25zIHJlc3BlY3QgQXBwbGVQZXJz aXN0ZW5jZUlnbm9yZVN0YXRlUXVpZXRseSAocmRhcjovLzE1MDMyODg2KS4KICAgICAgICAgcHVz aCBAYXJncywgKCItQXBwbGVQZXJzaXN0ZW5jZUlnbm9yZVN0YXRlIiwgIllFUyIpOwogICAgIH0K KworICAgIG15ICRsYW5nOworICAgIGlmIChjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFS R1ZHZXR0aW5nVmFsdWUoIi0tbGFuZyIsIFwkbGFuZykpIHsKKyAgICAgICAgcHVzaCBAYXJncywg KCItQXBwbGVMYW5ndWFnZXMiLCAiKCIgLiAkbGFuZyAuICIpIik7CisgICAgfQorCisgICAgbXkg JGxvY2FsZTsKKyAgICBpZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWR2V0dGlu Z1ZhbHVlKCItLWxvY2FsZSIsIFwkbG9jYWxlKSkgeworICAgICAgICBwdXNoIEBhcmdzLCAoIi1B cHBsZUxvY2FsZSIsICRsb2NhbGUpOworICAgIH0KKwogICAgIHVuc2hpZnQgQGFyZ3MsIEBBUkdW OwogCiAgICAgcmV0dXJuIEBhcmdzOwo= 306097 2017-04-03 13:05:15 -0700 2017-04-03 13:44:57 -0700 For Landing bug-170397-20170403130514.patch text/plain 2394 bburg U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NzA4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2E5NTI0ZmRhZDkxMzM1NWY0OWEwOTc5MDFmNjFmNzE3 YTVlYTFkNC4uYWVkODQ5ZDUzYWE1MDUwYzc4ZWMyMGE0ZmVkNzU0YTIwMmRhZjczYiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE3LTA0LTAzICBCcmlhbiBCdXJnICA8YmJ1cmdAYXBwbGUuY29tPgorCisgICAgICAg IHJ1bi1zYWZhcmkgc2hvdWxkIHN1cHBvcnQgbGF1bmNoaW5nIHdpdGggY3VzdG9tIGxhbmd1YWdl IGFuZCBsb2NhbGUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTE3MDM5NworCisgICAgICAgIFJldmlld2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCisK KyAgICAgICAgSG9vayB1cCAtQXBwbGVMYW5ndWFnZXMgYW5kIC1BcHBsZUxvY2FsZSB0byBjb21t YW5kIGxpbmUgb3B0aW9ucy4KKworICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbToKKyAg ICAgICAgKHByaW50SGVscEFuZEV4aXRGb3JSdW5BbmREZWJ1Z1dlYktpdEFwcElmTmVlZGVkKToK KyAgICAgICAgKGFyZ3VtZW50c0ZvclJ1bkFuZERlYnVnTWFjV2ViS2l0QXBwKToKKwogMjAxNy0w My0zMSAgSm9uYXRoYW4gQmVkYXJkICA8amJlZGFyZEBhcHBsZS5jb20+CiAKICAgICAgICAgd2Vi a2l0cHk6IEFkZCB0YXJnZXQgaG9zdCBjb25jZXB0CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRz L3dlYmtpdGRpcnMucG0gYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KaW5kZXggMDUzNDlh MWEyYjNiODdlNzUxM2Y3ZTNlMDNkMjU0MmI1MDFkYjdlMC4uNDRmM2FiYTYxZGFkYWZkNTUxM2Zk NjUwMWY2ZDc5NWM3ODBlYTMwNCAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtCisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQpAQCAtMjE3Niw3ICsyMTc2LDEy IEBAIHN1YiBwcmludEhlbHBBbmRFeGl0Rm9yUnVuQW5kRGVidWdXZWJLaXRBcHBJZk5lZWRlZAog VXNhZ2U6IEB7W2Jhc2VuYW1lKCQwKV19IFtvcHRpb25zXSBbYXJncyAuLi5dCiAgIC0taGVscCAg ICAgICAgICAgICAgICAgICAgICAgICAgICBTaG93IHRoaXMgaGVscCBtZXNzYWdlCiAgIC0tbm8t c2F2ZWQtc3RhdGUgICAgICAgICAgICAgICAgICBMYXVuY2ggdGhlIGFwcGxpY2F0aW9uIHdpdGhv dXQgc3RhdGUgcmVzdG9yYXRpb24KLSAgLWd8LS1ndWFyZC1tYWxsb2MgICAgICAgICAgICAgICAg IEVuYWJsZSBHdWFyZCBNYWxsb2MgKE9TIFggb25seSkKKworT3B0aW9ucyBzcGVjaWZpYyB0byBt YWNPUzoKKyAgLWd8LS1ndWFyZC1tYWxsb2MgICAgICAgICAgICAgICAgIEVuYWJsZSBHdWFyZCBN YWxsb2MKKyAgLS1sYW5nPUxBTkdVQUdFICAgICAgICAgICAgICAgICAgIFVzZSBhIHNwZWNpZmlj IGxhbmd1YWdlIGluc3RlYWQgb2Ygc3lzdGVtIGxhbmd1YWdlLgorICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgVGhpcyBhY2NlcHRzIGEgbGFuZ3VhZ2UgbmFtZSAoR2VybWFuKSBv ciBhIGxhbmd1YWdlIGNvZGUgKGRlLCBhciwgcHRfQlIsIGV0YykuCisgIC0tbG9jYWxlPUxPQ0FM RSAgICAgICAgICAgICAgICAgICBVc2UgYSBzcGVjaWZpYyBsb2NhbGUgaW5zdGVhZCBvZiB0aGUg c3lzdGVtIHJlZ2lvbi4KIEVPRgogCiAgICAgZXhpdCgxKTsKQEAgLTIxOTAsNiArMjE5NSwxNyBA QCBzdWIgYXJndW1lbnRzRm9yUnVuQW5kRGVidWdNYWNXZWJLaXRBcHAoKQogICAgICAgICAjIEZJ WE1FOiBEb24ndCBzZXQgQXBwbGVQZXJzaXN0ZW5jZUlnbm9yZVN0YXRlIG9uY2UgYWxsIHN1cHBv cnRlZCBPUyB2ZXJzaW9ucyByZXNwZWN0IEFwcGxlUGVyc2lzdGVuY2VJZ25vcmVTdGF0ZVF1aWV0 bHkgKHJkYXI6Ly8xNTAzMjg4NikuCiAgICAgICAgIHB1c2ggQGFyZ3MsICgiLUFwcGxlUGVyc2lz dGVuY2VJZ25vcmVTdGF0ZSIsICJZRVMiKTsKICAgICB9CisKKyAgICBteSAkbGFuZzsKKyAgICBp ZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWR2V0dGluZ1ZhbHVlKCItLWxhbmci LCBcJGxhbmcpKSB7CisgICAgICAgIHB1c2ggQGFyZ3MsICgiLUFwcGxlTGFuZ3VhZ2VzIiwgIigi IC4gJGxhbmcgLiAiKSIpOworICAgIH0KKworICAgIG15ICRsb2NhbGU7CisgICAgaWYgKGNoZWNr Rm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVkdldHRpbmdWYWx1ZSgiLS1sb2NhbGUiLCBcJGxv Y2FsZSkpIHsKKyAgICAgICAgcHVzaCBAYXJncywgKCItQXBwbGVMb2NhbGUiLCAkbG9jYWxlKTsK KyAgICB9CisKICAgICB1bnNoaWZ0IEBhcmdzLCBAQVJHVjsKIAogICAgIHJldHVybiBAYXJnczsK