170385 2017-04-01 14:34:23 -0700 [Xcode] In engineering builds, linker warns about libwebrtc.dylib’s install name being invalid 2017-04-01 15:57:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mitz mitz joepeck thorton oldest_to_newest 1293484 0 mitz 2017-04-01 14:34:23 -0700 In engineering builds, ld emits this warning when linking WebCore and WebKit: ld: warning: invalid -install_name (@loader_path/../../../libwebrtc.dylib) in dependent dylib (/symroot/Debug/libwebrtc.dylib). Dylibs/frameworks which might go in dyld shared cache cannot link with dylib that uses @rpath, @loader_path, etc. Patch forthcoming. 1293485 1 306051 mitz 2017-04-01 14:47:52 -0700 Created attachment 306051 Have the linker know that engineering builds are not destined for the shared cache 1293487 2 mitz 2017-04-01 15:57:59 -0700 Fixed in <https://trac.webkit.org/r214718>. 306051 2017-04-01 14:47:52 -0700 2017-04-01 15:15:18 -0700 Have the linker know that engineering builds are not destined for the shared cache bug-170385-20170401144751.patch text/plain 5468 mitz SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDcxNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE3LTA0LTAxICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgW1hjb2RlXSBJbiBlbmdpbmVlcmlu ZyBidWlsZHMsIGxpbmtlciB3YXJucyBhYm91dCBsaWJ3ZWJydGMuZHlsaWLigJlzIGluc3RhbGwg bmFtZSBiZWluZyBpbnZhbGlkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xNzAzODUKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIENvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZzogU2V0IFdL X1JFTE9DQVRBQkxFX0ZSQU1FV09SS1MgdG8gWUVTIGxpa2Ugd2UgZG8KKyAgICAgICAgICBpbiBz b21lIG90aGVyIHByb2plY3Rz4oCZIERlYnVnUmVsZWFzZS54Y2NvbmZpZy4gRW5naW5lZXJpbmcg YnVpbGRzIGFyZSBhbHdheXMgcmVsb2NhdGFibGUuCisgICAgICAgICogQ29uZmlndXJhdGlvbnMv V2ViQ29yZS54Y2NvbmZpZzogV2hlbiBXZWJDb3JlIGlzIHJlbG9jYXRhYmxlLCB0ZWxsIHRoZSBs aW5rZXIgdGhhdCBpdOKAmXMKKyAgICAgICAgICBub3QgZ29pbmcgdG8gYmUgaW4gdGhlIHNoYXJl ZCBjYWNoZSwgZXZlbiBpZiBpdHMgaW5zdGFsbCBuYW1lIGltcGxpZXMgdGhhdCBpdCBtaWdodCBi ZS4KKwogMjAxNy0wNC0wMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAog ICAgICAgICBSb2xsaW5nIGJhY2sgaHR0cDovL3RyYWMud2Via2l0Lm9yZy9yMjE0NjYzIC0gbWVt b3J5IGNvcnJ1cHRpb24KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVn UmVsZWFzZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0 aW9ucy9EZWJ1Z1JlbGVhc2UueGNjb25maWcJKHJldmlzaW9uIDIxNDcxNykKKysrIFNvdXJjZS9X ZWJDb3JlL0NvbmZpZ3VyYXRpb25zL0RlYnVnUmVsZWFzZS54Y2NvbmZpZwkod29ya2luZyBjb3B5 KQpAQCAtNDEsMyArNDEsNSBAQCBERUJVR19JTkZPUk1BVElPTl9GT1JNQVQgPSBkd2FyZjsKIFNE S1JPT1QgPSAkKFNES1JPT1RfJChVU0VfSU5URVJOQUxfU0RLKSk7CiBTREtST09UXyA9IG1hY29z eDsKIFNES1JPT1RfWUVTID0gbWFjb3N4LmludGVybmFsOworCitXS19SRUxPQ0FUQUJMRV9GUkFN RVdPUktTID0gWUVTOwpJbmRleDogU291cmNlL1dlYkNvcmUvQ29uZmlndXJhdGlvbnMvV2ViQ29y ZS54Y2NvbmZpZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9Db25maWd1cmF0aW9ucy9X ZWJDb3JlLnhjY29uZmlnCShyZXZpc2lvbiAyMTQ3MTcpCisrKyBTb3VyY2UvV2ViQ29yZS9Db25m aWd1cmF0aW9ucy9XZWJDb3JlLnhjY29uZmlnCSh3b3JraW5nIGNvcHkpCkBAIC03Nyw3ICs3Nyw3 IEBAIExJQldFQlJUQ19MSUJSQVJZX0RJUltzZGs9bWFjb3N4Kl0gPSAkKEwKIExJQldFQlJUQ19M SUJSQVJZX0RJUl9VU0VfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfTk8gPSAkKFdFQkNPUkVfRlJB TUVXT1JLU19ESVIpL1dlYkNvcmUuZnJhbWV3b3JrL1ZlcnNpb25zL0EvRnJhbWV3b3JrczsKIExJ QldFQlJUQ19MSUJSQVJZX0RJUl9VU0VfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfWUVTID0gJChX S19PVkVSUklERV9GUkFNRVdPUktTX0RJUik7CiAKLU9USEVSX0xERkxBR1MgPSAkKGluaGVyaXRl ZCkgJChPVEhFUl9MREZMQUdTX1BMQVRGT1JNKQorT1RIRVJfTERGTEFHUyA9ICQoaW5oZXJpdGVk KSAkKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19MREZMQUdTKSAkKE9USEVSX0xERkxBR1NfUExB VEZPUk0pOwogT1RIRVJfTERGTEFHU19CQVNFID0gLWxzcWxpdGUzIC1sb2JqYyAtbEFOR0xFIC1m cmFtZXdvcmsgTWV0YWw7CiBPVEhFUl9MREZMQUdTX0JBU0VfaW9zID0gJChPVEhFUl9MREZMQUdT X0JBU0UpIC1mcmFtZXdvcmsgQ0ZOZXR3b3JrIC1mcmFtZXdvcmsgQ29yZUdyYXBoaWNzIC1mcmFt ZXdvcmsgQ29yZVRleHQgLWZyYW1ld29yayBGb3VuZGF0aW9uIC1mcmFtZXdvcmsgSW1hZ2VJTyAt ZnJhbWV3b3JrIE1vYmlsZUNvcmVTZXJ2aWNlcyAtZnJhbWV3b3JrIE9wZW5HTEVTIC1sTW9iaWxl R2VzdGFsdCAkKFdLX0lPU19CSU5DT01QQVRfTERGTEFHUyk7CiBPVEhFUl9MREZMQUdTX1BMQVRG T1JNW3Nkaz1pcGhvbmVvcypdID0gJChPVEhFUl9MREZMQUdTX0JBU0VfaW9zKSAtZnJhbWV3b3Jr IElPU3VyZmFjZSAtZnJhbWV3b3JrIEdyYXBoaWNzU2VydmljZXMgJChMSUJXRUJSVENfTERGTEFH Uyk7CkBAIC0xMzEsNiArMTMxLDkgQEAgV0tfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfVVNFX1NU QUdJTkdfSQogV0tfUVVPVEVEX09WRVJSSURFX0ZSQU1FV09SS1NfRElSID0gJChXS19RVU9URURf T1ZFUlJJREVfRlJBTUVXT1JLU19ESVJfJChXS19VU0VfT1ZFUlJJREVfRlJBTUVXT1JLU19ESVIp KTsKIFdLX1FVT1RFRF9PVkVSUklERV9GUkFNRVdPUktTX0RJUl9ZRVMgPSAiJChXS19PVkVSUklE RV9GUkFNRVdPUktTX0RJUikiOwogCitXS19SRUxPQ0FUQUJMRV9GUkFNRVdPUktfTERGTEFHUyA9 ICQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLX0xERkxBR1NfJChXS19SRUxPQ0FUQUJMRV9GUkFN RVdPUktTKSk7CitXS19SRUxPQ0FUQUJMRV9GUkFNRVdPUktfTERGTEFHU19ZRVMgPSAtV2wsLW5v dF9mb3JfZHlsZF9zaGFyZWRfY2FjaGU7CisKIC8vIEVuYWJsZSBJbnN0YWxsQVBJIHN1cHBvcnQs IHdoZW4gYnVpbHQgd2l0aCBXRUJDT1JFX0VOQUJMRV9JTlNUQUxMQVBJPVlFUy4KIFNVUFBPUlRT X1RFWFRfQkFTRURfQVBJID0gJChTVVBQT1JUU19URVhUX0JBU0VEX0FQSV8kKFRBUkdFVF9OQU1F KSkKIFNVUFBPUlRTX1RFWFRfQkFTRURfQVBJX1dlYkNvcmUgPSAkKFdFQkNPUkVfRU5BQkxFX0lO U1RBTExBUEkpCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g U291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCShyZXZpc2lvbiAyMTQ3MTcpCisrKyBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNy0wNC0w MSAgRGFuIEJlcm5zdGVpbiAgPG1pdHpAYXBwbGUuY29tPgorCisgICAgICAgIFtYY29kZV0gSW4g ZW5naW5lZXJpbmcgYnVpbGRzLCBsaW5rZXIgd2FybnMgYWJvdXQgbGlid2VicnRjLmR5bGli4oCZ cyBpbnN0YWxsIG5hbWUgYmVpbmcgaW52YWxpZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzg1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBDb25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWc6IFdo ZW4gV2ViS2l0IGlzIHJlbG9jYXRhYmxlLCB0ZWxsIHRoZSBsaW5rZXIgdGhhdCBpdOKAmXMKKyAg ICAgICAgICBub3QgZ29pbmcgdG8gYmUgaW4gdGhlIHNoYXJlZCBjYWNoZSwgZXZlbiBpZiBpdHMg aW5zdGFsbCBuYW1lIGltcGxpZXMgdGhhdCBpdCBtaWdodCBiZS4KKwogMjAxNy0wMy0zMSAgU2lt b24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1vdmUgYSBs b2dnaW5nIHN0YXRlbWVudCBsZWZ0IGluIGJ5IG1pc3Rha2UuCkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9Db25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dl YktpdDIvQ29uZmlndXJhdGlvbnMvV2ViS2l0LnhjY29uZmlnCShyZXZpc2lvbiAyMTQ3MTcpCisr KyBTb3VyY2UvV2ViS2l0Mi9Db25maWd1cmF0aW9ucy9XZWJLaXQueGNjb25maWcJKHdvcmtpbmcg Y29weSkKQEAgLTU1LDcgKzU1LDcgQEAgTElCV0VCUlRDX0xJQlJBUllfRElSW3Nkaz1tYWNvc3gq XSA9ICQoTAogTElCV0VCUlRDX0xJQlJBUllfRElSX1VTRV9PVkVSUklERV9GUkFNRVdPUktTX0RJ Ul9OTyA9ICQoV0VCQ09SRV9GUkFNRVdPUktTX0RJUikvV2ViQ29yZS5mcmFtZXdvcmsvVmVyc2lv bnMvQS9GcmFtZXdvcmtzOwogTElCV0VCUlRDX0xJQlJBUllfRElSX1VTRV9PVkVSUklERV9GUkFN RVdPUktTX0RJUl9ZRVMgPSAkKFdLX09WRVJSSURFX0ZSQU1FV09SS1NfRElSKTsKIAotT1RIRVJf TERGTEFHUyA9ICQoaW5oZXJpdGVkKSAkKFVORVhQT1JURURfU1lNQk9MX0xERkxBR1MpICQoQVNB Tl9PVEhFUl9MREZMQUdTKSAkKEZSQU1FV09SS19BTkRfTElCUkFSWV9MREZMQUdTKSAkKE9USEVS X0xERkxBR1NfUExBVEZPUk0pIC1mcmFtZXdvcmsgV2ViS2l0TGVnYWN5OworT1RIRVJfTERGTEFH UyA9ICQoaW5oZXJpdGVkKSAkKFVORVhQT1JURURfU1lNQk9MX0xERkxBR1MpICQoQVNBTl9PVEhF Ul9MREZMQUdTKSAkKEZSQU1FV09SS19BTkRfTElCUkFSWV9MREZMQUdTKSAkKE9USEVSX0xERkxB R1NfUExBVEZPUk0pICQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLX0xERkxBR1MpIC1mcmFtZXdv cmsgV2ViS2l0TGVnYWN5OwogT1RIRVJfTERGTEFHU19QTEFURk9STVtzZGs9bWFjb3N4Kl0gPSAk KExJQldFQlJUQ19MREZMQUdTKTsKIE9USEVSX0xERkxBR1NfUExBVEZPUk1bc2RrPWlwaG9uZW9z Kl0gPSAtbEFjY2Vzc2liaWxpdHkgJChMSUJXRUJSVENfTERGTEFHUyk7CiBPVEhFUl9MREZMQUdT X1BMQVRGT1JNW3Nkaz1pcGhvbmVzaW11bGF0b3IqXSA9IC1sQWNjZXNzaWJpbGl0eSAkKExJQldF QlJUQ19MREZMQUdTKTsKQEAgLTgwLDMgKzgwLDYgQEAgV0tfRlJBTUVXT1JLX0hFQURFUl9QT1NU UFJPQ0VTU0lOR19ESVNBQgogCiBXS19GUkFNRVdPUktfSEVBREVSX1BPU1RQUk9DRVNTSU5HX0RJ U0FCTEVEW3Nkaz1pcGhvbmVvczkqXSA9IFlFUzsKIFdLX0ZSQU1FV09SS19IRUFERVJfUE9TVFBS T0NFU1NJTkdfRElTQUJMRURbc2RrPWlwaG9uZXNpbXVsYXRvcjkqXSA9IFlFUzsKKworV0tfUkVM T0NBVEFCTEVfRlJBTUVXT1JLX0xERkxBR1MgPSAkKFdLX1JFTE9DQVRBQkxFX0ZSQU1FV09SS19M REZMQUdTXyQoV0tfUkVMT0NBVEFCTEVfRlJBTUVXT1JLUykpOworV0tfUkVMT0NBVEFCTEVfRlJB TUVXT1JLX0xERkxBR1NfWUVTID0gLVdsLC1ub3RfZm9yX2R5bGRfc2hhcmVkX2NhY2hlOwo=