170381 2017-04-01 04:00:19 -0700 Mac cmake buildfix after 214586 2017-04-05 18:52:20 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 161675 1 ossy webkit-unassigned achristensen benjamin buildbot cdumez cmarcelo darin dbates ossy thorton oldest_to_newest 1293450 0 ossy 2017-04-01 04:00:19 -0700 In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:27: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.h:29: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WTF/wtf/BlockPtr.h:86:48: error: use of undeclared identifier 'std' return static_cast<Block*>(ptr)->f(std::forward<Args>(args)...); ^ ... In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:31: In file included from /Volumes/Data/slave/elcapitan-cmake-debug/build/WebKitBuild/Debug/DerivedSources/ForwardingHeaders/WebCore/CoreGraphicsSPI.h:1: /Volumes/Data/slave/elcapitan-cmake-debug/build/Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h:37:10: fatal error: 'ColorSync/ColorSync.h' file not found #include <ColorSync/ColorSync.h> ^ 1293451 1 306046 ossy 2017-04-01 04:03:23 -0700 Created attachment 306046 Patch patch for EWS 1293453 2 306046 ossy 2017-04-01 05:35:28 -0700 Comment on attachment 306046 Patch Clearing flags on attachment: 306046 Committed r214716: <http://trac.webkit.org/changeset/214716> 1293454 3 ossy 2017-04-01 05:35:32 -0700 All reviewed patches have been landed. Closing bug. 1293460 4 ossy 2017-04-01 05:48:38 -0700 Committed r214717: <http://trac.webkit.org/changeset/214717> 1293461 5 ossy 2017-04-01 06:51:34 -0700 forgot to mention https://trac.webkit.org/changeset/214715/webkit which was the first fix after the following build error: /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/WebKitTestRunner/mac/UIScriptControllerMac.mm:29:9: fatal error: 'EventSerializerMac.h' file not found #import "EventSerializerMac.h" ^ 1293464 6 ossy 2017-04-01 07:15:46 -0700 Still broken ... Undefined symbols for architecture x86_64: "_OBJC_CLASS_$_EventStreamPlayer", referenced from: objc-class-ref in UIScriptControllerMac.mm.o "beginSwipeBackEventStream()", referenced from: WTR::UIScriptController::beginBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o "completeSwipeBackEventStream()", referenced from: WTR::UIScriptController::completeBackSwipe(OpaqueJSValue const*) in UIScriptControllerMac.mm.o ld: symbol(s) not found for architecture x86_64 clang: error: linker command failed with exit code 1 (use -v to see invocation) make[2]: *** [bin/WebKitTestRunner] Error 1 make[1]: *** [Tools/WebKitTestRunner/CMakeFiles/WebKitTestRunner.dir/all] Error 2 ... /Volumes/Data/slave/elcapitan-cmake-debug/build/Tools/TestRunnerShared/EventSerialization/mac/EventSerializerMac.mm:59:38: error: unknown type name 'CGSEventType'; did you mean 'CGEventType'? bool eventIsOfType(CGEventRef event, CGSEventType type) ^~~~~~~~~~~~ CGEventType ... 1293631 7 ossy 2017-04-03 06:26:26 -0700 unassign, I don't have time for it, maybe Alex? 1294761 8 achristensen 2017-04-05 18:52:20 -0700 https://trac.webkit.org/changeset/214946/webkit 306046 2017-04-01 04:03:23 -0700 2017-04-01 04:03:23 -0700 Patch bug-170381-20170401130322.patch text/plain 908 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NzE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGI5Mjk4YWNiZDA2YzZiY2JlZWE0NmEy ODg5ZmMzMmY5MTE5MjFhMjguLjY0OWRkZGNmZDcyOGM3YmI1ZTYxY2FhNzMyZmY3NGUzZmU1N2E0 MDEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTctMDQtMDEgIENzYWJhIE9zenRyb2dvbsOhYyAg PG9zc3lAd2Via2l0Lm9yZz4KKworICAgICAgICBNYWMgY21ha2UgYnVpbGRmaXggYWZ0ZXIgMjE0 NTg2LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcw MzgxCisKKyAgICAgICAgVW5yZXZpZXdlZC4KKworICAgICAgICAqIHd0Zi9CbG9ja1B0ci5oOgor CiAyMDE3LTAzLTMwICBGaWxpcCBQaXpsbyAgPGZwaXpsb0BhcHBsZS5jb20+CiAKICAgICAgICAg QWlyIHNob3VsZCBzdXBwb3J0IGxpbmVhciBzY2FuIGZvciBvcHRMZXZlbDwyCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9CbG9ja1B0ci5oIGIvU291cmNlL1dURi93dGYvQmxvY2tQdHIuaApp bmRleCAxYjc5ZDQxNzhmZTFmYTcwZWQ3MDdmY2JmYWFhOTZkYmM3YmMwZTBkLi5lOTk3MWZiZDZj OTRjZDU1MmFiZTQzMDBlYTNjMmZiNzFlMzllM2UzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0 Zi9CbG9ja1B0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL0Jsb2NrUHRyLmgKQEAgLTI2LDYgKzI2 LDcgQEAKICNwcmFnbWEgb25jZQogCiAjaW5jbHVkZSA8QmxvY2suaD4KKyNpbmNsdWRlIDx1dGls aXR5PgogI2luY2x1ZGUgPHd0Zi9Bc3NlcnRpb25zLmg+CiAKIG5hbWVzcGFjZSBXVEYgewo=