170378 2017-03-31 18:48:21 -0700 WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default 2017-03-31 18:54:59 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller buildbot mark.lam msaboff saam oldest_to_newest 1293418 0 keith_miller 2017-03-31 18:48:21 -0700 WebAssembly: webAssemblyB3OptimizationLevel should use defaultB3OptLevel by default 1293419 1 306037 keith_miller 2017-03-31 18:48:44 -0700 Created attachment 306037 Patch 1293420 2 306037 saam 2017-03-31 18:53:02 -0700 Comment on attachment 306037 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306037&action=review > Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51 > +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel); You don't need to make the callers of this function pass in a value? 1293422 3 keith_miller 2017-03-31 18:54:37 -0700 (In reply to Saam Barati from comment #2) > Comment on attachment 306037 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=306037&action=review > > > Source/JavaScriptCore/wasm/WasmB3IRGenerator.h:51 > > +Expected<std::unique_ptr<WasmInternalFunction>, String> parseAndCompile(CompilationContext&, const uint8_t*, size_t, const Signature&, Vector<UnlinkedWasmToWasmCall>&, const ModuleInformation&, const Vector<SignatureIndex>&, MemoryMode, unsigned optLevel); > > You don't need to make the callers of this function pass in a value? I fixed that when I added the option. the default value is just unused atm. 1293423 4 keith_miller 2017-03-31 18:54:59 -0700 Committed r214709: <http://trac.webkit.org/changeset/214709> 306037 2017-03-31 18:48:44 -0700 2017-03-31 18:53:02 -0700 Patch bug-170378-20170331184843.patch text/plain 2995 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NzA4CmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCA3 ODMyMmI3MmNmODdlZTNjMGI1MWRkM2I2ZTA5Njk5NGRlOGQzOWRjLi5hZTMzYjhjNzlhYTQ0ODky MjNiZjA0OTc0MDZmY2FiOTI4YzI0Yjk3IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs NSArMSwxNSBAQAogMjAxNy0wMy0zMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KIAorICAgICAgICBXZWJBc3NlbWJseTogd2ViQXNzZW1ibHlCM09wdGltaXphdGlvbkxl dmVsIHNob3VsZCB1c2UgZGVmYXVsdEIzT3B0TGV2ZWwgYnkgZGVmYXVsdAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzc4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBydW50aW1lL09wdGlvbnMuaDoK KyAgICAgICAgKiB3YXNtL1dhc21CM0lSR2VuZXJhdG9yLmg6CisKKzIwMTctMDMtMzEgIEtlaXRo IE1pbGxlciAgPGtlaXRoX21pbGxlckBhcHBsZS5jb20+CisKICAgICAgICAgV2ViQXNzZW1ibHk6 IEFkZCBjb21waWxhdGlvbiBsZXZlbCBvcHRpb24KICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDM3NAogCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNj cmlwdENvcmUvcnVudGltZS9PcHRpb25zLmggYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVudGlt ZS9PcHRpb25zLmgKaW5kZXggOGUzZmIwYjYzZWY2MjVlZTkxNjkyNDBiMTZkM2RhNDA4YjMyNDg3 MS4uNjBjYWFlMGY2ZmY3NTMwZTE0MTdiZWEzYTgwZjg1MjE3OTJkYmI2ZiAxMDA2NDQKLS0tIGEv U291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCisrKyBiL1NvdXJjZS9KYXZh U2NyaXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaApAQCAtNDM1LDcgKzQzNSw3IEBAIHR5cGVkZWYg Y29uc3QgY2hhciogb3B0aW9uU3RyaW5nOwogICAgIFwKICAgICB2KGJvb2wsIGZhaWxUb0NvbXBp bGVXZWJBc3NlbWJseUNvZGUsIGZhbHNlLCBOb3JtYWwsICJJZiB0cnVlLCBubyBXYXNtOjpQbGFu IHdpbGwgc3VjZXNzZnVsbHkgY29tcGlsZSBhIGZ1bmN0aW9uLiIpIFwKICAgICB2KHNpemUsIHdl YkFzc2VtYmx5UGFydGlhbENvbXBpbGVMaW1pdCwgNTAwMCwgTm9ybWFsLCAiTGltaXQgb24gdGhl IG51bWJlciBvZiBieXRlcyBhIFdhc206OlBsYW46OmNvbXBpbGUgc2hvdWxkIGF0dGVtcHQgYmVm b3JlIGNoZWNraW5nIGZvciBvdGhlciB3b3JrLiIpIFwKLSAgICB2KHVuc2lnbmVkLCB3ZWJBc3Nl bWJseUIzT3B0aW1pemF0aW9uTGV2ZWwsIDIsIE5vcm1hbCwgIkIzIE9wdGltaXphdGlvbiBsZXZl bCBmb3IgV2ViIEFzc2VtYmx5IG1vZHVsZXMuIikgXAorICAgIHYodW5zaWduZWQsIHdlYkFzc2Vt Ymx5QjNPcHRpbWl6YXRpb25MZXZlbCwgT3B0aW9uczo6ZGVmYXVsdEIzT3B0TGV2ZWwoKSwgTm9y bWFsLCAiQjMgT3B0aW1pemF0aW9uIGxldmVsIGZvciBXZWIgQXNzZW1ibHkgbW9kdWxlcy4iKSBc CiAgICAgXAogICAgIHYoYm9vbCwgc2ltdWxhdGVXZWJBc3NlbWJseUxvd01lbW9yeSwgZmFsc2Us IE5vcm1hbCwgIklmIHRydWUsIHRoZSBNZW1vcnkgb2JqZWN0IHdvbid0IG1tYXAgdGhlIGZ1bGwg J21heGltdW0nIHJhbmdlIGFuZCBpbnN0ZWFkIHdpbGwgYWxsb2NhdGUgdGhlIG1pbmltdW0gcmVx dWlyZWQgYW1vdW50LiIpIFwKICAgICB2KGJvb2wsIHVzZVdlYkFzc2VtYmx5RmFzdE1lbW9yeSwg dHJ1ZSwgTm9ybWFsLCAiSWYgdHJ1ZSwgd2Ugd2lsbCB0cnkgdG8gdXNlIGEgMzItYml0IGFkZHJl c3Mgc3BhY2Ugd2l0aCBhIHNpZ25hbCBoYW5kbGVyIHRvIGJvdW5kcyBjaGVjayB3YXNtIG1lbW9y eS4iKSBcCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdl bmVyYXRvci5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3dhc20vV2FzbUIzSVJHZW5lcmF0b3Iu aAppbmRleCA4NjQ2MjkwM2I2NDA4MTI1NzkzYzE2OWVkMDRkNWJhMDRiYmM5YWIxLi5jMDhiOGQx OTQ0YjIxMmU0MDdlNWE2YTBjZTIzZDBiZjg3NjZkMmIxIDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2 YVNjcmlwdENvcmUvd2FzbS9XYXNtQjNJUkdlbmVyYXRvci5oCisrKyBiL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS93YXNtL1dhc21CM0lSR2VuZXJhdG9yLmgKQEAgLTQ4LDcgKzQ4LDcgQEAgc3RydWN0 IENvbXBpbGF0aW9uQ29udGV4dCB7CiAgICAgQ0NhbGxIZWxwZXJzOjpDYWxsIGpzRW50cnlwb2lu dFRvV2FzbUVudHJ5cG9pbnRDYWxsOwogfTsKIAotRXhwZWN0ZWQ8c3RkOjp1bmlxdWVfcHRyPFdh c21JbnRlcm5hbEZ1bmN0aW9uPiwgU3RyaW5nPiBwYXJzZUFuZENvbXBpbGUoQ29tcGlsYXRpb25D b250ZXh0JiwgY29uc3QgdWludDhfdCosIHNpemVfdCwgY29uc3QgU2lnbmF0dXJlJiwgVmVjdG9y PFVubGlua2VkV2FzbVRvV2FzbUNhbGw+JiwgY29uc3QgTW9kdWxlSW5mb3JtYXRpb24mLCBjb25z dCBWZWN0b3I8U2lnbmF0dXJlSW5kZXg+JiwgTWVtb3J5TW9kZSwgdW5zaWduZWQgb3B0TGV2ZWwg PSBCMzo6ZGVmYXVsdE9wdExldmVsKCkpOworRXhwZWN0ZWQ8c3RkOjp1bmlxdWVfcHRyPFdhc21J bnRlcm5hbEZ1bmN0aW9uPiwgU3RyaW5nPiBwYXJzZUFuZENvbXBpbGUoQ29tcGlsYXRpb25Db250 ZXh0JiwgY29uc3QgdWludDhfdCosIHNpemVfdCwgY29uc3QgU2lnbmF0dXJlJiwgVmVjdG9yPFVu bGlua2VkV2FzbVRvV2FzbUNhbGw+JiwgY29uc3QgTW9kdWxlSW5mb3JtYXRpb24mLCBjb25zdCBW ZWN0b3I8U2lnbmF0dXJlSW5kZXg+JiwgTWVtb3J5TW9kZSwgdW5zaWduZWQgb3B0TGV2ZWwpOwog CiB9IH0gLy8gbmFtZXNwYWNlIEpTQzo6V2FzbQogCg==