170374 2017-03-31 17:41:37 -0700 WebAssembly: Add compilation level option 2017-03-31 17:48:21 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 keith_miller keith_miller buildbot mark.lam msaboff saam oldest_to_newest 1293392 0 keith_miller 2017-03-31 17:41:37 -0700 WebAssembly: Add compilation level option 1293395 1 306031 keith_miller 2017-03-31 17:44:28 -0700 Created attachment 306031 Patch 1293396 2 306031 mark.lam 2017-03-31 17:46:39 -0700 Comment on attachment 306031 Patch r=me 1293397 3 keith_miller 2017-03-31 17:48:01 -0700 Committed r214708: <http://trac.webkit.org/changeset/214708> 1293398 4 306031 mark.lam 2017-03-31 17:48:21 -0700 Comment on attachment 306031 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=306031&action=review > Source/JavaScriptCore/wasm/WasmPlan.cpp:248 > + auto parseAndCompileResult = parseAndCompile(m_compilationContexts[functionIndex], functionStart, functionLength, signature, m_unlinkedWasmToWasmCalls[functionIndex], *m_moduleInformation, m_moduleSignatureIndicesToUniquedSignatureIndices, m_mode, Options::webAssemblyB3OptimizationLevel()); The current implementation uses "unsigned optLevel = B3::defaultOptLevel()" in the header file. Shouldn't you get rid of that since it's no longer used? 306031 2017-03-31 17:44:28 -0700 2017-03-31 17:46:39 -0700 Patch bug-170374-20170331174426.patch text/plain 3212 keith_miller U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NzAzCmRpZmYgLS1naXQgYS9Tb3VyY2UvSmF2YVNjcmlw dENvcmUvQ2hhbmdlTG9nIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwppbmRleCBl NTExMTRlNDBiZGJlZjg4MWMzMzUwMDRkYTYwZWMyZmM1ZWIxZGFlLi5lNzJmN2U3NzVlMTVkZjhk MzBkNTMwMGIwMmE2MzA5MWQzZDkxZWU0IDEwMDY0NAotLS0gYS9Tb3VyY2UvSmF2YVNjcmlwdENv cmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMy0zMSAgS2VpdGggTWlsbGVyICA8a2VpdGhfbWlsbGVyQGFwcGxl LmNvbT4KKworICAgICAgICBXZWJBc3NlbWJseTogQWRkIGNvbXBpbGF0aW9uIGxldmVsIG9wdGlv bgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzc0 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhpcyBw YXRjaCBhZGRzIGFuIG9wdGlvbiwgd2ViQXNzZW1ibHlCM09wdGltaXphdGlvbkxldmVsLCB3aGlj aAorICAgICAgICBjaGFuZ2VzIHRoZSBvcHRpbWl6YXRpb24gbW9kZSB3YXNtIHBhc3NlcyB0byBC My4KKworICAgICAgICAqIHJ1bnRpbWUvT3B0aW9ucy5oOgorICAgICAgICAqIHdhc20vV2FzbVBs YW4uY3BwOgorICAgICAgICAoSlNDOjpXYXNtOjpQbGFuOjpjb21waWxlRnVuY3Rpb25zKToKKwog MjAxNy0wMy0zMSAgU2FhbSBCYXJhdGkgIDxzYmFyYXRpQGFwcGxlLmNvbT4KIAogICAgICAgICBX ZWJBc3NlbWJseTogU3RyaXAgV2FzbVBhcnNlciBhbmQgV2FzbUZ1bmN0aW9uUGFyc2VyIGZyb20g a25vd2luZyBhYm91dCBWTQpkaWZmIC0tZ2l0IGEvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRp bWUvT3B0aW9ucy5oIGIvU291cmNlL0phdmFTY3JpcHRDb3JlL3J1bnRpbWUvT3B0aW9ucy5oCmlu ZGV4IDk5NDFhOTU4NTkwNWQ2ZDkzNjY4ZGI2ODg3MzZhYTJhZTdjYjEwNmUuLjhlM2ZiMGI2M2Vm NjI1ZWU5MTY5MjQwYjE2ZDNkYTQwOGIzMjQ4NzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9KYXZhU2Ny aXB0Q29yZS9ydW50aW1lL09wdGlvbnMuaAorKysgYi9Tb3VyY2UvSmF2YVNjcmlwdENvcmUvcnVu dGltZS9PcHRpb25zLmgKQEAgLTQzNSw2ICs0MzUsNyBAQCB0eXBlZGVmIGNvbnN0IGNoYXIqIG9w dGlvblN0cmluZzsKICAgICBcCiAgICAgdihib29sLCBmYWlsVG9Db21waWxlV2ViQXNzZW1ibHlD b2RlLCBmYWxzZSwgTm9ybWFsLCAiSWYgdHJ1ZSwgbm8gV2FzbTo6UGxhbiB3aWxsIHN1Y2Vzc2Z1 bGx5IGNvbXBpbGUgYSBmdW5jdGlvbi4iKSBcCiAgICAgdihzaXplLCB3ZWJBc3NlbWJseVBhcnRp YWxDb21waWxlTGltaXQsIDUwMDAsIE5vcm1hbCwgIkxpbWl0IG9uIHRoZSBudW1iZXIgb2YgYnl0 ZXMgYSBXYXNtOjpQbGFuOjpjb21waWxlIHNob3VsZCBhdHRlbXB0IGJlZm9yZSBjaGVja2luZyBm b3Igb3RoZXIgd29yay4iKSBcCisgICAgdih1bnNpZ25lZCwgd2ViQXNzZW1ibHlCM09wdGltaXph dGlvbkxldmVsLCAyLCBOb3JtYWwsICJCMyBPcHRpbWl6YXRpb24gbGV2ZWwgZm9yIFdlYiBBc3Nl bWJseSBtb2R1bGVzLiIpIFwKICAgICBcCiAgICAgdihib29sLCBzaW11bGF0ZVdlYkFzc2VtYmx5 TG93TWVtb3J5LCBmYWxzZSwgTm9ybWFsLCAiSWYgdHJ1ZSwgdGhlIE1lbW9yeSBvYmplY3Qgd29u J3QgbW1hcCB0aGUgZnVsbCAnbWF4aW11bScgcmFuZ2UgYW5kIGluc3RlYWQgd2lsbCBhbGxvY2F0 ZSB0aGUgbWluaW11bSByZXF1aXJlZCBhbW91bnQuIikgXAogICAgIHYoYm9vbCwgdXNlV2ViQXNz ZW1ibHlGYXN0TWVtb3J5LCB0cnVlLCBOb3JtYWwsICJJZiB0cnVlLCB3ZSB3aWxsIHRyeSB0byB1 c2UgYSAzMi1iaXQgYWRkcmVzcyBzcGFjZSB3aXRoIGEgc2lnbmFsIGhhbmRsZXIgdG8gYm91bmRz IGNoZWNrIHdhc20gbWVtb3J5LiIpIFwKZGlmZiAtLWdpdCBhL1NvdXJjZS9KYXZhU2NyaXB0Q29y ZS93YXNtL1dhc21QbGFuLmNwcCBiL1NvdXJjZS9KYXZhU2NyaXB0Q29yZS93YXNtL1dhc21QbGFu LmNwcAppbmRleCBlYjI5ZmU4NzRlMTI3ZWZmYWJjMzQ0NWUzMzAxODM5YzRmN2I5ZjI4Li4zMDRl NGY3YjdjZGYyNDM4ZWZlZmY2Y2NmMTcyNDRjMWExMDQ2M2NjIDEwMDY0NAotLS0gYS9Tb3VyY2Uv SmF2YVNjcmlwdENvcmUvd2FzbS9XYXNtUGxhbi5jcHAKKysrIGIvU291cmNlL0phdmFTY3JpcHRD b3JlL3dhc20vV2FzbVBsYW4uY3BwCkBAIC0yNDUsNyArMjQ1LDcgQEAgdm9pZCBQbGFuOjpjb21w aWxlRnVuY3Rpb25zKENvbXBpbGF0aW9uRWZmb3J0IGVmZm9ydCkKICAgICAgICAgQVNTRVJUKHZh bGlkYXRlRnVuY3Rpb24oZnVuY3Rpb25TdGFydCwgZnVuY3Rpb25MZW5ndGgsIHNpZ25hdHVyZSwg Km1fbW9kdWxlSW5mb3JtYXRpb24sIG1fbW9kdWxlU2lnbmF0dXJlSW5kaWNlc1RvVW5pcXVlZFNp Z25hdHVyZUluZGljZXMpKTsKIAogICAgICAgICBtX3VubGlua2VkV2FzbVRvV2FzbUNhbGxzW2Z1 bmN0aW9uSW5kZXhdID0gVmVjdG9yPFVubGlua2VkV2FzbVRvV2FzbUNhbGw+KCk7Ci0gICAgICAg IGF1dG8gcGFyc2VBbmRDb21waWxlUmVzdWx0ID0gcGFyc2VBbmRDb21waWxlKG1fY29tcGlsYXRp b25Db250ZXh0c1tmdW5jdGlvbkluZGV4XSwgZnVuY3Rpb25TdGFydCwgZnVuY3Rpb25MZW5ndGgs IHNpZ25hdHVyZSwgbV91bmxpbmtlZFdhc21Ub1dhc21DYWxsc1tmdW5jdGlvbkluZGV4XSwgKm1f bW9kdWxlSW5mb3JtYXRpb24sIG1fbW9kdWxlU2lnbmF0dXJlSW5kaWNlc1RvVW5pcXVlZFNpZ25h dHVyZUluZGljZXMsIG1fbW9kZSk7CisgICAgICAgIGF1dG8gcGFyc2VBbmRDb21waWxlUmVzdWx0 ID0gcGFyc2VBbmRDb21waWxlKG1fY29tcGlsYXRpb25Db250ZXh0c1tmdW5jdGlvbkluZGV4XSwg ZnVuY3Rpb25TdGFydCwgZnVuY3Rpb25MZW5ndGgsIHNpZ25hdHVyZSwgbV91bmxpbmtlZFdhc21U b1dhc21DYWxsc1tmdW5jdGlvbkluZGV4XSwgKm1fbW9kdWxlSW5mb3JtYXRpb24sIG1fbW9kdWxl U2lnbmF0dXJlSW5kaWNlc1RvVW5pcXVlZFNpZ25hdHVyZUluZGljZXMsIG1fbW9kZSwgT3B0aW9u czo6d2ViQXNzZW1ibHlCM09wdGltaXphdGlvbkxldmVsKCkpOwogCiAgICAgICAgIGlmIChVTkxJ S0VMWSghcGFyc2VBbmRDb21waWxlUmVzdWx0KSkgewogICAgICAgICAgICAgYXV0byBsb2NrZXIg PSBob2xkTG9jayhtX2xvY2spOwo=