170373 2017-03-31 17:18:43 -0700 REGRESSION(r213682): Web Inspector: Network columns don't get saved when Web Inspector is closed 2017-04-17 21:55:45 -0700 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 nvasilyev joepeck commit-queue inspector-bugzilla-changes joepeck mattbaker webkit-bug-importer oldest_to_newest 1293386 0 nvasilyev 2017-03-31 17:18:43 -0700 Steps: 1. Open Network tab. 2. Right click on one of the column headers, such as Domain. 3. Uncheck Domain to hide it. 4. Close Web Inspector. 5. Open Web Inspector. Expected: Domain column stays hidden. Actual: Domain column is visible. No matter what changes in column visibility were made, they don't get saved. 1293432 1 webkit-bug-importer 2017-03-31 20:57:43 -0700 <rdar://problem/31386336> 1298052 2 joepeck 2017-04-17 15:33:44 -0700 I don't think this was ever working. 1298055 3 307307 joepeck 2017-04-17 15:36:42 -0700 Created attachment 307307 [PATCH] Proposed Fix 1298057 4 joepeck 2017-04-17 15:39:32 -0700 NVI corrects me, this was working in the past. In that case, this would have regressed with: <https://trac.webkit.org/r213682> Which made it possible to save the hidden/visible state of default hidden columns. It didn't work for default visible columns because `columnInfo.hidden` was undefined. 1298061 5 307307 nvasilyev 2017-04-17 15:44:59 -0700 Comment on attachment 307307 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=307307&action=review Looks good to me. > Source/WebInspectorUI/ChangeLog:14 > + we always get an explicit boolean. This is indeed what was happening. 1298158 6 307307 mattbaker 2017-04-17 21:23:59 -0700 Comment on attachment 307307 [PATCH] Proposed Fix r=me. I think eventually it would be nice to have a DataGridColumn object that sanitizes these types of settings. 1298164 7 307307 commit-queue 2017-04-17 21:55:43 -0700 Comment on attachment 307307 [PATCH] Proposed Fix Clearing flags on attachment: 307307 Committed r215449: <http://trac.webkit.org/changeset/215449> 1298165 8 commit-queue 2017-04-17 21:55:45 -0700 All reviewed patches have been landed. Closing bug. 307307 2017-04-17 15:36:42 -0700 2017-04-17 21:55:43 -0700 [PATCH] Proposed Fix columns-1.patch text/plain 2188 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDFkN2Y1YTAyZGQ2Li5jZGNjZjViM2I3ZiAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTctMDQtMTcgIEpvc2Vw aCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVjdG9y OiBOZXR3b3JrIGNvbHVtbnMgZG9uJ3QgZ2V0IHNhdmVkIHdoZW4gV2ViIEluc3BlY3RvciBpcyBj bG9zZWQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3 MDM3MworICAgICAgICA8cmRhcjovL3Byb2JsZW0vMzEzODYzMzY+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0Rh dGFHcmlkLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkRhdGFHcmlkLnByb3RvdHlwZS5zZXRD b2x1bW5WaXNpYmxlKToKKyAgICAgICAgKFdlYkluc3BlY3Rvci5EYXRhR3JpZC5wcm90b3R5cGUu X2NvbnRleHRNZW51SW5IZWFkZXIpOgorICAgICAgICBUaGUgY29udGV4dCBtZW51IHdhcyBvZnRl biBwYXNzaW5nIGB1bmRlZmluZWRgIGFzIHRoZSB2aXNpYmxlIHZhbHVlCisgICAgICAgIHdoaWNo IHdvdWxkIGNhdXNlIHRoZSBzZXR0aW5nIHRvIG5vdCBiZSBzYXZlZCBhcHByb3ByaWF0ZWx5LiBF bnN1cmUKKyAgICAgICAgd2UgYWx3YXlzIGdldCBhbiBleHBsaWNpdCBib29sZWFuLgorCiAyMDE3 LTA0LTEyICBEYW4gQmVybnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CiAKICAgICAgICAgW01hY10g RnV0dXJlLXByb29mIC54Y2NvbmZpZyBmaWxlcwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkluc3Bl Y3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRGF0YUdyaWQuanMgYi9Tb3VyY2UvV2ViSW5zcGVj dG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9EYXRhR3JpZC5qcwppbmRleCAzNDZlMzdjOTdmOC4u MThjOTU4MTU5Y2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJm YWNlL1ZpZXdzL0RhdGFHcmlkLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50 ZXJmYWNlL1ZpZXdzL0RhdGFHcmlkLmpzCkBAIC05MjIsNiArOTIyLDcgQEAgV2ViSW5zcGVjdG9y LkRhdGFHcmlkID0gY2xhc3MgRGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAg IHsKICAgICAgICAgbGV0IGNvbHVtbiA9IHRoaXMuY29sdW1ucy5nZXQoY29sdW1uSWRlbnRpZmll cik7CiAgICAgICAgIGNvbnNvbGUuYXNzZXJ0KGNvbHVtbiwgIk1pc3NpbmcgY29sdW1uIGluZm8g Zm9yIGlkZW50aWZpZXI6ICIgKyBjb2x1bW5JZGVudGlmaWVyKTsKKyAgICAgICAgY29uc29sZS5h c3NlcnQodHlwZW9mIHZpc2libGUgPT09ICJib29sZWFuIiwgIk5ldyB2aXNpYmxlIHN0YXRlIHNo b3VsZCBiZSBleHBsaWNpdCBib29sZWFuIiwgdHlwZW9mIHZpc2libGUpOwogCiAgICAgICAgIGlm ICghY29sdW1uIHx8IHZpc2libGUgPT09ICFjb2x1bW4uaGlkZGVuKQogICAgICAgICAgICAgcmV0 dXJuOwpAQCAtMTY0MSw3ICsxNjQyLDkgQEAgV2ViSW5zcGVjdG9yLkRhdGFHcmlkID0gY2xhc3Mg RGF0YUdyaWQgZXh0ZW5kcyBXZWJJbnNwZWN0b3IuVmlldwogICAgICAgICAgICAgICAgICAgICBk aWRBZGRTZXBhcmF0b3IgPSB0cnVlOwogICAgICAgICAgICAgICAgIH0KIAotICAgICAgICAgICAg ICAgIGNvbnRleHRNZW51LmFwcGVuZENoZWNrYm94SXRlbShjb2x1bW5JbmZvLnRpdGxlLCAoKSA9 PiB7IHRoaXMuc2V0Q29sdW1uVmlzaWJsZShpZGVudGlmaWVyLCBjb2x1bW5JbmZvLmhpZGRlbik7 IH0sICFjb2x1bW5JbmZvLmhpZGRlbik7CisgICAgICAgICAgICAgICAgY29udGV4dE1lbnUuYXBw ZW5kQ2hlY2tib3hJdGVtKGNvbHVtbkluZm8udGl0bGUsICgpID0+IHsKKyAgICAgICAgICAgICAg ICAgICAgdGhpcy5zZXRDb2x1bW5WaXNpYmxlKGlkZW50aWZpZXIsICEhY29sdW1uSW5mby5oaWRk ZW4pOworICAgICAgICAgICAgICAgIH0sICFjb2x1bW5JbmZvLmhpZGRlbik7CiAgICAgICAgICAg ICB9CiAgICAgICAgIH0KICAgICB9Cg==