170357 2017-03-31 13:44:23 -0700 Fix memory leak in CreateSessionDescriptionObserver::OnSuccess 2017-04-11 21:46:31 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 youennf youennf commit-queue eric.carlson ggaren oldest_to_newest 1293285 0 youennf 2017-03-31 13:44:23 -0700 Passed raw pointer should be released. 1293287 1 306007 youennf 2017-03-31 13:45:36 -0700 Created attachment 306007 Patch 1293311 2 306007 ggaren 2017-03-31 14:56:17 -0700 Comment on attachment 306007 Patch r=me 1293319 3 306007 commit-queue 2017-03-31 15:05:25 -0700 Comment on attachment 306007 Patch Clearing flags on attachment: 306007 Committed r214689: <http://trac.webkit.org/changeset/214689> 1293320 4 commit-queue 2017-03-31 15:05:28 -0700 All reviewed patches have been landed. Closing bug. 1293363 5 ap 2017-03-31 16:35:45 -0700 This change caused a lot of crashes, rolling back. https://build.webkit.org/results/Apple%20Sierra%20Release%20WK2%20(Tests)/r214689%20(330)/results.html 1293372 6 ap 2017-03-31 16:59:35 -0700 Rolled back in r214700. 1293385 7 youennf 2017-03-31 17:16:18 -0700 Ah right, I should have updated libwebrtc mock. Will reland with mick updated 1293650 8 youennf 2017-04-03 08:41:26 -0700 Reopening to fix mock 1293658 9 306077 youennf 2017-04-03 09:31:31 -0700 Created attachment 306077 Patch 306007 2017-03-31 13:45:36 -0700 2017-04-03 09:31:29 -0700 Patch bug-170357-20170331134535.patch text/plain 1840 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NTU5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjkwNzM3YjcwYTY1MmZj ZDU4NGVkNGFiZjMzZDc3MjNkYTI5NWRjZi4uNjU3NzU4Mjk0YjdhMmFkMDM2ZDhkNjhlZmY5MjJj ZjdjODQ1Y2YxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE3IEBACiAyMDE3LTAzLTMxICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAorICAgICAgICBGaXggbWVtb3J5IGxlYWsg aW4gQ3JlYXRlU2Vzc2lvbkRlc2NyaXB0aW9uT2JzZXJ2ZXI6Ok9uU3VjY2VzcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2 aW9yLgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRD TWVkaWFFbmRwb2ludC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENNZWRpYUVuZHBv aW50OjpjcmVhdGVTZXNzaW9uRGVzY3JpcHRpb25TdWNjZWVkZWQpOiBBZG9wdGluZyB0aGUgcmF3 IHBvaW50ZXIgcGFyYW1ldGVyLgorCisyMDE3LTAzLTMxICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5u QGFwcGxlLmNvbT4KKwogICAgICAgICBGaXggbWVtb3J5IGxlYWsgaW4gUmVhbHRpbWVWaWRlb0lu Y29taW5nU291cmNlCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xNzAzNTYKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0 cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNw cAppbmRleCBkODM3ZTAwODZmMTliYjNiYjg1NjYzMGM3YWEyODkyYTEyNjQ2NGE3Li5lYmYyMmU2 M2I0NjQ3YjIzZjFhZjdhMmU1YzMxNDI5MjA3MjFkMjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50 LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9M aWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcApAQCAtNzAzLDggKzcwMywxMCBAQCB2b2lkIExpYldl YlJUQ01lZGlhRW5kcG9pbnQ6Ok9uSWNlQ2FuZGlkYXRlc1JlbW92ZWQoY29uc3Qgc3RkOjp2ZWN0 b3I8Y3JpY2tldDo6QwogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCi12b2lkIExpYldl YlJUQ01lZGlhRW5kcG9pbnQ6OmNyZWF0ZVNlc3Npb25EZXNjcmlwdGlvblN1Y2NlZWRlZCh3ZWJy dGM6OlNlc3Npb25EZXNjcmlwdGlvbkludGVyZmFjZSogZGVzY3JpcHRpb24pCit2b2lkIExpYldl YlJUQ01lZGlhRW5kcG9pbnQ6OmNyZWF0ZVNlc3Npb25EZXNjcmlwdGlvblN1Y2NlZWRlZCh3ZWJy dGM6OlNlc3Npb25EZXNjcmlwdGlvbkludGVyZmFjZSogcmF3RGVzY3JpcHRpb24pCiB7CisgICAg c3RkOjp1bmlxdWVfcHRyPHdlYnJ0Yzo6U2Vzc2lvbkRlc2NyaXB0aW9uSW50ZXJmYWNlPiBkZXNj cmlwdGlvbihyYXdEZXNjcmlwdGlvbik7CisKICAgICBzdGQ6OnN0cmluZyBzZHA7CiAgICAgZGVz Y3JpcHRpb24tPlRvU3RyaW5nKCZzZHApOwogICAgIFN0cmluZyBzZHBTdHJpbmcoc2RwLmRhdGEo KSwgc2RwLnNpemUoKSk7Cg== 306077 2017-04-03 09:31:31 -0700 2017-04-03 09:31:31 -0700 Patch bug-170357-20170403093131.patch text/plain 2974 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0Nzg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjg3MjEwMWEyMzZjNGY2 YjdhZGFmZTg5N2EyYjQ1NDdiY2M1ODZkZC4uOTQ2ZGQ4OGZjY2RmYjg5ZjZhMDA5MmVhNGJiMzEy MmM4YmFlYzFmMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE3LTA0LTAzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBGaXggbWVtb3J5IGxlYWsg aW4gQ3JlYXRlU2Vzc2lvbkRlc2NyaXB0aW9uT2JzZXJ2ZXI6Ok9uU3VjY2VzcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzU3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCisKKyAgICAgICAgTm8gY2hhbmdlIG9mIGJlaGF2aW9y LgorCisgICAgICAgICogTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDTWVk aWFFbmRwb2ludC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpMaWJXZWJSVENNZWRpYUVuZHBvaW50 OjpjcmVhdGVTZXNzaW9uRGVzY3JpcHRpb25TdWNjZWVkZWQpOiBBZG9wdGluZyB0aGUgcmF3IHBv aW50ZXIgcGFyYW1ldGVyLgorICAgICAgICAqIHRlc3RpbmcvTW9ja0xpYldlYlJUQ1BlZXJDb25u ZWN0aW9uLmNwcDogUGFzc2luZyBhbGxvY2F0ZWQgcmF3IHBvaW50ZXIgdG8gT25TdWNjZXNzIHRv IG1hdGNoIGxpYndlYnJ0YyBiZWhhdmlvci4KKwogMjAxNy0wNC0wMyAgUGVyIEFybmUgVm9sbGFu ICA8cHZvbGxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgSW1wbGVtZW50IHN0cm9rZS1taXRlcmxp bWl0LgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvTW9kdWxlcy9tZWRpYXN0cmVhbS9saWJ3 ZWJydGMvTGliV2ViUlRDTWVkaWFFbmRwb2ludC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVz L21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcAppbmRleCBk ODM3ZTAwODZmMTliYjNiYjg1NjYzMGM3YWEyODkyYTEyNjQ2NGE3Li5lYmYyMmU2M2I0NjQ3YjIz ZjFhZjdhMmU1YzMxNDI5MjA3MjFkMjg4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9Nb2R1 bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENNZWRpYUVuZHBvaW50LmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL21lZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENN ZWRpYUVuZHBvaW50LmNwcApAQCAtNzAzLDggKzcwMywxMCBAQCB2b2lkIExpYldlYlJUQ01lZGlh RW5kcG9pbnQ6Ok9uSWNlQ2FuZGlkYXRlc1JlbW92ZWQoY29uc3Qgc3RkOjp2ZWN0b3I8Y3JpY2tl dDo6QwogICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwogfQogCi12b2lkIExpYldlYlJUQ01lZGlh RW5kcG9pbnQ6OmNyZWF0ZVNlc3Npb25EZXNjcmlwdGlvblN1Y2NlZWRlZCh3ZWJydGM6OlNlc3Np b25EZXNjcmlwdGlvbkludGVyZmFjZSogZGVzY3JpcHRpb24pCit2b2lkIExpYldlYlJUQ01lZGlh RW5kcG9pbnQ6OmNyZWF0ZVNlc3Npb25EZXNjcmlwdGlvblN1Y2NlZWRlZCh3ZWJydGM6OlNlc3Np b25EZXNjcmlwdGlvbkludGVyZmFjZSogcmF3RGVzY3JpcHRpb24pCiB7CisgICAgc3RkOjp1bmlx dWVfcHRyPHdlYnJ0Yzo6U2Vzc2lvbkRlc2NyaXB0aW9uSW50ZXJmYWNlPiBkZXNjcmlwdGlvbihy YXdEZXNjcmlwdGlvbik7CisKICAgICBzdGQ6OnN0cmluZyBzZHA7CiAgICAgZGVzY3JpcHRpb24t PlRvU3RyaW5nKCZzZHApOwogICAgIFN0cmluZyBzZHBTdHJpbmcoc2RwLmRhdGEoKSwgc2RwLnNp emUoKSk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tMaWJXZWJSVENQ ZWVyQ29ubmVjdGlvbi5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL01vY2tMaWJXZWJSVENQ ZWVyQ29ubmVjdGlvbi5jcHAKaW5kZXggMDAwY2NiNWUwMjBkZTlhYTE0YzZkMjJiMGQ5MGZkZWQy MjRmMWU0My4uZjAyMjQ2NjA0Mzg3Y2JjODViMzNiNmRhNjVlOTlkOGU0NjhiODg5NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvdGVzdGluZy9Nb2NrTGliV2ViUlRDUGVlckNvbm5lY3Rpb24u Y3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rlc3RpbmcvTW9ja0xpYldlYlJUQ1BlZXJDb25uZWN0 aW9uLmNwcApAQCAtMzI3LDggKzMyNyw3IEBAIHZvaWQgTW9ja0xpYldlYlJUQ1BlZXJDb25uZWN0 aW9uOjpDcmVhdGVPZmZlcih3ZWJydGM6OkNyZWF0ZVNlc3Npb25EZXNjcmlwdGlvbk9iCiAgICAg ICAgICAgICAgICAgICAgICJhPXNldHVwOmFjdHBhc3NcclxuIjsKICAgICAgICAgICAgIH0KICAg ICAgICAgfQotICAgICAgICBNb2NrTGliV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9uIGRlc2NyaXB0 aW9uKHNkcC5zdHIoKSk7Ci0gICAgICAgIG9ic2VydmVyLT5PblN1Y2Nlc3MoJmRlc2NyaXB0aW9u KTsKKyAgICAgICAgb2JzZXJ2ZXItPk9uU3VjY2VzcyhuZXcgTW9ja0xpYldlYlJUQ1Nlc3Npb25E ZXNjcmlwdGlvbihzZHAuc3RyKCkpKTsKICAgICB9KTsKIH0KIApAQCAtNDI4LDggKzQyNyw3IEBA IHZvaWQgTW9ja0xpYldlYlJUQ1BlZXJDb25uZWN0aW9uOjpDcmVhdGVBbnN3ZXIod2VicnRjOjpD cmVhdGVTZXNzaW9uRGVzY3JpcHRpb25PCiAgICAgICAgICAgICAgICAgICAgICJhPXNldHVwOmFj dGl2ZVxyXG4iOwogICAgICAgICAgICAgfQogICAgICAgICB9Ci0gICAgICAgIE1vY2tMaWJXZWJS VENTZXNzaW9uRGVzY3JpcHRpb24gZGVzY3JpcHRpb24oc2RwLnN0cigpKTsKLSAgICAgICAgb2Jz ZXJ2ZXItPk9uU3VjY2VzcygmZGVzY3JpcHRpb24pOworICAgICAgICBvYnNlcnZlci0+T25TdWNj ZXNzKG5ldyBNb2NrTGliV2ViUlRDU2Vzc2lvbkRlc2NyaXB0aW9uKHNkcC5zdHIoKSkpOwogICAg IH0pOwogfQogCg==