170338 2017-03-31 05:57:27 -0700 Modern media controls should never be enabled in non cocoa ports 2017-03-31 06:37:43 -0700 1 1 1 Unclassified WebKit WebKit2 WebKit Local Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 1 cgarcia webkit-unassigned bugs-noreply calvaris dino graouts mcatanzaro oldest_to_newest 1293158 0 cgarcia 2017-03-31 05:57:27 -0700 It's currently enabled, because it uses the default value for all other runtime features, but modern media controls are not a cross-platform feature. I think this is why media/video-click-dblckick-standalone.html started to fail after r214426. I can't reproduce the failure locally, though. 1293160 1 305967 cgarcia 2017-03-31 05:59:46 -0700 Created attachment 305967 Patch 1293161 2 305967 mcatanzaro 2017-03-31 06:31:57 -0700 Comment on attachment 305967 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305967&action=review This needs a build flag too. Having only a runtime flag really only makes sense if the feature could plausibly work on all platforms. This one is Mac-only. And please name it with _ENABLED. > Source/WebKit2/Shared/WebPreferencesDefinitions.h:320 > +#define DEFAULT_MODERN_MEDIA_CONTROLS true DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED > Source/WebKit2/Shared/WebPreferencesDefinitions.h:322 > +#define DEFAULT_MODERN_MEDIA_CONTROLS false DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED 1293162 3 cgarcia 2017-03-31 06:35:46 -0700 (In reply to Michael Catanzaro from comment #2) > Comment on attachment 305967 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305967&action=review > > This needs a build flag too. Having only a runtime flag really only makes > sense if the feature could plausibly work on all platforms. This one is > Mac-only. > > And please name it with _ENABLED. Indeed. That was my intention, but somehow I didn't add that in the end. > > Source/WebKit2/Shared/WebPreferencesDefinitions.h:320 > > +#define DEFAULT_MODERN_MEDIA_CONTROLS true > > DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED > > > Source/WebKit2/Shared/WebPreferencesDefinitions.h:322 > > +#define DEFAULT_MODERN_MEDIA_CONTROLS false > > DEFAULT_MODERN_MEDIA_CONTROLS_ENABLED 1293163 4 cgarcia 2017-03-31 06:37:43 -0700 Committed r214666: <http://trac.webkit.org/changeset/214666> 305967 2017-03-31 05:59:46 -0700 2017-03-31 06:31:57 -0700 Patch wk2-disable-modern-controls.diff text/plain 2842 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCAxMmQ3MDZiNWI5Zi4uNmEzOTMyYThjYjkgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQyL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNyBAQAorMjAxNy0wMy0zMSAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGln YWxpYS5jb20+CisKKyAgICAgICAgTW9kZXJuIG1lZGlhIGNvbnRyb2xzIHNob3VsZCBuZXZlciBi ZSBlbmFibGVkIGluIG5vbiBjb2NvYSBwb3J0cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzM4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgSXQncyBjdXJyZW50bHkgZW5hYmxlZCwgYmVjYXVzZSBpdCB1 c2VzIHRoZSBkZWZhdWx0IHZhbHVlIGZvciBhbGwgb3RoZXIgcnVudGltZSBmZWF0dXJlcywgYnV0 IG1vZGVybiBtZWRpYQorICAgICAgICBjb250cm9scyBhcmUgbm90IGEgY3Jvc3MtcGxhdGZvcm0g ZmVhdHVyZS4gSSB0aGluayB0aGlzIGlzIHdoeSBtZWRpYS92aWRlby1jbGljay1kYmxja2ljay1z dGFuZGFsb25lLmh0bWwKKyAgICAgICAgc3RhcnRlZCB0byBmYWlsIGluIEdUSysgcG9ydCBhZnRl ciByMjE0NDI2LiBJIGNhbid0IHJlcHJvdWR1Y2UgdGhlIGZhaWx1cmUgbG9jYWxseSwgc28gSSBj YW4ndCBjb25maXJtIGl0LAorICAgICAgICB0aG91Z2guCisKKyAgICAgICAgKiBTaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oOgorCiAyMDE3LTAzLTMwICBaYW4gRG9iZXJzZWsgIDx6 ZG9iZXJzZWtAaWdhbGlhLmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIEdUSysgYnVpbGQgZml4 LiBMaXN0IFdlYkNvcmUgYmVmb3JlIEphdmFTY3JpcHRDb3JlIGFzIHRoZQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYktpdDIvU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmaW5pdGlvbnMuaCBiL1NvdXJj ZS9XZWJLaXQyL1NoYXJlZC9XZWJQcmVmZXJlbmNlc0RlZmluaXRpb25zLmgKaW5kZXggNmMxOWQ1 NDQ1ZGQuLmEyMzQyYmUxZjFlIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2Vi UHJlZmVyZW5jZXNEZWZpbml0aW9ucy5oCisrKyBiL1NvdXJjZS9XZWJLaXQyL1NoYXJlZC9XZWJQ cmVmZXJlbmNlc0RlZmluaXRpb25zLmgKQEAgLTMxNiw2ICszMTYsMTIgQEAKICNkZWZpbmUgREVG QVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCBmYWxzZQogI2VuZGlmCiAKKyNpZiBQ TEFURk9STShDT0NPQSkKKyNkZWZpbmUgREVGQVVMVF9NT0RFUk5fTUVESUFfQ09OVFJPTFMgdHJ1 ZQorI2Vsc2UKKyNkZWZpbmUgREVGQVVMVF9NT0RFUk5fTUVESUFfQ09OVFJPTFMgZmFsc2UKKyNl bmRpZgorCiAjaWYgUExBVEZPUk0oTUFDKSAmJiBfX01BQ19PU19YX1ZFUlNJT05fTUlOX1JFUVVJ UkVEIDwgMTAxMjAwCiAvLyA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTY4NDE1PiBFbCBDYXBpdGFu IE5ldHdvcmtMb2FkVGltaW5nIHZhbHVlcyBhcmUgc29tZXRpbWVzIGp1bWJsZWQKICNkZWZpbmUg REVGQVVMVF9SRVNPVVJDRV9USU1JTkdfRU5BQkxFRCBmYWxzZQpAQCAtMzM1LDcgKzM0MSw3IEBA CiAjZGVmaW5lIEZPUl9FQUNIX1dFQktJVF9FWFBFUklNRU5UQUxfRkVBVFVSRV9QUkVGRVJFTkNF KG1hY3JvKSBcCiAgICAgbWFjcm8oU3ByaW5nVGltaW5nRnVuY3Rpb25FbmFibGVkLCBzcHJpbmdU aW1pbmdGdW5jdGlvbkVuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZF QVRVUkVTX0VOQUJMRUQsICJDU1MgU3ByaW5nIEFuaW1hdGlvbnMiLCAiQ1NTIFNwcmluZyBBbmlt YXRpb24gcHJvdG90eXBlIikgXAogICAgIG1hY3JvKExpbmtQcmVsb2FkRW5hYmxlZCwgbGlua1By ZWxvYWRFbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0VYUEVSSU1FTlRBTF9GRUFUVVJFU19F TkFCTEVELCAiTGluayBQcmVsb2FkIiwgIkxpbmsgcHJlbG9hZCBzdXBwb3J0IikgXAotICAgIG1h Y3JvKE1vZGVybk1lZGlhQ29udHJvbHNFbmFibGVkLCBtb2Rlcm5NZWRpYUNvbnRyb2xzRW5hYmxl ZCwgQm9vbCwgYm9vbCwgREVGQVVMVF9FWFBFUklNRU5UQUxfRkVBVFVSRVNfRU5BQkxFRCwgIk1v ZGVybiBNZWRpYSBDb250cm9scyIsICJVc2UgbW9kZXJuIG1lZGlhIGNvbnRyb2xzIGxvb2siKSBc CisgICAgbWFjcm8oTW9kZXJuTWVkaWFDb250cm9sc0VuYWJsZWQsIG1vZGVybk1lZGlhQ29udHJv bHNFbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX01PREVSTl9NRURJQV9DT05UUk9MUywgIk1v ZGVybiBNZWRpYSBDb250cm9scyIsICJVc2UgbW9kZXJuIG1lZGlhIGNvbnRyb2xzIGxvb2siKSBc CiAgICAgbWFjcm8oUmVzb3VyY2VUaW1pbmdFbmFibGVkLCByZXNvdXJjZVRpbWluZ0VuYWJsZWQs IEJvb2wsIGJvb2wsIERFRkFVTFRfUkVTT1VSQ0VfVElNSU5HX0VOQUJMRUQsICJSZXNvdXJjZSBU aW1pbmciLCAiRW5hYmxlIFJlc291cmNlVGltaW5nIEFQSSIpIFwKICAgICBtYWNybyhTdWJ0bGVD cnlwdG9FbmFibGVkLCBzdWJ0bGVDcnlwdG9FbmFibGVkLCBCb29sLCBib29sLCBERUZBVUxUX0VY UEVSSU1FTlRBTF9GRUFUVVJFU19FTkFCTEVELCAiU3VidGxlQ3J5cHRvIiwgIkVuYWJsZSBTdWJ0 bGVDcnlwdG8gc3VwcG9ydCIpIFwKICAgICBtYWNybyhVc2VyVGltaW5nRW5hYmxlZCwgdXNlclRp bWluZ0VuYWJsZWQsIEJvb2wsIGJvb2wsIERFRkFVTFRfRVhQRVJJTUVOVEFMX0ZFQVRVUkVTX0VO QUJMRUQsICJVc2VyIFRpbWluZyIsICJFbmFibGUgVXNlclRpbWluZyBBUEkiKSBcCg==