<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>170328</bug_id>
          
          <creation_ts>2017-03-30 23:32:40 -0700</creation_ts>
          <short_desc>[WK2] Tapping away to dismiss the selection does not update the selected DOM range using character granularity</short_desc>
          <delta_ts>2017-03-31 16:19:54 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>WebKit2</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Wenson Hsieh">wenson_hsieh</reporter>
          <assigned_to name="Wenson Hsieh">wenson_hsieh</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>mitz</cc>
    
    <cc>thorton</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1293104</commentid>
    <comment_count>0</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-30 23:32:40 -0700</bug_when>
    <thetext>&lt;rdar://problem/30904558&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293288</commentid>
    <comment_count>1</comment_count>
      <attachid>306008</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-31 13:46:13 -0700</bug_when>
    <thetext>Created attachment 306008
Patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293309</commentid>
    <comment_count>2</comment_count>
      <attachid>306014</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-31 14:53:33 -0700</bug_when>
    <thetext>Created attachment 306014
Patch for landing</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293334</commentid>
    <comment_count>3</comment_count>
      <attachid>306014</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2017-03-31 15:36:03 -0700</bug_when>
    <thetext>Comment on attachment 306014
Patch for landing

Clearing flags on attachment: 306014

Committed r214692: &lt;http://trac.webkit.org/changeset/214692&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293340</commentid>
    <comment_count>4</comment_count>
      <attachid>306014</attachid>
    <who name="">mitz</who>
    <bug_when>2017-03-31 15:50:03 -0700</bug_when>
    <thetext>Comment on attachment 306014
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=306014&amp;action=review

&gt; Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2982
&gt; +    if (_webView.configuration.selectionGranularity != WKSelectionGranularityCharacter)
&gt; +        return;
&gt; +

Why is this dependent on the selection granularity rather than the kind of selection assistant we are currently using. In other words, why does this bug (and fix) not apply to contenteditable elements in web views that don’t opt into character granularity?</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293348</commentid>
    <comment_count>5</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-31 16:07:22 -0700</bug_when>
    <thetext>(In reply to mitz@webkit.org from comment #4)
&gt; Comment on attachment 306014 [details]
&gt; Patch for landing
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=306014&amp;action=review
&gt; 
&gt; &gt; Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:2982
&gt; &gt; +    if (_webView.configuration.selectionGranularity != WKSelectionGranularityCharacter)
&gt; &gt; +        return;
&gt; &gt; +
&gt; 
&gt; Why is this dependent on the selection granularity rather than the kind of
&gt; selection assistant we are currently using. In other words, why does this
&gt; bug (and fix) not apply to contenteditable elements in web views that don’t
&gt; opt into character granularity?

Good point. This handling should apply when using the text interaction assistant rather than when using selectionGranularity WKSelectionGranularityCharacter. I&apos;ll fix this in a followup patch.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293351</commentid>
    <comment_count>6</comment_count>
      <attachid>306024</attachid>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-31 16:12:48 -0700</bug_when>
    <thetext>Created attachment 306024
Address post-review feedback</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1293358</commentid>
    <comment_count>7</comment_count>
    <who name="Wenson Hsieh">wenson_hsieh</who>
    <bug_when>2017-03-31 16:19:54 -0700</bug_when>
    <thetext>Landed followup: &lt;http://trac.webkit.org/changeset/214696&gt;</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>306008</attachid>
            <date>2017-03-31 13:46:13 -0700</date>
            <delta_ts>2017-03-31 13:52:53 -0700</delta_ts>
            <desc>Patch</desc>
            <filename>bug-170328-20170331134613.patch</filename>
            <type>text/plain</type>
            <size>7177</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0NjIwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggNzljNGEzNDRjNzVmZWUy
ODcyMTU3NGRlZDY3MzlhN2JlNGNiNmUzNC4uNzc2ODhlN2E5MzdiYmJjNzBjODQzYTMzYWM0Zjk2
ODFhYTg0ZjUwNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE3LTAzLTMxICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCisgICAgICAgIFtXSzJdIFRhcHBp
bmcgYXdheSB0byBkaXNtaXNzIHRoZSBzZWxlY3Rpb24gZG9lcyBub3QgdXBkYXRlIHRoZSBzZWxl
Y3RlZCBET00gcmFuZ2UgdXNpbmcgY2hhcmFjdGVyIGdyYW51bGFyaXR5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAzMjgKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzMwOTA0NTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp
LgorCisgICAgICAgIFdoZW4gVUlLaXQgY2xlYXJzIHRoZSBzZWxlY3Rpb24gd2hpbGUgaW4gdGV4
dCBpbnRlcmFjdGlvbiBtb2RlLCBpdCBub3RpZmllcyBpdHMgZG9jdW1lbnQgdmlldyAoaS5lLiwg
dGhlCisgICAgICAgIFdLQ29udGVudFZpZXcpIGJ5IHNldHRpbmcgaXRzIHNlbGVjdGVkIHRleHQg
cmFuZ2UgdG8gbmlsLiBXaGVuIGNoYXJhY3RlciBncmFudWxhcml0eSBzZWxlY3Rpb24gaXMgZW5h
YmxlZCwgdXNlCisgICAgICAgIHRoaXMgYXMgYSBjdWUgdG8gbm90aWZ5IHRoZSB3ZWIgcHJvY2Vz
cyB0aGF0IHRoZSBzZWxlY3Rpb24gaXMgYmVpbmcgY2xlYXJlZCBvdXQuCisKKyAgICAgICAgLXNl
dFNlbGVjdGVkVGV4dFJhbmdlOiBpcyBhIG5vb3AgaW4gdGhlIGdlbmVyYWwgY2FzZSBiZWNhdXNl
IHRoZSB3ZWIgcHJvY2VzcyBhY3RzIGFzIHRoZSBzb3VyY2Ugb2YgdHJ1dGggZm9yIHdoYXQKKyAg
ICAgICAgdGhlIHNlbGVjdGlvbiBjdXJyZW50bHkgY29uc2lzdHMgb2YsIGFuZCBub3RpZmllcyB0
aGUgVUkgcHJvY2VzcyBhbmQgVUlLaXQgdmlhIFdLVGV4dFBvc2l0aW9uIGFuZCBXS1RleHRSYW5n
ZS4KKyAgICAgICAgSG93ZXZlciwgaW4gdGhlIGNhc2Ugb2YgY2hhcmFjdGVyIGdyYW51bGFyaXR5
IHNlbGVjdGlvbnMsIHRhcHBpbmcgYXdheSB0byBjbGVhciB0aGUgc2VsZWN0aW9uIGlzIGhhbmRs
ZWQgYnkKKyAgICAgICAgVUlLaXQncyB0ZXh0IGdlc3R1cmUgcmVjb2duaXplciBjbHVzdGVyLCB3
aGljaCB0aGVuIGluZm9ybXMgdGhlIGRvY3VtZW50ICh2aWEgLXNldFNlbGVjdGVkVGV4dFJhbmdl
OikgdGhhdCB0aGUKKyAgICAgICAgc2VsZWN0aW9uIHNob3VsZCBiZSBjbGVhcmVkIG91dC4KKwor
ICAgICAgICBBZGRzIGEgbmV3IExheW91dCB0ZXN0OiBlZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0
ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24u
aHRtbC4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9u
Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHNldFNlbGVjdGVkVGV4dFJhbmdlOl0pOgor
CiAyMDE3LTAzLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCiAg
ICAgICAgIFtXSzJdIFRvdWNoZXMgc2hvdWxkIG5vdCBjYW5jZWwgd2hlbiBzaG93aW5nIGEgY3Vz
dG9tIGFjdGlvbiBzaGVldCB3aGlsZSBkYXRhIGludGVyYWN0aW9uIGlzIGFjdGl2ZQpkaWZmIC0t
Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rp
b24ubW0gYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFj
dGlvbi5tbQppbmRleCA3NGIyODY1NDA5MzZlMWY0ZDM5ODBlNTg0NjEyNDgxY2M3MmM3YWMzLi5j
NmY2ZDEyZDgyMjMyZWZmYWY0NDc3MTI1NDIyNzQzYWY1M2U2ZDAyIDEwMDY0NAotLS0gYS9Tb3Vy
Y2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQorKysg
Yi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5t
bQpAQCAtMjk3Miw2ICsyOTcyLDExIEBAIHN0YXRpYyB2b2lkIHNlbGVjdGlvbkNoYW5nZWRXaXRo
VG91Y2goV0tDb250ZW50VmlldyAqdmlldywgY29uc3QgV2ViQ29yZTo6SW50UG9pCiAKIC0gKHZv
aWQpc2V0U2VsZWN0ZWRUZXh0UmFuZ2U6KFVJVGV4dFJhbmdlICopcmFuZ2UKIHsKKyAgICBpZiAo
X3dlYlZpZXcuY29uZmlndXJhdGlvbi5zZWxlY3Rpb25HcmFudWxhcml0eSAhPSBXS1NlbGVjdGlv
bkdyYW51bGFyaXR5Q2hhcmFjdGVyKQorICAgICAgICByZXR1cm47CisKKyAgICBpZiAoIXJhbmdl
KQorICAgICAgICBbc2VsZiBjbGVhclNlbGVjdGlvbl07CiB9CiAKIC0gKEJPT0wpaGFzTWFya2Vk
VGV4dApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hh
bmdlTG9nCmluZGV4IDIzZThlZDM2MWExYzE0NGYxNGU1YzZmZDc0M2I1ZGQ2ZDY2MDM2ZDguLjJm
Y2JkNTliN2UyNzVmMzg1NjkyZjBiYWQ2Nzc4MDNlZGUwOTFiZTcgMTAwNjQ0Ci0tLSBhL0xheW91
dFRlc3RzL0NoYW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwx
OCBAQAorMjAxNy0wMy0zMSAgV2Vuc29uIEhzaWVoICA8d2Vuc29uX2hzaWVoQGFwcGxlLmNvbT4K
KworICAgICAgICBbV0syXSBUYXBwaW5nIGF3YXkgdG8gZGlzbWlzcyB0aGUgc2VsZWN0aW9uIGRv
ZXMgbm90IHVwZGF0ZSB0aGUgc2VsZWN0ZWQgRE9NIHJhbmdlIHVzaW5nIGNoYXJhY3RlciBncmFu
dWxhcml0eQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9
MTcwMzI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8zMDkwNDU1OD4KKworICAgICAgICBSZXZp
ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGRzIGEgbmV3IGxheW91dCB0ZXN0
IHZlcmlmeWluZyB0aGF0IHdoZW4gYSB1c2VyIHRhcHMgYXdheSB0byBjbGVhciB0aGUgY3VycmVu
dCBzZWxlY3Rpb24gaW4gY2hhcmFjdGVyCisgICAgICAgIGdyYW51bGFyaXR5IHNlbGVjdGlvbiBt
b2RlLCB0aGUgc2VsZWN0ZWQgRE9NIHJhbmdlIGluIHRoZSB3ZWIgcHJvY2VzcyBkb2VzIG5vdCBm
YWxsIG91dCBvZiBzeW5jIHdpdGggVUlLaXQncworICAgICAgICBzZWxlY3Rpb24gdmlld3MsIHdo
aWNoIGFyZSBkaXNtaXNzZWQuCisKKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0
ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24t
ZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAgKiBlZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0
ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24u
aHRtbDogQWRkZWQuCisKIDIwMTctMDMtMzAgIFlvdWVubiBGYWJsZXQgIDx5b3Vlbm5AYXBwbGUu
Y29tPgogCiAgICAgICAgIHdlYnJ0Yy92aWRlby1zdGF0cy5odG1sIGFuZCB3ZWJydGMvdmlkZW8t
cmVwbGFjZS10cmFjay5odG1sIGFyZSBmbGFreQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVz
dEV4cGVjdGF0aW9ucyBiL0xheW91dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggOGVjOGQ0
MmRmNzA0OTQ0Nzk0NDg1MGVmNDgwMjk2YWFlMzM1NDdmYi4uMzExNGNmYTU2ZTM1OTI5NWNjNjg3
MzQ5YWUzN2NiYWVlZWZhNTQzMyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0
aW9ucworKysgYi9MYXlvdXRUZXN0cy9UZXN0RXhwZWN0YXRpb25zCkBAIC03OCw2ICs3OCw3IEBA
IGZhc3QvaGFybmVzcy91aXNjcmlwdGNvbnRyb2xsZXIgWyBTa2lwIF0KIGZhc3QvYXR0YWNobWVu
dC9hdHRhY2htZW50LXN1YnRpdGxlLXJlc2l6ZS5odG1sCiAKICMgVGhpcyB0ZXN0IG9ubHkgbWFr
ZXMgc2Vuc2Ugb24gaU9TCitlZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0ZXItZ3JhbnVsYXJpdHkt
c2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24uaHRtbAogZmFzdC9hdHRh
Y2htZW50L2F0dGFjaG1lbnQtd3JhcHBpbmctYWN0aW9uLmh0bWwKIAogIyBPbmx5IGlPUyBoYXMg
c2VsZWN0aW9uIFVJIGRyYXduIGJ5IFVJS2l0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9lZGl0
aW5nL3NlbGVjdGlvbi9jaGFyYWN0ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQtcmFuZ2UtYWZ0ZXIt
ZGlzbWlzc2luZy1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZWRpdGluZy9z
ZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFmdGVyLWRpc21p
c3Npbmctc2VsZWN0aW9uLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi5lNDg1YTU4NzI1Y2Y3MGU2
Y2JiMjQ1NjViNjFiMDM0YmNlM2UyM2MzCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv
ZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFm
dGVyLWRpc21pc3Npbmctc2VsZWN0aW9uLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDUgQEAKK1dF
QgorS0lUCitUaGUgc2VsZWN0ZWQgY29udGVudCBpcyBub3c6ICJXRUIiCitUaGUgc2VsZWN0ZWQg
Y29udGVudCBpcyBub3c6ICIiCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2VkaXRpbmcvc2Vs
ZWN0aW9uL2NoYXJhY3Rlci1ncmFudWxhcml0eS1zZWxlY3RlZC1yYW5nZS1hZnRlci1kaXNtaXNz
aW5nLXNlbGVjdGlvbi5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFj
dGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFmdGVyLWRpc21pc3Npbmctc2VsZWN0aW9u
Lmh0bWwKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMC4uNmE5NTIyNzljNzI3YzQ0OTI2MjNhZjZiMGNlZWZkOTFmODEwYjlh
NQotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2NoYXJh
Y3Rlci1ncmFudWxhcml0eS1zZWxlY3RlZC1yYW5nZS1hZnRlci1kaXNtaXNzaW5nLXNlbGVjdGlv
bi5odG1sCkBAIC0wLDAgKzEsNTggQEAKKzwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRmxl
eGlibGVWaWV3cG9ydD10cnVlLCB1c2VDaGFyYWN0ZXJTZWxlY3Rpb25HcmFudWxhcml0eT10cnVl
IF0gLS0+Cis8bWV0YSBuYW1lPXZpZXdwb3J0IGNvbnRlbnQ9IndpZHRoPWRldmljZS13aWR0aCwg
aW5pdGlhbC1zY2FsZT0xIj4KKzxkaXYgc3R5bGU9ImZvbnQtc2l6ZTogMTI1cHg7Ij5XRUI8YnI+
S0lUPC9kaXY+Cis8ZGl2IGlkPSJvdXRwdXQiIHN0eWxlPSJjb2xvcjogZ3JlZW47IG1hcmdpbi10
b3A6IDFlbTsiPjwvZGl2PgorPHNjcmlwdD4KKyAgICBmdW5jdGlvbiBzZWxlY3RVcHBlclRleHRT
Y3JpcHQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGAKKyAgICAgICAgKCgpID0+IHsKKyAgICAg
ICAgICAgIHVpQ29udHJvbGxlci5sb25nUHJlc3NBdFBvaW50KDEwMCwgMTAwLCAoKSA9PiB7Cisg
ICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKKyAgICAgICAg
ICAgIH0pOworICAgICAgICB9KSgpO2AKKyAgICB9CisKKyAgICBmdW5jdGlvbiB0YXBMb3dlclRl
eHRTY3JpcHQoKQorICAgIHsKKyAgICAgICAgcmV0dXJuIGAKKyAgICAgICAgKCgpID0+IHsKKyAg
ICAgICAgICAgIHVpQ29udHJvbGxlci5zaW5nbGVUYXBBdFBvaW50KDEwMCwgMjI1LCAoKSA9PiB7
CisgICAgICAgICAgICAgICAgdWlDb250cm9sbGVyLnVpU2NyaXB0Q29tcGxldGUoKTsKKyAgICAg
ICAgICAgIH0pOworICAgICAgICB9KSgpO2AKKyAgICB9CisKKyAgICBmdW5jdGlvbiBhcHBlbmRP
dXRwdXQobWVzc2FnZSkKKyAgICB7CisgICAgICAgIGxldCBjb2RlID0gZG9jdW1lbnQuY3JlYXRl
RWxlbWVudCgiY29kZSIpOworICAgICAgICBjb2RlLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0
ZVRleHROb2RlKG1lc3NhZ2UpKTsKKyAgICAgICAgb3V0cHV0LmFwcGVuZENoaWxkKGNvZGUpOwor
ICAgICAgICBvdXRwdXQuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgiYnIiKSk7
CisgICAgfQorCisgICAgKCgpID0+IHsKKyAgICAgICAgaWYgKCF3aW5kb3cudGVzdFJ1bm5lcikg
eworICAgICAgICAgICAgYXBwZW5kT3V0cHV0KGBUaGlzIHRlc3QgY2Fubm90IGJlIHJ1biBtYW51
YWxseTsgY2hhcmFjdGVyIGdyYW51bGFyaXR5IHNlbGVjdGlvbnMgbXVzdCBiZSBlbmFibGVkLmAp
OworICAgICAgICAgICAgcmV0dXJuOworICAgICAgICB9CisKKyAgICAgICAgbGV0IHNlbGVjdGVk
U3RyaW5nID0gIiI7CisgICAgICAgIGRvY3VtZW50LmFkZEV2ZW50TGlzdGVuZXIoInNlbGVjdGlv
bmNoYW5nZSIsICgpID0+IHsKKyAgICAgICAgICAgIGxldCBjdXJyZW50U2VsZWN0ZWRTdHJpbmcg
PSBnZXRTZWxlY3Rpb24oKS50b1N0cmluZygpOworICAgICAgICAgICAgaWYgKHNlbGVjdGVkU3Ry
aW5nID09PSBjdXJyZW50U2VsZWN0ZWRTdHJpbmcpCisgICAgICAgICAgICAgICAgcmV0dXJuOwor
CisgICAgICAgICAgICBzZWxlY3RlZFN0cmluZyA9IGN1cnJlbnRTZWxlY3RlZFN0cmluZzsKKyAg
ICAgICAgICAgIGFwcGVuZE91dHB1dChgVGhlIHNlbGVjdGVkIGNvbnRlbnQgaXMgbm93OiAiJHtz
ZWxlY3RlZFN0cmluZ30iYCk7CisgICAgICAgICAgICBpZiAoc2VsZWN0ZWRTdHJpbmcgPT09ICIi
KQorICAgICAgICAgICAgICAgIHRlc3RSdW5uZXIubm90aWZ5RG9uZSgpOworICAgICAgICB9KTsK
KyAgICB9KSgpOworCisgICAgdGVzdFJ1bm5lci5kdW1wQXNUZXh0KCk7CisgICAgdGVzdFJ1bm5l
ci53YWl0VW50aWxEb25lKCk7CisgICAgdGVzdFJ1bm5lci5ydW5VSVNjcmlwdChzZWxlY3RVcHBl
clRleHRTY3JpcHQoKSwgKCkgPT4geworICAgICAgICB0ZXN0UnVubmVyLnJ1blVJU2NyaXB0KHRh
cExvd2VyVGV4dFNjcmlwdCgpLCAoKSA9PiB7IH0pOworICAgIH0pOworPC9zY3JpcHQ+Cg==
</data>
<flag name="review"
          id="327389"
          type_id="1"
          status="+"
          setter="thorton"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>306014</attachid>
            <date>2017-03-31 14:53:33 -0700</date>
            <delta_ts>2017-03-31 15:36:03 -0700</delta_ts>
            <desc>Patch for landing</desc>
            <filename>bug-170328-20170331145332.patch</filename>
            <type>text/plain</type>
            <size>7422</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZWExMDk0NmFmYzE5YTY4
YmFmYzI1YjdjM2Y5NmUzYTE1NTk2NzcwOC4uMWM1ZTk5YmU3MDAzN2Q3OWJjYjczNGNkMGFmZDFj
MTE4NDkzMDA3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI4IEBACiAyMDE3LTAzLTMxICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIFRhcHBp
bmcgYXdheSB0byBkaXNtaXNzIHRoZSBzZWxlY3Rpb24gZG9lcyBub3QgdXBkYXRlIHRoZSBzZWxl
Y3RlZCBET00gcmFuZ2UgdXNpbmcgY2hhcmFjdGVyIGdyYW51bGFyaXR5CisgICAgICAgIGh0dHBz
Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAzMjgKKyAgICAgICAgPHJkYXI6
Ly9wcm9ibGVtLzMwOTA0NTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisK
KyAgICAgICAgV2hlbiBVSUtpdCBjbGVhcnMgdGhlIHNlbGVjdGlvbiB3aGlsZSBpbiB0ZXh0IGlu
dGVyYWN0aW9uIG1vZGUsIGl0IG5vdGlmaWVzIGl0cyBkb2N1bWVudCB2aWV3IChpLmUuLCB0aGUK
KyAgICAgICAgV0tDb250ZW50VmlldykgYnkgc2V0dGluZyBpdHMgc2VsZWN0ZWQgdGV4dCByYW5n
ZSB0byBuaWwuIFdoZW4gY2hhcmFjdGVyIGdyYW51bGFyaXR5IHNlbGVjdGlvbiBpcyBlbmFibGVk
LCB1c2UKKyAgICAgICAgdGhpcyBhcyBhIGN1ZSB0byBub3RpZnkgdGhlIHdlYiBwcm9jZXNzIHRo
YXQgdGhlIHNlbGVjdGlvbiBpcyBiZWluZyBjbGVhcmVkIG91dC4KKworICAgICAgICAtc2V0U2Vs
ZWN0ZWRUZXh0UmFuZ2U6IGlzIGEgbm9vcCBpbiB0aGUgZ2VuZXJhbCBjYXNlIGJlY2F1c2UgdGhl
IHdlYiBwcm9jZXNzIGFjdHMgYXMgdGhlIHNvdXJjZSBvZiB0cnV0aCBmb3Igd2hhdAorICAgICAg
ICB0aGUgc2VsZWN0aW9uIGN1cnJlbnRseSBjb25zaXN0cyBvZiwgYW5kIG5vdGlmaWVzIHRoZSBV
SSBwcm9jZXNzIGFuZCBVSUtpdCB2aWEgV0tUZXh0UG9zaXRpb24gYW5kIFdLVGV4dFJhbmdlLgor
ICAgICAgICBIb3dldmVyLCBpbiB0aGUgY2FzZSBvZiBjaGFyYWN0ZXIgZ3JhbnVsYXJpdHkgc2Vs
ZWN0aW9ucywgdGFwcGluZyBhd2F5IHRvIGNsZWFyIHRoZSBzZWxlY3Rpb24gaXMgaGFuZGxlZCBi
eQorICAgICAgICBVSUtpdCdzIHRleHQgZ2VzdHVyZSByZWNvZ25pemVyIGNsdXN0ZXIsIHdoaWNo
IHRoZW4gaW5mb3JtcyB0aGUgZG9jdW1lbnQgKHZpYSAtc2V0U2VsZWN0ZWRUZXh0UmFuZ2U6KSB0
aGF0IHRoZQorICAgICAgICBzZWxlY3Rpb24gc2hvdWxkIGJlIGNsZWFyZWQgb3V0LgorCisgICAg
ICAgIEFkZHMgYSBuZXcgTGF5b3V0IHRlc3Q6IGVkaXRpbmcvc2VsZWN0aW9uL2NoYXJhY3Rlci1n
cmFudWxhcml0eS1zZWxlY3RlZC1yYW5nZS1hZnRlci1kaXNtaXNzaW5nLXNlbGVjdGlvbi5odG1s
LgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06
CisgICAgICAgICgtW1dLQ29udGVudFZpZXcgc2V0U2VsZWN0ZWRUZXh0UmFuZ2U6XSk6CisKKzIw
MTctMDMtMzEgIFdlbnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKICAgICAg
ICAgW1dLMl0gVGFwcGluZyBlZGl0YWJsZSB0ZXh0IGluc2lkZSBvZiBhIHJhbmdlIHNlbGVjdGlv
biBubyBsb25nZXIgY2hhbmdlcyB0aGUgc2VsZWN0aW9uIHRvIGEgY2FyZXQKICAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDMyNwogICAgICAgICA8cmRh
cjovL3Byb2JsZW0vMzEzNjM4MTY+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDI1MmFmNGRiMjRjNjg3
NzVmNDZjNzM0YjFkOTJlZGQ2ZGIxNTk2YzMuLjE3MjdmYWUyNDY4N2NhMjNmMmQ0MTcxMThkYjNj
NTkxZmRmMWIxM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD
b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p
b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0yOTc3LDYgKzI5NzcsMTEgQEAgc3Rh
dGljIHZvaWQgc2VsZWN0aW9uQ2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3ICp2aWV3LCBj
b25zdCBXZWJDb3JlOjpJbnRQb2kKIAogLSAodm9pZClzZXRTZWxlY3RlZFRleHRSYW5nZTooVUlU
ZXh0UmFuZ2UgKilyYW5nZQogeworICAgIGlmIChfd2ViVmlldy5jb25maWd1cmF0aW9uLnNlbGVj
dGlvbkdyYW51bGFyaXR5ICE9IFdLU2VsZWN0aW9uR3JhbnVsYXJpdHlDaGFyYWN0ZXIpCisgICAg
ICAgIHJldHVybjsKKworICAgIGlmICghcmFuZ2UpCisgICAgICAgIFtzZWxmIGNsZWFyU2VsZWN0
aW9uXTsKIH0KIAogLSAoQk9PTCloYXNNYXJrZWRUZXh0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0
cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNTJhMWZkMjhlMzllNjM4
M2IxMDdmYTY0MjY0NTAzYWJhZTVlMjM2My4uZjc3OWE0NGJhZTM2N2UyMzNiMmM1NjdjMThkOWZm
YjIwMDMxZTJmYiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91
dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDIwIEBACiAyMDE3LTAzLTMxICBXZW5zb24gSHNp
ZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIFtXSzJdIFRhcHBpbmcgYXdh
eSB0byBkaXNtaXNzIHRoZSBzZWxlY3Rpb24gZG9lcyBub3QgdXBkYXRlIHRoZSBzZWxlY3RlZCBE
T00gcmFuZ2UgdXNpbmcgY2hhcmFjdGVyIGdyYW51bGFyaXR5CisgICAgICAgIGh0dHBzOi8vYnVn
cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAzMjgKKyAgICAgICAgPHJkYXI6Ly9wcm9i
bGVtLzMwOTA0NTU4PgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24uCisKKyAgICAg
ICAgQWRkcyBhIG5ldyBsYXlvdXQgdGVzdCB2ZXJpZnlpbmcgdGhhdCB3aGVuIGEgdXNlciB0YXBz
IGF3YXkgdG8gY2xlYXIgdGhlIGN1cnJlbnQgc2VsZWN0aW9uIGluIGNoYXJhY3RlcgorICAgICAg
ICBncmFudWxhcml0eSBzZWxlY3Rpb24gbW9kZSwgdGhlIHNlbGVjdGVkIERPTSByYW5nZSBpbiB0
aGUgd2ViIHByb2Nlc3MgZG9lcyBub3QgZmFsbCBvdXQgb2Ygc3luYyB3aXRoIFVJS2l0J3MKKyAg
ICAgICAgc2VsZWN0aW9uIHZpZXdzLCB3aGljaCBhcmUgZGlzbWlzc2VkLgorCisgICAgICAgICog
ZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFm
dGVyLWRpc21pc3Npbmctc2VsZWN0aW9uLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICog
ZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFm
dGVyLWRpc21pc3Npbmctc2VsZWN0aW9uLmh0bWw6IEFkZGVkLgorCisyMDE3LTAzLTMxICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgorCiAgICAgICAgIFtXSzJdIFRhcHBp
bmcgZWRpdGFibGUgdGV4dCBpbnNpZGUgb2YgYSByYW5nZSBzZWxlY3Rpb24gbm8gbG9uZ2VyIGNo
YW5nZXMgdGhlIHNlbGVjdGlvbiB0byBhIGNhcmV0CiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr
aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAzMjcKICAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzMx
MzYzODE2PgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucyBiL0xheW91
dFRlc3RzL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggYzlmNWQxYzdmY2JjYmViMWZiNjg5OTI4OTUz
ZDY5N2UwOGJmOTFkMS4uZGI5YmViZDBmYzBlNTY2OGM2NjQxZGMxYjA0OGMzNzFlNjQ3MWMyOCAx
MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvVGVzdEV4cGVjdGF0aW9ucworKysgYi9MYXlvdXRUZXN0
cy9UZXN0RXhwZWN0YXRpb25zCkBAIC03OSw2ICs3OSw3IEBAIGZhc3QvYXR0YWNobWVudC9hdHRh
Y2htZW50LXN1YnRpdGxlLXJlc2l6ZS5odG1sCiAKICMgVGhpcyB0ZXN0IG9ubHkgbWFrZXMgc2Vu
c2Ugb24gaU9TCiBmYXN0L2F0dGFjaG1lbnQvYXR0YWNobWVudC13cmFwcGluZy1hY3Rpb24uaHRt
bAorZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdl
LWFmdGVyLWRpc21pc3Npbmctc2VsZWN0aW9uLmh0bWwgWyBTa2lwIF0KIGVkaXRpbmcvc2VsZWN0
aW9uL2NhcmV0LWFmdGVyLXRhcC1pbi1lZGl0YWJsZS1zZWxlY3Rpb24uaHRtbCBbIFNraXAgXQog
CiAjIE9ubHkgaU9TIGhhcyBzZWxlY3Rpb24gVUkgZHJhd24gYnkgVUlLaXQKZGlmZiAtLWdpdCBh
L0xheW91dFRlc3RzL2VkaXRpbmcvc2VsZWN0aW9uL2NoYXJhY3Rlci1ncmFudWxhcml0eS1zZWxl
Y3RlZC1yYW5nZS1hZnRlci1kaXNtaXNzaW5nLXNlbGVjdGlvbi1leHBlY3RlZC50eHQgYi9MYXlv
dXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQt
cmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0Cm5ldyBmaWxlIG1v
ZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAu
LmU0ODVhNTg3MjVjZjcwZTZjYmIyNDU2NWI2MWIwMzRiY2UzZTIzYzMKLS0tIC9kZXYvbnVsbAor
KysgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3NlbGVjdGlvbi9jaGFyYWN0ZXItZ3JhbnVsYXJpdHkt
c2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlzbWlzc2luZy1zZWxlY3Rpb24tZXhwZWN0ZWQudHh0CkBA
IC0wLDAgKzEsNSBAQAorV0VCCitLSVQKK1RoZSBzZWxlY3RlZCBjb250ZW50IGlzIG5vdzogIldF
QiIKK1RoZSBzZWxlY3RlZCBjb250ZW50IGlzIG5vdzogIiIKKwpkaWZmIC0tZ2l0IGEvTGF5b3V0
VGVzdHMvZWRpdGluZy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJh
bmdlLWFmdGVyLWRpc21pc3Npbmctc2VsZWN0aW9uLmh0bWwgYi9MYXlvdXRUZXN0cy9lZGl0aW5n
L3NlbGVjdGlvbi9jaGFyYWN0ZXItZ3JhbnVsYXJpdHktc2VsZWN0ZWQtcmFuZ2UtYWZ0ZXItZGlz
bWlzc2luZy1zZWxlY3Rpb24uaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAw
MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi42YTk1MjI3OWM3MjdjNDQ5MjYyM2Fm
NmIwY2VlZmQ5MWY4MTBiOWE1Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGlu
Zy9zZWxlY3Rpb24vY2hhcmFjdGVyLWdyYW51bGFyaXR5LXNlbGVjdGVkLXJhbmdlLWFmdGVyLWRp
c21pc3Npbmctc2VsZWN0aW9uLmh0bWwKQEAgLTAsMCArMSw1OCBAQAorPCEtLSB3ZWJraXQtdGVz
dC1ydW5uZXIgWyB1c2VGbGV4aWJsZVZpZXdwb3J0PXRydWUsIHVzZUNoYXJhY3RlclNlbGVjdGlv
bkdyYW51bGFyaXR5PXRydWUgXSAtLT4KKzxtZXRhIG5hbWU9dmlld3BvcnQgY29udGVudD0id2lk
dGg9ZGV2aWNlLXdpZHRoLCBpbml0aWFsLXNjYWxlPTEiPgorPGRpdiBzdHlsZT0iZm9udC1zaXpl
OiAxMjVweDsiPldFQjxicj5LSVQ8L2Rpdj4KKzxkaXYgaWQ9Im91dHB1dCIgc3R5bGU9ImNvbG9y
OiBncmVlbjsgbWFyZ2luLXRvcDogMWVtOyI+PC9kaXY+Cis8c2NyaXB0PgorICAgIGZ1bmN0aW9u
IHNlbGVjdFVwcGVyVGV4dFNjcmlwdCgpCisgICAgeworICAgICAgICByZXR1cm4gYAorICAgICAg
ICAoKCkgPT4geworICAgICAgICAgICAgdWlDb250cm9sbGVyLmxvbmdQcmVzc0F0UG9pbnQoMTAw
LCAxMDAsICgpID0+IHsKKyAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIudWlTY3JpcHRDb21w
bGV0ZSgpOworICAgICAgICAgICAgfSk7CisgICAgICAgIH0pKCk7YAorICAgIH0KKworICAgIGZ1
bmN0aW9uIHRhcExvd2VyVGV4dFNjcmlwdCgpCisgICAgeworICAgICAgICByZXR1cm4gYAorICAg
ICAgICAoKCkgPT4geworICAgICAgICAgICAgdWlDb250cm9sbGVyLnNpbmdsZVRhcEF0UG9pbnQo
MTAwLCAyMjUsICgpID0+IHsKKyAgICAgICAgICAgICAgICB1aUNvbnRyb2xsZXIudWlTY3JpcHRD
b21wbGV0ZSgpOworICAgICAgICAgICAgfSk7CisgICAgICAgIH0pKCk7YAorICAgIH0KKworICAg
IGZ1bmN0aW9uIGFwcGVuZE91dHB1dChtZXNzYWdlKQorICAgIHsKKyAgICAgICAgbGV0IGNvZGUg
PSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCJjb2RlIik7CisgICAgICAgIGNvZGUuYXBwZW5kQ2hp
bGQoZG9jdW1lbnQuY3JlYXRlVGV4dE5vZGUobWVzc2FnZSkpOworICAgICAgICBvdXRwdXQuYXBw
ZW5kQ2hpbGQoY29kZSk7CisgICAgICAgIG91dHB1dC5hcHBlbmRDaGlsZChkb2N1bWVudC5jcmVh
dGVFbGVtZW50KCJiciIpKTsKKyAgICB9CisKKyAgICAoKCkgPT4geworICAgICAgICBpZiAoIXdp
bmRvdy50ZXN0UnVubmVyKSB7CisgICAgICAgICAgICBhcHBlbmRPdXRwdXQoYFRoaXMgdGVzdCBj
YW5ub3QgYmUgcnVuIG1hbnVhbGx5OyBjaGFyYWN0ZXIgZ3JhbnVsYXJpdHkgc2VsZWN0aW9ucyBt
dXN0IGJlIGVuYWJsZWQuYCk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKworICAg
ICAgICBsZXQgc2VsZWN0ZWRTdHJpbmcgPSAiIjsKKyAgICAgICAgZG9jdW1lbnQuYWRkRXZlbnRM
aXN0ZW5lcigic2VsZWN0aW9uY2hhbmdlIiwgKCkgPT4geworICAgICAgICAgICAgbGV0IGN1cnJl
bnRTZWxlY3RlZFN0cmluZyA9IGdldFNlbGVjdGlvbigpLnRvU3RyaW5nKCk7CisgICAgICAgICAg
ICBpZiAoc2VsZWN0ZWRTdHJpbmcgPT09IGN1cnJlbnRTZWxlY3RlZFN0cmluZykKKyAgICAgICAg
ICAgICAgICByZXR1cm47CisKKyAgICAgICAgICAgIHNlbGVjdGVkU3RyaW5nID0gY3VycmVudFNl
bGVjdGVkU3RyaW5nOworICAgICAgICAgICAgYXBwZW5kT3V0cHV0KGBUaGUgc2VsZWN0ZWQgY29u
dGVudCBpcyBub3c6ICIke3NlbGVjdGVkU3RyaW5nfSJgKTsKKyAgICAgICAgICAgIGlmIChzZWxl
Y3RlZFN0cmluZyA9PT0gIiIpCisgICAgICAgICAgICAgICAgdGVzdFJ1bm5lci5ub3RpZnlEb25l
KCk7CisgICAgICAgIH0pOworICAgIH0pKCk7CisKKyAgICB0ZXN0UnVubmVyLmR1bXBBc1RleHQo
KTsKKyAgICB0ZXN0UnVubmVyLndhaXRVbnRpbERvbmUoKTsKKyAgICB0ZXN0UnVubmVyLnJ1blVJ
U2NyaXB0KHNlbGVjdFVwcGVyVGV4dFNjcmlwdCgpLCAoKSA9PiB7CisgICAgICAgIHRlc3RSdW5u
ZXIucnVuVUlTY3JpcHQodGFwTG93ZXJUZXh0U2NyaXB0KCksICgpID0+IHsgfSk7CisgICAgfSk7
Cis8L3NjcmlwdD4K
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>306024</attachid>
            <date>2017-03-31 16:12:48 -0700</date>
            <delta_ts>2017-03-31 16:14:33 -0700</delta_ts>
            <desc>Address post-review feedback</desc>
            <filename>bug-170328-20170331161248.patch</filename>
            <type>text/plain</type>
            <size>1822</size>
            <attacher name="Wenson Hsieh">wenson_hsieh</attacher>
            
              <data encoding="base64">U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0Njg3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D
aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggMWM1ZTk5YmU3MDAzN2Q3
OWJjYjczNGNkMGFmZDFjMTE4NDkzMDA3YS4uODQ5ZjQ1NzZiMWMxNjRkMWFlNmJhMDhmMWI1M2Zj
ZjZlYmNhZDE3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv
dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDE5IEBACiAyMDE3LTAzLTMxICBXZW5z
b24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29tPgogCisgICAgICAgIEFkZHJlc3MgcG9z
dC1yZXZpZXcgZmVlZGJhY2sgYWZ0ZXIgcjIxNDY5MgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi
a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzI4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C
T0RZIChPT1BTISkuCisKKyAgICAgICAgQ2xlYXJpbmcgdGhlIHNlbGVjdGlvbiB3aGVuIFVJS2l0
IGNhbGxzIGludG8gV0tDb250ZW50VmlldyB0byBzZXQgaXRzIHNlbGVjdGVkIHRleHQgcmFuZ2Ug
dG8gbmlsIGlzIGEgcnVsZQorICAgICAgICB0aGF0IHNob3VsZCBiZSBhcHBsaWVkIHdoZW4gdXNp
bmcgYSB0ZXh0IGludGVyYWN0aW9uIGFzc2lzdGFudCwgbm90IGp1c3Qgd2hlbiB1c2luZyBjaGFy
YWN0ZXIgZ3JhbnVsYXJpdHkKKyAgICAgICAgZm9yIHNlbGVjdGluZyB0ZXh0LgorCisgICAgICAg
ICogVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24ubW06CisgICAgICAgICgt
W1dLQ29udGVudFZpZXcgc2V0U2VsZWN0ZWRUZXh0UmFuZ2U6XSk6CisKKzIwMTctMDMtMzEgIFdl
bnNvbiBIc2llaCAgPHdlbnNvbl9oc2llaEBhcHBsZS5jb20+CisKICAgICAgICAgW1dLMl0gVGFw
cGluZyBhd2F5IHRvIGRpc21pc3MgdGhlIHNlbGVjdGlvbiBkb2VzIG5vdCB1cGRhdGUgdGhlIHNl
bGVjdGVkIERPTSByYW5nZSB1c2luZyBjaGFyYWN0ZXIgZ3JhbnVsYXJpdHkKICAgICAgICAgaHR0
cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDMyOAogICAgICAgICA8cmRh
cjovL3Byb2JsZW0vMzA5MDQ1NTg+CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nl
c3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbSBiL1NvdXJjZS9XZWJLaXQyL1VJUHJv
Y2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCmluZGV4IDE3MjdmYWUyNDY4N2Nh
MjNmMmQ0MTcxMThkYjNjNTkxZmRmMWIxM2IuLjg2YzE1MjcxMTdhY2VmMDNhNzQ5ZTBhOTYzNDc2
NjBkZDI1MWM3ZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3MvV0tD
b250ZW50Vmlld0ludGVyYWN0aW9uLm1tCisrKyBiL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9p
b3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1tCkBAIC0yOTc3LDEwICsyOTc3LDcgQEAgc3Rh
dGljIHZvaWQgc2VsZWN0aW9uQ2hhbmdlZFdpdGhUb3VjaChXS0NvbnRlbnRWaWV3ICp2aWV3LCBj
b25zdCBXZWJDb3JlOjpJbnRQb2kKIAogLSAodm9pZClzZXRTZWxlY3RlZFRleHRSYW5nZTooVUlU
ZXh0UmFuZ2UgKilyYW5nZQogewotICAgIGlmIChfd2ViVmlldy5jb25maWd1cmF0aW9uLnNlbGVj
dGlvbkdyYW51bGFyaXR5ICE9IFdLU2VsZWN0aW9uR3JhbnVsYXJpdHlDaGFyYWN0ZXIpCi0gICAg
ICAgIHJldHVybjsKLQotICAgIGlmICghcmFuZ2UpCisgICAgaWYgKF90ZXh0U2VsZWN0aW9uQXNz
aXN0YW50ICYmICFyYW5nZSkKICAgICAgICAgW3NlbGYgY2xlYXJTZWxlY3Rpb25dOwogfQogCg==
</data>
<flag name="review"
          id="327406"
          type_id="1"
          status="+"
          setter="mitz"
    />
          </attachment>
      

    </bug>

</bugzilla>