170324 2017-03-30 20:16:33 -0700 Resource Load Statistics: Check if the store exists before clearing it 2017-03-31 09:54:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 wilander wilander bfulgham buildbot cdumez commit-queue dbates japhet webkit-bug-importer wilander oldest_to_newest 1293083 0 wilander 2017-03-30 20:16:33 -0700 Non-web clients may delete website data records. In such cases the shared observer will not have a store to clear so we should check that it exists. 1293084 1 wilander 2017-03-30 20:16:56 -0700 rdar://problem/31258505 1293085 2 305940 wilander 2017-03-30 20:20:40 -0700 Created attachment 305940 Patch 1293173 3 305940 bfulgham 2017-03-31 09:04:17 -0700 Comment on attachment 305940 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305940&action=review r=me > Source/WebCore/loader/ResourceLoadObserver.cpp:74 > + m_store->clearInMemoryAndPersistent(); We should audit the code for other cases like this, since we now realize there are other WK2 clients that are not browsers. 1293179 4 wilander 2017-03-31 09:24:33 -0700 (In reply to Brent Fulgham from comment #3) > Comment on attachment 305940 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305940&action=review > > r=me Thanks! > > Source/WebCore/loader/ResourceLoadObserver.cpp:74 > > + m_store->clearInMemoryAndPersistent(); > > We should audit the code for other cases like this, since we now realize > there are other WK2 clients that are not browsers. Agreed. The root cause is the static sharedObserver() getter which anyone can call, no matter how they’ve set up the WebsiteDataStore. I'll land this and take another look. 1293185 5 305940 commit-queue 2017-03-31 09:54:44 -0700 Comment on attachment 305940 Patch Clearing flags on attachment: 305940 Committed r214669: <http://trac.webkit.org/changeset/214669> 1293186 6 commit-queue 2017-03-31 09:54:45 -0700 All reviewed patches have been landed. Closing bug. 305940 2017-03-30 20:20:40 -0700 2017-03-31 09:54:44 -0700 Patch bug-170324-20170330202039.patch text/plain 1436 wilander SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDY1NykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBACisyMDE3LTAzLTMwICBKb2huIFdp bGFuZGVyICA8d2lsYW5kZXJAYXBwbGUuY29tPgorCisgICAgICAgIFJlc291cmNlIExvYWQgU3Rh dGlzdGljczogQ2hlY2sgaWYgdGhlIHN0b3JlIGV4aXN0cyBiZWZvcmUgY2xlYXJpbmcgaXQKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTE3MDMyNAorICAg ICAgICA8cmRhcjovL3Byb2JsZW0vMzEyNTg1MDU+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiBBZGRlZCBhIG51bGwgY2hlY2su CisKKyAgICAgICAgKiBsb2FkZXIvUmVzb3VyY2VMb2FkT2JzZXJ2ZXIuY3BwOgorICAgICAgICAo V2ViQ29yZTo6UmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OmNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50 U3RvcmUpOgorICAgICAgICAgICAgQWRkZWQgYSBudWxsIGNoZWNrLgorCiAyMDE3LTAzLTMwICBT aW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEVuc3VyZSB0 aGF0IE5vZGU6OndpbGxCZURlbGV0ZWRGcm9tKCkgYWx3YXlzIHJlbW92ZXMgdG91Y2ggZXZlbnQg aGFuZGxlcnMgZnJvbSB0aGUgZG9jdW1lbnQKSW5kZXg6IFNvdXJjZS9XZWJDb3JlL2xvYWRlci9S ZXNvdXJjZUxvYWRPYnNlcnZlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvbG9h ZGVyL1Jlc291cmNlTG9hZE9ic2VydmVyLmNwcAkocmV2aXNpb24gMjE0NjEyKQorKysgU291cmNl L1dlYkNvcmUvbG9hZGVyL1Jlc291cmNlTG9hZE9ic2VydmVyLmNwcAkod29ya2luZyBjb3B5KQpA QCAtNzAsNyArNzAsOCBAQCB2b2lkIFJlc291cmNlTG9hZE9ic2VydmVyOjpzZXRTdGF0aXN0aWNz CiAKIHZvaWQgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OmNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50 U3RvcmUoKQogewotICAgIG1fc3RvcmUtPmNsZWFySW5NZW1vcnlBbmRQZXJzaXN0ZW50KCk7Cisg ICAgaWYgKG1fc3RvcmUpCisgICAgICAgIG1fc3RvcmUtPmNsZWFySW5NZW1vcnlBbmRQZXJzaXN0 ZW50KCk7CiB9CiAKIHZvaWQgUmVzb3VyY2VMb2FkT2JzZXJ2ZXI6OmNsZWFySW5NZW1vcnlBbmRQ ZXJzaXN0ZW50U3RvcmUoc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2Rp ZmllZFNpbmNlKQo=