17032 2008-01-27 12:04:02 -0800 No rand_s on Windows 2000 -> crash 2012-09-06 17:30:26 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC Windows 2000 RESOLVED INVALID P4 Minor --- 1 eu4bbt12phas4ek webkit-unassigned ap barraclough hausmann jeisecke xhva.net oldest_to_newest 68371 0 eu4bbt12phas4ek 2008-01-27 12:04:02 -0800 There is no rand_s on Windows 2000. Safari crashes with first html request. Related files: http://trac.webkit.org/projects/webkit/browser/trunk/JavaScriptCore/kjs/config.h http://trac.webkit.org/projects/webkit/browser/trunk/JavaScriptCore/wtf/MathExtras.h 68374 1 eu4bbt12phas4ek 2008-01-27 12:08:23 -0800 see also: http://connect.microsoft.com/VisualStudio/feedback/ViewFeedback.aspx?FeedbackID=101607 68398 2 mrowe 2008-01-27 18:02:29 -0800 http://www.apple.com/safari/download/ states that Safari is only supported on Windows XP and Vista. Windows XP has been the minimum officially supported version since the initial beta release. 68442 3 aroben 2008-01-28 08:50:04 -0800 (In reply to comment #2) > http://www.apple.com/safari/download/ states that Safari is only supported on > Windows XP and Vista. Windows XP has been the minimum officially supported > version since the initial beta release. That's not to say this bug can't be fixed, though! We'll gladly accept a patch to fix this that doesn't regress other platforms. 69380 4 eu4bbt12phas4ek 2008-02-04 13:05:30 -0800 (In reply to comment #3) > That's not to say this bug can't be fixed, though! We'll gladly accept a patch > to fix this that doesn't regress other platforms. I've found the bug through Qt's webkit integration, and I assume they wanna support win2k. The solution is to not use rand_s on win2k. But to have only one binary excludes a macro solution. It must be checked for rand_s at runtime: somewhere in a cpp file: #include <windows.h> bool checkFor_rand_s() { HMODULE dll = LoadLibrary("ADVAPI32.DLL"); if (dll && GetProcAddress(dll, "RtlGenRandom") ) { FreeLibrary(dll); return true; } FreeLibrary(dll); return false; } And a dynamic switch in wtf_random_init/wtf_random, static bool do_check = true; static bool rand_s_exists = false; if (do_check) { rand_s_exists = checkFor_rand_s(); } if (rand_s_exists) { .... } The only problem I see is that it is ugly and that it eventually breaks the inlining of the rand functions. 69382 5 eu4bbt12phas4ek 2008-02-04 13:08:37 -0800 correction: if (do_check) { do_check = false; rand_s_exists = checkFor_rand_s(); } 76475 6 hausmann 2008-04-07 03:47:36 -0700 A more complete patch can also be found at http://lists.trolltech.com/qt4-preview-feedback/2008-04/thread00028-0.html 85975 7 ap 2008-07-15 15:10:22 -0700 (In reply to comment #6) > http://lists.trolltech.com/qt4-preview-feedback/2008-04/thread00028-0.html +void check_for_rand_s() +{ + if (!already_checked) { There is no need for this check - check_for_rand_s() is called from wtf_random_init(), which is guaranteed to be called once. 274579 8 jeisecke 2010-09-06 06:15:25 -0700 Nobody interested in Windows 2000 any more? The code seems to have been moved to JavaScriptCore/wtf/RandomNumber.cpp but the idea of the patch should still solve the problem. 713899 9 barraclough 2012-09-06 17:30:26 -0700 We don't appear to call rand_s any more.