170314 2017-03-30 17:10:03 -0700 Allow for extended color in snapshots 2017-03-30 18:40:36 -0700 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 megan_gardner megan_gardner bdakin sam simon.fraser thorton oldest_to_newest 1293034 0 megan_gardner 2017-03-30 17:10:03 -0700 Allow for extended color in snapshots 1293036 1 305929 megan_gardner 2017-03-30 17:12:45 -0700 Created attachment 305929 Patch 1293042 2 sam 2017-03-30 17:32:12 -0700 Can this be API tested? Maybe make a wide gamut snapshot of a page that just some wide gamut red, and then confirm the pixels are still extended. 1293060 3 megan_gardner 2017-03-30 18:40:36 -0700 https://trac.webkit.org/r214646 305929 2017-03-30 17:12:45 -0700 2017-03-30 18:07:59 -0700 Patch bug-170314-20170330171245.patch text/plain 4163 megan_gardner SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDIxNDY0MCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE3LTAzLTMwICBNZWdhbiBH YXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWxsb3cgZm9yIGV4 dGVuZGVkIGNvbG9yIGluIHNuYXBzaG90cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTcwMzE0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS8yODY3NjA5 Mj4gV0tJbWFnZUNyZWF0ZUNHSW1hZ2Ugc2hvdWxkIHN1cHBvcnQgV2lkZUdhbXV0IGluIFdlYktp dDIgb24gbWFjT1MKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBQaXBpbmcgb3B0aW9ucyB0aHJvdWdoIHNuYXBzaG90cyB0byBhbGxvdyBmb3Igd2lkZSBn YW11dCBzdXBwb3J0LgorCisgICAgICAgICogU2hhcmVkL0FQSS9jL1dLSW1hZ2UuaDoKKyAgICAg ICAgKiBTaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0Lmg6CisgICAgICAgIChXZWJLaXQ6OnNu YXBzaG90T3B0aW9uc0Zyb21JbWFnZU9wdGlvbnMpOgorICAgICAgICAqIFNoYXJlZC9JbWFnZU9w dGlvbnMuaDoKKyAgICAgICAgKFdlYktpdDo6c25hcHNob3RPcHRpb25zVG9JbWFnZU9wdGlvbnMp OgorICAgICAgICAqIFNoYXJlZC9XZWJJbWFnZS5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYklt YWdlOjpjcmVhdGUpOgorCiAyMDE3LTAzLTMwICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhA YXBwbGUuY29tPgogCiAgICAgICAgIFtXSzJdIFRvdWNoZXMgc2hvdWxkIG5vdCBjYW5jZWwgd2hl biBzaG93aW5nIGEgY3VzdG9tIGFjdGlvbiBzaGVldCB3aGlsZSBkYXRhIGludGVyYWN0aW9uIGlz IGFjdGl2ZQpJbmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL0ltYWdlT3B0aW9ucy5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9JbWFnZU9wdGlvbnMuaAkocmV2aXNpb24g MjE0NDQyKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0ltYWdlT3B0aW9ucy5oCSh3b3JraW5n IGNvcHkpCkBAIC0zMCw2ICszMCw3IEBAIG5hbWVzcGFjZSBXZWJLaXQgewogCiBlbnVtIEltYWdl T3B0aW9ucyB7CiAgICAgSW1hZ2VPcHRpb25zU2hhcmVhYmxlID0gMSA8PCAwLAorICAgIEltYWdl T3B0aW9uc0V4dGVuZGVkQ29sb3IgPSAxIDw8IDEsCiB9OwogCiBlbnVtIHsKQEAgLTQxLDYgKzQy LDcgQEAgZW51bSB7CiAgICAgU25hcHNob3RPcHRpb25zRm9yY2VCbGFja1RleHQgPSAxIDw8IDYs CiAgICAgU25hcHNob3RPcHRpb25zRm9yY2VXaGl0ZVRleHQgPSAxIDw8IDcsCiAgICAgU25hcHNo b3RPcHRpb25zUHJpbnRpbmcgPSAxIDw8IDgsCisgICAgU25hcHNob3RPcHRpb25zRXh0ZW5kZWRD b2xvciA9IDEgPDwgOSwKIH07CiB0eXBlZGVmIHVpbnQzMl90IFNuYXBzaG90T3B0aW9uczsKIApA QCAtNTEsNiArNTMsMTAgQEAgaW5saW5lIEltYWdlT3B0aW9ucyBzbmFwc2hvdE9wdGlvbnNUb0lt YQogCiAgICAgaWYgKHNuYXBzaG90T3B0aW9ucyAmIFNuYXBzaG90T3B0aW9uc1NoYXJlYWJsZSkK ICAgICAgICAgaW1hZ2VPcHRpb25zIHw9IEltYWdlT3B0aW9uc1NoYXJlYWJsZTsKKyAgICAKKyAg ICBpZiAoc25hcHNob3RPcHRpb25zICYgU25hcHNob3RPcHRpb25zRXh0ZW5kZWRDb2xvcikKKyAg ICAgICAgaW1hZ2VPcHRpb25zIHw9IEltYWdlT3B0aW9uc0V4dGVuZGVkQ29sb3I7CisgICAgCiAK ICAgICByZXR1cm4gc3RhdGljX2Nhc3Q8SW1hZ2VPcHRpb25zPihpbWFnZU9wdGlvbnMpOwogfQpJ bmRleDogU291cmNlL1dlYktpdDIvU2hhcmVkL1dlYkltYWdlLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViSW1hZ2UuY3BwCShyZXZpc2lvbiAyMTQ0NDIpCisrKyBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvV2ViSW1hZ2UuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNCwx MyArMzQsMTcgQEAgbmFtZXNwYWNlIFdlYktpdCB7CiAKIFJlZlB0cjxXZWJJbWFnZT4gV2ViSW1h Z2U6OmNyZWF0ZShjb25zdCBJbnRTaXplJiBzaXplLCBJbWFnZU9wdGlvbnMgb3B0aW9ucykKIHsK KyAgICBpbnQgc2hhcmFibGVPcHRpb25zID0gU2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0FscGhh OworICAgIAorICAgIGlmIChvcHRpb25zICYgSW1hZ2VPcHRpb25zRXh0ZW5kZWRDb2xvcikKKyAg ICAgICAgc2hhcmFibGVPcHRpb25zIHw9IFNoYXJlYWJsZUJpdG1hcDo6U3VwcG9ydHNFeHRlbmRl ZENvbG9yOwogICAgIGlmIChvcHRpb25zICYgSW1hZ2VPcHRpb25zU2hhcmVhYmxlKSB7Ci0gICAg ICAgIGF1dG8gYml0bWFwID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGVTaGFyZWFibGUoc2l6ZSwg U2hhcmVhYmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKKyAgICAgICAgYXV0byBiaXRtYXAgPSBT aGFyZWFibGVCaXRtYXA6OmNyZWF0ZVNoYXJlYWJsZShzaXplLCBzaGFyYWJsZU9wdGlvbnMpOwog ICAgICAgICBpZiAoIWJpdG1hcCkKICAgICAgICAgICAgIHJldHVybiBudWxscHRyOwogICAgICAg ICByZXR1cm4gV2ViSW1hZ2U6OmNyZWF0ZShiaXRtYXAucmVsZWFzZU5vbk51bGwoKSk7CiAgICAg fQotICAgIGF1dG8gYml0bWFwID0gU2hhcmVhYmxlQml0bWFwOjpjcmVhdGUoc2l6ZSwgU2hhcmVh YmxlQml0bWFwOjpTdXBwb3J0c0FscGhhKTsKKyAgICBhdXRvIGJpdG1hcCA9IFNoYXJlYWJsZUJp dG1hcDo6Y3JlYXRlKHNpemUsIHNoYXJhYmxlT3B0aW9ucyk7CiAgICAgaWYgKCFiaXRtYXApCiAg ICAgICAgIHJldHVybiBudWxscHRyOwogICAgIHJldHVybiBXZWJJbWFnZTo6Y3JlYXRlKGJpdG1h cC5yZWxlYXNlTm9uTnVsbCgpKTsKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1NoYXJlZC9BUEkvYy9X S0ltYWdlLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLSW1h Z2UuaAkocmV2aXNpb24gMjE0NDQyKQorKysgU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dL SW1hZ2UuaAkod29ya2luZyBjb3B5KQpAQCAtNDcsNiArNDcsNyBAQCBlbnVtIHsKICAgICBrV0tT bmFwc2hvdE9wdGlvbnNGb3JjZVdoaXRlVGV4dCA9IDEgPDwgNSwKICAgICBrV0tTbmFwc2hvdE9w dGlvbnNQcmludGluZyA9IDEgPDwgNiwKICAgICBrV0tTbmFwc2hvdE9wdGlvbnNFeGNsdWRlT3Zl cmZsb3cgPSAxIDw8IDcsCisgICAga1dLU25hcHNob3RPcHRpb25zRXh0ZW5kZWRDb2xvciA9IDEg PDwgOCwKIH07CiB0eXBlZGVmIHVpbnQzMl90IFdLU25hcHNob3RPcHRpb25zOwogCkluZGV4OiBT b3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0LmgKPT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQot LS0gU291cmNlL1dlYktpdDIvU2hhcmVkL0FQSS9jL1dLU2hhcmVkQVBJQ2FzdC5oCShyZXZpc2lv biAyMTQ0NDIpCisrKyBTb3VyY2UvV2ViS2l0Mi9TaGFyZWQvQVBJL2MvV0tTaGFyZWRBUElDYXN0 LmgJKHdvcmtpbmcgY29weSkKQEAgLTkzMSw2ICs5MzEsOSBAQCBpbmxpbmUgU25hcHNob3RPcHRp b25zIHNuYXBzaG90T3B0aW9uc0ZyCiAgICAgaWYgKHdrSW1hZ2VPcHRpb25zICYga1dLSW1hZ2VP cHRpb25zU2hhcmVhYmxlKQogICAgICAgICBzbmFwc2hvdE9wdGlvbnMgfD0gU25hcHNob3RPcHRp b25zU2hhcmVhYmxlOwogCisgICAgaWYgKHdrSW1hZ2VPcHRpb25zICYga1dLU25hcHNob3RPcHRp b25zRXh0ZW5kZWRDb2xvcikKKyAgICAgICAgc25hcHNob3RPcHRpb25zIHw9IFNuYXBzaG90T3B0 aW9uc0V4dGVuZGVkQ29sb3I7CisgICAgCiAgICAgcmV0dXJuIHNuYXBzaG90T3B0aW9uczsKIH0K IAo=