170297 2017-03-30 13:15:38 -0700 YouTube sometimes does not respect "user gesture" restriction for videos 2017-03-30 16:37:15 -0700 1 1 1 Unclassified WebKit Media WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 mrajca mrajca eric.carlson oldest_to_newest 1292879 0 mrajca 2017-03-30 13:15:38 -0700 I discovered a code path in WebKit that does not honor the “user gesture” requirement even though we have a restriction in place. This occurs on YouTube, which happens to use Media Streams. <rdar://problem/31137640> 1292889 1 305889 mrajca 2017-03-30 13:21:54 -0700 Created attachment 305889 Patch 1292896 2 305889 eric.carlson 2017-03-30 13:32:22 -0700 Comment on attachment 305889 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=305889&action=review As discussed over IRC, you should be able to make a layout test for this. > Source/WebCore/ChangeLog:7 > + even though we have a restriction in place. When using Media Streams, which YouTube does, we transition I think you mean "MSE", not "Media Streams". 1293019 3 mrajca 2017-03-30 16:32:16 -0700 (In reply to Eric Carlson from comment #2) > Comment on attachment 305889 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=305889&action=review > > As discussed over IRC, you should be able to make a layout test for this. Will do. > > > Source/WebCore/ChangeLog:7 > > + even though we have a restriction in place. When using Media Streams, which YouTube does, we transition > > I think you mean "MSE", not "Media Streams". Yup, updated the ChangeLog. 305889 2017-03-30 13:21:54 -0700 2017-03-30 13:32:22 -0700 Patch bug-170297-20170330132154.patch text/plain 2049 mrajca U3VidmVyc2lvbiBSZXZpc2lvbjogMjE0Mjc4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTI1NzI4NDc4MzczYjcw YzQyYmY0MzdmYmE2NDYwMzk0NjhmNmE5Zi4uOGM5OGExZDg1MDZlOGQ1OWNkN2FiNmQ3NDE1Yjcy YTdjMzdlOTBlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE3LTAzLTMwICBNYXR0 IFJhamNhICA8bXJhamNhQGFwcGxlLmNvbT4KKworICAgICAgICBZb3VUdWJlIHNvbWV0aW1lcyBk b2VzIG5vdCByZXNwZWN0ICJ1c2VyIGdlc3R1cmUiIHJlc3RyaWN0aW9uIGZvciB2aWRlb3MuCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xNzAyOTcKKwor ICAgICAgICBJIGRpc2NvdmVyZWQgYSBjb2RlIHBhdGggdGhhdCBkb2VzIG5vdCBob25vciB0aGUg InVzZXIgZ2VzdHVyZSIgcmVxdWlyZW1lbnQgYW5kIHBsYXliYWNrIGlzIGFibGUgdG8gYmVnaW4K KyAgICAgICAgZXZlbiB0aG91Z2ggd2UgaGF2ZSBhIHJlc3RyaWN0aW9uIGluIHBsYWNlLiBXaGVu IHVzaW5nIE1lZGlhIFN0cmVhbXMsIHdoaWNoIFlvdVR1YmUgZG9lcywgd2UgdHJhbnNpdGlvbgor ICAgICAgICBmcm9tIGEgIkhhdmUgTWV0YWRhdGEiIHRvIGEgIkZ1dHVyZSBEYXRhIiBzdGF0ZSB0 aGF0IGNhdXNlcyBwbGF5YmFjayB0byBiZWdpbiwgaG93ZXZlciwgd2UgbmV2ZXIgY2hlY2sKKyAg ICAgICAgaWYgd2UgaGF2ZSBhIHBsYXliYWNrIHJlc3RyaWN0aW9uIGluIHBsYWNlLgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogaHRtbC9IVE1MTWVk aWFFbGVtZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkhUTUxNZWRpYUVsZW1lbnQ6OnNldFJl YWR5U3RhdGUpOgorCiAyMDE3LTAzLTIyICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+ CiAKICAgICAgICAgV2ViS2l0IHNob3VsZCBkaXNhbGxvdyBiZWZvcmV1bmxvYWQgYWxlcnRzIGZy b20gd2ViIHBhZ2VzIHVzZXJzIGhhdmUgbmV2ZXIgaW50ZXJhY3RlZCB3aXRoCmRpZmYgLS1naXQg YS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3BwIGIvU291cmNlL1dlYkNv cmUvaHRtbC9IVE1MTWVkaWFFbGVtZW50LmNwcAppbmRleCA3ZDM0ZTMxMzVhNjZjMmQ1OGI3ZjI4 NDg0NWNhZTg4Yzc5NjAyYmJlLi41ZWNjNTc2Mjg1MWYyNjU0YTg2OWE3MjFiZTI5NmQxZDRlYjI0 OGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxNZWRpYUVsZW1lbnQuY3Bw CisrKyBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTE1lZGlhRWxlbWVudC5jcHAKQEAgLTI0NTcs NiArMjQ1NywxMSBAQCB2b2lkIEhUTUxNZWRpYUVsZW1lbnQ6OnNldFJlYWR5U3RhdGUoTWVkaWFQ bGF5ZXI6OlJlYWR5U3RhdGUgc3RhdGUpCiAgICAgICAgIHNob3VsZFVwZGF0ZURpc3BsYXlTdGF0 ZSA9IHRydWU7CiAgICAgfQogCisgICAgLy8gSWYgd2UgdHJhbnNpdGlvbiB0byB0aGUgRnV0dXJl IERhdGEgc3RhdGUgYW5kIHdlJ3JlIGFib3V0IHRvIGJlZ2luIHBsYXlpbmcsIGVuc3VyZSBwbGF5 YmFjayBpcyBhY3R1YWxseSBwZXJtaXR0ZWQgZmlyc3QsCisgICAgLy8gaG9ub3JpbmcgYW55IHBs YXliYWNrIGRlbmlhbCByZWFzb25zIHN1Y2ggYXMgdGhlIHJlcXVpcmVtZW50IG9mIGEgdXNlciBn ZXN0dXJlLgorICAgIGlmIChtX3JlYWR5U3RhdGUgPT0gSEFWRV9GVVRVUkVfREFUQSAmJiBvbGRT dGF0ZSA8IEhBVkVfRlVUVVJFX0RBVEEgJiYgcG90ZW50aWFsbHlQbGF5aW5nKCkgJiYgIW1fbWVk aWFTZXNzaW9uLT5wbGF5YmFja1Blcm1pdHRlZCgqdGhpcykpCisgICAgICAgIHBhdXNlSW50ZXJu YWwoKTsKKwogICAgIGlmIChzaG91bGRVcGRhdGVEaXNwbGF5U3RhdGUpIHsKICAgICAgICAgdXBk YXRlRGlzcGxheVN0YXRlKCk7CiAgICAgICAgIGlmIChoYXNNZWRpYUNvbnRyb2xzKCkpIHsK